From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: Allen-KH Cheng <allen-kh.cheng@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai <wenst@chromium.org> Subject: Re: [PATCH 4/5] arm64: dts: mt8192: Add dsi node Date: Wed, 29 Jun 2022 19:31:34 -0400 [thread overview] Message-ID: <20220629233134.zt5ua4v5itycjmlt@notapiano> (raw) In-Reply-To: <730f334e-c10d-8f8b-94e6-b66a56e03320@collabora.com> On Wed, Jun 29, 2022 at 03:42:42PM +0200, AngeloGioacchino Del Regno wrote: > Il 29/06/22 14:13, Allen-KH Cheng ha scritto: > > Add dsi ndoe for mt8192 SoC. Typo: s/ndoe/node. > > > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > > --- > > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > index 26d01544b4ea..72af328126de 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > @@ -1334,6 +1334,24 @@ > > mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xe000 0x1000>; > > }; > > + dsi0: dsi@14010000 { > > + compatible = "mediatek,mt8183-dsi"; > > + reg = <0 0x14010000 0 0x1000>; > > + interrupts = <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH 0>; > > + mediatek,syscon-dsi = <&mmsys 0x140>; Also drop this syscon-dsi property. > > + clocks = <&mmsys CLK_MM_DSI0>, > > + <&mmsys CLK_MM_DSI_DSI0>, > > + <&mipi_tx0>; > > + clock-names = "engine", "digital", "hs"; > > + phys = <&mipi_tx0>; > > + phy-names = "dphy"; It's also missing power-domains. > > resets = <&mmsys MT8192_MMSYS_SW0_RST_B_DISP_DSI0>; > > ^^^ This is missing, please add it and resend :-) Also, when this is added you'll need #include <dt-bindings/reset/mt8192-resets.h> With those addressed, Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Thanks, Nícolas > > > + status = "disabled"; > > + > > + port { > > + dsi_out: endpoint { }; > > + }; > > + }; > > + > > ovl_2l2: ovl@14014000 { > > compatible = "mediatek,mt8192-disp-ovl-2l"; > > reg = <0 0x14014000 0 0x1000>; > > >
WARNING: multiple messages have this Message-ID (diff)
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: Allen-KH Cheng <allen-kh.cheng@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai <wenst@chromium.org> Subject: Re: [PATCH 4/5] arm64: dts: mt8192: Add dsi node Date: Wed, 29 Jun 2022 19:31:34 -0400 [thread overview] Message-ID: <20220629233134.zt5ua4v5itycjmlt@notapiano> (raw) In-Reply-To: <730f334e-c10d-8f8b-94e6-b66a56e03320@collabora.com> On Wed, Jun 29, 2022 at 03:42:42PM +0200, AngeloGioacchino Del Regno wrote: > Il 29/06/22 14:13, Allen-KH Cheng ha scritto: > > Add dsi ndoe for mt8192 SoC. Typo: s/ndoe/node. > > > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > > --- > > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > index 26d01544b4ea..72af328126de 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > @@ -1334,6 +1334,24 @@ > > mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xe000 0x1000>; > > }; > > + dsi0: dsi@14010000 { > > + compatible = "mediatek,mt8183-dsi"; > > + reg = <0 0x14010000 0 0x1000>; > > + interrupts = <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH 0>; > > + mediatek,syscon-dsi = <&mmsys 0x140>; Also drop this syscon-dsi property. > > + clocks = <&mmsys CLK_MM_DSI0>, > > + <&mmsys CLK_MM_DSI_DSI0>, > > + <&mipi_tx0>; > > + clock-names = "engine", "digital", "hs"; > > + phys = <&mipi_tx0>; > > + phy-names = "dphy"; It's also missing power-domains. > > resets = <&mmsys MT8192_MMSYS_SW0_RST_B_DISP_DSI0>; > > ^^^ This is missing, please add it and resend :-) Also, when this is added you'll need #include <dt-bindings/reset/mt8192-resets.h> With those addressed, Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Thanks, Nícolas > > > + status = "disabled"; > > + > > + port { > > + dsi_out: endpoint { }; > > + }; > > + }; > > + > > ovl_2l2: ovl@14014000 { > > compatible = "mediatek,mt8192-disp-ovl-2l"; > > reg = <0 0x14014000 0 0x1000>; > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-29 23:31 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-29 12:13 [PATCH 0/5] Complete driver nodes for MT8192 SoC Allen-KH Cheng 2022-06-29 12:13 ` Allen-KH Cheng 2022-06-29 12:13 ` [PATCH 1/5] arm64: dts: mt8192: Add pwm node Allen-KH Cheng 2022-06-29 12:13 ` Allen-KH Cheng 2022-06-29 23:12 ` Nícolas F. R. A. Prado 2022-06-29 23:12 ` Nícolas F. R. A. Prado 2022-06-29 12:13 ` [PATCH 2/5] arm64: dts: mt8192: Add mipi_tx node Allen-KH Cheng 2022-06-29 12:13 ` Allen-KH Cheng 2022-06-29 23:14 ` Nícolas F. R. A. Prado 2022-06-29 23:14 ` Nícolas F. R. A. Prado 2022-06-29 12:13 ` [PATCH 3/5] arm64: dts: mt8192: Add display nodes Allen-KH Cheng 2022-06-29 12:13 ` Allen-KH Cheng 2022-06-29 23:24 ` Nícolas F. R. A. Prado 2022-06-29 23:24 ` Nícolas F. R. A. Prado 2022-06-30 9:41 ` allen-kh.cheng 2022-06-30 9:41 ` allen-kh.cheng 2022-06-30 13:42 ` Nícolas F. R. A. Prado 2022-06-30 13:42 ` Nícolas F. R. A. Prado 2022-07-01 5:25 ` Chen-Yu Tsai 2022-07-01 5:25 ` Chen-Yu Tsai 2022-07-01 5:59 ` allen-kh.cheng 2022-07-01 5:59 ` allen-kh.cheng 2022-06-29 12:13 ` [PATCH 4/5] arm64: dts: mt8192: Add dsi node Allen-KH Cheng 2022-06-29 12:13 ` Allen-KH Cheng 2022-06-29 13:42 ` AngeloGioacchino Del Regno 2022-06-29 13:42 ` AngeloGioacchino Del Regno 2022-06-29 23:31 ` Nícolas F. R. A. Prado [this message] 2022-06-29 23:31 ` Nícolas F. R. A. Prado 2022-06-29 12:13 ` [PATCH 5/5] arm64: dts: mt8192: Add vcodec lat and core nodes Allen-KH Cheng 2022-06-29 12:13 ` Allen-KH Cheng 2022-06-29 23:32 ` Nícolas F. R. A. Prado 2022-06-29 23:32 ` Nícolas F. R. A. Prado
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220629233134.zt5ua4v5itycjmlt@notapiano \ --to=nfraprado@collabora.com \ --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \ --cc=allen-kh.cheng@mediatek.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ --cc=wenst@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.