* [PATCH bpf-next] bpftool: remove attach_type_name forward declaration
@ 2022-06-30 9:36 Tobias Klauser
2022-06-30 10:07 ` Quentin Monnet
2022-06-30 14:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Tobias Klauser @ 2022-06-30 9:36 UTC (permalink / raw)
To: Quentin Monnet; +Cc: bpf
The attach_type_name definition was removed in commit 1ba5ad36e00f
("bpftool: Use libbpf_bpf_attach_type_str"). Remove its forward
declaration in main.h as well.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
tools/bpf/bpftool/main.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/bpf/bpftool/main.h b/tools/bpf/bpftool/main.h
index 589cb76b227a..5e5060c2ac04 100644
--- a/tools/bpf/bpftool/main.h
+++ b/tools/bpf/bpftool/main.h
@@ -63,8 +63,6 @@ static inline void *u64_to_ptr(__u64 ptr)
#define HELP_SPEC_LINK \
"LINK := { id LINK_ID | pinned FILE }"
-extern const char * const attach_type_name[__MAX_BPF_ATTACH_TYPE];
-
/* keep in sync with the definition in skeleton/pid_iter.bpf.c */
enum bpf_obj_type {
BPF_OBJ_UNKNOWN,
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] bpftool: remove attach_type_name forward declaration
2022-06-30 9:36 [PATCH bpf-next] bpftool: remove attach_type_name forward declaration Tobias Klauser
@ 2022-06-30 10:07 ` Quentin Monnet
2022-06-30 14:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Quentin Monnet @ 2022-06-30 10:07 UTC (permalink / raw)
To: Tobias Klauser; +Cc: bpf
On 30/06/2022 10:36, Tobias Klauser wrote:
> The attach_type_name definition was removed in commit 1ba5ad36e00f
> ("bpftool: Use libbpf_bpf_attach_type_str"). Remove its forward
> declaration in main.h as well.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> tools/bpf/bpftool/main.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/bpf/bpftool/main.h b/tools/bpf/bpftool/main.h
> index 589cb76b227a..5e5060c2ac04 100644
> --- a/tools/bpf/bpftool/main.h
> +++ b/tools/bpf/bpftool/main.h
> @@ -63,8 +63,6 @@ static inline void *u64_to_ptr(__u64 ptr)
> #define HELP_SPEC_LINK \
> "LINK := { id LINK_ID | pinned FILE }"
>
> -extern const char * const attach_type_name[__MAX_BPF_ATTACH_TYPE];
> -
> /* keep in sync with the definition in skeleton/pid_iter.bpf.c */
> enum bpf_obj_type {
> BPF_OBJ_UNKNOWN,
Reviewed-by: Quentin Monnet <quentin@isovalent.com>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] bpftool: remove attach_type_name forward declaration
2022-06-30 9:36 [PATCH bpf-next] bpftool: remove attach_type_name forward declaration Tobias Klauser
2022-06-30 10:07 ` Quentin Monnet
@ 2022-06-30 14:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-06-30 14:20 UTC (permalink / raw)
To: Tobias Klauser; +Cc: quentin, bpf
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:
On Thu, 30 Jun 2022 11:36:38 +0200 you wrote:
> The attach_type_name definition was removed in commit 1ba5ad36e00f
> ("bpftool: Use libbpf_bpf_attach_type_str"). Remove its forward
> declaration in main.h as well.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> tools/bpf/bpftool/main.h | 2 --
> 1 file changed, 2 deletions(-)
Here is the summary with links:
- [bpf-next] bpftool: remove attach_type_name forward declaration
https://git.kernel.org/bpf/bpf-next/c/b0cbd6154a9a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-30 14:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-30 9:36 [PATCH bpf-next] bpftool: remove attach_type_name forward declaration Tobias Klauser
2022-06-30 10:07 ` Quentin Monnet
2022-06-30 14:20 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.