[PATCH bpf-next] bpftool: remove attach_type_name forward declaration

[PATCH bpf-next] bpftool: remove attach_type_name forward declaration

[Tobias Klauser]

The attach_type_name definition was removed in commit 1ba5ad36e00f
("bpftool: Use libbpf_bpf_attach_type_str"). Remove its forward
declaration in main.h as well.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 tools/bpf/bpftool/main.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/bpf/bpftool/main.h b/tools/bpf/bpftool/main.h
index 589cb76b227a..5e5060c2ac04 100644
--- a/tools/bpf/bpftool/main.h
+++ b/tools/bpf/bpftool/main.h
@@ -63,8 +63,6 @@ static inline void *u64_to_ptr(__u64 ptr)
 #define HELP_SPEC_LINK							\
 	"LINK := { id LINK_ID | pinned FILE }"
 
-extern const char * const attach_type_name[__MAX_BPF_ATTACH_TYPE];
-
 /* keep in sync with the definition in skeleton/pid_iter.bpf.c */
 enum bpf_obj_type {
 	BPF_OBJ_UNKNOWN,
-- 
2.36.1

Re: [PATCH bpf-next] bpftool: remove attach_type_name forward declaration

[Quentin Monnet]

On 30/06/2022 10:36, Tobias Klauser wrote:
> The attach_type_name definition was removed in commit 1ba5ad36e00f
> ("bpftool: Use libbpf_bpf_attach_type_str"). Remove its forward
> declaration in main.h as well.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
>  tools/bpf/bpftool/main.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/bpf/bpftool/main.h b/tools/bpf/bpftool/main.h
> index 589cb76b227a..5e5060c2ac04 100644
> --- a/tools/bpf/bpftool/main.h
> +++ b/tools/bpf/bpftool/main.h
> @@ -63,8 +63,6 @@ static inline void *u64_to_ptr(__u64 ptr)
>  #define HELP_SPEC_LINK							\
>  	"LINK := { id LINK_ID | pinned FILE }"
>  
> -extern const char * const attach_type_name[__MAX_BPF_ATTACH_TYPE];
> -
>  /* keep in sync with the definition in skeleton/pid_iter.bpf.c */
>  enum bpf_obj_type {
>  	BPF_OBJ_UNKNOWN,

Reviewed-by: Quentin Monnet <quentin@isovalent.com>

Thanks!

Re: [PATCH bpf-next] bpftool: remove attach_type_name forward declaration

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Thu, 30 Jun 2022 11:36:38 +0200 you wrote:
> The attach_type_name definition was removed in commit 1ba5ad36e00f
> ("bpftool: Use libbpf_bpf_attach_type_str"). Remove its forward
> declaration in main.h as well.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
>  tools/bpf/bpftool/main.h | 2 --
>  1 file changed, 2 deletions(-)

Here is the summary with links:
  - [bpf-next] bpftool: remove attach_type_name forward declaration
    https://git.kernel.org/bpf/bpf-next/c/b0cbd6154a9a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html