[PATCH 1/2] dt-bindings: arm: sunxi: Default to the full MBUS binding

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 1/2] dt-bindings: arm: sunxi: Default to the full MBUS binding
@ 2022-07-02  4:24 ` Samuel Holland
  0 siblings, 0 replies; 20+ messages in thread
From: Samuel Holland @ 2022-07-02  4:24 UTC (permalink / raw)
  To: Chen-Yu Tsai, Jernej Skrabec
  Cc: Samuel Holland, Chanwoo Choi, Krzysztof Kozlowski, Maxime Ripard,
	Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
	linux-sunxi

Some older SoCs use a deprecated MBUS binding with some clocks missing.
Currently, new SoCs must opt in to the complete binding. This should be
the default, so new SoCs do not accidentally use the deprecated version.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 .../arm/sunxi/allwinner,sun4i-a10-mbus.yaml        | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
index 8eee312c2e6f..2b018feb56df 100644
--- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
@@ -81,13 +81,13 @@ required:
   - dma-ranges
 
 if:
-  properties:
-    compatible:
-      contains:
-        enum:
-          - allwinner,sun8i-h3-mbus
-          - allwinner,sun50i-a64-mbus
-          - allwinner,sun50i-h5-mbus
+  not:
+    properties:
+      compatible:
+        contains:
+          enum:
+            - allwinner,sun5i-a13-mbus
+            - allwinner,sun8i-r40-mbus
 
 then:
   properties:
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [PATCH 1/2] dt-bindings: arm: sunxi: Default to the full MBUS binding
@ 2022-07-02  4:24 ` Samuel Holland
  0 siblings, 0 replies; 20+ messages in thread
From: Samuel Holland @ 2022-07-02  4:24 UTC (permalink / raw)
  To: Chen-Yu Tsai, Jernej Skrabec
  Cc: Samuel Holland, Chanwoo Choi, Krzysztof Kozlowski, Maxime Ripard,
	Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
	linux-sunxi

Some older SoCs use a deprecated MBUS binding with some clocks missing.
Currently, new SoCs must opt in to the complete binding. This should be
the default, so new SoCs do not accidentally use the deprecated version.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 .../arm/sunxi/allwinner,sun4i-a10-mbus.yaml        | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
index 8eee312c2e6f..2b018feb56df 100644
--- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
@@ -81,13 +81,13 @@ required:
   - dma-ranges
 
 if:
-  properties:
-    compatible:
-      contains:
-        enum:
-          - allwinner,sun8i-h3-mbus
-          - allwinner,sun50i-a64-mbus
-          - allwinner,sun50i-h5-mbus
+  not:
+    properties:
+      compatible:
+        contains:
+          enum:
+            - allwinner,sun5i-a13-mbus
+            - allwinner,sun8i-r40-mbus
 
 then:
   properties:
-- 
2.35.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles
  2022-07-02  4:24 ` Samuel Holland
@ 2022-07-02  4:24   ` Samuel Holland
  -1 siblings, 0 replies; 20+ messages in thread
From: Samuel Holland @ 2022-07-02  4:24 UTC (permalink / raw)
  To: Chen-Yu Tsai, Jernej Skrabec
  Cc: Samuel Holland, Chanwoo Choi, Krzysztof Kozlowski, Maxime Ripard,
	Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
	linux-sunxi

All of the sunxi SoCs since at least the A33 have a similar structure
for the MBUS and DRAM controller, but they all have minor differences in
MBUS port assignments and DRAM controller behavior. Give each SoC its
own compatible.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
index 2b018feb56df..99566688d033 100644
--- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
@@ -29,10 +29,20 @@ properties:
   compatible:
     enum:
       - allwinner,sun5i-a13-mbus
+      - allwinner,sun8i-a33-mbus
+      - allwinner,sun8i-a50-mbus
+      - allwinner,sun8i-a83t-mbus
       - allwinner,sun8i-h3-mbus
       - allwinner,sun8i-r40-mbus
+      - allwinner,sun8i-v3s-mbus
+      - allwinner,sun8i-v536-mbus
+      - allwinner,sun20i-d1-mbus
       - allwinner,sun50i-a64-mbus
+      - allwinner,sun50i-a100-mbus
       - allwinner,sun50i-h5-mbus
+      - allwinner,sun50i-h6-mbus
+      - allwinner,sun50i-h616-mbus
+      - allwinner,sun50i-r329-mbus
 
   reg:
     minItems: 1
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles
@ 2022-07-02  4:24   ` Samuel Holland
  0 siblings, 0 replies; 20+ messages in thread
From: Samuel Holland @ 2022-07-02  4:24 UTC (permalink / raw)
  To: Chen-Yu Tsai, Jernej Skrabec
  Cc: Samuel Holland, Chanwoo Choi, Krzysztof Kozlowski, Maxime Ripard,
	Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
	linux-sunxi

All of the sunxi SoCs since at least the A33 have a similar structure
for the MBUS and DRAM controller, but they all have minor differences in
MBUS port assignments and DRAM controller behavior. Give each SoC its
own compatible.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
index 2b018feb56df..99566688d033 100644
--- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
@@ -29,10 +29,20 @@ properties:
   compatible:
     enum:
       - allwinner,sun5i-a13-mbus
+      - allwinner,sun8i-a33-mbus
+      - allwinner,sun8i-a50-mbus
+      - allwinner,sun8i-a83t-mbus
       - allwinner,sun8i-h3-mbus
       - allwinner,sun8i-r40-mbus
+      - allwinner,sun8i-v3s-mbus
+      - allwinner,sun8i-v536-mbus
+      - allwinner,sun20i-d1-mbus
       - allwinner,sun50i-a64-mbus
+      - allwinner,sun50i-a100-mbus
       - allwinner,sun50i-h5-mbus
+      - allwinner,sun50i-h6-mbus
+      - allwinner,sun50i-h616-mbus
+      - allwinner,sun50i-r329-mbus
 
   reg:
     minItems: 1
-- 
2.35.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles
  2022-07-02  4:24   ` Samuel Holland
@ 2022-07-02 19:46     ` Jernej Škrabec
  -1 siblings, 0 replies; 20+ messages in thread
From: Jernej Škrabec @ 2022-07-02 19:46 UTC (permalink / raw)
  To: Chen-Yu Tsai, Samuel Holland
  Cc: Samuel Holland, Chanwoo Choi, Krzysztof Kozlowski, Maxime Ripard,
	Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
	linux-sunxi

Dne sobota, 02. julij 2022 ob 06:24:47 CEST je Samuel Holland napisal(a):
> All of the sunxi SoCs since at least the A33 have a similar structure
> for the MBUS and DRAM controller, but they all have minor differences in
> MBUS port assignments and DRAM controller behavior. Give each SoC its
> own compatible.

Shouldn't be compatibles introduced when they are actually used either in 
driver or in DT file?

Best regards,
Jernej

> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> index 2b018feb56df..99566688d033 100644
> ---
> a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> +++
> b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> @@ -29,10 +29,20 @@ properties:
>    compatible:
>      enum:
>        - allwinner,sun5i-a13-mbus
> +      - allwinner,sun8i-a33-mbus
> +      - allwinner,sun8i-a50-mbus
> +      - allwinner,sun8i-a83t-mbus
>        - allwinner,sun8i-h3-mbus
>        - allwinner,sun8i-r40-mbus
> +      - allwinner,sun8i-v3s-mbus
> +      - allwinner,sun8i-v536-mbus
> +      - allwinner,sun20i-d1-mbus
>        - allwinner,sun50i-a64-mbus
> +      - allwinner,sun50i-a100-mbus
>        - allwinner,sun50i-h5-mbus
> +      - allwinner,sun50i-h6-mbus
> +      - allwinner,sun50i-h616-mbus
> +      - allwinner,sun50i-r329-mbus
> 
>    reg:
>      minItems: 1





^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles
@ 2022-07-02 19:46     ` Jernej Škrabec
  0 siblings, 0 replies; 20+ messages in thread
From: Jernej Škrabec @ 2022-07-02 19:46 UTC (permalink / raw)
  To: Chen-Yu Tsai, Samuel Holland
  Cc: Samuel Holland, Chanwoo Choi, Krzysztof Kozlowski, Maxime Ripard,
	Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
	linux-sunxi

Dne sobota, 02. julij 2022 ob 06:24:47 CEST je Samuel Holland napisal(a):
> All of the sunxi SoCs since at least the A33 have a similar structure
> for the MBUS and DRAM controller, but they all have minor differences in
> MBUS port assignments and DRAM controller behavior. Give each SoC its
> own compatible.

Shouldn't be compatibles introduced when they are actually used either in 
driver or in DT file?

Best regards,
Jernej

> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> index 2b018feb56df..99566688d033 100644
> ---
> a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> +++
> b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> @@ -29,10 +29,20 @@ properties:
>    compatible:
>      enum:
>        - allwinner,sun5i-a13-mbus
> +      - allwinner,sun8i-a33-mbus
> +      - allwinner,sun8i-a50-mbus
> +      - allwinner,sun8i-a83t-mbus
>        - allwinner,sun8i-h3-mbus
>        - allwinner,sun8i-r40-mbus
> +      - allwinner,sun8i-v3s-mbus
> +      - allwinner,sun8i-v536-mbus
> +      - allwinner,sun20i-d1-mbus
>        - allwinner,sun50i-a64-mbus
> +      - allwinner,sun50i-a100-mbus
>        - allwinner,sun50i-h5-mbus
> +      - allwinner,sun50i-h6-mbus
> +      - allwinner,sun50i-h616-mbus
> +      - allwinner,sun50i-r329-mbus
> 
>    reg:
>      minItems: 1





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles
  2022-07-02  4:24   ` Samuel Holland
@ 2022-07-05 20:29     ` Rob Herring
  -1 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2022-07-05 20:29 UTC (permalink / raw)
  To: Samuel Holland
  Cc: linux-sunxi, linux-arm-kernel, linux-kernel, devicetree,
	Chen-Yu Tsai, Rob Herring, Chanwoo Choi, Jernej Skrabec,
	Maxime Ripard, Krzysztof Kozlowski

On Fri, 01 Jul 2022 23:24:47 -0500, Samuel Holland wrote:
> All of the sunxi SoCs since at least the A33 have a similar structure
> for the MBUS and DRAM controller, but they all have minor differences in
> MBUS port assignments and DRAM controller behavior. Give each SoC its
> own compatible.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles
@ 2022-07-05 20:29     ` Rob Herring
  0 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2022-07-05 20:29 UTC (permalink / raw)
  To: Samuel Holland
  Cc: linux-sunxi, linux-arm-kernel, linux-kernel, devicetree,
	Chen-Yu Tsai, Rob Herring, Chanwoo Choi, Jernej Skrabec,
	Maxime Ripard, Krzysztof Kozlowski

On Fri, 01 Jul 2022 23:24:47 -0500, Samuel Holland wrote:
> All of the sunxi SoCs since at least the A33 have a similar structure
> for the MBUS and DRAM controller, but they all have minor differences in
> MBUS port assignments and DRAM controller behavior. Give each SoC its
> own compatible.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles
  2022-07-02  4:24   ` Samuel Holland
@ 2022-07-07 20:06     ` Chanwoo Choi
  -1 siblings, 0 replies; 20+ messages in thread
From: Chanwoo Choi @ 2022-07-07 20:06 UTC (permalink / raw)
  To: Samuel Holland, Chen-Yu Tsai, Jernej Skrabec
  Cc: Chanwoo Choi, Krzysztof Kozlowski, Maxime Ripard, Rob Herring,
	devicetree, linux-arm-kernel, linux-kernel, linux-sunxi

Hi Samuel,

On 22. 7. 2. 13:24, Samuel Holland wrote:
> All of the sunxi SoCs since at least the A33 have a similar structure
> for the MBUS and DRAM controller, but they all have minor differences in
> MBUS port assignments and DRAM controller behavior. Give each SoC its
> own compatible.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> index 2b018feb56df..99566688d033 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> @@ -29,10 +29,20 @@ properties:
>    compatible:
>      enum:
>        - allwinner,sun5i-a13-mbus
> +      - allwinner,sun8i-a33-mbus
> +      - allwinner,sun8i-a50-mbus
> +      - allwinner,sun8i-a83t-mbus
>        - allwinner,sun8i-h3-mbus
>        - allwinner,sun8i-r40-mbus
> +      - allwinner,sun8i-v3s-mbus
> +      - allwinner,sun8i-v536-mbus
> +      - allwinner,sun20i-d1-mbus
>        - allwinner,sun50i-a64-mbus
> +      - allwinner,sun50i-a100-mbus
>        - allwinner,sun50i-h5-mbus
> +      - allwinner,sun50i-h6-mbus
> +      - allwinner,sun50i-h616-mbus
> +      - allwinner,sun50i-r329-mbus
>  
>    reg:
>      minItems: 1

I have a question. 
Are there the device drivers for the newly added compatible?

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles
@ 2022-07-07 20:06     ` Chanwoo Choi
  0 siblings, 0 replies; 20+ messages in thread
From: Chanwoo Choi @ 2022-07-07 20:06 UTC (permalink / raw)
  To: Samuel Holland, Chen-Yu Tsai, Jernej Skrabec
  Cc: Chanwoo Choi, Krzysztof Kozlowski, Maxime Ripard, Rob Herring,
	devicetree, linux-arm-kernel, linux-kernel, linux-sunxi

Hi Samuel,

On 22. 7. 2. 13:24, Samuel Holland wrote:
> All of the sunxi SoCs since at least the A33 have a similar structure
> for the MBUS and DRAM controller, but they all have minor differences in
> MBUS port assignments and DRAM controller behavior. Give each SoC its
> own compatible.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> index 2b018feb56df..99566688d033 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> @@ -29,10 +29,20 @@ properties:
>    compatible:
>      enum:
>        - allwinner,sun5i-a13-mbus
> +      - allwinner,sun8i-a33-mbus
> +      - allwinner,sun8i-a50-mbus
> +      - allwinner,sun8i-a83t-mbus
>        - allwinner,sun8i-h3-mbus
>        - allwinner,sun8i-r40-mbus
> +      - allwinner,sun8i-v3s-mbus
> +      - allwinner,sun8i-v536-mbus
> +      - allwinner,sun20i-d1-mbus
>        - allwinner,sun50i-a64-mbus
> +      - allwinner,sun50i-a100-mbus
>        - allwinner,sun50i-h5-mbus
> +      - allwinner,sun50i-h6-mbus
> +      - allwinner,sun50i-h616-mbus
> +      - allwinner,sun50i-r329-mbus
>  
>    reg:
>      minItems: 1

I have a question. 
Are there the device drivers for the newly added compatible?

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles
  2022-07-07 20:06     ` Chanwoo Choi
@ 2022-07-13  3:01       ` Samuel Holland
  -1 siblings, 0 replies; 20+ messages in thread
From: Samuel Holland @ 2022-07-13  3:01 UTC (permalink / raw)
  To: Chanwoo Choi, Chen-Yu Tsai, Jernej Skrabec
  Cc: Chanwoo Choi, Krzysztof Kozlowski, Maxime Ripard, Rob Herring,
	devicetree, linux-arm-kernel, linux-kernel, linux-sunxi

On 7/7/22 3:06 PM, Chanwoo Choi wrote:
> Hi Samuel,
> 
> On 22. 7. 2. 13:24, Samuel Holland wrote:
>> All of the sunxi SoCs since at least the A33 have a similar structure
>> for the MBUS and DRAM controller, but they all have minor differences in
>> MBUS port assignments and DRAM controller behavior. Give each SoC its
>> own compatible.
>>
>> Signed-off-by: Samuel Holland <samuel@sholland.org>
>> ---
>>
>>  .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> index 2b018feb56df..99566688d033 100644
>> --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> @@ -29,10 +29,20 @@ properties:
>>    compatible:
>>      enum:
>>        - allwinner,sun5i-a13-mbus
>> +      - allwinner,sun8i-a33-mbus
>> +      - allwinner,sun8i-a50-mbus
>> +      - allwinner,sun8i-a83t-mbus
>>        - allwinner,sun8i-h3-mbus
>>        - allwinner,sun8i-r40-mbus
>> +      - allwinner,sun8i-v3s-mbus
>> +      - allwinner,sun8i-v536-mbus
>> +      - allwinner,sun20i-d1-mbus
>>        - allwinner,sun50i-a64-mbus
>> +      - allwinner,sun50i-a100-mbus
>>        - allwinner,sun50i-h5-mbus
>> +      - allwinner,sun50i-h6-mbus
>> +      - allwinner,sun50i-h616-mbus
>> +      - allwinner,sun50i-r329-mbus
>>  
>>    reg:
>>      minItems: 1
> 
> I have a question. 
> Are there the device drivers for the newly added compatible?

There are not DVFS drivers yet. However, the nodes are needed for their
dma-ranges property, which affects some other devices that do have drivers. And
at least for D1, the MBUS node is used for U-Boot's DRAM driver.

Regards,
Samuel

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles
@ 2022-07-13  3:01       ` Samuel Holland
  0 siblings, 0 replies; 20+ messages in thread
From: Samuel Holland @ 2022-07-13  3:01 UTC (permalink / raw)
  To: Chanwoo Choi, Chen-Yu Tsai, Jernej Skrabec
  Cc: Chanwoo Choi, Krzysztof Kozlowski, Maxime Ripard, Rob Herring,
	devicetree, linux-arm-kernel, linux-kernel, linux-sunxi

On 7/7/22 3:06 PM, Chanwoo Choi wrote:
> Hi Samuel,
> 
> On 22. 7. 2. 13:24, Samuel Holland wrote:
>> All of the sunxi SoCs since at least the A33 have a similar structure
>> for the MBUS and DRAM controller, but they all have minor differences in
>> MBUS port assignments and DRAM controller behavior. Give each SoC its
>> own compatible.
>>
>> Signed-off-by: Samuel Holland <samuel@sholland.org>
>> ---
>>
>>  .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> index 2b018feb56df..99566688d033 100644
>> --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> @@ -29,10 +29,20 @@ properties:
>>    compatible:
>>      enum:
>>        - allwinner,sun5i-a13-mbus
>> +      - allwinner,sun8i-a33-mbus
>> +      - allwinner,sun8i-a50-mbus
>> +      - allwinner,sun8i-a83t-mbus
>>        - allwinner,sun8i-h3-mbus
>>        - allwinner,sun8i-r40-mbus
>> +      - allwinner,sun8i-v3s-mbus
>> +      - allwinner,sun8i-v536-mbus
>> +      - allwinner,sun20i-d1-mbus
>>        - allwinner,sun50i-a64-mbus
>> +      - allwinner,sun50i-a100-mbus
>>        - allwinner,sun50i-h5-mbus
>> +      - allwinner,sun50i-h6-mbus
>> +      - allwinner,sun50i-h616-mbus
>> +      - allwinner,sun50i-r329-mbus
>>  
>>    reg:
>>      minItems: 1
> 
> I have a question. 
> Are there the device drivers for the newly added compatible?

There are not DVFS drivers yet. However, the nodes are needed for their
dma-ranges property, which affects some other devices that do have drivers. And
at least for D1, the MBUS node is used for U-Boot's DRAM driver.

Regards,
Samuel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles
  2022-07-02  4:24   ` Samuel Holland
@ 2022-07-12  5:52     ` Icenowy Zheng
  -1 siblings, 0 replies; 20+ messages in thread
From: Icenowy Zheng @ 2022-07-12  5:52 UTC (permalink / raw)
  To: Samuel Holland, Chen-Yu Tsai, Jernej Skrabec
  Cc: Chanwoo Choi, Krzysztof Kozlowski, Maxime Ripard, Rob Herring,
	devicetree, linux-arm-kernel, linux-kernel, linux-sunxi

在 2022-07-01星期五的 23:24 -0500，Samuel Holland写道：
> All of the sunxi SoCs since at least the A33 have a similar structure
> for the MBUS and DRAM controller, but they all have minor differences
> in
> MBUS port assignments and DRAM controller behavior. Give each SoC its
> own compatible.

Should this kind of assignment be described in DT instead?

> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 10
> ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-
> mbus.yaml
> b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-
> mbus.yaml
> index 2b018feb56df..99566688d033 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-
> a10-mbus.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-
> a10-mbus.yaml
> @@ -29,10 +29,20 @@ properties:
>    compatible:
>      enum:
>        - allwinner,sun5i-a13-mbus
> +      - allwinner,sun8i-a33-mbus
> +      - allwinner,sun8i-a50-mbus
> +      - allwinner,sun8i-a83t-mbus
>        - allwinner,sun8i-h3-mbus
>        - allwinner,sun8i-r40-mbus
> +      - allwinner,sun8i-v3s-mbus
> +      - allwinner,sun8i-v536-mbus
> +      - allwinner,sun20i-d1-mbus
>        - allwinner,sun50i-a64-mbus
> +      - allwinner,sun50i-a100-mbus
>        - allwinner,sun50i-h5-mbus
> +      - allwinner,sun50i-h6-mbus
> +      - allwinner,sun50i-h616-mbus
> +      - allwinner,sun50i-r329-mbus
>  
>    reg:
>      minItems: 1



^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles
@ 2022-07-12  5:52     ` Icenowy Zheng
  0 siblings, 0 replies; 20+ messages in thread
From: Icenowy Zheng @ 2022-07-12  5:52 UTC (permalink / raw)
  To: Samuel Holland, Chen-Yu Tsai, Jernej Skrabec
  Cc: Chanwoo Choi, Krzysztof Kozlowski, Maxime Ripard, Rob Herring,
	devicetree, linux-arm-kernel, linux-kernel, linux-sunxi

在 2022-07-01星期五的 23:24 -0500，Samuel Holland写道：
> All of the sunxi SoCs since at least the A33 have a similar structure
> for the MBUS and DRAM controller, but they all have minor differences
> in
> MBUS port assignments and DRAM controller behavior. Give each SoC its
> own compatible.

Should this kind of assignment be described in DT instead?

> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 10
> ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-
> mbus.yaml
> b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-
> mbus.yaml
> index 2b018feb56df..99566688d033 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-
> a10-mbus.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-
> a10-mbus.yaml
> @@ -29,10 +29,20 @@ properties:
>    compatible:
>      enum:
>        - allwinner,sun5i-a13-mbus
> +      - allwinner,sun8i-a33-mbus
> +      - allwinner,sun8i-a50-mbus
> +      - allwinner,sun8i-a83t-mbus
>        - allwinner,sun8i-h3-mbus
>        - allwinner,sun8i-r40-mbus
> +      - allwinner,sun8i-v3s-mbus
> +      - allwinner,sun8i-v536-mbus
> +      - allwinner,sun20i-d1-mbus
>        - allwinner,sun50i-a64-mbus
> +      - allwinner,sun50i-a100-mbus
>        - allwinner,sun50i-h5-mbus
> +      - allwinner,sun50i-h6-mbus
> +      - allwinner,sun50i-h616-mbus
> +      - allwinner,sun50i-r329-mbus
>  
>    reg:
>      minItems: 1



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm: sunxi: Default to the full MBUS binding
  2022-07-02  4:24 ` Samuel Holland
@ 2022-07-02 19:41   ` Jernej Škrabec
  -1 siblings, 0 replies; 20+ messages in thread
From: Jernej Škrabec @ 2022-07-02 19:41 UTC (permalink / raw)
  To: Chen-Yu Tsai, Samuel Holland
  Cc: Samuel Holland, Chanwoo Choi, Krzysztof Kozlowski, Maxime Ripard,
	Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
	linux-sunxi

Dne sobota, 02. julij 2022 ob 06:24:46 CEST je Samuel Holland napisal(a):
> Some older SoCs use a deprecated MBUS binding with some clocks missing.
> Currently, new SoCs must opt in to the complete binding. This should be
> the default, so new SoCs do not accidentally use the deprecated version.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej



^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm: sunxi: Default to the full MBUS binding
@ 2022-07-02 19:41   ` Jernej Škrabec
  0 siblings, 0 replies; 20+ messages in thread
From: Jernej Škrabec @ 2022-07-02 19:41 UTC (permalink / raw)
  To: Chen-Yu Tsai, Samuel Holland
  Cc: Samuel Holland, Chanwoo Choi, Krzysztof Kozlowski, Maxime Ripard,
	Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
	linux-sunxi

Dne sobota, 02. julij 2022 ob 06:24:46 CEST je Samuel Holland napisal(a):
> Some older SoCs use a deprecated MBUS binding with some clocks missing.
> Currently, new SoCs must opt in to the complete binding. This should be
> the default, so new SoCs do not accidentally use the deprecated version.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm: sunxi: Default to the full MBUS binding
  2022-07-02  4:24 ` Samuel Holland
@ 2022-07-05 20:29   ` Rob Herring
  -1 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2022-07-05 20:29 UTC (permalink / raw)
  To: Samuel Holland
  Cc: Rob Herring, Maxime Ripard, Chanwoo Choi, linux-sunxi,
	linux-kernel, devicetree, linux-arm-kernel, Chen-Yu Tsai,
	Krzysztof Kozlowski, Jernej Skrabec

On Fri, 01 Jul 2022 23:24:46 -0500, Samuel Holland wrote:
> Some older SoCs use a deprecated MBUS binding with some clocks missing.
> Currently, new SoCs must opt in to the complete binding. This should be
> the default, so new SoCs do not accidentally use the deprecated version.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  .../arm/sunxi/allwinner,sun4i-a10-mbus.yaml        | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm: sunxi: Default to the full MBUS binding
@ 2022-07-05 20:29   ` Rob Herring
  0 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2022-07-05 20:29 UTC (permalink / raw)
  To: Samuel Holland
  Cc: Rob Herring, Maxime Ripard, Chanwoo Choi, linux-sunxi,
	linux-kernel, devicetree, linux-arm-kernel, Chen-Yu Tsai,
	Krzysztof Kozlowski, Jernej Skrabec

On Fri, 01 Jul 2022 23:24:46 -0500, Samuel Holland wrote:
> Some older SoCs use a deprecated MBUS binding with some clocks missing.
> Currently, new SoCs must opt in to the complete binding. This should be
> the default, so new SoCs do not accidentally use the deprecated version.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  .../arm/sunxi/allwinner,sun4i-a10-mbus.yaml        | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm: sunxi: Default to the full MBUS binding
  2022-07-02  4:24 ` Samuel Holland
@ 2022-07-08 16:50   ` Jernej Škrabec
  -1 siblings, 0 replies; 20+ messages in thread
From: Jernej Škrabec @ 2022-07-08 16:50 UTC (permalink / raw)
  To: Chen-Yu Tsai, Samuel Holland
  Cc: Samuel Holland, Chanwoo Choi, Krzysztof Kozlowski, Maxime Ripard,
	Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
	linux-sunxi

Dne sobota, 02. julij 2022 ob 06:24:46 CEST je Samuel Holland napisal(a):
> Some older SoCs use a deprecated MBUS binding with some clocks missing.
> Currently, new SoCs must opt in to the complete binding. This should be
> the default, so new SoCs do not accidentally use the deprecated version.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Applied both, thanks!

Best regards,
Jernej



^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm: sunxi: Default to the full MBUS binding
@ 2022-07-08 16:50   ` Jernej Škrabec
  0 siblings, 0 replies; 20+ messages in thread
From: Jernej Škrabec @ 2022-07-08 16:50 UTC (permalink / raw)
  To: Chen-Yu Tsai, Samuel Holland
  Cc: Samuel Holland, Chanwoo Choi, Krzysztof Kozlowski, Maxime Ripard,
	Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
	linux-sunxi

Dne sobota, 02. julij 2022 ob 06:24:46 CEST je Samuel Holland napisal(a):
> Some older SoCs use a deprecated MBUS binding with some clocks missing.
> Currently, new SoCs must opt in to the complete binding. This should be
> the default, so new SoCs do not accidentally use the deprecated version.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Applied both, thanks!

Best regards,
Jernej



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2022-07-13  3:02 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-02  4:24 [PATCH 1/2] dt-bindings: arm: sunxi: Default to the full MBUS binding Samuel Holland
2022-07-02  4:24 ` Samuel Holland
2022-07-02  4:24 ` [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles Samuel Holland
2022-07-02  4:24   ` Samuel Holland
2022-07-02 19:46   ` Jernej Škrabec
2022-07-02 19:46     ` Jernej Škrabec
2022-07-05 20:29   ` Rob Herring
2022-07-05 20:29     ` Rob Herring
2022-07-07 20:06   ` Chanwoo Choi
2022-07-07 20:06     ` Chanwoo Choi
2022-07-13  3:01     ` Samuel Holland
2022-07-13  3:01       ` Samuel Holland
2022-07-12  5:52   ` Icenowy Zheng
2022-07-12  5:52     ` Icenowy Zheng
2022-07-02 19:41 ` [PATCH 1/2] dt-bindings: arm: sunxi: Default to the full MBUS binding Jernej Škrabec
2022-07-02 19:41   ` Jernej Škrabec
2022-07-05 20:29 ` Rob Herring
2022-07-05 20:29   ` Rob Herring
2022-07-08 16:50 ` Jernej Škrabec
2022-07-08 16:50   ` Jernej Škrabec

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.