* [PATCH] drm/amdgpu: Remove one duplicated ef removal
@ 2022-07-08 1:53 xinhui pan
2022-07-08 10:04 ` Christian König
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: xinhui pan @ 2022-07-08 1:53 UTC (permalink / raw)
To: amd-gfx; +Cc: alexander.deucher, Felix.Kuehling, xinhui pan, christian.koenig
That has been done in BO release notify.
Signed-off-by: xinhui pan <xinhui.pan@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
index 0f9811d02f61..49536fa8d269 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
@@ -1583,11 +1583,6 @@ void amdgpu_amdkfd_gpuvm_destroy_cb(struct amdgpu_device *adev,
if (!process_info)
return;
- /* Release eviction fence from PD */
- amdgpu_bo_reserve(pd, false);
- amdgpu_bo_fence(pd, NULL, false);
- amdgpu_bo_unreserve(pd);
-
/* Update process info */
mutex_lock(&process_info->lock);
process_info->n_vms--;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu: Remove one duplicated ef removal
2022-07-08 1:53 [PATCH] drm/amdgpu: Remove one duplicated ef removal xinhui pan
@ 2022-07-08 10:04 ` Christian König
2022-07-08 21:00 ` Felix Kuehling
2022-07-19 8:31 ` Mike Lothian
2 siblings, 0 replies; 5+ messages in thread
From: Christian König @ 2022-07-08 10:04 UTC (permalink / raw)
To: xinhui pan, amd-gfx; +Cc: alexander.deucher, Felix.Kuehling, christian.koenig
Am 08.07.22 um 03:53 schrieb xinhui pan:
> That has been done in BO release notify.
>
> Signed-off-by: xinhui pan <xinhui.pan@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index 0f9811d02f61..49536fa8d269 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -1583,11 +1583,6 @@ void amdgpu_amdkfd_gpuvm_destroy_cb(struct amdgpu_device *adev,
> if (!process_info)
> return;
>
> - /* Release eviction fence from PD */
> - amdgpu_bo_reserve(pd, false);
> - amdgpu_bo_fence(pd, NULL, false);
> - amdgpu_bo_unreserve(pd);
> -
> /* Update process info */
> mutex_lock(&process_info->lock);
> process_info->n_vms--;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu: Remove one duplicated ef removal
2022-07-08 1:53 [PATCH] drm/amdgpu: Remove one duplicated ef removal xinhui pan
2022-07-08 10:04 ` Christian König
@ 2022-07-08 21:00 ` Felix Kuehling
2022-07-19 8:31 ` Mike Lothian
2 siblings, 0 replies; 5+ messages in thread
From: Felix Kuehling @ 2022-07-08 21:00 UTC (permalink / raw)
To: xinhui pan, amd-gfx; +Cc: alexander.deucher, christian.koenig
On 2022-07-07 21:53, xinhui pan wrote:
> That has been done in BO release notify.
>
> Signed-off-by: xinhui pan <xinhui.pan@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index 0f9811d02f61..49536fa8d269 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -1583,11 +1583,6 @@ void amdgpu_amdkfd_gpuvm_destroy_cb(struct amdgpu_device *adev,
> if (!process_info)
> return;
>
> - /* Release eviction fence from PD */
> - amdgpu_bo_reserve(pd, false);
> - amdgpu_bo_fence(pd, NULL, false);
> - amdgpu_bo_unreserve(pd);
> -
> /* Update process info */
> mutex_lock(&process_info->lock);
> process_info->n_vms--;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu: Remove one duplicated ef removal
2022-07-08 1:53 [PATCH] drm/amdgpu: Remove one duplicated ef removal xinhui pan
2022-07-08 10:04 ` Christian König
2022-07-08 21:00 ` Felix Kuehling
@ 2022-07-19 8:31 ` Mike Lothian
2022-07-19 19:49 ` Alex Deucher
2 siblings, 1 reply; 5+ messages in thread
From: Mike Lothian @ 2022-07-19 8:31 UTC (permalink / raw)
To: xinhui pan; +Cc: alexander.deucher, Felix.Kuehling, christian.koenig, amd-gfx
With this patch applied on Linus's tree 5.18-rc7 I get the following warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1367:20: warning:
unused variable 'pd' [-Wunused-variable]
struct amdgpu_bo *pd = vm->root.bo;
^
1 warning generated.
It does fix the nullpointer though :D
On Fri, 8 Jul 2022 at 02:55, xinhui pan <xinhui.pan@amd.com> wrote:
>
> That has been done in BO release notify.
>
> Signed-off-by: xinhui pan <xinhui.pan@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index 0f9811d02f61..49536fa8d269 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -1583,11 +1583,6 @@ void amdgpu_amdkfd_gpuvm_destroy_cb(struct amdgpu_device *adev,
> if (!process_info)
> return;
>
> - /* Release eviction fence from PD */
> - amdgpu_bo_reserve(pd, false);
> - amdgpu_bo_fence(pd, NULL, false);
> - amdgpu_bo_unreserve(pd);
> -
> /* Update process info */
> mutex_lock(&process_info->lock);
> process_info->n_vms--;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu: Remove one duplicated ef removal
2022-07-19 8:31 ` Mike Lothian
@ 2022-07-19 19:49 ` Alex Deucher
0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2022-07-19 19:49 UTC (permalink / raw)
To: Mike Lothian
Cc: alexander.deucher, Felix.Kuehling, xinhui pan, christian.koenig, amd-gfx
On Tue, Jul 19, 2022 at 4:32 AM Mike Lothian <mike@fireburn.co.uk> wrote:
>
> With this patch applied on Linus's tree 5.18-rc7 I get the following warning:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1367:20: warning:
> unused variable 'pd' [-Wunused-variable]
> struct amdgpu_bo *pd = vm->root.bo;
> ^
> 1 warning generated.
>
> It does fix the nullpointer though :D
I fixed that up when I pulled the patch in.
Alex
>
>
> On Fri, 8 Jul 2022 at 02:55, xinhui pan <xinhui.pan@amd.com> wrote:
> >
> > That has been done in BO release notify.
> >
> > Signed-off-by: xinhui pan <xinhui.pan@amd.com>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> > index 0f9811d02f61..49536fa8d269 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> > @@ -1583,11 +1583,6 @@ void amdgpu_amdkfd_gpuvm_destroy_cb(struct amdgpu_device *adev,
> > if (!process_info)
> > return;
> >
> > - /* Release eviction fence from PD */
> > - amdgpu_bo_reserve(pd, false);
> > - amdgpu_bo_fence(pd, NULL, false);
> > - amdgpu_bo_unreserve(pd);
> > -
> > /* Update process info */
> > mutex_lock(&process_info->lock);
> > process_info->n_vms--;
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-19 19:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-08 1:53 [PATCH] drm/amdgpu: Remove one duplicated ef removal xinhui pan
2022-07-08 10:04 ` Christian König
2022-07-08 21:00 ` Felix Kuehling
2022-07-19 8:31 ` Mike Lothian
2022-07-19 19:49 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.