From: kernel test robot <lkp@intel.com>
To: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
paul@crapouillou.net, lgirdwood@gmail.com, broonie@kernel.org,
perex@perex.cz, tiwai@suse.com
Cc: kbuild-all@lists.01.org, linux-mips@vger.kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 11/11] ASoC: jz4740-i2s: Refactor DAI probe/remove ops as component ops
Date: Fri, 8 Jul 2022 08:43:24 +0800 [thread overview]
Message-ID: <202207080814.p8h1it9G-lkp@intel.com> (raw)
In-Reply-To: <20220707194655.312892-12-aidanmacdonald.0x0@gmail.com>
Hi Aidan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on broonie-sound/for-next]
[cannot apply to linus/master v5.19-rc5 next-20220707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Aidan-MacDonald/ASoC-cleanups-and-improvements-for-jz4740-i2s/20220708-034953
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: s390-randconfig-m031-20220707 (https://download.01.org/0day-ci/archive/20220708/202207080814.p8h1it9G-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/d990302616fcc22f1e2a3b963c25fdec9d787251
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Aidan-MacDonald/ASoC-cleanups-and-improvements-for-jz4740-i2s/20220708-034953
git checkout d990302616fcc22f1e2a3b963c25fdec9d787251
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash sound/soc/jz4740/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
sound/soc/jz4740/jz4740-i2s.c: In function 'jz4740_i2s_probe':
>> sound/soc/jz4740/jz4740-i2s.c:442:9: error: 'ret' undeclared (first use in this function); did you mean 'net'?
442 | ret = clk_prepare_enable(i2s->clk_aic);
| ^~~
| net
sound/soc/jz4740/jz4740-i2s.c:442:9: note: each undeclared identifier is reported only once for each function it appears in
vim +442 sound/soc/jz4740/jz4740-i2s.c
437
438 static int jz4740_i2s_probe(struct snd_soc_component *component)
439 {
440 struct jz4740_i2s *i2s = snd_soc_component_get_drvdata(component);
441
> 442 ret = clk_prepare_enable(i2s->clk_aic);
443 if (ret)
444 return ret;
445
446 regmap_write(i2s->regmap, JZ_REG_AIC_CONF, JZ_AIC_CONF_RESET);
447
448 regmap_write(i2s->regmap, JZ_REG_AIC_CONF,
449 JZ_AIC_CONF_OVERFLOW_PLAY_LAST |
450 JZ_AIC_CONF_I2S | JZ_AIC_CONF_INTERNAL_CODEC);
451
452 regmap_field_write(i2s->field_rx_fifo_thresh, 7);
453 regmap_field_write(i2s->field_tx_fifo_thresh, 8);
454
455 return 0;
456 }
457
--
0-DAY CI Kernel Test Service
https://01.org/lkp
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
paul@crapouillou.net, lgirdwood@gmail.com, broonie@kernel.org,
perex@perex.cz, tiwai@suse.com
Cc: alsa-devel@alsa-project.org, kbuild-all@lists.01.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 11/11] ASoC: jz4740-i2s: Refactor DAI probe/remove ops as component ops
Date: Fri, 8 Jul 2022 08:43:24 +0800 [thread overview]
Message-ID: <202207080814.p8h1it9G-lkp@intel.com> (raw)
In-Reply-To: <20220707194655.312892-12-aidanmacdonald.0x0@gmail.com>
Hi Aidan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on broonie-sound/for-next]
[cannot apply to linus/master v5.19-rc5 next-20220707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Aidan-MacDonald/ASoC-cleanups-and-improvements-for-jz4740-i2s/20220708-034953
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: s390-randconfig-m031-20220707 (https://download.01.org/0day-ci/archive/20220708/202207080814.p8h1it9G-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/d990302616fcc22f1e2a3b963c25fdec9d787251
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Aidan-MacDonald/ASoC-cleanups-and-improvements-for-jz4740-i2s/20220708-034953
git checkout d990302616fcc22f1e2a3b963c25fdec9d787251
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash sound/soc/jz4740/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
sound/soc/jz4740/jz4740-i2s.c: In function 'jz4740_i2s_probe':
>> sound/soc/jz4740/jz4740-i2s.c:442:9: error: 'ret' undeclared (first use in this function); did you mean 'net'?
442 | ret = clk_prepare_enable(i2s->clk_aic);
| ^~~
| net
sound/soc/jz4740/jz4740-i2s.c:442:9: note: each undeclared identifier is reported only once for each function it appears in
vim +442 sound/soc/jz4740/jz4740-i2s.c
437
438 static int jz4740_i2s_probe(struct snd_soc_component *component)
439 {
440 struct jz4740_i2s *i2s = snd_soc_component_get_drvdata(component);
441
> 442 ret = clk_prepare_enable(i2s->clk_aic);
443 if (ret)
444 return ret;
445
446 regmap_write(i2s->regmap, JZ_REG_AIC_CONF, JZ_AIC_CONF_RESET);
447
448 regmap_write(i2s->regmap, JZ_REG_AIC_CONF,
449 JZ_AIC_CONF_OVERFLOW_PLAY_LAST |
450 JZ_AIC_CONF_I2S | JZ_AIC_CONF_INTERNAL_CODEC);
451
452 regmap_field_write(i2s->field_rx_fifo_thresh, 7);
453 regmap_field_write(i2s->field_tx_fifo_thresh, 8);
454
455 return 0;
456 }
457
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-07-08 0:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 19:46 [PATCH v2 0/11] ASoC: cleanups and improvements for jz4740-i2s Aidan MacDonald
2022-07-07 19:46 ` Aidan MacDonald
2022-07-07 19:46 ` [PATCH v2 01/11] ASoC: jz4740-i2s: Remove unused 'mem' resource Aidan MacDonald
2022-07-07 19:46 ` Aidan MacDonald
2022-07-07 20:19 ` Paul Cercueil
2022-07-07 20:19 ` Paul Cercueil
2022-07-07 19:46 ` [PATCH v2 02/11] ASoC: jz4740-i2s: Convert to regmap API Aidan MacDonald
2022-07-07 19:46 ` Aidan MacDonald
2022-07-07 19:46 ` [PATCH v2 03/11] ASoC: jz4740-i2s: Simplify using regmap fields Aidan MacDonald
2022-07-07 19:46 ` Aidan MacDonald
2022-07-07 19:46 ` [PATCH v2 04/11] ASoC: jz4740-i2s: Handle independent FIFO flush bits Aidan MacDonald
2022-07-07 19:46 ` Aidan MacDonald
2022-07-07 19:46 ` [PATCH v2 05/11] ASoC: jz4740-i2s: Use FIELD_PREP() macros in hw_params callback Aidan MacDonald
2022-07-07 19:46 ` Aidan MacDonald
2022-07-07 19:46 ` [PATCH v2 06/11] ASoC: jz4740-i2s: Align macro values and sort includes Aidan MacDonald
2022-07-07 19:46 ` Aidan MacDonald
2022-07-07 19:46 ` [PATCH v2 07/11] ASoC: jz4740-i2s: Make the PLL clock name SoC-specific Aidan MacDonald
2022-07-07 19:46 ` Aidan MacDonald
2022-07-07 19:46 ` [PATCH v2 08/11] ASoC: jz4740-i2s: Support S20_LE and S24_LE sample formats Aidan MacDonald
2022-07-07 19:46 ` Aidan MacDonald
2022-07-07 19:46 ` [PATCH v2 09/11] ASoC: jz4740-i2s: Support continuous sample rate Aidan MacDonald
2022-07-07 19:46 ` Aidan MacDonald
2022-07-07 19:46 ` [PATCH v2 10/11] ASoC: jz4740-i2s: Move component functions near the component driver Aidan MacDonald
2022-07-07 19:46 ` Aidan MacDonald
2022-07-07 19:46 ` [PATCH v2 11/11] ASoC: jz4740-i2s: Refactor DAI probe/remove ops as component ops Aidan MacDonald
2022-07-07 19:46 ` Aidan MacDonald
2022-07-08 0:43 ` kernel test robot [this message]
2022-07-08 0:43 ` kernel test robot
2022-07-08 4:48 ` kernel test robot
2022-07-08 4:48 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202207080814.p8h1it9G-lkp@intel.com \
--to=lkp@intel.com \
--cc=aidanmacdonald.0x0@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.