From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Subject: [PATCH 1/5] configure: Add missing POSIX-required space
Date: Wed, 20 Jul 2022 16:26:27 +0100 [thread overview]
Message-ID: <20220720152631.450903-2-peter.maydell@linaro.org> (raw)
In-Reply-To: <20220720152631.450903-1-peter.maydell@linaro.org>
In commit 7d7dbf9dc15be6e1 we added a line to the configure script
which is not valid POSIX shell syntax, because it is missing a space
after a '!' character. shellcheck diagnoses this:
if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then
^-- SC1035: You are missing a required space after the !.
and the OpenBSD shell will not correctly handle this without the space.
Fixes: 7d7dbf9dc15be6e1 ("configure: replace --enable/disable-git-update with --with-git-submodules")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
David Gilbert noted the OpenBSD issue on IRC -- I have not tested
this fix there myself.
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 35e0b281985..dec6f030346 100755
--- a/configure
+++ b/configure
@@ -2425,7 +2425,7 @@ else
cxx=
fi
-if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then
+if ! (GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then
exit 1
fi
--
2.25.1
next prev parent reply other threads:[~2022-07-20 15:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 15:26 [PATCH 0/5] configure: fix some non-portabilities Peter Maydell
2022-07-20 15:26 ` Peter Maydell [this message]
2022-07-20 15:30 ` [PATCH 1/5] configure: Add missing POSIX-required space Thomas Huth
2022-07-20 16:01 ` Dr. David Alan Gilbert
2022-07-20 15:26 ` [PATCH 2/5] configure: Add braces to clarify intent of $emu[[:space:]] Peter Maydell
2022-07-20 15:36 ` Thomas Huth
2022-07-21 6:24 ` Markus Armbruster
2022-07-21 8:28 ` Peter Maydell
2022-07-20 15:26 ` [PATCH 3/5] configure: Don't use bash-specific string-replacement syntax Peter Maydell
2022-07-20 15:57 ` Thomas Huth
2022-07-20 16:29 ` Eric Blake
2022-07-20 17:32 ` Peter Maydell
2022-07-20 18:37 ` Eric Blake
2022-07-20 15:26 ` [PATCH 4/5] configure: Drop dead code attempting to use -msmall-data on alpha hosts Peter Maydell
2022-07-20 15:38 ` Thomas Huth
2022-07-20 15:26 ` [PATCH 5/5] configure: Avoid '==' bashism Peter Maydell
2022-07-20 15:39 ` Thomas Huth
2022-07-26 12:41 ` [PATCH 0/5] configure: fix some non-portabilities Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720152631.450903-2-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.