All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>
Subject: [PATCH 4/5] configure: Drop dead code attempting to use -msmall-data on alpha hosts
Date: Wed, 20 Jul 2022 16:26:30 +0100	[thread overview]
Message-ID: <20220720152631.450903-5-peter.maydell@linaro.org> (raw)
In-Reply-To: <20220720152631.450903-1-peter.maydell@linaro.org>

In commit 823eb013452e93d we moved the setting of ARCH from configure
to meson.build, but we accidentally left behind one attempt to use
$ARCH in configure, which was trying to add -msmall-data to the
compiler flags on Alpha hosts.  Since ARCH is now never set, the test
always fails and we never add the flag.

There isn't actually any need to use this compiler flag on Alpha:
the original intent was that it would allow us to simplify our TCG
codegen on that platform, but we never actually made the TCG changes
that would rely on -msmall-data.

Drop the effectively-dead code from configure, as we don't need it.

This was spotted by shellcheck:

In ./configure line 2254:
case "$ARCH" in
      ^---^ SC2153: Possible misspelling: ARCH may not be assigned, but arch is.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 configure | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/configure b/configure
index c05205b6085..d0e9a51462e 100755
--- a/configure
+++ b/configure
@@ -2251,13 +2251,6 @@ if test "$fortify_source" = "yes" ; then
   QEMU_CFLAGS="-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 $QEMU_CFLAGS"
 fi
 
-case "$ARCH" in
-alpha)
-  # Ensure there's only a single GP
-  QEMU_CFLAGS="-msmall-data $QEMU_CFLAGS"
-;;
-esac
-
 if test "$have_asan" = "yes"; then
   QEMU_CFLAGS="-fsanitize=address $QEMU_CFLAGS"
   QEMU_LDFLAGS="-fsanitize=address $QEMU_LDFLAGS"
-- 
2.25.1



  parent reply	other threads:[~2022-07-20 15:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 15:26 [PATCH 0/5] configure: fix some non-portabilities Peter Maydell
2022-07-20 15:26 ` [PATCH 1/5] configure: Add missing POSIX-required space Peter Maydell
2022-07-20 15:30   ` Thomas Huth
2022-07-20 16:01   ` Dr. David Alan Gilbert
2022-07-20 15:26 ` [PATCH 2/5] configure: Add braces to clarify intent of $emu[[:space:]] Peter Maydell
2022-07-20 15:36   ` Thomas Huth
2022-07-21  6:24   ` Markus Armbruster
2022-07-21  8:28     ` Peter Maydell
2022-07-20 15:26 ` [PATCH 3/5] configure: Don't use bash-specific string-replacement syntax Peter Maydell
2022-07-20 15:57   ` Thomas Huth
2022-07-20 16:29   ` Eric Blake
2022-07-20 17:32     ` Peter Maydell
2022-07-20 18:37       ` Eric Blake
2022-07-20 15:26 ` Peter Maydell [this message]
2022-07-20 15:38   ` [PATCH 4/5] configure: Drop dead code attempting to use -msmall-data on alpha hosts Thomas Huth
2022-07-20 15:26 ` [PATCH 5/5] configure: Avoid '==' bashism Peter Maydell
2022-07-20 15:39   ` Thomas Huth
2022-07-26 12:41 ` [PATCH 0/5] configure: fix some non-portabilities Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220720152631.450903-5-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=dgilbert@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.