All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH 5/5] configure: Avoid '==' bashism
Date: Wed, 20 Jul 2022 17:39:08 +0200	[thread overview]
Message-ID: <26c89926-5d96-bb9c-130a-2e5052de1a1e@redhat.com> (raw)
In-Reply-To: <20220720152631.450903-6-peter.maydell@linaro.org>

On 20/07/2022 17.26, Peter Maydell wrote:
> The '==' operator to test is a bashism; the standard way to copmare
> strings is '='. This causes dash to complain:
> 
> ../../configure: 681: test: linux: unexpected operator
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index d0e9a51462e..2c19329d58c 100755
> --- a/configure
> +++ b/configure
> @@ -678,7 +678,7 @@ werror=""
>   
>   meson_option_build_array() {
>     printf '['
> -  (if test "$targetos" == windows; then
> +  (if test "$targetos" = windows; then
>       IFS=\;
>     else
>       IFS=:

Reviewed-by: Thomas Huth <thuth@redhat.com>



  reply	other threads:[~2022-07-20 15:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 15:26 [PATCH 0/5] configure: fix some non-portabilities Peter Maydell
2022-07-20 15:26 ` [PATCH 1/5] configure: Add missing POSIX-required space Peter Maydell
2022-07-20 15:30   ` Thomas Huth
2022-07-20 16:01   ` Dr. David Alan Gilbert
2022-07-20 15:26 ` [PATCH 2/5] configure: Add braces to clarify intent of $emu[[:space:]] Peter Maydell
2022-07-20 15:36   ` Thomas Huth
2022-07-21  6:24   ` Markus Armbruster
2022-07-21  8:28     ` Peter Maydell
2022-07-20 15:26 ` [PATCH 3/5] configure: Don't use bash-specific string-replacement syntax Peter Maydell
2022-07-20 15:57   ` Thomas Huth
2022-07-20 16:29   ` Eric Blake
2022-07-20 17:32     ` Peter Maydell
2022-07-20 18:37       ` Eric Blake
2022-07-20 15:26 ` [PATCH 4/5] configure: Drop dead code attempting to use -msmall-data on alpha hosts Peter Maydell
2022-07-20 15:38   ` Thomas Huth
2022-07-20 15:26 ` [PATCH 5/5] configure: Avoid '==' bashism Peter Maydell
2022-07-20 15:39   ` Thomas Huth [this message]
2022-07-26 12:41 ` [PATCH 0/5] configure: fix some non-portabilities Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26c89926-5d96-bb9c-130a-2e5052de1a1e@redhat.com \
    --to=thuth@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.