All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Kepplinger <martin.kepplinger@puri.sm>
To: rafael@kernel.org, khilman@kernel.org, ulf.hansson@linaro.org,
	robh@kernel.org, krzysztof.kozlowski@linaro.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
	pavel@ucw.cz
Cc: kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org,
	l.stach@pengutronix.de, aford173@gmail.com,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Martin Kepplinger <martin.kepplinger@puri.sm>
Subject: [PATCH v6 0/2] power: domain: handle power supplies that need interrupts
Date: Tue, 26 Jul 2022 10:32:55 +0200	[thread overview]
Message-ID: <20220726083257.1730630-1-martin.kepplinger@puri.sm> (raw)

hi Ulf, Lucas and all interested,

This makes available a new genpd flag GENPD_FLAG_IRQ_ON in a relatively
generic way:
genpd providers can set it when irqs are needed to manage power on/off.
Since the main goal here has been to fix systemd suspend/resume,
adjusting these callbacks is all that's being done when this flag gets set.

And since I'm working on imx8mq, the 2nd patch makes gpcv2 set this new
flag when a power domain has a power-supply described in DT.
For i.MX8M* platforms, this should be ok. For other platforms this might
be useful too but needs to be tested.


revision history
----------------
v6: (thank you Ulf and Lucas)
* drop the cleanup patch to use BIT()
* use of_property_read_bool() to find the power-supply
* clean up the callback assignment
* remove the wrong error printing
  (flag-check can be added later to *drivers* that have noirq callbacks)

v5: (thank you Lucas)
* simplify gpcv2 code: just set GENPD_FLAG_IRQ_ON when a power-supply is present
https://lore.kernel.org/linux-arm-kernel/20220721043608.1527686-1-martin.kepplinger@puri.sm/

v4: (thank you Ulf and Lucas)
* split up genpd core and gpcv2 changes
* set callbacks inside of pm_genpd_init()
* make flag name and description a bit more generic
* print an error in __genpd_dev_pm_attach() if there a "mismatch"
https://lore.kernel.org/linux-arm-kernel/20220720043444.1289952-1-martin.kepplinger@puri.sm/T/#t

v3: (thank you Ulf)
* move DT parsing to gpcv2 and create a genpd flag that gets set
https://lore.kernel.org/linux-arm-kernel/20220718210302.674897-1-martin.kepplinger@puri.sm/

v2: (thank you Krzysztof)
* rewrite: find possible regulators' interrupts property in parents
  instead of inventing a new property.
https://lore.kernel.org/linux-arm-kernel/20220712121832.3659769-1-martin.kepplinger@puri.sm/

v1: (initial idea)
https://lore.kernel.org/linux-arm-kernel/20220711094549.3445566-1-martin.kepplinger@puri.sm/T/#t



Martin Kepplinger (2):
  power: domain: handle genpd correctly when needing interrupts
  soc: imx: gpcv2: fix suspend/resume by setting GENPD_FLAG_IRQ_ON

 drivers/base/power/domain.c | 13 +++++++++++--
 drivers/soc/imx/gpcv2.c     |  3 +++
 include/linux/pm_domain.h   |  5 +++++
 3 files changed, 19 insertions(+), 2 deletions(-)

-- 
2.30.2


WARNING: multiple messages have this Message-ID (diff)
From: Martin Kepplinger <martin.kepplinger@puri.sm>
To: rafael@kernel.org, khilman@kernel.org, ulf.hansson@linaro.org,
	robh@kernel.org, krzysztof.kozlowski@linaro.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
	pavel@ucw.cz
Cc: kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org,
	l.stach@pengutronix.de, aford173@gmail.com,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Martin Kepplinger <martin.kepplinger@puri.sm>
Subject: [PATCH v6 0/2] power: domain: handle power supplies that need interrupts
Date: Tue, 26 Jul 2022 10:32:55 +0200	[thread overview]
Message-ID: <20220726083257.1730630-1-martin.kepplinger@puri.sm> (raw)

hi Ulf, Lucas and all interested,

This makes available a new genpd flag GENPD_FLAG_IRQ_ON in a relatively
generic way:
genpd providers can set it when irqs are needed to manage power on/off.
Since the main goal here has been to fix systemd suspend/resume,
adjusting these callbacks is all that's being done when this flag gets set.

And since I'm working on imx8mq, the 2nd patch makes gpcv2 set this new
flag when a power domain has a power-supply described in DT.
For i.MX8M* platforms, this should be ok. For other platforms this might
be useful too but needs to be tested.


revision history
----------------
v6: (thank you Ulf and Lucas)
* drop the cleanup patch to use BIT()
* use of_property_read_bool() to find the power-supply
* clean up the callback assignment
* remove the wrong error printing
  (flag-check can be added later to *drivers* that have noirq callbacks)

v5: (thank you Lucas)
* simplify gpcv2 code: just set GENPD_FLAG_IRQ_ON when a power-supply is present
https://lore.kernel.org/linux-arm-kernel/20220721043608.1527686-1-martin.kepplinger@puri.sm/

v4: (thank you Ulf and Lucas)
* split up genpd core and gpcv2 changes
* set callbacks inside of pm_genpd_init()
* make flag name and description a bit more generic
* print an error in __genpd_dev_pm_attach() if there a "mismatch"
https://lore.kernel.org/linux-arm-kernel/20220720043444.1289952-1-martin.kepplinger@puri.sm/T/#t

v3: (thank you Ulf)
* move DT parsing to gpcv2 and create a genpd flag that gets set
https://lore.kernel.org/linux-arm-kernel/20220718210302.674897-1-martin.kepplinger@puri.sm/

v2: (thank you Krzysztof)
* rewrite: find possible regulators' interrupts property in parents
  instead of inventing a new property.
https://lore.kernel.org/linux-arm-kernel/20220712121832.3659769-1-martin.kepplinger@puri.sm/

v1: (initial idea)
https://lore.kernel.org/linux-arm-kernel/20220711094549.3445566-1-martin.kepplinger@puri.sm/T/#t



Martin Kepplinger (2):
  power: domain: handle genpd correctly when needing interrupts
  soc: imx: gpcv2: fix suspend/resume by setting GENPD_FLAG_IRQ_ON

 drivers/base/power/domain.c | 13 +++++++++++--
 drivers/soc/imx/gpcv2.c     |  3 +++
 include/linux/pm_domain.h   |  5 +++++
 3 files changed, 19 insertions(+), 2 deletions(-)

-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2022-07-26  8:33 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26  8:32 Martin Kepplinger [this message]
2022-07-26  8:32 ` [PATCH v6 0/2] power: domain: handle power supplies that need interrupts Martin Kepplinger
2022-07-26  8:32 ` [PATCH v6 1/2] power: domain: handle genpd correctly when needing interrupts Martin Kepplinger
2022-07-26  8:32   ` Martin Kepplinger
2022-07-26 15:07   ` Ulf Hansson
2022-07-26 15:07     ` Ulf Hansson
2022-07-26 18:33     ` Rafael J. Wysocki
2022-07-26 18:33       ` Rafael J. Wysocki
2022-07-28  9:19       ` Ulf Hansson
2022-07-28  9:19         ` Ulf Hansson
2022-08-19  9:17     ` Martin Kepplinger
2022-08-19  9:17       ` Martin Kepplinger
2022-08-19 14:53       ` Ulf Hansson
2022-08-19 14:53         ` Ulf Hansson
2022-08-22  8:38         ` Martin Kepplinger
2022-08-22  8:38           ` Martin Kepplinger
2022-08-24 13:30           ` Ulf Hansson
2022-08-24 13:30             ` Ulf Hansson
2022-08-25  7:06             ` Martin Kepplinger
2022-08-25  7:06               ` Martin Kepplinger
2022-09-23 13:55               ` Ulf Hansson
2022-09-23 13:55                 ` Ulf Hansson
2022-09-26  9:52                 ` Martin Kepplinger
2022-09-26  9:52                   ` Martin Kepplinger
2023-06-21 18:20                 ` Martin Kepplinger
2023-06-21 18:20                   ` Martin Kepplinger
2023-06-26  9:50                   ` Ulf Hansson
2023-06-26  9:50                     ` Ulf Hansson
2022-07-26  8:32 ` [PATCH v6 2/2] soc: imx: gpcv2: fix suspend/resume by setting GENPD_FLAG_IRQ_ON Martin Kepplinger
2022-07-26  8:32   ` Martin Kepplinger
2022-07-26 15:08   ` Ulf Hansson
2022-07-26 15:08     ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220726083257.1730630-1-martin.kepplinger@puri.sm \
    --to=martin.kepplinger@puri.sm \
    --cc=aford173@gmail.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@puri.sm \
    --cc=khilman@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.