From: Enzo Matsumiya <ematsumiya@suse.de>
To: Steve French <smfrench@gmail.com>,
ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: CIFS <linux-cifs@vger.kernel.org>, Tom Talpey <tom@talpey.com>
Subject: Re: [WIP PATCH][CIFS] move legacy cifs (smb1) code to legacy ifdef and do not include in build when legacy disabled
Date: Mon, 1 Aug 2022 09:39:30 -0300 [thread overview]
Message-ID: <20220801123930.ltet3tadtdlf6hpq@cyberdelia> (raw)
In-Reply-To: <20220801121507.zpcnz55jj2qre3kh@cyberdelia>
On 08/01, Enzo Matsumiya wrote:
>On 08/01, ronnie sahlberg wrote:
>>Small nit : in cifssmb.c why comment out smb2proto.h, just delete the line.
>
>Agreed.
>
>@Steve also, why ifdef everything instead of putting everything in a
>"smb1" dir and just use Kconfig to build that dir? IOW like I did in in
>my branch https://github.com/ematsumiya/linux/commits/refactor
Just to be clear on the advantages of this: clean code (reduce those
ifdefs by a lot), move shared code to module top-level and fixes to
those code gets higher priority to the newer protocol versions, proper
isolation of smb1 code (separate dir) instead of a "virtual" one (ifdefs),
all that while we can also maintain history if using "git mv" to move
SMB1 specific files.
next prev parent reply other threads:[~2022-08-01 12:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 6:28 [WIP PATCH][CIFS] move legacy cifs (smb1) code to legacy ifdef and do not include in build when legacy disabled Steve French
2022-08-01 8:25 ` ronnie sahlberg
2022-08-01 12:15 ` Enzo Matsumiya
2022-08-01 12:39 ` Enzo Matsumiya [this message]
2022-08-01 15:49 ` Tom Talpey
2022-08-01 16:36 ` Steve French
2022-08-01 17:11 ` Enzo Matsumiya
2022-08-01 17:23 ` Steve French
2022-08-01 19:17 ` Tom Talpey
2022-08-01 19:44 ` Enzo Matsumiya
2022-08-01 19:46 ` Enzo Matsumiya
2022-08-01 16:04 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220801123930.ltet3tadtdlf6hpq@cyberdelia \
--to=ematsumiya@suse.de \
--cc=linux-cifs@vger.kernel.org \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.