From: Enzo Matsumiya <ematsumiya@suse.de>
To: Steve French <smfrench@gmail.com>
Cc: Tom Talpey <tom@talpey.com>,
ronnie sahlberg <ronniesahlberg@gmail.com>,
CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [WIP PATCH][CIFS] move legacy cifs (smb1) code to legacy ifdef and do not include in build when legacy disabled
Date: Mon, 1 Aug 2022 14:11:26 -0300 [thread overview]
Message-ID: <20220801171126.wotyb4mibyvrttio@cyberdelia> (raw)
In-Reply-To: <CAH2r5muP5ZgcsypLSFm1t2cE8x4n_8fmu7heoUiW5x2L6rN__Q@mail.gmail.com>
On 08/01, Steve French wrote:
>On Mon, Aug 1, 2022 at 10:49 AM Tom Talpey <tom@talpey.com> wrote:
>>
>> I think a big chunk of cifsfs.c, and a boatload of module params,
>> can be similarly conditionalized.
>
>Good point - and will make it easier to read as well. Perhaps I can
>move most of cifsfs.c to smbfs.c and just leave smb1 specific
>things in cifsfs.c so it can be optionally compiled out?
I'd suggest "core.c" (but smbfs.h) so it doesn't conflict with module name,
e.g.:
Makefile:
----
...
obj-$(CONFIG_SMBFS) += smbfs.o
smbfs-y := smbfs.o ...
...
----
next prev parent reply other threads:[~2022-08-01 17:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 6:28 [WIP PATCH][CIFS] move legacy cifs (smb1) code to legacy ifdef and do not include in build when legacy disabled Steve French
2022-08-01 8:25 ` ronnie sahlberg
2022-08-01 12:15 ` Enzo Matsumiya
2022-08-01 12:39 ` Enzo Matsumiya
2022-08-01 15:49 ` Tom Talpey
2022-08-01 16:36 ` Steve French
2022-08-01 17:11 ` Enzo Matsumiya [this message]
2022-08-01 17:23 ` Steve French
2022-08-01 19:17 ` Tom Talpey
2022-08-01 19:44 ` Enzo Matsumiya
2022-08-01 19:46 ` Enzo Matsumiya
2022-08-01 16:04 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220801171126.wotyb4mibyvrttio@cyberdelia \
--to=ematsumiya@suse.de \
--cc=linux-cifs@vger.kernel.org \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.