All of lore.kernel.org
 help / color / mirror / Atom feed
From: ronnie sahlberg <ronniesahlberg@gmail.com>
To: Steve French <smfrench@gmail.com>
Cc: CIFS <linux-cifs@vger.kernel.org>,
	Enzo Matsumiya <ematsumiya@suse.de>, Tom Talpey <tom@talpey.com>
Subject: Re: [WIP PATCH][CIFS] move legacy cifs (smb1) code to legacy ifdef and do not include in build when legacy disabled
Date: Mon, 1 Aug 2022 18:25:12 +1000	[thread overview]
Message-ID: <CAN05THRJTvA7huZjuW-tCPZjk6Nq_8EasjP6kQ0BGMBxBCtgqg@mail.gmail.com> (raw)
In-Reply-To: <CAH2r5mvX3UT0q50rmMb-WSt6eSxh1i_gcmPdDBW1x1Qn6ppDNg@mail.gmail.com>

Small nit : in cifssmb.c  why comment out smb2proto.h,  just delete the line.

Otherwise, a good first step. Good work.
Reviewed-by me.

Maybe we should now also add a warning to smb1 mounts that smb1 will
be disabled by default in say jan 2024 ?




On Mon, 1 Aug 2022 at 16:28, Steve French <smfrench@gmail.com> wrote:
>
> Currently much of the smb1 code is built even when
> CONFIG_CIFS_ALLOW_INSECURE_LEGACY is disabled.
>
> Move cifssmb.c to only be compiled when insecure legacy is disabled,
> and move various SMB1/CIFS helper functions to that ifdef.   Some
> functions that were not SMB1/CIFS specific needed to be moved out of
> cifssmb.c
>
> This shrinks cifs.ko by more than 10% which is good - but also will
> help with the eventual movement of the legacy code to a distinct
> module.
>
> See attached.
>
> --
> Thanks,
>
> Steve

  reply	other threads:[~2022-08-01  8:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-01  6:28 [WIP PATCH][CIFS] move legacy cifs (smb1) code to legacy ifdef and do not include in build when legacy disabled Steve French
2022-08-01  8:25 ` ronnie sahlberg [this message]
2022-08-01 12:15   ` Enzo Matsumiya
2022-08-01 12:39     ` Enzo Matsumiya
2022-08-01 15:49       ` Tom Talpey
2022-08-01 16:36         ` Steve French
2022-08-01 17:11           ` Enzo Matsumiya
2022-08-01 17:23             ` Steve French
2022-08-01 19:17           ` Tom Talpey
2022-08-01 19:44           ` Enzo Matsumiya
2022-08-01 19:46             ` Enzo Matsumiya
2022-08-01 16:04     ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN05THRJTvA7huZjuW-tCPZjk6Nq_8EasjP6kQ0BGMBxBCtgqg@mail.gmail.com \
    --to=ronniesahlberg@gmail.com \
    --cc=ematsumiya@suse.de \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.