All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: juno: Add missing MHU secure-irq
@ 2022-08-01 14:10 jassisinghbrar
  2022-08-15 14:24 ` Sudeep Holla
  0 siblings, 1 reply; 5+ messages in thread
From: jassisinghbrar @ 2022-08-01 14:10 UTC (permalink / raw)
  To: robh, krzysztof.kozlowski+dt, sudeep.holla
  Cc: linux-kernel, devicetree, Jassi Brar

From: Jassi Brar <jaswinder.singh@linaro.org>

The MHU secure interrupt exists physically but is missing in the DT node.

Specify the interrupt in DT node to fix a warning on Arm Juno board:
   mhu@2b1f0000: interrupts: [[0, 36, 4], [0, 35, 4]] is too short

Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
---
 arch/arm64/boot/dts/arm/juno-base.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
index 446c8f476eec0..fa3710c7c26c4 100644
--- a/arch/arm64/boot/dts/arm/juno-base.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
@@ -26,7 +26,8 @@ mailbox: mhu@2b1f0000 {
 		compatible = "arm,mhu", "arm,primecell";
 		reg = <0x0 0x2b1f0000 0x0 0x1000>;
 		interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
-			     <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
+			     <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
 		#mbox-cells = <1>;
 		clocks = <&soc_refclk100mhz>;
 		clock-names = "apb_pclk";
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: juno: Add missing MHU secure-irq
  2022-08-01 14:10 [PATCH] arm64: dts: juno: Add missing MHU secure-irq jassisinghbrar
@ 2022-08-15 14:24 ` Sudeep Holla
  0 siblings, 0 replies; 5+ messages in thread
From: Sudeep Holla @ 2022-08-15 14:24 UTC (permalink / raw)
  To: krzysztof.kozlowski+dt, robh, jassisinghbrar
  Cc: Sudeep Holla, linux-kernel, devicetree, jaswinder.singh

On Mon, 1 Aug 2022 09:10:05 -0500, jassisinghbrar@gmail.com wrote:
> From: Jassi Brar <jaswinder.singh@linaro.org>
> 
> The MHU secure interrupt exists physically but is missing in the DT node.
> 
> Specify the interrupt in DT node to fix a warning on Arm Juno board:
>    mhu@2b1f0000: interrupts: [[0, 36, 4], [0, 35, 4]] is too short
> 
> [...]

Applied to sudeep.holla/linux (for-next/juno), thanks!

[1/1] arm64: dts: juno: Add missing MHU secure-irq
      https://git.kernel.org/sudeep.holla/c/422ab8fe15

--
Regards,
Sudeep


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: juno: Add missing MHU secure-irq
  2022-08-01 10:33 ` Sudeep Holla
@ 2022-08-01 10:38   ` Sudeep Holla
  0 siblings, 0 replies; 5+ messages in thread
From: Sudeep Holla @ 2022-08-01 10:38 UTC (permalink / raw)
  To: jassisinghbrar
  Cc: robh, krzysztof.kozlowski+dt, linux-kernel, devicetree,
	Sudeep Holla, Jassi Brar

On Mon, Aug 01, 2022 at 11:33:08AM +0100, Sudeep Holla wrote:
> On Sat, Jul 30, 2022 at 09:23:36AM -0500, jassisinghbrar@gmail.com wrote:
> > From: Jassi Brar <jaswinder.singh@linaro.org>
> > 
> > The MHU secure interrupt exists physically but is missing in the DT node.
> > 
> > Specify the interrupt in DT node to fix a warning on Arm Juno board:
> >    mhu@2b1f0000: interrupts: [[0, 36, 4], [0, 35, 4]] is too short
> >
> 
> It fails to apply on v5.18-rc1 or v5.19. Can you please rebase and resend ?
> 

Sorry I meant v5.19-rc1 or v5.19 as my -next branch is based on the former.
IIUC the interrupt-names are dropped couple of release back as it was not
in the binding.

-- 
Regards,
Sudeep

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: juno: Add missing MHU secure-irq
  2022-07-30 14:23 jassisinghbrar
@ 2022-08-01 10:33 ` Sudeep Holla
  2022-08-01 10:38   ` Sudeep Holla
  0 siblings, 1 reply; 5+ messages in thread
From: Sudeep Holla @ 2022-08-01 10:33 UTC (permalink / raw)
  To: jassisinghbrar
  Cc: robh, krzysztof.kozlowski+dt, linux-kernel, devicetree,
	Sudeep Holla, Jassi Brar

On Sat, Jul 30, 2022 at 09:23:36AM -0500, jassisinghbrar@gmail.com wrote:
> From: Jassi Brar <jaswinder.singh@linaro.org>
> 
> The MHU secure interrupt exists physically but is missing in the DT node.
> 
> Specify the interrupt in DT node to fix a warning on Arm Juno board:
>    mhu@2b1f0000: interrupts: [[0, 36, 4], [0, 35, 4]] is too short
>

It fails to apply on v5.18-rc1 or v5.19. Can you please rebase and resend ?

-- 
Regards,
Sudeep

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] arm64: dts: juno: Add missing MHU secure-irq
@ 2022-07-30 14:23 jassisinghbrar
  2022-08-01 10:33 ` Sudeep Holla
  0 siblings, 1 reply; 5+ messages in thread
From: jassisinghbrar @ 2022-07-30 14:23 UTC (permalink / raw)
  To: robh, krzysztof.kozlowski+dt, sudeep.holla
  Cc: linux-kernel, devicetree, Jassi Brar

From: Jassi Brar <jaswinder.singh@linaro.org>

The MHU secure interrupt exists physically but is missing in the DT node.

Specify the interrupt in DT node to fix a warning on Arm Juno board:
   mhu@2b1f0000: interrupts: [[0, 36, 4], [0, 35, 4]] is too short

Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
---
 arch/arm64/boot/dts/arm/juno-base.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
index f6c55877fbd94..3220a00e9500d 100644
--- a/arch/arm64/boot/dts/arm/juno-base.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
@@ -26,9 +26,11 @@ mailbox: mhu@2b1f0000 {
 		compatible = "arm,mhu", "arm,primecell";
 		reg = <0x0 0x2b1f0000 0x0 0x1000>;
 		interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
-			     <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
+			     <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-names = "mhu_lpri_rx",
-				  "mhu_hpri_rx";
+				  "mhu_hpri_rx",
+				  "mhu_secure_rx";
 		#mbox-cells = <1>;
 		clocks = <&soc_refclk100mhz>;
 		clock-names = "apb_pclk";
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-08-15 14:24 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-01 14:10 [PATCH] arm64: dts: juno: Add missing MHU secure-irq jassisinghbrar
2022-08-15 14:24 ` Sudeep Holla
  -- strict thread matches above, loose matches on Subject: below --
2022-07-30 14:23 jassisinghbrar
2022-08-01 10:33 ` Sudeep Holla
2022-08-01 10:38   ` Sudeep Holla

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.