From: Yu Kuai <yukuai1@huaweicloud.com> To: tj@kernel.org, mkoutny@suse.com, axboe@kernel.dk, ming.lei@redhat.com Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com Subject: [PATCH v7 0/9] bugfix and cleanup for blk-throttle Date: Tue, 2 Aug 2022 22:04:06 +0800 [thread overview] Message-ID: <20220802140415.2960284-1-yukuai1@huaweicloud.com> (raw) From: Yu Kuai <yukuai3@huawei.com> Changes in v7: - add patch 5 to improve handling of re-entered bio for bps limit - as suggested by Tejun, add some comments - sdd some Acked tag by Tejun Changes in v6: - rename parameter in patch 3 - add comments and reviewed tag for patch 4 Changes in v5: - add comments in patch 4 - clear bytes/io_skipped in throtl_start_new_slice_with_credit() in patch 4 - and cleanup patches 5-8 Changes in v4: - add reviewed-by tag for patch 1 - add patch 2,3 - use a different way to fix io hung in patch 4 Changes in v3: - fix a check in patch 1 - fix link err in patch 2 on 32-bit platform - handle overflow in patch 2 Changes in v2: - use a new solution suggested by Ming - change the title of patch 1 - add patch 2 Patch 1 fix that blk-throttle can't work if multiple bios are throttle. Patch 2 fix overflow while calculating wait time. Patch 3,4 fix io hung due to configuration updates. Patch 5 improve handling of re-entered bio for bps limit. Patch 6-9 are cleanup patches, there are no functional changes, just some places that I think can be optimized during code review. Previous version: v1: https://lore.kernel.org/all/20220517134909.2910251-1-yukuai3@huawei.com/ v2: https://lore.kernel.org/all/20220518072751.1188163-1-yukuai3@huawei.com/ v3: https://lore.kernel.org/all/20220519085811.879097-1-yukuai3@huawei.com/ v4: https://lore.kernel.org/all/20220523082633.2324980-1-yukuai3@huawei.com/ v5: https://lore.kernel.org/all/20220528064330.3471000-1-yukuai3@huawei.com/ v6: https://lore.kernel.org/all/20220701093441.885741-1-yukuai1@huaweicloud.com/ Yu Kuai (9): blk-throttle: fix that io throttle can only work for single bio blk-throttle: prevent overflow while calculating wait time blk-throttle: factor out code to calculate ios/bytes_allowed blk-throttle: fix io hung due to configuration updates blk-throttle: improve handling of re-entered bio for bps limit blk-throttle: use 'READ/WRITE' instead of '0/1' blk-throttle: calling throtl_dequeue/enqueue_tg in pairs blk-throttle: cleanup tg_update_disptime() blk-throttle: clean up flag 'THROTL_TG_PENDING' block/blk-throttle.c | 175 ++++++++++++++++++++++++++++++------------- block/blk-throttle.h | 20 ++++- 2 files changed, 139 insertions(+), 56 deletions(-) -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Yu Kuai <yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org> To: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mkoutny-IBi9RG/b67k@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org, yi.zhang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org Subject: [PATCH v7 0/9] bugfix and cleanup for blk-throttle Date: Tue, 2 Aug 2022 22:04:06 +0800 [thread overview] Message-ID: <20220802140415.2960284-1-yukuai1@huaweicloud.com> (raw) From: Yu Kuai <yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Changes in v7: - add patch 5 to improve handling of re-entered bio for bps limit - as suggested by Tejun, add some comments - sdd some Acked tag by Tejun Changes in v6: - rename parameter in patch 3 - add comments and reviewed tag for patch 4 Changes in v5: - add comments in patch 4 - clear bytes/io_skipped in throtl_start_new_slice_with_credit() in patch 4 - and cleanup patches 5-8 Changes in v4: - add reviewed-by tag for patch 1 - add patch 2,3 - use a different way to fix io hung in patch 4 Changes in v3: - fix a check in patch 1 - fix link err in patch 2 on 32-bit platform - handle overflow in patch 2 Changes in v2: - use a new solution suggested by Ming - change the title of patch 1 - add patch 2 Patch 1 fix that blk-throttle can't work if multiple bios are throttle. Patch 2 fix overflow while calculating wait time. Patch 3,4 fix io hung due to configuration updates. Patch 5 improve handling of re-entered bio for bps limit. Patch 6-9 are cleanup patches, there are no functional changes, just some places that I think can be optimized during code review. Previous version: v1: https://lore.kernel.org/all/20220517134909.2910251-1-yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org/ v2: https://lore.kernel.org/all/20220518072751.1188163-1-yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org/ v3: https://lore.kernel.org/all/20220519085811.879097-1-yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org/ v4: https://lore.kernel.org/all/20220523082633.2324980-1-yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org/ v5: https://lore.kernel.org/all/20220528064330.3471000-1-yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org/ v6: https://lore.kernel.org/all/20220701093441.885741-1-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org/ Yu Kuai (9): blk-throttle: fix that io throttle can only work for single bio blk-throttle: prevent overflow while calculating wait time blk-throttle: factor out code to calculate ios/bytes_allowed blk-throttle: fix io hung due to configuration updates blk-throttle: improve handling of re-entered bio for bps limit blk-throttle: use 'READ/WRITE' instead of '0/1' blk-throttle: calling throtl_dequeue/enqueue_tg in pairs blk-throttle: cleanup tg_update_disptime() blk-throttle: clean up flag 'THROTL_TG_PENDING' block/blk-throttle.c | 175 ++++++++++++++++++++++++++++++------------- block/blk-throttle.h | 20 ++++- 2 files changed, 139 insertions(+), 56 deletions(-) -- 2.31.1
next reply other threads:[~2022-08-02 13:52 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-02 14:04 Yu Kuai [this message] 2022-08-02 14:04 ` [PATCH v7 0/9] bugfix and cleanup for blk-throttle Yu Kuai 2022-08-02 14:04 ` [PATCH v7 1/9] blk-throttle: fix that io throttle can only work for single bio Yu Kuai 2022-08-16 19:37 ` Tejun Heo 2022-08-17 1:13 ` Yu Kuai 2022-08-17 1:13 ` Yu Kuai 2022-08-17 17:50 ` Tejun Heo 2022-08-18 1:23 ` Yu Kuai 2022-08-18 1:23 ` Yu Kuai 2022-08-22 3:06 ` Yu Kuai 2022-08-22 3:06 ` Yu Kuai 2022-08-22 7:25 ` Tejun Heo 2022-08-22 7:25 ` Tejun Heo 2022-08-22 7:44 ` Yu Kuai 2022-08-22 7:44 ` Yu Kuai 2022-08-02 14:04 ` [PATCH v7 2/9] blk-throttle: prevent overflow while calculating wait time Yu Kuai 2022-08-02 14:04 ` [PATCH v7 3/9] blk-throttle: factor out code to calculate ios/bytes_allowed Yu Kuai 2022-08-02 14:04 ` Yu Kuai 2022-08-16 19:47 ` Tejun Heo 2022-08-17 1:32 ` Yu Kuai 2022-08-17 1:32 ` Yu Kuai 2022-08-02 14:04 ` [PATCH v7 4/9] blk-throttle: fix io hung due to configuration updates Yu Kuai 2022-08-02 14:04 ` Yu Kuai 2022-08-16 20:01 ` Tejun Heo 2022-08-16 20:01 ` Tejun Heo 2022-08-17 1:30 ` Yu Kuai 2022-08-17 1:30 ` Yu Kuai 2022-08-17 17:52 ` Tejun Heo 2022-08-17 17:52 ` Tejun Heo 2022-08-18 1:16 ` Yu Kuai 2022-08-18 1:16 ` Yu Kuai 2022-08-19 17:33 ` Tejun Heo 2022-08-19 17:33 ` Tejun Heo 2022-08-02 14:04 ` [PATCH v7 5/9] blk-throttle: improve handling of re-entered bio for bps limit Yu Kuai 2022-08-02 14:04 ` Yu Kuai 2022-08-16 20:02 ` Tejun Heo 2022-08-16 20:02 ` Tejun Heo 2022-08-02 14:04 ` [PATCH v7 6/9] blk-throttle: use 'READ/WRITE' instead of '0/1' Yu Kuai 2022-08-02 14:04 ` Yu Kuai 2022-08-16 20:03 ` Tejun Heo 2022-08-17 1:33 ` Yu Kuai 2022-08-17 1:33 ` Yu Kuai 2022-08-02 14:04 ` [PATCH v7 7/9] blk-throttle: calling throtl_dequeue/enqueue_tg in pairs Yu Kuai 2022-08-02 14:04 ` Yu Kuai 2022-08-02 14:04 ` [PATCH v7 8/9] blk-throttle: cleanup tg_update_disptime() Yu Kuai 2022-08-02 14:04 ` Yu Kuai 2022-08-16 20:09 ` Tejun Heo 2022-08-17 1:38 ` Yu Kuai 2022-08-17 1:38 ` Yu Kuai 2022-08-02 14:04 ` [PATCH v7 9/9] blk-throttle: clean up flag 'THROTL_TG_PENDING' Yu Kuai 2022-08-02 14:04 ` Yu Kuai 2022-08-16 20:14 ` Tejun Heo 2022-08-17 1:45 ` Yu Kuai 2022-08-17 1:45 ` Yu Kuai 2022-08-17 17:54 ` Tejun Heo 2022-08-17 17:54 ` Tejun Heo 2022-08-18 9:29 ` Yu Kuai 2022-08-18 9:29 ` Yu Kuai 2022-08-19 17:35 ` Tejun Heo 2022-08-19 17:35 ` Tejun Heo 2022-08-13 5:59 ` [PATCH v7 0/9] bugfix and cleanup for blk-throttle Yu Kuai 2022-08-13 5:59 ` Yu Kuai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220802140415.2960284-1-yukuai1@huaweicloud.com \ --to=yukuai1@huaweicloud.com \ --cc=axboe@kernel.dk \ --cc=cgroups@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=ming.lei@redhat.com \ --cc=mkoutny@suse.com \ --cc=tj@kernel.org \ --cc=yi.zhang@huawei.com \ --cc=yukuai3@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.