* [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw domain reset for gen12+
@ 2022-08-17 22:43 Radhakrishna Sripada
2022-08-17 23:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Radhakrishna Sripada @ 2022-08-17 22:43 UTC (permalink / raw)
To: intel-gfx
Bit12 of the Forcewake request register should not be cleared post
gen12. Do not touch this bit while clearing during fw domain reset.
Bspec: 52542
Signed-off-by: Sushma Venkatesh Reddy <sushma.venkatesh.reddy@intel.com>
Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
---
drivers/gpu/drm/i915/intel_uncore.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index a852c471d1b3..c85e2b686c95 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -113,7 +113,10 @@ fw_domain_reset(const struct intel_uncore_forcewake_domain *d)
* off in ICL+), so no waiting for acks
*/
/* WaRsClearFWBitsAtReset:bdw,skl */
- fw_clear(d, 0xffff);
+ if (GRAPHICS_VER(d->uncore->i915) >= 12)
+ fw_clear(d, 0xefff);
+ else
+ fw_clear(d, 0xffff);
}
static inline void
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Skip Bit12 fw domain reset for gen12+
2022-08-17 22:43 [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw domain reset for gen12+ Radhakrishna Sripada
@ 2022-08-17 23:14 ` Patchwork
2022-08-18 6:00 ` [Intel-gfx] [PATCH] " Matt Roper
2022-08-18 9:40 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-08-17 23:14 UTC (permalink / raw)
To: Radhakrishna Sripada; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3540 bytes --]
== Series Details ==
Series: drm/i915: Skip Bit12 fw domain reset for gen12+
URL : https://patchwork.freedesktop.org/series/107426/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11995 -> Patchwork_107426v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/index.html
Participating hosts (33 -> 31)
------------------------------
Missing (2): fi-bdw-5557u bat-adls-5
Known issues
------------
Here are the changes found in Patchwork_107426v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gem:
- fi-pnv-d510: NOTRUN -> [DMESG-FAIL][1] ([i915#4528])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/fi-pnv-d510/igt@i915_selftest@live@gem.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: NOTRUN -> [DMESG-FAIL][2] ([i915#4494] / [i915#4957])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-dg1-6: NOTRUN -> [INCOMPLETE][3] ([i915#6011])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/bat-dg1-6/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [PASS][4] -> [FAIL][5] ([i915#6298])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_engines:
- bat-dg1-6: [INCOMPLETE][6] ([i915#4418]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/bat-dg1-6/igt@i915_selftest@live@gt_engines.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/bat-dg1-6/igt@i915_selftest@live@gt_engines.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][8] ([i915#4528]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/fi-pnv-d510/igt@i915_selftest@live@requests.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/fi-pnv-d510/igt@i915_selftest@live@requests.html
[i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#6011]: https://gitlab.freedesktop.org/drm/intel/issues/6011
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
Build changes
-------------
* Linux: CI_DRM_11995 -> Patchwork_107426v1
CI-20190529: 20190529
CI_DRM_11995: 3f79495b5f708c18bc5aac01a9b6d3b954d887a6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6630: b5e2222c9a988015bdf237e6ebb9f5b6d87ac7e1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107426v1: 3f79495b5f708c18bc5aac01a9b6d3b954d887a6 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
fd180b1136d7 drm/i915: Skip Bit12 fw domain reset for gen12+
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/index.html
[-- Attachment #2: Type: text/html, Size: 4357 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw domain reset for gen12+
2022-08-17 22:43 [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw domain reset for gen12+ Radhakrishna Sripada
2022-08-17 23:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2022-08-18 6:00 ` Matt Roper
2022-08-24 6:14 ` Gwan-gyeong Mun
2022-08-18 9:40 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 1 reply; 8+ messages in thread
From: Matt Roper @ 2022-08-18 6:00 UTC (permalink / raw)
To: Radhakrishna Sripada; +Cc: intel-gfx
On Wed, Aug 17, 2022 at 03:43:04PM -0700, Radhakrishna Sripada wrote:
> Bit12 of the Forcewake request register should not be cleared post
> gen12. Do not touch this bit while clearing during fw domain reset.
>
> Bspec: 52542
>
> Signed-off-by: Sushma Venkatesh Reddy <sushma.venkatesh.reddy@intel.com>
> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index a852c471d1b3..c85e2b686c95 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -113,7 +113,10 @@ fw_domain_reset(const struct intel_uncore_forcewake_domain *d)
> * off in ICL+), so no waiting for acks
> */
> /* WaRsClearFWBitsAtReset:bdw,skl */
While we're at it, let's remove the "bdw,skl" from this comment since
it's misleading and doesn't match the code. We do still apply this
workaround on other pre-gen12 platforms than just those two.
Aside from the comment tweak,
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> - fw_clear(d, 0xffff);
> + if (GRAPHICS_VER(d->uncore->i915) >= 12)
> + fw_clear(d, 0xefff);
> + else
> + fw_clear(d, 0xffff);
> }
>
> static inline void
> --
> 2.25.1
>
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Skip Bit12 fw domain reset for gen12+
2022-08-17 22:43 [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw domain reset for gen12+ Radhakrishna Sripada
2022-08-17 23:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-08-18 6:00 ` [Intel-gfx] [PATCH] " Matt Roper
@ 2022-08-18 9:40 ` Patchwork
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-08-18 9:40 UTC (permalink / raw)
To: Radhakrishna Sripada; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 15414 bytes --]
== Series Details ==
Series: drm/i915: Skip Bit12 fw domain reset for gen12+
URL : https://patchwork.freedesktop.org/series/107426/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11995_full -> Patchwork_107426v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_107426v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_107426v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (12 -> 11)
------------------------------
Additional (1): shard-rkl
Missing (2): pig-skl-6260u pig-glk-j5005
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_107426v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rps@engine-order:
- shard-tglb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/shard-tglb7/igt@i915_pm_rps@engine-order.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-tglb7/igt@i915_pm_rps@engine-order.html
Known issues
------------
Here are the changes found in Patchwork_107426v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@kms:
- shard-tglb: [PASS][3] -> [FAIL][4] ([i915#5784]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/shard-tglb7/igt@gem_eio@kms.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-tglb3/igt@gem_eio@kms.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [PASS][5] -> [FAIL][6] ([i915#2842]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/shard-tglb5/igt@gem_exec_fair@basic-none-share@rcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-tglb7/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-kbl: [PASS][7] -> [FAIL][8] ([i915#2842]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/shard-kbl4/igt@gem_exec_fair@basic-none@vcs1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-kbl7/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/shard-apl4/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-apl8/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_lmem_swapping@verify:
- shard-kbl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4613]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-kbl4/igt@gem_lmem_swapping@verify.html
* igt@i915_suspend@basic-s2idle-without-i915:
- shard-kbl: NOTRUN -> [FAIL][12] ([i915#6559])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-kbl4/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@i915_suspend@fence-restore-untiled:
- shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/shard-kbl4/igt@i915_suspend@fence-restore-untiled.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-kbl7/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#3886]) +3 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-kbl4/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-crc-primary-rotation-180-4_tiled_dg2_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][16] ([fdo#109271]) +78 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-kbl4/igt@kms_ccs@pipe-d-crc-primary-rotation-180-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_chamelium@vga-edid-read:
- shard-kbl: NOTRUN -> [SKIP][17] ([fdo#109271] / [fdo#111827]) +4 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-kbl4/igt@kms_chamelium@vga-edid-read.html
* igt@kms_content_protection@lic:
- shard-kbl: NOTRUN -> [TIMEOUT][18] ([i915#1319]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-kbl4/igt@kms_content_protection@lic.html
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([i915#180])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/shard-apl3/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-apl1/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][21] ([i915#265])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-kbl4/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
#### Possible fixes ####
* igt@gem_ctx_persistence@engines-hang@vcs0:
- {shard-dg1}: [FAIL][22] ([i915#4883]) -> [PASS][23] +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/shard-dg1-17/igt@gem_ctx_persistence@engines-hang@vcs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-dg1-17/igt@gem_ctx_persistence@engines-hang@vcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [FAIL][24] ([i915#2842]) -> [PASS][25] +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/shard-kbl4/igt@gem_exec_fair@basic-pace@vecs0.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-kbl7/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@i915_selftest@live@hangcheck:
- {shard-dg1}: [DMESG-FAIL][26] ([i915#4494] / [i915#4957]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/shard-dg1-18/igt@i915_selftest@live@hangcheck.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-dg1-16/igt@i915_selftest@live@hangcheck.html
* igt@kms_cursor_crc@cursor-suspend@pipe-b-dp-1:
- shard-kbl: [DMESG-WARN][28] ([i915#180]) -> [PASS][29] +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/shard-kbl7/igt@kms_cursor_crc@cursor-suspend@pipe-b-dp-1.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-kbl4/igt@kms_cursor_crc@cursor-suspend@pipe-b-dp-1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1:
- shard-kbl: [FAIL][30] ([i915#79]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/shard-kbl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-kbl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
#### Warnings ####
* igt@i915_suspend@forcewake:
- shard-snb: [INCOMPLETE][32] ([i915#4817]) -> [INCOMPLETE][33] ([i915#4817] / [i915#6598])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/shard-snb5/igt@i915_suspend@forcewake.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-snb4/igt@i915_suspend@forcewake.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [INCOMPLETE][34] ([i915#180] / [i915#4939]) -> [FAIL][35] ([i915#4767])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@runner@aborted:
- shard-apl: [FAIL][36] ([i915#4312] / [i915#6599]) -> ([FAIL][37], [FAIL][38]) ([i915#4312] / [i915#5257] / [i915#6599])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11995/shard-apl4/igt@runner@aborted.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-apl1/igt@runner@aborted.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/shard-apl1/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4521]: https://gitlab.freedesktop.org/drm/intel/issues/4521
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4853]: https://gitlab.freedesktop.org/drm/intel/issues/4853
[i915#4855]: https://gitlab.freedesktop.org/drm/intel/issues/4855
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6331]: https://gitlab.freedesktop.org/drm/intel/issues/6331
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6458]: https://gitlab.freedesktop.org/drm/intel/issues/6458
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6559]: https://gitlab.freedesktop.org/drm/intel/issues/6559
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6598]: https://gitlab.freedesktop.org/drm/intel/issues/6598
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_11995 -> Patchwork_107426v1
CI-20190529: 20190529
CI_DRM_11995: 3f79495b5f708c18bc5aac01a9b6d3b954d887a6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6630: b5e2222c9a988015bdf237e6ebb9f5b6d87ac7e1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107426v1: 3f79495b5f708c18bc5aac01a9b6d3b954d887a6 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107426v1/index.html
[-- Attachment #2: Type: text/html, Size: 12680 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw domain reset for gen12+
2022-08-18 6:00 ` [Intel-gfx] [PATCH] " Matt Roper
@ 2022-08-24 6:14 ` Gwan-gyeong Mun
2022-08-25 17:49 ` Sripada, Radhakrishna
0 siblings, 1 reply; 8+ messages in thread
From: Gwan-gyeong Mun @ 2022-08-24 6:14 UTC (permalink / raw)
To: Matt Roper, Radhakrishna Sripada; +Cc: intel-gfx
On 8/18/22 3:00 PM, Matt Roper wrote:
> On Wed, Aug 17, 2022 at 03:43:04PM -0700, Radhakrishna Sripada wrote:
>> Bit12 of the Forcewake request register should not be cleared post
>> gen12. Do not touch this bit while clearing during fw domain reset.
>>
>> Bspec: 52542
>>
>> Signed-off-by: Sushma Venkatesh Reddy <sushma.venkatesh.reddy@intel.com>
>> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_uncore.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
>> index a852c471d1b3..c85e2b686c95 100644
>> --- a/drivers/gpu/drm/i915/intel_uncore.c
>> +++ b/drivers/gpu/drm/i915/intel_uncore.c
>> @@ -113,7 +113,10 @@ fw_domain_reset(const struct intel_uncore_forcewake_domain *d)
>> * off in ICL+), so no waiting for acks
>> */
>> /* WaRsClearFWBitsAtReset:bdw,skl */
>
> While we're at it, let's remove the "bdw,skl" from this comment since
> it's misleading and doesn't match the code. We do still apply this
> workaround on other pre-gen12 platforms than just those two.
>
> Aside from the comment tweak,
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>
>> - fw_clear(d, 0xffff);
>> + if (GRAPHICS_VER(d->uncore->i915) >= 12)
Hi Radhakrishna Sripada,
In bspec 52542, there is an explanation that BIT12 should not be set for
address 0xA188 corresponding to FORCEWAKE_MT/FORCEWAKE_GT_GEN9, but in
bspec 52466, there is no explanation that BIT12 should not be set for
address 0xA278, address of FORCEWAKE_RENDER_GEN9.
I ask if fw_domain_reset() should perform fw_clear() by comparing not
only GRAPHICS_VER() >= 12 but also checking of FW_DOMAIN_ID_RENDER and
FW_DOMAIN_ID_GT values.
Br,
G.G.
>> + fw_clear(d, 0xefff);
>> + else
>> + fw_clear(d, 0xffff);
>> }
>>
>> static inline void
>> --
>> 2.25.1
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw domain reset for gen12+
2022-08-24 6:14 ` Gwan-gyeong Mun
@ 2022-08-25 17:49 ` Sripada, Radhakrishna
2022-12-15 17:38 ` Tvrtko Ursulin
0 siblings, 1 reply; 8+ messages in thread
From: Sripada, Radhakrishna @ 2022-08-25 17:49 UTC (permalink / raw)
To: Mun, Gwan-gyeong, Roper, Matthew D; +Cc: intel-gfx
Hi G.G,
> -----Original Message-----
> From: Mun, Gwan-gyeong <gwan-gyeong.mun@intel.com>
> Sent: Tuesday, August 23, 2022 11:14 PM
> To: Roper, Matthew D <matthew.d.roper@intel.com>; Sripada, Radhakrishna
> <radhakrishna.sripada@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw domain reset for gen12+
>
>
>
> On 8/18/22 3:00 PM, Matt Roper wrote:
> > On Wed, Aug 17, 2022 at 03:43:04PM -0700, Radhakrishna Sripada wrote:
> >> Bit12 of the Forcewake request register should not be cleared post
> >> gen12. Do not touch this bit while clearing during fw domain reset.
> >>
> >> Bspec: 52542
> >>
> >> Signed-off-by: Sushma Venkatesh Reddy
> <sushma.venkatesh.reddy@intel.com>
> >> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/intel_uncore.c | 5 ++++-
> >> 1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/intel_uncore.c
> b/drivers/gpu/drm/i915/intel_uncore.c
> >> index a852c471d1b3..c85e2b686c95 100644
> >> --- a/drivers/gpu/drm/i915/intel_uncore.c
> >> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> >> @@ -113,7 +113,10 @@ fw_domain_reset(const struct
> intel_uncore_forcewake_domain *d)
> >> * off in ICL+), so no waiting for acks
> >> */
> >> /* WaRsClearFWBitsAtReset:bdw,skl */
> >
> > While we're at it, let's remove the "bdw,skl" from this comment since
> > it's misleading and doesn't match the code. We do still apply this
> > workaround on other pre-gen12 platforms than just those two.
> >
> > Aside from the comment tweak,
> >
> > Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> >
> >> - fw_clear(d, 0xffff);
> >> + if (GRAPHICS_VER(d->uncore->i915) >= 12)
> Hi Radhakrishna Sripada,
>
> In bspec 52542, there is an explanation that BIT12 should not be set for
> address 0xA188 corresponding to FORCEWAKE_MT/FORCEWAKE_GT_GEN9, but
> in
> bspec 52466, there is no explanation that BIT12 should not be set for
> address 0xA278, address of FORCEWAKE_RENDER_GEN9.
>
> I ask if fw_domain_reset() should perform fw_clear() by comparing not
> only GRAPHICS_VER() >= 12 but also checking of FW_DOMAIN_ID_RENDER and
> FW_DOMAIN_ID_GT values.
Based on the note in 52542, all other WA notes are overridden by the comment. So unless stated
otherwise, it should apply to this register as well.
Created a bspec issue to request for additional clarification just to be safe. Will send an additional
patch if the comment contradicts our understanding.
Thanks,
RK
>
> Br,
> G.G.
> >> + fw_clear(d, 0xefff);
> >> + else
> >> + fw_clear(d, 0xffff);
> >> }
> >>
> >> static inline void
> >> --
> >> 2.25.1
> >>
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw domain reset for gen12+
2022-08-25 17:49 ` Sripada, Radhakrishna
@ 2022-12-15 17:38 ` Tvrtko Ursulin
2022-12-15 17:57 ` Matt Roper
0 siblings, 1 reply; 8+ messages in thread
From: Tvrtko Ursulin @ 2022-12-15 17:38 UTC (permalink / raw)
To: Sripada, Radhakrishna, Mun, Gwan-gyeong, Roper, Matthew D; +Cc: intel-gfx
On 25/08/2022 18:49, Sripada, Radhakrishna wrote:
> Hi G.G,
>
>> -----Original Message-----
>> From: Mun, Gwan-gyeong <gwan-gyeong.mun@intel.com>
>> Sent: Tuesday, August 23, 2022 11:14 PM
>> To: Roper, Matthew D <matthew.d.roper@intel.com>; Sripada, Radhakrishna
>> <radhakrishna.sripada@intel.com>
>> Cc: intel-gfx@lists.freedesktop.org
>> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw domain reset for gen12+
>>
>>
>>
>> On 8/18/22 3:00 PM, Matt Roper wrote:
>>> On Wed, Aug 17, 2022 at 03:43:04PM -0700, Radhakrishna Sripada wrote:
>>>> Bit12 of the Forcewake request register should not be cleared post
>>>> gen12. Do not touch this bit while clearing during fw domain reset.
>>>>
>>>> Bspec: 52542
>>>>
>>>> Signed-off-by: Sushma Venkatesh Reddy
>> <sushma.venkatesh.reddy@intel.com>
>>>> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
>>>> ---
>>>> drivers/gpu/drm/i915/intel_uncore.c | 5 ++++-
>>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/intel_uncore.c
>> b/drivers/gpu/drm/i915/intel_uncore.c
>>>> index a852c471d1b3..c85e2b686c95 100644
>>>> --- a/drivers/gpu/drm/i915/intel_uncore.c
>>>> +++ b/drivers/gpu/drm/i915/intel_uncore.c
>>>> @@ -113,7 +113,10 @@ fw_domain_reset(const struct
>> intel_uncore_forcewake_domain *d)
>>>> * off in ICL+), so no waiting for acks
>>>> */
>>>> /* WaRsClearFWBitsAtReset:bdw,skl */
>>>
>>> While we're at it, let's remove the "bdw,skl" from this comment since
>>> it's misleading and doesn't match the code. We do still apply this
>>> workaround on other pre-gen12 platforms than just those two.
>>>
>>> Aside from the comment tweak,
>>>
>>> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>>>
>>>> - fw_clear(d, 0xffff);
>>>> + if (GRAPHICS_VER(d->uncore->i915) >= 12)
>> Hi Radhakrishna Sripada,
>>
>> In bspec 52542, there is an explanation that BIT12 should not be set for
>> address 0xA188 corresponding to FORCEWAKE_MT/FORCEWAKE_GT_GEN9, but
>> in
>> bspec 52466, there is no explanation that BIT12 should not be set for
>> address 0xA278, address of FORCEWAKE_RENDER_GEN9.
>>
>> I ask if fw_domain_reset() should perform fw_clear() by comparing not
>> only GRAPHICS_VER() >= 12 but also checking of FW_DOMAIN_ID_RENDER and
>> FW_DOMAIN_ID_GT values.
> Based on the note in 52542, all other WA notes are overridden by the comment. So unless stated
> otherwise, it should apply to this register as well.
>
> Created a bspec issue to request for additional clarification just to be safe. Will send an additional
> patch if the comment contradicts our understanding.
How important was this patch - should it be sent to stable?
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw domain reset for gen12+
2022-12-15 17:38 ` Tvrtko Ursulin
@ 2022-12-15 17:57 ` Matt Roper
0 siblings, 0 replies; 8+ messages in thread
From: Matt Roper @ 2022-12-15 17:57 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: intel-gfx
On Thu, Dec 15, 2022 at 05:38:22PM +0000, Tvrtko Ursulin wrote:
>
> On 25/08/2022 18:49, Sripada, Radhakrishna wrote:
> > Hi G.G,
> >
> > > -----Original Message-----
> > > From: Mun, Gwan-gyeong <gwan-gyeong.mun@intel.com>
> > > Sent: Tuesday, August 23, 2022 11:14 PM
> > > To: Roper, Matthew D <matthew.d.roper@intel.com>; Sripada, Radhakrishna
> > > <radhakrishna.sripada@intel.com>
> > > Cc: intel-gfx@lists.freedesktop.org
> > > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw domain reset for gen12+
> > >
> > >
> > >
> > > On 8/18/22 3:00 PM, Matt Roper wrote:
> > > > On Wed, Aug 17, 2022 at 03:43:04PM -0700, Radhakrishna Sripada wrote:
> > > > > Bit12 of the Forcewake request register should not be cleared post
> > > > > gen12. Do not touch this bit while clearing during fw domain reset.
> > > > >
> > > > > Bspec: 52542
> > > > >
> > > > > Signed-off-by: Sushma Venkatesh Reddy
> > > <sushma.venkatesh.reddy@intel.com>
> > > > > Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> > > > > ---
> > > > > drivers/gpu/drm/i915/intel_uncore.c | 5 ++++-
> > > > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/i915/intel_uncore.c
> > > b/drivers/gpu/drm/i915/intel_uncore.c
> > > > > index a852c471d1b3..c85e2b686c95 100644
> > > > > --- a/drivers/gpu/drm/i915/intel_uncore.c
> > > > > +++ b/drivers/gpu/drm/i915/intel_uncore.c
> > > > > @@ -113,7 +113,10 @@ fw_domain_reset(const struct
> > > intel_uncore_forcewake_domain *d)
> > > > > * off in ICL+), so no waiting for acks
> > > > > */
> > > > > /* WaRsClearFWBitsAtReset:bdw,skl */
> > > >
> > > > While we're at it, let's remove the "bdw,skl" from this comment since
> > > > it's misleading and doesn't match the code. We do still apply this
> > > > workaround on other pre-gen12 platforms than just those two.
> > > >
> > > > Aside from the comment tweak,
> > > >
> > > > Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> > > >
> > > > > - fw_clear(d, 0xffff);
> > > > > + if (GRAPHICS_VER(d->uncore->i915) >= 12)
> > > Hi Radhakrishna Sripada,
> > >
> > > In bspec 52542, there is an explanation that BIT12 should not be set for
> > > address 0xA188 corresponding to FORCEWAKE_MT/FORCEWAKE_GT_GEN9, but
> > > in
> > > bspec 52466, there is no explanation that BIT12 should not be set for
> > > address 0xA278, address of FORCEWAKE_RENDER_GEN9.
> > >
> > > I ask if fw_domain_reset() should perform fw_clear() by comparing not
> > > only GRAPHICS_VER() >= 12 but also checking of FW_DOMAIN_ID_RENDER and
> > > FW_DOMAIN_ID_GT values.
> > Based on the note in 52542, all other WA notes are overridden by the comment. So unless stated
> > otherwise, it should apply to this register as well.
> >
> > Created a bspec issue to request for additional clarification just to be safe. Will send an additional
> > patch if the comment contradicts our understanding.
>
> How important was this patch - should it be sent to stable?
It shouldn't be needed for stable; clearing the bit isn't necessary from
gen12 onward, but as far as we know it doesn't cause any problems either
(except maybe on MTL, which is still under force_probe and not supported
on stable kernels). So according to stable-kernel-rules.rst, this patch
would not qualify.
Matt
>
> Regards,
>
> Tvrtko
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-12-15 17:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-17 22:43 [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw domain reset for gen12+ Radhakrishna Sripada
2022-08-17 23:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-08-18 6:00 ` [Intel-gfx] [PATCH] " Matt Roper
2022-08-24 6:14 ` Gwan-gyeong Mun
2022-08-25 17:49 ` Sripada, Radhakrishna
2022-12-15 17:38 ` Tvrtko Ursulin
2022-12-15 17:57 ` Matt Roper
2022-08-18 9:40 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.