* [PATCH 0/2] Add a new board device tree named 'evoker' for herobrine variant. @ 2022-09-01 9:12 Sheng-Liang Pan 2022-09-01 9:12 ` [PATCH 1/2] arm64: dts: qcom: sc7280: Add device tree for herobrine evoker Sheng-Liang Pan 2022-09-01 9:12 ` [PATCH 2/2] dt-bindings: arm: qcom: document sc7280 and evoker board Sheng-Liang Pan 0 siblings, 2 replies; 8+ messages in thread From: Sheng-Liang Pan @ 2022-09-01 9:12 UTC (permalink / raw) To: LKML Cc: mka, dianders, Sheng-Liang Pan, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm This patch add the initial dts file for new board 'evoker'. Changes in v2: - document sc7280 and evoker board Sheng-Liang Pan (2): arm64: dts: qcom: sc7280: Add device tree for herobrine evoker dt-bindings: arm: qcom: document sc7280 and evoker board .../devicetree/bindings/arm/qcom.yaml | 5 + arch/arm64/boot/dts/qcom/Makefile | 1 + .../dts/qcom/sc7280-herobrine-evoker-r0.dts | 333 ++++++++++++++++++ 3 files changed, 339 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts -- 2.34.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] arm64: dts: qcom: sc7280: Add device tree for herobrine evoker 2022-09-01 9:12 [PATCH 0/2] Add a new board device tree named 'evoker' for herobrine variant Sheng-Liang Pan @ 2022-09-01 9:12 ` Sheng-Liang Pan 2022-09-01 10:01 ` Krzysztof Kozlowski 2022-09-01 9:12 ` [PATCH 2/2] dt-bindings: arm: qcom: document sc7280 and evoker board Sheng-Liang Pan 1 sibling, 1 reply; 8+ messages in thread From: Sheng-Liang Pan @ 2022-09-01 9:12 UTC (permalink / raw) To: LKML Cc: mka, dianders, Sheng-Liang Pan, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm Add a basic device tree for the herobrine evoker board. Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> --- arch/arm64/boot/dts/qcom/Makefile | 1 + .../dts/qcom/sc7280-herobrine-evoker-r0.dts | 333 ++++++++++++++++++ 2 files changed, 334 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 1d86a33de528c..dd18ae8cd81c2 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -101,6 +101,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-crd.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker-r0.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-herobrine-r1.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r0.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp.dtb diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts new file mode 100644 index 0000000000000..ccbe50b6249ab --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts @@ -0,0 +1,333 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Evoker board device tree source + * + * Copyright 2022 Google LLC. + */ + +/dts-v1/; + +#include "sc7280-herobrine.dtsi" + +/ { + model = "Google Evoker"; + compatible = "google,evoker", "qcom,sc7280"; +}; + +/* + * ADDITIONS TO FIXED REGULATORS DEFINED IN PARENT DEVICE TREE FILES + * + * Sort order matches the order in the parent files (parents before children). + */ + +&pp3300_codec { + status = "okay"; +}; + +/* ADDITIONS TO NODES DEFINED IN PARENT DEVICE TREE FILES */ + +ap_tp_i2c: &i2c0 { + status = "okay"; + clock-frequency = <400000>; + + trackpad: trackpad@2c { + compatible = "hid-over-i2c"; + reg = <0x2c>; + pinctrl-names = "default"; + pinctrl-0 = <&tp_int_odl>; + + interrupt-parent = <&tlmm>; + interrupts = <7 IRQ_TYPE_EDGE_FALLING>; + + hid-descr-addr = <0x20>; + vcc-supply = <&pp3300_z1>; + + wakeup-source; + }; +}; + +ts_i2c: &i2c13 { + status = "okay"; + clock-frequency = <400000>; + + ap_ts: touchscreen@10 { + compatible = "elan,ekth6915"; + reg = <0x10>; + pinctrl-names = "default"; + pinctrl-0 = <&ts_int_conn>, <&ts_rst_conn>; + + interrupt-parent = <&tlmm>; + interrupts = <55 IRQ_TYPE_LEVEL_LOW>; + + reset-gpios = <&tlmm 54 GPIO_ACTIVE_LOW>; + + vcc33-supply = <&ts_avdd>; + }; +}; + +&ap_sar_sensor_i2c { + status = "okay"; +}; + +&ap_sar_sensor0 { + status = "okay"; +}; + +&ap_sar_sensor1 { + status = "okay"; +}; + +&mdss_edp { + status = "okay"; +}; + +&mdss_edp_phy { + status = "okay"; +}; + +/* For nvme */ +&pcie1 { + status = "okay"; +}; + +/* For nvme */ +&pcie1_phy { + status = "okay"; +}; + +&pwmleds { + status = "okay"; +}; + +/* For eMMC */ +&sdhc_1 { + status = "okay"; +}; + +/* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */ + +&ts_rst_conn { + bias-disable; +}; + +/* PINCTRL - BOARD-SPECIFIC */ + +/* + * Methodology for gpio-line-names: + * - If a pin goes to herobrine board and is named it gets that name. + * - If a pin goes to herobrine board and is not named, it gets no name. + * - If a pin is totally internal to Qcard then it gets Qcard name. + * - If a pin is not hooked up on Qcard, it gets no name. + */ + +&pm8350c_gpios { + gpio-line-names = "FLASH_STROBE_1", /* 1 */ + "AP_SUSPEND", + "PM8008_1_RST_N", + "", + "", + "", + "PMIC_EDP_BL_EN", + "PMIC_EDP_BL_PWM", + ""; +}; + +&tlmm { + gpio-line-names = "AP_TP_I2C_SDA", /* 0 */ + "AP_TP_I2C_SCL", + "SSD_RST_L", + "PE_WAKE_ODL", + "AP_SAR_SDA", + "AP_SAR_SCL", + "PRB_SC_GPIO_6", + "TP_INT_ODL", + "HP_I2C_SDA", + "HP_I2C_SCL", + + "GNSS_L1_EN", /* 10 */ + "GNSS_L5_EN", + "SPI_AP_MOSI", + "SPI_AP_MISO", + "SPI_AP_CLK", + "SPI_AP_CS0_L", + /* + * AP_FLASH_WP is crossystem ABI. Schematics + * call it BIOS_FLASH_WP_OD. + */ + "AP_FLASH_WP", + "", + "AP_EC_INT_L", + "", + + "UF_CAM_RST_L", /* 20 */ + "WF_CAM_RST_L", + "UART_AP_TX_DBG_RX", + "UART_DBG_TX_AP_RX", + "", + "PM8008_IRQ_1", + "HOST2WLAN_SOL", + "WLAN2HOST_SOL", + "MOS_BT_UART_CTS", + "MOS_BT_UART_RFR", + + "MOS_BT_UART_TX", /* 30 */ + "MOS_BT_UART_RX", + "PRB_SC_GPIO_32", + "HUB_RST_L", + "", + "", + "AP_SPI_FP_MISO", + "AP_SPI_FP_MOSI", + "AP_SPI_FP_CLK", + "AP_SPI_FP_CS_L", + + "AP_EC_SPI_MISO", /* 40 */ + "AP_EC_SPI_MOSI", + "AP_EC_SPI_CLK", + "AP_EC_SPI_CS_L", + "LCM_RST_L", + "EARLY_EUD_N", + "", + "DP_HOT_PLUG_DET", + "IO_BRD_MLB_ID0", + "IO_BRD_MLB_ID1", + + "IO_BRD_MLB_ID2", /* 50 */ + "SSD_EN", + "TS_I2C_SDA_CONN", + "TS_I2C_CLK_CONN", + "TS_RST_CONN", + "TS_INT_CONN", + "AP_I2C_TPM_SDA", + "AP_I2C_TPM_SCL", + "PRB_SC_GPIO_58", + "PRB_SC_GPIO_59", + + "EDP_HOT_PLUG_DET_N", /* 60 */ + "FP_TO_AP_IRQ_L", + "", + "AMP_EN", + "CAM0_MCLK_GPIO_64", + "CAM1_MCLK_GPIO_65", + "WF_CAM_MCLK", + "PRB_SC_GPIO_67", + "FPMCU_BOOT0", + "UF_CAM_SDA", + + "UF_CAM_SCL", /* 70 */ + "", + "", + "WF_CAM_SDA", + "WF_CAM_SCL", + "", + "", + "EN_FP_RAILS", + "FP_RST_L", + "PCIE1_CLKREQ_ODL", + + "EN_PP3300_DX_EDP", /* 80 */ + "SC_GPIO_81", + "FORCED_USB_BOOT", + "WCD_RESET_N", + "MOS_WLAN_EN", + "MOS_BT_EN", + "MOS_SW_CTRL", + "MOS_PCIE0_RST", + "MOS_PCIE0_CLKREQ_N", + "MOS_PCIE0_WAKE_N", + + "MOS_LAA_AS_EN", /* 90 */ + "SD_CD_ODL", + "", + "", + "MOS_BT_WLAN_SLIMBUS_CLK", + "MOS_BT_WLAN_SLIMBUS_DAT0", + "HP_MCLK", + "HP_BCLK", + "HP_DOUT", + "HP_DIN", + + "HP_LRCLK", /* 100 */ + "HP_IRQ", + "", + "", + "GSC_AP_INT_ODL", + "EN_PP3300_CODEC", + "AMP_BCLK", + "AMP_DIN", + "AMP_LRCLK", + "UIM1_DATA_GPIO_109", + + "UIM1_CLK_GPIO_110", /* 110 */ + "UIM1_RESET_GPIO_111", + "PRB_SC_GPIO_112", + "UIM0_DATA", + "UIM0_CLK", + "UIM0_RST", + "UIM0_PRESENT_ODL", + "SDM_RFFE0_CLK", + "SDM_RFFE0_DATA", + "WF_CAM_EN", + + "FASTBOOT_SEL_0", /* 120 */ + "SC_GPIO_121", + "FASTBOOT_SEL_1", + "SC_GPIO_123", + "FASTBOOT_SEL_2", + "SM_RFFE4_CLK_GRFC_8", + "SM_RFFE4_DATA_GRFC_9", + "WLAN_COEX_UART1_RX", + "WLAN_COEX_UART1_TX", + "PRB_SC_GPIO_129", + + "LCM_ID0", /* 130 */ + "LCM_ID1", + "", + "SDR_QLINK_REQ", + "SDR_QLINK_EN", + "QLINK0_WMSS_RESET_N", + "SMR526_QLINK1_REQ", + "SMR526_QLINK1_EN", + "SMR526_QLINK1_WMSS_RESET_N", + "PRB_SC_GPIO_139", + + "SAR1_IRQ_ODL", /* 140 */ + "SAR0_IRQ_ODL", + "PRB_SC_GPIO_142", + "", + "WCD_SWR_TX_CLK", + "WCD_SWR_TX_DATA0", + "WCD_SWR_TX_DATA1", + "WCD_SWR_RX_CLK", + "WCD_SWR_RX_DATA0", + "WCD_SWR_RX_DATA1", + + "DMIC01_CLK", /* 150 */ + "DMIC01_DATA", + "DMIC23_CLK", + "DMIC23_DATA", + "", + "", + "EC_IN_RW_ODL", + "HUB_EN", + "WCD_SWR_TX_DATA2", + "", + + "", /* 160 */ + "", + "", + "", + "", + "", + "", + "", + "", + "", + + "", /* 170 */ + "MOS_BLE_UART_TX", + "MOS_BLE_UART_RX", + "", + "", + ""; +}; -- 2.34.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: sc7280: Add device tree for herobrine evoker 2022-09-01 9:12 ` [PATCH 1/2] arm64: dts: qcom: sc7280: Add device tree for herobrine evoker Sheng-Liang Pan @ 2022-09-01 10:01 ` Krzysztof Kozlowski 2022-09-01 15:06 ` Doug Anderson 0 siblings, 1 reply; 8+ messages in thread From: Krzysztof Kozlowski @ 2022-09-01 10:01 UTC (permalink / raw) To: Sheng-Liang Pan, LKML Cc: mka, dianders, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm On 01/09/2022 12:12, Sheng-Liang Pan wrote: > Add a basic device tree for the herobrine evoker board. > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > --- And this is third v1? At least this is what your subject is suggesting. Patches should be properly versioned. Git format-patch helps in that, but you can use any other tools if you wish. I pointed you to documentation you must read before posting. You can keep ignoring it, so we keep ignoring your patch. That's a NAK :( Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: sc7280: Add device tree for herobrine evoker 2022-09-01 10:01 ` Krzysztof Kozlowski @ 2022-09-01 15:06 ` Doug Anderson 0 siblings, 0 replies; 8+ messages in thread From: Doug Anderson @ 2022-09-01 15:06 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Sheng-Liang Pan, LKML, Matthias Kaehlcke, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-arm-msm Hi, On Thu, Sep 1, 2022 at 3:01 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 01/09/2022 12:12, Sheng-Liang Pan wrote: > > Add a basic device tree for the herobrine evoker board. > > > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > > --- > > And this is third v1? At least this is what your subject is suggesting. > Patches should be properly versioned. Git format-patch helps in that, > but you can use any other tools if you wish. Just to make it clear, what Krzysztof is pointing at is the subject line of your email. Based on your email headers it looks like you're using "patman" to send out your emails. That means you can get what Krzysztof wants by putting a "Series-version" in one of your patches. Given that you had three v1 posts, maybe call the next version "v4"? That means that one of the patches should have: Series-version: 4 Then in each patch you'll have details about what changed in each version. I guess we could sorta call the one where you added the bindings "v2". So in the bindings patch you could add: Series-changes: 2 - Bindings patch added ...and in both patches you could add: Series-changes: 4 - Got the version number correct You've already got a cover letter setup, so in that you should attempt to explain some of this mess, like saying: Sorry about getting mixed up with version numbers. Here are links to previous postings and what I'll assume the version number is: v1: https://lore.kernel.org/r/20220830053307.3997495-1-sheng-liang.pan@quanta.corp-partner.google.com/ v2: https://lore.kernel.org/r/20220901061336.61386-1-sheng-liang.pan@quanta.corp-partner.google.com/ v3: https://lore.kernel.org/r/20220901091253.93333-1-sheng-liang.pan@quanta.corp-partner.google.com/ As an extra note: the bindings patch should be patch #1 and the device tree should be patch #2. That means you should reorder your patches. -Doug > > I pointed you to documentation you must read before posting. You can > keep ignoring it, so we keep ignoring your patch. > > That's a NAK :( > > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] dt-bindings: arm: qcom: document sc7280 and evoker board 2022-09-01 9:12 [PATCH 0/2] Add a new board device tree named 'evoker' for herobrine variant Sheng-Liang Pan 2022-09-01 9:12 ` [PATCH 1/2] arm64: dts: qcom: sc7280: Add device tree for herobrine evoker Sheng-Liang Pan @ 2022-09-01 9:12 ` Sheng-Liang Pan 2022-09-01 10:03 ` Krzysztof Kozlowski 1 sibling, 1 reply; 8+ messages in thread From: Sheng-Liang Pan @ 2022-09-01 9:12 UTC (permalink / raw) To: LKML Cc: mka, dianders, Sheng-Liang Pan, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm This adds Chromebook Evoker to the yaml. Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> --- Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index fb1d00bcc847c..d4b2d947859d4 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -565,6 +565,11 @@ properties: - const: google,piglin - const: qcom,sc7280 + - description: Google Evoker (newest rev) + items: + - const: google,evoker + - const: qcom,sc7280 + - description: Google Herobrine (newest rev) items: - const: google,herobrine -- 2.34.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] dt-bindings: arm: qcom: document sc7280 and evoker board 2022-09-01 9:12 ` [PATCH 2/2] dt-bindings: arm: qcom: document sc7280 and evoker board Sheng-Liang Pan @ 2022-09-01 10:03 ` Krzysztof Kozlowski 0 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2022-09-01 10:03 UTC (permalink / raw) To: Sheng-Liang Pan, LKML Cc: mka, dianders, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm On 01/09/2022 12:12, Sheng-Liang Pan wrote: > This adds Chromebook Evoker to the yaml. > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> Read the docs I already sent you. Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 0/2] Add a new board device tree named 'evoker' for herobrine variant. @ 2022-09-02 7:42 Sheng-Liang Pan 0 siblings, 0 replies; 8+ messages in thread From: Sheng-Liang Pan @ 2022-09-02 7:42 UTC (permalink / raw) To: LKML Cc: dianders, mka, Sheng-Liang Pan, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm This patch add the initial dts file for new board 'evoker'. Sorry about getting mixed up with version numbers. Here are links to previous postings and what I'll assume the version number is: v1: https://lore.kernel.org/r/20220830053307.3997495-1-sheng-liang.pan@quanta.corp-partner.google.com/ v2: https://lore.kernel.org/r/20220901061336.61386-1-sheng-liang.pan@quanta.corp-partner.google.com/ v3: https://lore.kernel.org/r/20220901091253.93333-1-sheng-liang.pan@quanta.corp-partner.google.com/ Changes in v4: - Got the version number correct - Got the version number correct Changes in v2: - Bindings patch added Sheng-Liang Pan (2): dt-bindings: arm: qcom: document sc7280 and evoker board arm64: dts: qcom: sc7280: Add device tree for herobrine evoker .../devicetree/bindings/arm/qcom.yaml | 5 + arch/arm64/boot/dts/qcom/Makefile | 1 + .../dts/qcom/sc7280-herobrine-evoker-r0.dts | 333 ++++++++++++++++++ 3 files changed, 339 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts -- 2.34.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 0/2] Add a new board device tree named 'evoker' for herobrine variant. @ 2022-09-01 6:13 Sheng-Liang Pan 0 siblings, 0 replies; 8+ messages in thread From: Sheng-Liang Pan @ 2022-09-01 6:13 UTC (permalink / raw) To: LKML Cc: mka, dianders, Sheng-Liang Pan, Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm This patch add the initial dts file for new board 'evoker'. Sheng-Liang Pan (2): arm64: dts: qcom: sc7280: Add device tree for herobrine evoker dt-bindings: arm: qcom: document sc7280 and evoker board .../devicetree/bindings/arm/qcom.yaml | 5 + arch/arm64/boot/dts/qcom/Makefile | 1 + .../dts/qcom/sc7280-herobrine-evoker-r0.dts | 333 ++++++++++++++++++ 3 files changed, 339 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts -- 2.34.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-09-02 7:42 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-09-01 9:12 [PATCH 0/2] Add a new board device tree named 'evoker' for herobrine variant Sheng-Liang Pan 2022-09-01 9:12 ` [PATCH 1/2] arm64: dts: qcom: sc7280: Add device tree for herobrine evoker Sheng-Liang Pan 2022-09-01 10:01 ` Krzysztof Kozlowski 2022-09-01 15:06 ` Doug Anderson 2022-09-01 9:12 ` [PATCH 2/2] dt-bindings: arm: qcom: document sc7280 and evoker board Sheng-Liang Pan 2022-09-01 10:03 ` Krzysztof Kozlowski -- strict thread matches above, loose matches on Subject: below -- 2022-09-02 7:42 [PATCH 0/2] Add a new board device tree named 'evoker' for herobrine variant Sheng-Liang Pan 2022-09-01 6:13 Sheng-Liang Pan
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.