From: Jiri Slaby <jslaby@suse.cz> To: gregkh@linuxfoundation.org Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby" <jslaby@suse.cz>, "Vladimir Zapolskiy" <vz@mleia.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 05/10] tty: serial: extract tx_ready() from __serial_lpc32xx_tx() Date: Tue, 20 Sep 2022 07:20:45 +0200 [thread overview] Message-ID: <20220920052049.20507-6-jslaby@suse.cz> (raw) In-Reply-To: <20220920052049.20507-1-jslaby@suse.cz> The condition in __serial_lpc32xx_tx()'s loop is barely readable. Extract it to a separate function. This will make the cleanup in the next patches easier too. Cc: Vladimir Zapolskiy <vz@mleia.com> Cc: <linux-arm-kernel@lists.infradead.org> Signed-off-by: Jiri Slaby <jslaby@suse.cz> --- Notes: [v4] this is new in v4 -- extracted as a separate change drivers/tty/serial/lpc32xx_hs.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/lpc32xx_hs.c b/drivers/tty/serial/lpc32xx_hs.c index 0d5ef7df27d0..ed47f4768338 100644 --- a/drivers/tty/serial/lpc32xx_hs.c +++ b/drivers/tty/serial/lpc32xx_hs.c @@ -278,6 +278,13 @@ static void __serial_lpc32xx_rx(struct uart_port *port) static void serial_lpc32xx_stop_tx(struct uart_port *port); +static bool serial_lpc32xx_tx_ready(struct uart_port *port) +{ + u32 level = readl(LPC32XX_HSUART_LEVEL(port->membase)); + + return LPC32XX_HSU_TX_LEV(level) < 64; +} + static void __serial_lpc32xx_tx(struct uart_port *port) { struct circ_buf *xmit = &port->state->xmit; @@ -293,8 +300,7 @@ static void __serial_lpc32xx_tx(struct uart_port *port) goto exit_tx; /* Transfer data */ - while (LPC32XX_HSU_TX_LEV(readl( - LPC32XX_HSUART_LEVEL(port->membase))) < 64) { + while (serial_lpc32xx_tx_ready(port)) { writel((u32) xmit->buf[xmit->tail], LPC32XX_HSUART_FIFO(port->membase)); xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1); -- 2.37.3
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jslaby@suse.cz> To: gregkh@linuxfoundation.org Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby" <jslaby@suse.cz>, "Vladimir Zapolskiy" <vz@mleia.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 05/10] tty: serial: extract tx_ready() from __serial_lpc32xx_tx() Date: Tue, 20 Sep 2022 07:20:45 +0200 [thread overview] Message-ID: <20220920052049.20507-6-jslaby@suse.cz> (raw) In-Reply-To: <20220920052049.20507-1-jslaby@suse.cz> The condition in __serial_lpc32xx_tx()'s loop is barely readable. Extract it to a separate function. This will make the cleanup in the next patches easier too. Cc: Vladimir Zapolskiy <vz@mleia.com> Cc: <linux-arm-kernel@lists.infradead.org> Signed-off-by: Jiri Slaby <jslaby@suse.cz> --- Notes: [v4] this is new in v4 -- extracted as a separate change drivers/tty/serial/lpc32xx_hs.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/lpc32xx_hs.c b/drivers/tty/serial/lpc32xx_hs.c index 0d5ef7df27d0..ed47f4768338 100644 --- a/drivers/tty/serial/lpc32xx_hs.c +++ b/drivers/tty/serial/lpc32xx_hs.c @@ -278,6 +278,13 @@ static void __serial_lpc32xx_rx(struct uart_port *port) static void serial_lpc32xx_stop_tx(struct uart_port *port); +static bool serial_lpc32xx_tx_ready(struct uart_port *port) +{ + u32 level = readl(LPC32XX_HSUART_LEVEL(port->membase)); + + return LPC32XX_HSU_TX_LEV(level) < 64; +} + static void __serial_lpc32xx_tx(struct uart_port *port) { struct circ_buf *xmit = &port->state->xmit; @@ -293,8 +300,7 @@ static void __serial_lpc32xx_tx(struct uart_port *port) goto exit_tx; /* Transfer data */ - while (LPC32XX_HSU_TX_LEV(readl( - LPC32XX_HSUART_LEVEL(port->membase))) < 64) { + while (serial_lpc32xx_tx_ready(port)) { writel((u32) xmit->buf[xmit->tail], LPC32XX_HSUART_FIFO(port->membase)); xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1); -- 2.37.3 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-20 5:21 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-20 5:20 [PATCH v4 00/10] tty: TX helpers Jiri Slaby 2022-09-20 5:20 ` [PATCH v4 01/10] tty: serial: move and cleanup vt8500_tx_empty() Jiri Slaby 2022-09-20 5:20 ` Jiri Slaby 2022-09-20 7:53 ` Ilpo Järvinen 2022-09-20 7:53 ` Ilpo Järvinen 2022-09-20 5:20 ` [PATCH v4 02/10] tty: serial: clean up stop-tx part in altera_uart_tx_chars() Jiri Slaby 2022-09-20 8:03 ` Ilpo Järvinen 2022-09-20 14:17 ` Tobias Klauser 2022-09-20 5:20 ` [PATCH v4 03/10] tty: serial: altera_uart_{r,t}x_chars() need only uart_port Jiri Slaby 2022-09-20 8:04 ` Ilpo Järvinen 2022-09-20 14:15 ` Tobias Klauser 2022-09-20 5:20 ` [PATCH v4 04/10] tty: serial: extract lqasc_tx_ready() from lqasc_tx_chars() Jiri Slaby 2022-09-20 8:03 ` Ilpo Järvinen 2022-09-20 5:20 ` Jiri Slaby [this message] 2022-09-20 5:20 ` [PATCH v4 05/10] tty: serial: extract tx_ready() from __serial_lpc32xx_tx() Jiri Slaby 2022-09-20 8:11 ` Ilpo Järvinen 2022-09-20 8:11 ` Ilpo Järvinen 2022-09-20 5:20 ` [PATCH v4 06/10] tty: serial: switch mpc52xx_uart_int_{r,t}x_chars() to bool Jiri Slaby 2022-09-20 8:37 ` Ilpo Järvinen 2022-09-20 5:20 ` [PATCH v4 07/10] tty: serial: extract serial_omap_put_char() from transmit_chars() Jiri Slaby 2022-09-20 8:37 ` Ilpo Järvinen 2022-09-20 5:20 ` [PATCH v4 08/10] tty: serial: introduce transmit helpers Jiri Slaby 2022-09-20 8:43 ` Ilpo Järvinen 2022-09-20 5:20 ` [PATCH v4 09/10] tty: serial: use uart_port_tx() helper Jiri Slaby 2022-09-20 8:54 ` Ilpo Järvinen 2022-09-20 8:56 ` Jiri Slaby 2022-09-20 7:58 ` [PATCH v4 10/10] tty: serial: use uart_port_tx_limited() Jiri Slaby 2022-09-20 7:58 ` Jiri Slaby 2022-09-20 9:19 ` Ilpo Järvinen 2022-09-20 9:19 ` Ilpo Järvinen 2022-09-20 10:58 ` Jiri Slaby 2022-09-20 10:58 ` Jiri Slaby 2022-09-22 14:15 ` [PATCH v4 00/10] tty: TX helpers Greg KH
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220920052049.20507-6-jslaby@suse.cz \ --to=jslaby@suse.cz \ --cc=gregkh@linuxfoundation.org \ --cc=ilpo.jarvinen@linux.intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=vz@mleia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.