From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com> To: Jiri Slaby <jslaby@suse.cz> Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, linux-serial <linux-serial@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, "Russell King" <linux@armlinux.org.uk>, "Florian Fainelli" <f.fainelli@gmail.com>, bcm-kernel-feedback-list@broadcom.com, "Pali Rohár" <pali@kernel.org>, "Kevin Cernekee" <cernekee@gmail.com>, "Palmer Dabbelt" <palmer@dabbelt.com>, "Paul Walmsley" <paul.walmsley@sifive.com>, "Orson Zhai" <orsonzhai@gmail.com>, "Baolin Wang" <baolin.wang7@gmail.com>, "Chunyan Zhang" <zhang.lyra@gmail.com>, "Patrice Chotard" <patrice.chotard@foss.st.com>, linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 10/10] tty: serial: use uart_port_tx_limited() Date: Tue, 20 Sep 2022 12:19:08 +0300 (EEST) [thread overview] Message-ID: <f2653c92-1769-fc7c-8ad8-abf34affef6b@linux.intel.com> (raw) In-Reply-To: <20220920075844.29360-1-jslaby@suse.cz> [-- Attachment #1: Type: text/plain, Size: 2712 bytes --] On Tue, 20 Sep 2022, Jiri Slaby wrote: > uart_port_tx_limited() is a new helper to send characters to the device. > Use it in these drivers. > > mux.c also needs to define tx_done(). But I'm not sure if the driver > really wants to wait for all the characters to dismiss from the HW fifo > at this code point. Hence I marked this as FIXME. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Russell King <linux@armlinux.org.uk> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: "Pali Rohár" <pali@kernel.org> > Cc: Kevin Cernekee <cernekee@gmail.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Paul Walmsley <paul.walmsley@sifive.com> > Cc: Orson Zhai <orsonzhai@gmail.com> > Cc: Baolin Wang <baolin.wang7@gmail.com> > Cc: Chunyan Zhang <zhang.lyra@gmail.com> > Cc: Patrice Chotard <patrice.chotard@foss.st.com> > Cc: linux-riscv@lists.infradead.org Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> One improvement suggestion below. > diff --git a/drivers/tty/serial/altera_jtaguart.c b/drivers/tty/serial/altera_jtaguart.c > index 23f339757894..f224f5141726 100644 > --- a/drivers/tty/serial/altera_jtaguart.c > +++ b/drivers/tty/serial/altera_jtaguart.c > @@ -137,39 +137,17 @@ static void altera_jtaguart_rx_chars(struct altera_jtaguart *pp) > static void altera_jtaguart_tx_chars(struct altera_jtaguart *pp) > { > struct uart_port *port = &pp->port; > - struct circ_buf *xmit = &port->state->xmit; > - unsigned int pending, count; > - > - if (port->x_char) { > - /* Send special char - probably flow control */ > - writel(port->x_char, port->membase + ALTERA_JTAGUART_DATA_REG); > - port->x_char = 0; > - port->icount.tx++; > - return; > - } > + unsigned int space; > + u8 ch; > > - pending = uart_circ_chars_pending(xmit); > - if (pending > 0) { > - count = (readl(port->membase + ALTERA_JTAGUART_CONTROL_REG) & > - ALTERA_JTAGUART_CONTROL_WSPACE_MSK) >> > - ALTERA_JTAGUART_CONTROL_WSPACE_OFF; > - if (count > pending) > - count = pending; > - if (count > 0) { > - pending -= count; > - while (count--) { > - writel(xmit->buf[xmit->tail], > - port->membase + ALTERA_JTAGUART_DATA_REG); > - xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1); > - port->icount.tx++; > - } > - if (pending < WAKEUP_CHARS) > - uart_write_wakeup(port); > - } > - } > + space = readl(port->membase + ALTERA_JTAGUART_CONTROL_REG); > + space &= ALTERA_JTAGUART_CONTROL_WSPACE_MSK; > + space >>= ALTERA_JTAGUART_CONTROL_WSPACE_OFF; This is FIELD_GET(ALTERA_JTAGUART_CONTROL_WSPACE_MSK, ...) & then allows killing ALTERA_JTAGUART_CONTROL_WSPACE_OFF. I'd probably do it in a separate patch though. -- i.
WARNING: multiple messages have this Message-ID (diff)
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com> To: Jiri Slaby <jslaby@suse.cz> Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, linux-serial <linux-serial@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, "Russell King" <linux@armlinux.org.uk>, "Florian Fainelli" <f.fainelli@gmail.com>, bcm-kernel-feedback-list@broadcom.com, "Pali Rohár" <pali@kernel.org>, "Kevin Cernekee" <cernekee@gmail.com>, "Palmer Dabbelt" <palmer@dabbelt.com>, "Paul Walmsley" <paul.walmsley@sifive.com>, "Orson Zhai" <orsonzhai@gmail.com>, "Baolin Wang" <baolin.wang7@gmail.com>, "Chunyan Zhang" <zhang.lyra@gmail.com>, "Patrice Chotard" <patrice.chotard@foss.st.com>, linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 10/10] tty: serial: use uart_port_tx_limited() Date: Tue, 20 Sep 2022 12:19:08 +0300 (EEST) [thread overview] Message-ID: <f2653c92-1769-fc7c-8ad8-abf34affef6b@linux.intel.com> (raw) In-Reply-To: <20220920075844.29360-1-jslaby@suse.cz> [-- Attachment #1: Type: text/plain, Size: 2712 bytes --] On Tue, 20 Sep 2022, Jiri Slaby wrote: > uart_port_tx_limited() is a new helper to send characters to the device. > Use it in these drivers. > > mux.c also needs to define tx_done(). But I'm not sure if the driver > really wants to wait for all the characters to dismiss from the HW fifo > at this code point. Hence I marked this as FIXME. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Russell King <linux@armlinux.org.uk> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: "Pali Rohár" <pali@kernel.org> > Cc: Kevin Cernekee <cernekee@gmail.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Paul Walmsley <paul.walmsley@sifive.com> > Cc: Orson Zhai <orsonzhai@gmail.com> > Cc: Baolin Wang <baolin.wang7@gmail.com> > Cc: Chunyan Zhang <zhang.lyra@gmail.com> > Cc: Patrice Chotard <patrice.chotard@foss.st.com> > Cc: linux-riscv@lists.infradead.org Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> One improvement suggestion below. > diff --git a/drivers/tty/serial/altera_jtaguart.c b/drivers/tty/serial/altera_jtaguart.c > index 23f339757894..f224f5141726 100644 > --- a/drivers/tty/serial/altera_jtaguart.c > +++ b/drivers/tty/serial/altera_jtaguart.c > @@ -137,39 +137,17 @@ static void altera_jtaguart_rx_chars(struct altera_jtaguart *pp) > static void altera_jtaguart_tx_chars(struct altera_jtaguart *pp) > { > struct uart_port *port = &pp->port; > - struct circ_buf *xmit = &port->state->xmit; > - unsigned int pending, count; > - > - if (port->x_char) { > - /* Send special char - probably flow control */ > - writel(port->x_char, port->membase + ALTERA_JTAGUART_DATA_REG); > - port->x_char = 0; > - port->icount.tx++; > - return; > - } > + unsigned int space; > + u8 ch; > > - pending = uart_circ_chars_pending(xmit); > - if (pending > 0) { > - count = (readl(port->membase + ALTERA_JTAGUART_CONTROL_REG) & > - ALTERA_JTAGUART_CONTROL_WSPACE_MSK) >> > - ALTERA_JTAGUART_CONTROL_WSPACE_OFF; > - if (count > pending) > - count = pending; > - if (count > 0) { > - pending -= count; > - while (count--) { > - writel(xmit->buf[xmit->tail], > - port->membase + ALTERA_JTAGUART_DATA_REG); > - xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1); > - port->icount.tx++; > - } > - if (pending < WAKEUP_CHARS) > - uart_write_wakeup(port); > - } > - } > + space = readl(port->membase + ALTERA_JTAGUART_CONTROL_REG); > + space &= ALTERA_JTAGUART_CONTROL_WSPACE_MSK; > + space >>= ALTERA_JTAGUART_CONTROL_WSPACE_OFF; This is FIELD_GET(ALTERA_JTAGUART_CONTROL_WSPACE_MSK, ...) & then allows killing ALTERA_JTAGUART_CONTROL_WSPACE_OFF. I'd probably do it in a separate patch though. -- i. [-- Attachment #2: Type: text/plain, Size: 161 bytes --] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-09-20 9:19 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-20 5:20 [PATCH v4 00/10] tty: TX helpers Jiri Slaby 2022-09-20 5:20 ` [PATCH v4 01/10] tty: serial: move and cleanup vt8500_tx_empty() Jiri Slaby 2022-09-20 5:20 ` Jiri Slaby 2022-09-20 7:53 ` Ilpo Järvinen 2022-09-20 7:53 ` Ilpo Järvinen 2022-09-20 5:20 ` [PATCH v4 02/10] tty: serial: clean up stop-tx part in altera_uart_tx_chars() Jiri Slaby 2022-09-20 8:03 ` Ilpo Järvinen 2022-09-20 14:17 ` Tobias Klauser 2022-09-20 5:20 ` [PATCH v4 03/10] tty: serial: altera_uart_{r,t}x_chars() need only uart_port Jiri Slaby 2022-09-20 8:04 ` Ilpo Järvinen 2022-09-20 14:15 ` Tobias Klauser 2022-09-20 5:20 ` [PATCH v4 04/10] tty: serial: extract lqasc_tx_ready() from lqasc_tx_chars() Jiri Slaby 2022-09-20 8:03 ` Ilpo Järvinen 2022-09-20 5:20 ` [PATCH v4 05/10] tty: serial: extract tx_ready() from __serial_lpc32xx_tx() Jiri Slaby 2022-09-20 5:20 ` Jiri Slaby 2022-09-20 8:11 ` Ilpo Järvinen 2022-09-20 8:11 ` Ilpo Järvinen 2022-09-20 5:20 ` [PATCH v4 06/10] tty: serial: switch mpc52xx_uart_int_{r,t}x_chars() to bool Jiri Slaby 2022-09-20 8:37 ` Ilpo Järvinen 2022-09-20 5:20 ` [PATCH v4 07/10] tty: serial: extract serial_omap_put_char() from transmit_chars() Jiri Slaby 2022-09-20 8:37 ` Ilpo Järvinen 2022-09-20 5:20 ` [PATCH v4 08/10] tty: serial: introduce transmit helpers Jiri Slaby 2022-09-20 8:43 ` Ilpo Järvinen 2022-09-20 5:20 ` [PATCH v4 09/10] tty: serial: use uart_port_tx() helper Jiri Slaby 2022-09-20 8:54 ` Ilpo Järvinen 2022-09-20 8:56 ` Jiri Slaby 2022-09-20 7:58 ` [PATCH v4 10/10] tty: serial: use uart_port_tx_limited() Jiri Slaby 2022-09-20 7:58 ` Jiri Slaby 2022-09-20 9:19 ` Ilpo Järvinen [this message] 2022-09-20 9:19 ` Ilpo Järvinen 2022-09-20 10:58 ` Jiri Slaby 2022-09-20 10:58 ` Jiri Slaby 2022-09-22 14:15 ` [PATCH v4 00/10] tty: TX helpers Greg KH
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f2653c92-1769-fc7c-8ad8-abf34affef6b@linux.intel.com \ --to=ilpo.jarvinen@linux.intel.com \ --cc=baolin.wang7@gmail.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=cernekee@gmail.com \ --cc=f.fainelli@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=jslaby@suse.cz \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=orsonzhai@gmail.com \ --cc=pali@kernel.org \ --cc=palmer@dabbelt.com \ --cc=patrice.chotard@foss.st.com \ --cc=paul.walmsley@sifive.com \ --cc=zhang.lyra@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.