* [PATCH net-next 1/3] net: use netdev_unregistering instead of open code
@ 2022-09-23 16:09 Juhee Kang
2022-09-23 16:09 ` [PATCH net-next 2/3] ethtool: " Juhee Kang
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Juhee Kang @ 2022-09-23 16:09 UTC (permalink / raw)
To: netdev, simon.horman, kuba, davem, edumazet, pabeni; +Cc: skhan, Juhee Kang
The open code is defined as a helper function(netdev_unregistering)
on netdev.h, which the open code is dev->reg_state == NETREG_UNREGISTERING.
Thus, netdev_unregistering() replaces the open code. This patch doesn't
change logic.
Signed-off-by: Juhee Kang <claudiajkang@gmail.com>
---
net/core/dev.c | 9 ++++-----
net/core/net-sysfs.c | 2 +-
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index d66c73c1c734..f3f9394f0b5a 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2886,8 +2886,7 @@ int netif_set_real_num_tx_queues(struct net_device *dev, unsigned int txq)
if (txq < 1 || txq > dev->num_tx_queues)
return -EINVAL;
- if (dev->reg_state == NETREG_REGISTERED ||
- dev->reg_state == NETREG_UNREGISTERING) {
+ if (dev->reg_state == NETREG_REGISTERED || netdev_unregistering(dev)) {
ASSERT_RTNL();
rc = netdev_queue_update_kobjects(dev, dev->real_num_tx_queues,
@@ -5786,7 +5785,7 @@ static void flush_backlog(struct work_struct *work)
rps_lock_irq_disable(sd);
skb_queue_walk_safe(&sd->input_pkt_queue, skb, tmp) {
- if (skb->dev->reg_state == NETREG_UNREGISTERING) {
+ if (netdev_unregistering(skb->dev)) {
__skb_unlink(skb, &sd->input_pkt_queue);
dev_kfree_skb_irq(skb);
input_queue_head_incr(sd);
@@ -5795,7 +5794,7 @@ static void flush_backlog(struct work_struct *work)
rps_unlock_irq_enable(sd);
skb_queue_walk_safe(&sd->process_queue, skb, tmp) {
- if (skb->dev->reg_state == NETREG_UNREGISTERING) {
+ if (netdev_unregistering(skb->dev)) {
__skb_unlink(skb, &sd->process_queue);
kfree_skb(skb);
input_queue_head_incr(sd);
@@ -10708,7 +10707,7 @@ void free_netdev(struct net_device *dev)
* handling may still be dismantling the device. Handle that case by
* deferring the free.
*/
- if (dev->reg_state == NETREG_UNREGISTERING) {
+ if (netdev_unregistering(dev)) {
ASSERT_RTNL();
dev->needs_free_netdev = true;
return;
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index d61afd21aab5..ec929bf15268 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -1711,7 +1711,7 @@ netdev_queue_update_kobjects(struct net_device *dev, int old_num, int new_num)
* unregistered, but solely to remove queues from qdiscs. Any path
* adding queues should be fixed.
*/
- WARN(dev->reg_state == NETREG_UNREGISTERING && new_num > old_num,
+ WARN(netdev_unregistering(dev) && new_num > old_num,
"New queues can't be registered after device unregistration.");
for (i = old_num; i < new_num; i++) {
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net-next 2/3] ethtool: use netdev_unregistering instead of open code
2022-09-23 16:09 [PATCH net-next 1/3] net: use netdev_unregistering instead of open code Juhee Kang
@ 2022-09-23 16:09 ` Juhee Kang
2022-09-26 7:45 ` Simon Horman
2022-09-23 16:09 ` [PATCH net-next 3/3] nfp: abm: " Juhee Kang
2022-09-26 7:44 ` [PATCH net-next 1/3] net: " Simon Horman
2 siblings, 1 reply; 14+ messages in thread
From: Juhee Kang @ 2022-09-23 16:09 UTC (permalink / raw)
To: netdev, simon.horman, kuba, davem, edumazet, pabeni; +Cc: skhan, Juhee Kang
The open code is defined as a helper function(netdev_unregistering)
on netdev.h, which the open code is dev->reg_state == NETREG_UNREGISTERING.
Thus, netdev_unregistering() replaces the open code. This patch doesn't
change logic.
Signed-off-by: Juhee Kang <claudiajkang@gmail.com>
---
net/ethtool/netlink.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ethtool/netlink.c b/net/ethtool/netlink.c
index f4e41a6e0163..835b13264b15 100644
--- a/net/ethtool/netlink.c
+++ b/net/ethtool/netlink.c
@@ -40,8 +40,7 @@ int ethnl_ops_begin(struct net_device *dev)
if (dev->dev.parent)
pm_runtime_get_sync(dev->dev.parent);
- if (!netif_device_present(dev) ||
- dev->reg_state == NETREG_UNREGISTERING) {
+ if (!netif_device_present(dev) || netdev_unregistering(dev)) {
ret = -ENODEV;
goto err;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net-next 3/3] nfp: abm: use netdev_unregistering instead of open code
2022-09-23 16:09 [PATCH net-next 1/3] net: use netdev_unregistering instead of open code Juhee Kang
2022-09-23 16:09 ` [PATCH net-next 2/3] ethtool: " Juhee Kang
@ 2022-09-23 16:09 ` Juhee Kang
2022-09-26 7:48 ` Simon Horman
2022-09-26 7:44 ` [PATCH net-next 1/3] net: " Simon Horman
2 siblings, 1 reply; 14+ messages in thread
From: Juhee Kang @ 2022-09-23 16:09 UTC (permalink / raw)
To: netdev, simon.horman, kuba, davem, edumazet, pabeni; +Cc: skhan, Juhee Kang
The open code is defined as a helper function(netdev_unregistering)
on netdev.h, which the open code is dev->reg_state == NETREG_UNREGISTERING.
Thus, netdev_unregistering() replaces the open code. This patch doesn't
change logic.
Signed-off-by: Juhee Kang <claudiajkang@gmail.com>
---
drivers/net/ethernet/netronome/nfp/abm/qdisc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/netronome/nfp/abm/qdisc.c b/drivers/net/ethernet/netronome/nfp/abm/qdisc.c
index 2a5cc64227e9..19b1ccc9abf6 100644
--- a/drivers/net/ethernet/netronome/nfp/abm/qdisc.c
+++ b/drivers/net/ethernet/netronome/nfp/abm/qdisc.c
@@ -296,7 +296,7 @@ nfp_abm_qdisc_clear_mq(struct net_device *netdev, struct nfp_abm_link *alink,
*/
if (qdisc->type == NFP_QDISC_MQ &&
qdisc == alink->root_qdisc &&
- netdev->reg_state == NETREG_UNREGISTERING)
+ netdev_unregistering(netdev))
return;
/* Count refs held by MQ instances and clear pointers */
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 1/3] net: use netdev_unregistering instead of open code
2022-09-23 16:09 [PATCH net-next 1/3] net: use netdev_unregistering instead of open code Juhee Kang
2022-09-23 16:09 ` [PATCH net-next 2/3] ethtool: " Juhee Kang
2022-09-23 16:09 ` [PATCH net-next 3/3] nfp: abm: " Juhee Kang
@ 2022-09-26 7:44 ` Simon Horman
2022-09-26 8:05 ` Juhee Kang
2 siblings, 1 reply; 14+ messages in thread
From: Simon Horman @ 2022-09-26 7:44 UTC (permalink / raw)
To: Juhee Kang; +Cc: netdev, kuba, davem, edumazet, pabeni, skhan
On Sat, Sep 24, 2022 at 01:09:35AM +0900, Juhee Kang wrote:
> [You don't often get email from claudiajkang@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> The open code is defined as a helper function(netdev_unregistering)
> on netdev.h, which the open code is dev->reg_state == NETREG_UNREGISTERING.
> Thus, netdev_unregistering() replaces the open code. This patch doesn't
> change logic.
>
> Signed-off-by: Juhee Kang <claudiajkang@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
> ---
> net/core/dev.c | 9 ++++-----
> net/core/net-sysfs.c | 2 +-
> 2 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index d66c73c1c734..f3f9394f0b5a 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -2886,8 +2886,7 @@ int netif_set_real_num_tx_queues(struct net_device *dev, unsigned int txq)
> if (txq < 1 || txq > dev->num_tx_queues)
> return -EINVAL;
>
> - if (dev->reg_state == NETREG_REGISTERED ||
> - dev->reg_state == NETREG_UNREGISTERING) {
> + if (dev->reg_state == NETREG_REGISTERED || netdev_unregistering(dev)) {
> ASSERT_RTNL();
>
> rc = netdev_queue_update_kobjects(dev, dev->real_num_tx_queues,
Is there any value in adding a netdev_registered() helper?
...
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 2/3] ethtool: use netdev_unregistering instead of open code
2022-09-23 16:09 ` [PATCH net-next 2/3] ethtool: " Juhee Kang
@ 2022-09-26 7:45 ` Simon Horman
0 siblings, 0 replies; 14+ messages in thread
From: Simon Horman @ 2022-09-26 7:45 UTC (permalink / raw)
To: Juhee Kang; +Cc: netdev, kuba, davem, edumazet, pabeni, skhan
On Sat, Sep 24, 2022 at 01:09:36AM +0900, Juhee Kang wrote:
> [You don't often get email from claudiajkang@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> The open code is defined as a helper function(netdev_unregistering)
> on netdev.h, which the open code is dev->reg_state == NETREG_UNREGISTERING.
> Thus, netdev_unregistering() replaces the open code. This patch doesn't
> change logic.
>
> Signed-off-by: Juhee Kang <claudiajkang@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 3/3] nfp: abm: use netdev_unregistering instead of open code
2022-09-23 16:09 ` [PATCH net-next 3/3] nfp: abm: " Juhee Kang
@ 2022-09-26 7:48 ` Simon Horman
0 siblings, 0 replies; 14+ messages in thread
From: Simon Horman @ 2022-09-26 7:48 UTC (permalink / raw)
To: Juhee Kang; +Cc: netdev, kuba, davem, edumazet, pabeni, skhan, oss-drivers
+oss-drivers@netronome.com
On Sat, Sep 24, 2022 at 01:09:37AM +0900, Juhee Kang wrote:
> [You don't often get email from claudiajkang@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> The open code is defined as a helper function(netdev_unregistering)
> on netdev.h, which the open code is dev->reg_state == NETREG_UNREGISTERING.
> Thus, netdev_unregistering() replaces the open code. This patch doesn't
> change logic.
>
> Signed-off-by: Juhee Kang <claudiajkang@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 1/3] net: use netdev_unregistering instead of open code
2022-09-26 7:44 ` [PATCH net-next 1/3] net: " Simon Horman
@ 2022-09-26 8:05 ` Juhee Kang
2022-09-26 8:19 ` Simon Horman
0 siblings, 1 reply; 14+ messages in thread
From: Juhee Kang @ 2022-09-26 8:05 UTC (permalink / raw)
To: Simon Horman; +Cc: netdev, kuba, davem, edumazet, pabeni, skhan
Hi Simon,
Thanks a lot for your review!
On Mon, Sep 26, 2022 at 4:44 PM Simon Horman <simon.horman@corigine.com> wrote:
>
> On Sat, Sep 24, 2022 at 01:09:35AM +0900, Juhee Kang wrote:
> > [You don't often get email from claudiajkang@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> >
> > The open code is defined as a helper function(netdev_unregistering)
> > on netdev.h, which the open code is dev->reg_state == NETREG_UNREGISTERING.
> > Thus, netdev_unregistering() replaces the open code. This patch doesn't
> > change logic.
> >
> > Signed-off-by: Juhee Kang <claudiajkang@gmail.com>
>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
>
> > ---
> > net/core/dev.c | 9 ++++-----
> > net/core/net-sysfs.c | 2 +-
> > 2 files changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/net/core/dev.c b/net/core/dev.c
> > index d66c73c1c734..f3f9394f0b5a 100644
> > --- a/net/core/dev.c
> > +++ b/net/core/dev.c
> > @@ -2886,8 +2886,7 @@ int netif_set_real_num_tx_queues(struct net_device *dev, unsigned int txq)
> > if (txq < 1 || txq > dev->num_tx_queues)
> > return -EINVAL;
> >
> > - if (dev->reg_state == NETREG_REGISTERED ||
> > - dev->reg_state == NETREG_UNREGISTERING) {
> > + if (dev->reg_state == NETREG_REGISTERED || netdev_unregistering(dev)) {
> > ASSERT_RTNL();
> >
> > rc = netdev_queue_update_kobjects(dev, dev->real_num_tx_queues,
>
> Is there any value in adding a netdev_registered() helper?
>
The open code which is reg_state == NETREG_REGISTERED used 37 times on
some codes related to the network. I think that the
netdev_registered() helper is valuable.
> ...
Best regards,
Juhee
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 1/3] net: use netdev_unregistering instead of open code
2022-09-26 8:05 ` Juhee Kang
@ 2022-09-26 8:19 ` Simon Horman
2022-09-26 8:25 ` Juhee Kang
0 siblings, 1 reply; 14+ messages in thread
From: Simon Horman @ 2022-09-26 8:19 UTC (permalink / raw)
To: Juhee Kang; +Cc: netdev, kuba, davem, edumazet, pabeni, skhan
On Mon, Sep 26, 2022 at 05:05:08PM +0900, Juhee Kang wrote:
> Hi Simon,
...
> > > diff --git a/net/core/dev.c b/net/core/dev.c
> > > index d66c73c1c734..f3f9394f0b5a 100644
> > > --- a/net/core/dev.c
> > > +++ b/net/core/dev.c
> > > @@ -2886,8 +2886,7 @@ int netif_set_real_num_tx_queues(struct net_device *dev, unsigned int txq)
> > > if (txq < 1 || txq > dev->num_tx_queues)
> > > return -EINVAL;
> > >
> > > - if (dev->reg_state == NETREG_REGISTERED ||
> > > - dev->reg_state == NETREG_UNREGISTERING) {
> > > + if (dev->reg_state == NETREG_REGISTERED || netdev_unregistering(dev)) {
> > > ASSERT_RTNL();
> > >
> > > rc = netdev_queue_update_kobjects(dev, dev->real_num_tx_queues,
> >
> > Is there any value in adding a netdev_registered() helper?
> >
>
> The open code which is reg_state == NETREG_REGISTERED used 37 times on
> some codes related to the network. I think that the
> netdev_registered() helper is valuable.
Thanks, FWIIW, that seems likely to me too.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 1/3] net: use netdev_unregistering instead of open code
2022-09-26 8:19 ` Simon Horman
@ 2022-09-26 8:25 ` Juhee Kang
2022-09-26 8:27 ` Simon Horman
0 siblings, 1 reply; 14+ messages in thread
From: Juhee Kang @ 2022-09-26 8:25 UTC (permalink / raw)
To: Simon Horman; +Cc: netdev, kuba, davem, edumazet, pabeni, skhan
On Mon, Sep 26, 2022 at 5:19 PM Simon Horman <simon.horman@corigine.com> wrote:
>
> On Mon, Sep 26, 2022 at 05:05:08PM +0900, Juhee Kang wrote:
> > Hi Simon,
>
> ...
>
> > > > diff --git a/net/core/dev.c b/net/core/dev.c
> > > > index d66c73c1c734..f3f9394f0b5a 100644
> > > > --- a/net/core/dev.c
> > > > +++ b/net/core/dev.c
> > > > @@ -2886,8 +2886,7 @@ int netif_set_real_num_tx_queues(struct net_device *dev, unsigned int txq)
> > > > if (txq < 1 || txq > dev->num_tx_queues)
> > > > return -EINVAL;
> > > >
> > > > - if (dev->reg_state == NETREG_REGISTERED ||
> > > > - dev->reg_state == NETREG_UNREGISTERING) {
> > > > + if (dev->reg_state == NETREG_REGISTERED || netdev_unregistering(dev)) {
> > > > ASSERT_RTNL();
> > > >
> > > > rc = netdev_queue_update_kobjects(dev, dev->real_num_tx_queues,
> > >
> > > Is there any value in adding a netdev_registered() helper?
> > >
> >
> > The open code which is reg_state == NETREG_REGISTERED used 37 times on
> > some codes related to the network. I think that the
> > netdev_registered() helper is valuable.
>
> Thanks, FWIIW, that seems likely to me too.
Thanks!
Apart from this patch, is it okay to send a patch that adds the
netdev_registered helper function later?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 1/3] net: use netdev_unregistering instead of open code
2022-09-26 8:25 ` Juhee Kang
@ 2022-09-26 8:27 ` Simon Horman
2022-09-26 8:29 ` Juhee Kang
0 siblings, 1 reply; 14+ messages in thread
From: Simon Horman @ 2022-09-26 8:27 UTC (permalink / raw)
To: Juhee Kang; +Cc: netdev, kuba, davem, edumazet, pabeni, skhan
On Mon, Sep 26, 2022 at 05:25:01PM +0900, Juhee Kang wrote:
> On Mon, Sep 26, 2022 at 5:19 PM Simon Horman <simon.horman@corigine.com> wrote:
> >
> > On Mon, Sep 26, 2022 at 05:05:08PM +0900, Juhee Kang wrote:
> > > Hi Simon,
> >
> > ...
> >
> > > > > diff --git a/net/core/dev.c b/net/core/dev.c
> > > > > index d66c73c1c734..f3f9394f0b5a 100644
> > > > > --- a/net/core/dev.c
> > > > > +++ b/net/core/dev.c
> > > > > @@ -2886,8 +2886,7 @@ int netif_set_real_num_tx_queues(struct net_device *dev, unsigned int txq)
> > > > > if (txq < 1 || txq > dev->num_tx_queues)
> > > > > return -EINVAL;
> > > > >
> > > > > - if (dev->reg_state == NETREG_REGISTERED ||
> > > > > - dev->reg_state == NETREG_UNREGISTERING) {
> > > > > + if (dev->reg_state == NETREG_REGISTERED || netdev_unregistering(dev)) {
> > > > > ASSERT_RTNL();
> > > > >
> > > > > rc = netdev_queue_update_kobjects(dev, dev->real_num_tx_queues,
> > > >
> > > > Is there any value in adding a netdev_registered() helper?
> > > >
> > >
> > > The open code which is reg_state == NETREG_REGISTERED used 37 times on
> > > some codes related to the network. I think that the
> > > netdev_registered() helper is valuable.
> >
> > Thanks, FWIIW, that seems likely to me too.
>
> Thanks!
> Apart from this patch, is it okay to send a patch that adds the
> netdev_registered helper function later?
In my opinion that would be good: let's fix one thing at a time.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 1/3] net: use netdev_unregistering instead of open code
2022-09-26 8:27 ` Simon Horman
@ 2022-09-26 8:29 ` Juhee Kang
2022-09-26 17:04 ` Jakub Kicinski
0 siblings, 1 reply; 14+ messages in thread
From: Juhee Kang @ 2022-09-26 8:29 UTC (permalink / raw)
To: Simon Horman; +Cc: netdev, kuba, davem, edumazet, pabeni, skhan
On Mon, Sep 26, 2022 at 5:27 PM Simon Horman <simon.horman@corigine.com> wrote:
>
> On Mon, Sep 26, 2022 at 05:25:01PM +0900, Juhee Kang wrote:
> > On Mon, Sep 26, 2022 at 5:19 PM Simon Horman <simon.horman@corigine.com> wrote:
> > >
> > > On Mon, Sep 26, 2022 at 05:05:08PM +0900, Juhee Kang wrote:
> > > > Hi Simon,
> > >
> > > ...
> > >
> > > > > > diff --git a/net/core/dev.c b/net/core/dev.c
> > > > > > index d66c73c1c734..f3f9394f0b5a 100644
> > > > > > --- a/net/core/dev.c
> > > > > > +++ b/net/core/dev.c
> > > > > > @@ -2886,8 +2886,7 @@ int netif_set_real_num_tx_queues(struct net_device *dev, unsigned int txq)
> > > > > > if (txq < 1 || txq > dev->num_tx_queues)
> > > > > > return -EINVAL;
> > > > > >
> > > > > > - if (dev->reg_state == NETREG_REGISTERED ||
> > > > > > - dev->reg_state == NETREG_UNREGISTERING) {
> > > > > > + if (dev->reg_state == NETREG_REGISTERED || netdev_unregistering(dev)) {
> > > > > > ASSERT_RTNL();
> > > > > >
> > > > > > rc = netdev_queue_update_kobjects(dev, dev->real_num_tx_queues,
> > > > >
> > > > > Is there any value in adding a netdev_registered() helper?
> > > > >
> > > >
> > > > The open code which is reg_state == NETREG_REGISTERED used 37 times on
> > > > some codes related to the network. I think that the
> > > > netdev_registered() helper is valuable.
> > >
> > > Thanks, FWIIW, that seems likely to me too.
> >
> > Thanks!
> > Apart from this patch, is it okay to send a patch that adds the
> > netdev_registered helper function later?
>
> In my opinion that would be good: let's fix one thing at a time.
I agree with you.
I will send a patch by applying netdev_registered() helper function by
directory.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 1/3] net: use netdev_unregistering instead of open code
2022-09-26 8:29 ` Juhee Kang
@ 2022-09-26 17:04 ` Jakub Kicinski
2022-09-26 17:45 ` Jakub Kicinski
0 siblings, 1 reply; 14+ messages in thread
From: Jakub Kicinski @ 2022-09-26 17:04 UTC (permalink / raw)
To: Juhee Kang; +Cc: Simon Horman, netdev, davem, edumazet, pabeni, skhan
On Mon, 26 Sep 2022 17:29:39 +0900 Juhee Kang wrote:
> I will send a patch by applying netdev_registered() helper function by
> directory.
Please hold off doing that. My preference would be to remove
netdev_unregistering(), this is all low-gain churn.
IMHO the helpers don't add much to readability and increase
the number of random helpers programmer must be aware of.
Let me check with other netdev maintainers and get back to you.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 1/3] net: use netdev_unregistering instead of open code
2022-09-26 17:04 ` Jakub Kicinski
@ 2022-09-26 17:45 ` Jakub Kicinski
2022-09-28 14:57 ` Juhee Kang
0 siblings, 1 reply; 14+ messages in thread
From: Jakub Kicinski @ 2022-09-26 17:45 UTC (permalink / raw)
To: Juhee Kang; +Cc: Simon Horman, netdev, davem, edumazet, pabeni, skhan
On Mon, 26 Sep 2022 10:04:44 -0700 Jakub Kicinski wrote:
> On Mon, 26 Sep 2022 17:29:39 +0900 Juhee Kang wrote:
> > I will send a patch by applying netdev_registered() helper function by
> > directory.
>
> Please hold off doing that. My preference would be to remove
> netdev_unregistering(), this is all low-gain churn.
> IMHO the helpers don't add much to readability and increase
> the number of random helpers programmer must be aware of.
> Let me check with other netdev maintainers and get back to you.
I got hold of Paolo and he concurred. Let's remove
netdev_unregistering() instead. Thanks!
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next 1/3] net: use netdev_unregistering instead of open code
2022-09-26 17:45 ` Jakub Kicinski
@ 2022-09-28 14:57 ` Juhee Kang
0 siblings, 0 replies; 14+ messages in thread
From: Juhee Kang @ 2022-09-28 14:57 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: Simon Horman, netdev, davem, edumazet, pabeni, skhan
Hi Jakub,
On Tue, Sep 27, 2022 at 2:45 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon, 26 Sep 2022 10:04:44 -0700 Jakub Kicinski wrote:
> > On Mon, 26 Sep 2022 17:29:39 +0900 Juhee Kang wrote:
> > > I will send a patch by applying netdev_registered() helper function by
> > > directory.
> >
> > Please hold off doing that. My preference would be to remove
> > netdev_unregistering(), this is all low-gain churn.
> > IMHO the helpers don't add much to readability and increase
> > the number of random helpers programmer must be aware of.
> > Let me check with other netdev maintainers and get back to you.
>
> I got hold of Paolo and he concurred. Let's remove
> netdev_unregistering() instead. Thanks!
Thank you for your review!
I will send the next version which includes removing netdev_unregistering()
as soon as possible.
Best regards,
Juhee
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2022-09-28 14:58 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23 16:09 [PATCH net-next 1/3] net: use netdev_unregistering instead of open code Juhee Kang
2022-09-23 16:09 ` [PATCH net-next 2/3] ethtool: " Juhee Kang
2022-09-26 7:45 ` Simon Horman
2022-09-23 16:09 ` [PATCH net-next 3/3] nfp: abm: " Juhee Kang
2022-09-26 7:48 ` Simon Horman
2022-09-26 7:44 ` [PATCH net-next 1/3] net: " Simon Horman
2022-09-26 8:05 ` Juhee Kang
2022-09-26 8:19 ` Simon Horman
2022-09-26 8:25 ` Juhee Kang
2022-09-26 8:27 ` Simon Horman
2022-09-26 8:29 ` Juhee Kang
2022-09-26 17:04 ` Jakub Kicinski
2022-09-26 17:45 ` Jakub Kicinski
2022-09-28 14:57 ` Juhee Kang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.