From: Jakub Kicinski <kuba@kernel.org> To: Jiri Pirko <jiri@resnulli.us> Cc: Vadim Fedorenko <vfedorenko@novek.ru>, Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>, Jonathan Lemon <jonathan.lemon@gmail.com>, Vadim Fedorenko <vadfed@fb.com>, Aya Levin <ayal@nvidia.com>, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Gal Pressman <gal@nvidia.com> Subject: Re: [RFC PATCH v2 0/3] Create common DPLL/clock configuration API Date: Sat, 1 Oct 2022 07:18:27 -0700 [thread overview] Message-ID: <20221001071827.202fe4c1@kernel.org> (raw) In-Reply-To: <YzfUbKtWlxuq+FzI@nanopsycho> On Sat, 1 Oct 2022 07:47:24 +0200 Jiri Pirko wrote: > >> Sure, but more hw does not mean you can't use sysfs. Take netdev as an > >> example. The sysfs exposed for it is implemented net/core/net-sysfs.c > >> and is exposed for all netdev instances, no matter what the > >> driver/hardware is. > > > >Wait, *you* are suggesting someone uses sysfs instead of netlink? > > > >Could you say more because I feel like that's kicking the absolute. > > I don't understand why that would be a problem. Why did you do devlink over netlink then? The bus device is already there in sysfs. > What I'm trying to say > is, perhaps sysfs is a better API for this purpose. The API looks very > neat and there is no probabilito of huge grow. "this API is nice and small" said everyone about every new API ever, APIs grow. > Also, with sysfs, you > don't need userspace app to do basic work with the api. In this case, I > don't see why the app is needed. Yes, with the YAML specs you don't need a per-family APP. A generic app can support any family, just JSON in JSON out. DPLL-nl will come with a YAML spec. > These are 2 biggest arguments for sysfs in this case as I see it. 2 biggest arguments? Is "this API is small" one of the _biggest_ arguments you see? I don't think it's an argument at all. The OCP PTP driver started small and now its not small. And the files don't even follow sysfs rules. Trust me, we have some experience here :/ As I said to you in private I feel like there may be some political games being played here, so I'd like to urge you to focus on real issues.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org> To: Jiri Pirko <jiri@resnulli.us> Cc: Vadim Fedorenko <vfedorenko@novek.ru>, Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>, Jonathan Lemon <jonathan.lemon@gmail.com>, Vadim Fedorenko <vadfed@fb.com>, Aya Levin <ayal@nvidia.com>, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Gal Pressman <gal@nvidia.com> Subject: Re: [RFC PATCH v2 0/3] Create common DPLL/clock configuration API Date: Sat, 1 Oct 2022 07:18:27 -0700 [thread overview] Message-ID: <20221001071827.202fe4c1@kernel.org> (raw) In-Reply-To: <YzfUbKtWlxuq+FzI@nanopsycho> On Sat, 1 Oct 2022 07:47:24 +0200 Jiri Pirko wrote: > >> Sure, but more hw does not mean you can't use sysfs. Take netdev as an > >> example. The sysfs exposed for it is implemented net/core/net-sysfs.c > >> and is exposed for all netdev instances, no matter what the > >> driver/hardware is. > > > >Wait, *you* are suggesting someone uses sysfs instead of netlink? > > > >Could you say more because I feel like that's kicking the absolute. > > I don't understand why that would be a problem. Why did you do devlink over netlink then? The bus device is already there in sysfs. > What I'm trying to say > is, perhaps sysfs is a better API for this purpose. The API looks very > neat and there is no probabilito of huge grow. "this API is nice and small" said everyone about every new API ever, APIs grow. > Also, with sysfs, you > don't need userspace app to do basic work with the api. In this case, I > don't see why the app is needed. Yes, with the YAML specs you don't need a per-family APP. A generic app can support any family, just JSON in JSON out. DPLL-nl will come with a YAML spec. > These are 2 biggest arguments for sysfs in this case as I see it. 2 biggest arguments? Is "this API is small" one of the _biggest_ arguments you see? I don't think it's an argument at all. The OCP PTP driver started small and now its not small. And the files don't even follow sysfs rules. Trust me, we have some experience here :/ As I said to you in private I feel like there may be some political games being played here, so I'd like to urge you to focus on real issues. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-01 14:18 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-26 19:24 [RFC PATCH v2 0/3] Create common DPLL/clock configuration API Vadim Fedorenko 2022-06-26 19:24 ` Vadim Fedorenko 2022-06-26 19:24 ` [RFC PATCH v2 1/3] dpll: Add DPLL framework base functions Vadim Fedorenko 2022-06-26 19:24 ` Vadim Fedorenko 2022-06-29 8:34 ` Stephen Boyd 2022-06-29 8:34 ` Stephen Boyd 2022-06-29 23:37 ` Vadim Fedorenko 2022-06-29 23:37 ` Vadim Fedorenko 2022-07-11 9:01 ` Kubalewski, Arkadiusz 2022-07-11 9:01 ` Kubalewski, Arkadiusz 2022-07-14 23:23 ` Vadim Fedorenko 2022-07-14 23:23 ` Vadim Fedorenko 2022-07-15 17:31 ` Kubalewski, Arkadiusz 2022-07-15 17:31 ` Kubalewski, Arkadiusz 2022-06-26 19:24 ` [RFC PATCH v2 2/3] dpll: add netlink events Vadim Fedorenko 2022-06-26 19:24 ` Vadim Fedorenko 2022-07-11 9:02 ` Kubalewski, Arkadiusz 2022-07-11 9:02 ` Kubalewski, Arkadiusz 2022-07-14 23:29 ` Vadim Fedorenko 2022-07-14 23:29 ` Vadim Fedorenko 2022-07-15 17:31 ` Kubalewski, Arkadiusz 2022-07-15 17:31 ` Kubalewski, Arkadiusz 2022-08-02 14:02 ` Kubalewski, Arkadiusz 2022-08-02 14:02 ` Kubalewski, Arkadiusz 2022-08-02 15:52 ` Jakub Kicinski 2022-08-02 15:52 ` Jakub Kicinski 2022-08-03 0:05 ` Vadim Fedorenko 2022-08-03 0:05 ` Vadim Fedorenko 2022-08-03 15:21 ` Stephen Hemminger 2022-08-03 15:21 ` Stephen Hemminger 2022-09-29 12:13 ` Jiri Pirko 2022-09-29 12:13 ` Jiri Pirko 2022-09-30 0:48 ` Vadim Fedorenko 2022-09-30 0:48 ` Vadim Fedorenko 2022-06-26 19:24 ` [RFC PATCH v2 3/3] ptp_ocp: implement DPLL ops Vadim Fedorenko 2022-06-26 19:24 ` Vadim Fedorenko 2022-06-27 19:34 ` Jonathan Lemon 2022-06-27 19:34 ` Jonathan Lemon 2022-06-27 22:13 ` Vadim Fedorenko 2022-06-27 22:13 ` Vadim Fedorenko 2022-06-28 19:11 ` Jonathan Lemon 2022-06-28 19:11 ` Jonathan Lemon 2022-06-29 3:24 ` Jakub Kicinski 2022-06-29 3:24 ` Jakub Kicinski 2022-06-29 23:31 ` Vadim Fedorenko 2022-06-29 23:31 ` Vadim Fedorenko 2022-09-29 11:33 ` Jiri Pirko 2022-09-29 11:33 ` Jiri Pirko 2022-09-30 0:56 ` Vadim Fedorenko 2022-09-30 0:56 ` Vadim Fedorenko 2022-09-01 12:02 ` [RFC PATCH v2 0/3] Create common DPLL/clock configuration API Gal Pressman 2022-09-01 12:02 ` Gal Pressman 2022-09-29 11:40 ` Jiri Pirko 2022-09-29 11:40 ` Jiri Pirko 2022-09-30 0:44 ` Vadim Fedorenko 2022-09-30 0:44 ` Vadim Fedorenko 2022-09-30 8:33 ` Jiri Pirko 2022-09-30 8:33 ` Jiri Pirko 2022-09-30 14:33 ` Jakub Kicinski 2022-09-30 14:33 ` Jakub Kicinski 2022-10-01 5:47 ` Jiri Pirko 2022-10-01 5:47 ` Jiri Pirko 2022-10-01 14:18 ` Jakub Kicinski [this message] 2022-10-01 14:18 ` Jakub Kicinski 2022-10-02 14:35 ` Jiri Pirko 2022-10-02 14:35 ` Jiri Pirko 2022-10-03 14:28 ` Jakub Kicinski 2022-10-03 14:28 ` Jakub Kicinski 2022-10-03 17:20 ` Vadim Fedorenko 2022-10-03 17:20 ` Vadim Fedorenko 2022-10-04 6:33 ` Jiri Pirko 2022-10-04 6:33 ` Jiri Pirko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221001071827.202fe4c1@kernel.org \ --to=kuba@kernel.org \ --cc=arkadiusz.kubalewski@intel.com \ --cc=ayal@nvidia.com \ --cc=gal@nvidia.com \ --cc=jiri@resnulli.us \ --cc=jonathan.lemon@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=vadfed@fb.com \ --cc=vfedorenko@novek.ru \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.