All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Vadim Fedorenko <vfedorenko@novek.ru>,
	Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
	Jonathan Lemon <jonathan.lemon@gmail.com>,
	Vadim Fedorenko <vadfed@fb.com>, Aya Levin <ayal@nvidia.com>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-clk@vger.kernel.org
Subject: Re: [RFC PATCH v2 0/3] Create common DPLL/clock configuration API
Date: Sat, 1 Oct 2022 07:47:24 +0200	[thread overview]
Message-ID: <YzfUbKtWlxuq+FzI@nanopsycho> (raw)
In-Reply-To: <20220930073312.23685d5d@kernel.org>

Fri, Sep 30, 2022 at 04:33:12PM CEST, kuba@kernel.org wrote:
>On Fri, 30 Sep 2022 10:33:57 +0200 Jiri Pirko wrote:
>> >> Also, did you consider usage of sysfs? Why it isn't a better fit than
>> >> netlink?  
>> >
>> >We already have sysfs implemented in the ptp_ocp driver. But it looks like
>> >more hardware is going to be available soon with almost the same functions,
>> >so it would be great to have common protocol to configure such devices.  
>> 
>> Sure, but more hw does not mean you can't use sysfs. Take netdev as an
>> example. The sysfs exposed for it is implemented net/core/net-sysfs.c
>> and is exposed for all netdev instances, no matter what the
>> driver/hardware is.
>
>Wait, *you* are suggesting someone uses sysfs instead of netlink?
>
>Could you say more because I feel like that's kicking the absolute.

I don't understand why that would be a problem. What I'm trying to say
is, perhaps sysfs is a better API for this purpose. The API looks very
neat and there is no probabilito of huge grow. Also, with sysfs, you
don't need userspace app to do basic work with the api. In this case, I
don't see why the app is needed. These are 2 biggest arguments for sysfs
in this case as I see it.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Vadim Fedorenko <vfedorenko@novek.ru>,
	Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
	Jonathan Lemon <jonathan.lemon@gmail.com>,
	Vadim Fedorenko <vadfed@fb.com>, Aya Levin <ayal@nvidia.com>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-clk@vger.kernel.org
Subject: Re: [RFC PATCH v2 0/3] Create common DPLL/clock configuration API
Date: Sat, 1 Oct 2022 07:47:24 +0200	[thread overview]
Message-ID: <YzfUbKtWlxuq+FzI@nanopsycho> (raw)
In-Reply-To: <20220930073312.23685d5d@kernel.org>

Fri, Sep 30, 2022 at 04:33:12PM CEST, kuba@kernel.org wrote:
>On Fri, 30 Sep 2022 10:33:57 +0200 Jiri Pirko wrote:
>> >> Also, did you consider usage of sysfs? Why it isn't a better fit than
>> >> netlink?  
>> >
>> >We already have sysfs implemented in the ptp_ocp driver. But it looks like
>> >more hardware is going to be available soon with almost the same functions,
>> >so it would be great to have common protocol to configure such devices.  
>> 
>> Sure, but more hw does not mean you can't use sysfs. Take netdev as an
>> example. The sysfs exposed for it is implemented net/core/net-sysfs.c
>> and is exposed for all netdev instances, no matter what the
>> driver/hardware is.
>
>Wait, *you* are suggesting someone uses sysfs instead of netlink?
>
>Could you say more because I feel like that's kicking the absolute.

I don't understand why that would be a problem. What I'm trying to say
is, perhaps sysfs is a better API for this purpose. The API looks very
neat and there is no probabilito of huge grow. Also, with sysfs, you
don't need userspace app to do basic work with the api. In this case, I
don't see why the app is needed. These are 2 biggest arguments for sysfs
in this case as I see it.

  reply	other threads:[~2022-10-01  5:49 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-26 19:24 [RFC PATCH v2 0/3] Create common DPLL/clock configuration API Vadim Fedorenko
2022-06-26 19:24 ` Vadim Fedorenko
2022-06-26 19:24 ` [RFC PATCH v2 1/3] dpll: Add DPLL framework base functions Vadim Fedorenko
2022-06-26 19:24   ` Vadim Fedorenko
2022-06-29  8:34   ` Stephen Boyd
2022-06-29  8:34     ` Stephen Boyd
2022-06-29 23:37     ` Vadim Fedorenko
2022-06-29 23:37       ` Vadim Fedorenko
2022-07-11  9:01   ` Kubalewski, Arkadiusz
2022-07-11  9:01     ` Kubalewski, Arkadiusz
2022-07-14 23:23     ` Vadim Fedorenko
2022-07-14 23:23       ` Vadim Fedorenko
2022-07-15 17:31       ` Kubalewski, Arkadiusz
2022-07-15 17:31         ` Kubalewski, Arkadiusz
2022-06-26 19:24 ` [RFC PATCH v2 2/3] dpll: add netlink events Vadim Fedorenko
2022-06-26 19:24   ` Vadim Fedorenko
2022-07-11  9:02   ` Kubalewski, Arkadiusz
2022-07-11  9:02     ` Kubalewski, Arkadiusz
2022-07-14 23:29     ` Vadim Fedorenko
2022-07-14 23:29       ` Vadim Fedorenko
2022-07-15 17:31       ` Kubalewski, Arkadiusz
2022-07-15 17:31         ` Kubalewski, Arkadiusz
2022-08-02 14:02         ` Kubalewski, Arkadiusz
2022-08-02 14:02           ` Kubalewski, Arkadiusz
2022-08-02 15:52           ` Jakub Kicinski
2022-08-02 15:52             ` Jakub Kicinski
2022-08-03  0:05           ` Vadim Fedorenko
2022-08-03  0:05             ` Vadim Fedorenko
2022-08-03 15:21   ` Stephen Hemminger
2022-08-03 15:21     ` Stephen Hemminger
2022-09-29 12:13   ` Jiri Pirko
2022-09-29 12:13     ` Jiri Pirko
2022-09-30  0:48     ` Vadim Fedorenko
2022-09-30  0:48       ` Vadim Fedorenko
2022-06-26 19:24 ` [RFC PATCH v2 3/3] ptp_ocp: implement DPLL ops Vadim Fedorenko
2022-06-26 19:24   ` Vadim Fedorenko
2022-06-27 19:34   ` Jonathan Lemon
2022-06-27 19:34     ` Jonathan Lemon
2022-06-27 22:13     ` Vadim Fedorenko
2022-06-27 22:13       ` Vadim Fedorenko
2022-06-28 19:11       ` Jonathan Lemon
2022-06-28 19:11         ` Jonathan Lemon
2022-06-29  3:24         ` Jakub Kicinski
2022-06-29  3:24           ` Jakub Kicinski
2022-06-29 23:31           ` Vadim Fedorenko
2022-06-29 23:31             ` Vadim Fedorenko
2022-09-29 11:33   ` Jiri Pirko
2022-09-29 11:33     ` Jiri Pirko
2022-09-30  0:56     ` Vadim Fedorenko
2022-09-30  0:56       ` Vadim Fedorenko
2022-09-01 12:02 ` [RFC PATCH v2 0/3] Create common DPLL/clock configuration API Gal Pressman
2022-09-01 12:02   ` Gal Pressman
2022-09-29 11:40 ` Jiri Pirko
2022-09-29 11:40   ` Jiri Pirko
2022-09-30  0:44   ` Vadim Fedorenko
2022-09-30  0:44     ` Vadim Fedorenko
2022-09-30  8:33     ` Jiri Pirko
2022-09-30  8:33       ` Jiri Pirko
2022-09-30 14:33       ` Jakub Kicinski
2022-09-30 14:33         ` Jakub Kicinski
2022-10-01  5:47         ` Jiri Pirko [this message]
2022-10-01  5:47           ` Jiri Pirko
2022-10-01 14:18           ` Jakub Kicinski
2022-10-01 14:18             ` Jakub Kicinski
2022-10-02 14:35             ` Jiri Pirko
2022-10-02 14:35               ` Jiri Pirko
2022-10-03 14:28               ` Jakub Kicinski
2022-10-03 14:28                 ` Jakub Kicinski
2022-10-03 17:20                 ` Vadim Fedorenko
2022-10-03 17:20                   ` Vadim Fedorenko
2022-10-04  6:33                 ` Jiri Pirko
2022-10-04  6:33                   ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YzfUbKtWlxuq+FzI@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=arkadiusz.kubalewski@intel.com \
    --cc=ayal@nvidia.com \
    --cc=jonathan.lemon@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vadfed@fb.com \
    --cc=vfedorenko@novek.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.