All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH AUTOSEL 4.19 01/11] ARM: dts: imx7d-sdb: config the max pressure for tsc2046
@ 2022-10-11 14:53 ` Sasha Levin
  0 siblings, 0 replies; 29+ messages in thread
From: Sasha Levin @ 2022-10-11 14:53 UTC (permalink / raw)
  To: linux-kernel, stable
  Cc: Haibo Chen, Shawn Guo, Sasha Levin, robh+dt, devicetree,
	linux-arm-kernel

From: Haibo Chen <haibo.chen@nxp.com>

[ Upstream commit e7c4ebe2f9cd68588eb24ba4ed122e696e2d5272 ]

Use the general touchscreen method to config the max pressure for
touch tsc2046(data sheet suggest 8 bit pressure), otherwise, for
ABS_PRESSURE, when config the same max and min value, weston will
meet the following issue,

[17:19:39.183] event1  - ADS7846 Touchscreen: is tagged by udev as: Touchscreen
[17:19:39.183] event1  - ADS7846 Touchscreen: kernel bug: device has min == max on ABS_PRESSURE
[17:19:39.183] event1  - ADS7846 Touchscreen: was rejected
[17:19:39.183] event1  - not using input device '/dev/input/event1'

This will then cause the APP weston-touch-calibrator can't list touch devices.

root@imx6ul7d:~# weston-touch-calibrator
could not load cursor 'dnd-move'
could not load cursor 'dnd-copy'
could not load cursor 'dnd-none'
No devices listed.

And accroding to binding Doc, "ti,x-max", "ti,y-max", "ti,pressure-max"
belong to the deprecated properties, so remove them. Also for "ti,x-min",
"ti,y-min", "ti,x-plate-ohms", the value set in dts equal to the default
value in driver, so are redundant, also remove here.

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/arm/boot/dts/imx7d-sdb.dts | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
index 317f1bcc56e2..bd2c3c8f4ebb 100644
--- a/arch/arm/boot/dts/imx7d-sdb.dts
+++ b/arch/arm/boot/dts/imx7d-sdb.dts
@@ -163,12 +163,7 @@ tsc2046@0 {
 		interrupt-parent = <&gpio2>;
 		interrupts = <29 0>;
 		pendown-gpio = <&gpio2 29 GPIO_ACTIVE_HIGH>;
-		ti,x-min = /bits/ 16 <0>;
-		ti,x-max = /bits/ 16 <0>;
-		ti,y-min = /bits/ 16 <0>;
-		ti,y-max = /bits/ 16 <0>;
-		ti,pressure-max = /bits/ 16 <0>;
-		ti,x-plate-ohms = /bits/ 16 <400>;
+		touchscreen-max-pressure = <255>;
 		wakeup-source;
 	};
 };
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 29+ messages in thread

end of thread, other threads:[~2022-10-21  8:16 UTC | newest]

Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-11 14:53 [PATCH AUTOSEL 4.19 01/11] ARM: dts: imx7d-sdb: config the max pressure for tsc2046 Sasha Levin
2022-10-11 14:53 ` Sasha Levin
2022-10-11 14:53 ` [PATCH AUTOSEL 4.19 02/11] soc: mediatek: Let PMIC Wrapper and SCPSYS depend on OF Sasha Levin
2022-10-11 14:53   ` Sasha Levin
2022-10-11 14:53 ` [PATCH AUTOSEL 4.19 03/11] ARM: dts: imx6q: add missing properties for sram Sasha Levin
2022-10-11 14:53   ` Sasha Levin
2022-10-11 14:53 ` [PATCH AUTOSEL 4.19 04/11] ARM: dts: imx6dl: " Sasha Levin
2022-10-11 14:53   ` Sasha Levin
2022-10-11 14:53 ` [PATCH AUTOSEL 4.19 05/11] ARM: dts: imx6qp: " Sasha Levin
2022-10-11 14:53   ` Sasha Levin
2022-10-11 14:53 ` [PATCH AUTOSEL 4.19 06/11] ARM: dts: imx6sl: " Sasha Levin
2022-10-11 14:53   ` Sasha Levin
2022-10-11 14:53 ` [PATCH AUTOSEL 4.19 07/11] ARM: dts: imx6sll: " Sasha Levin
2022-10-11 14:53   ` Sasha Levin
2022-10-11 14:53 ` [PATCH AUTOSEL 4.19 08/11] ARM: dts: imx6sx: " Sasha Levin
2022-10-11 14:53   ` Sasha Levin
2022-10-11 14:53 ` [PATCH AUTOSEL 4.19 09/11] ARM: orion: fix include path Sasha Levin
2022-10-11 14:53   ` Sasha Levin
2022-10-11 14:53 ` [PATCH AUTOSEL 4.19 10/11] arm64: dts: uniphier: Add USB-device support for PXs3 reference board Sasha Levin
2022-10-11 14:53   ` Sasha Levin
2022-10-17 11:23   ` Pavel Machek
2022-10-17 11:23     ` Pavel Machek
2022-10-21  6:29     ` Arnd Bergmann
2022-10-21  6:29       ` Arnd Bergmann
2022-10-21  6:54       ` Greg KH
2022-10-21  6:54         ` Greg KH
2022-10-21  8:13         ` Kunihiko Hayashi
2022-10-21  8:13           ` Kunihiko Hayashi
2022-10-11 14:53 ` [PATCH AUTOSEL 4.19 11/11] selftests/cpu-hotplug: Use return instead of exit Sasha Levin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.