* [PATCH] arm64: dts: broadcom: bcmbca: bcm4908: drop invalid "nand" interrupt name
@ 2022-11-03 10:41 ` Rafał Miłecki
0 siblings, 0 replies; 6+ messages in thread
From: Rafał Miłecki @ 2022-11-03 10:41 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rob Herring, Krzysztof Kozlowski, William Zhang, Anand Gore,
Kursad Oney, devicetree, linux-arm-kernel,
bcm-kernel-feedback-list, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
String "nand" was never a valid interrupt name. It was never documented
and never used in Linux or U-Boot driver. This mistake was propagated
from the bcm63138.dtsi.
The whole "interrupt-names" property is optional and can be skipped.
Fixes: 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi
index dac9d3b4e91d..ba1d44e98c32 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi
@@ -532,7 +532,6 @@ nand-controller@1800 {
reg = <0x1800 0x600>, <0x2000 0x10>;
reg-names = "nand", "nand-int-base";
interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "nand";
status = "okay";
nandcs: nand@0 {
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: broadcom: bcmbca: bcm4908: drop invalid "nand" interrupt name
@ 2022-11-03 10:41 ` Rafał Miłecki
0 siblings, 0 replies; 6+ messages in thread
From: Rafał Miłecki @ 2022-11-03 10:41 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rob Herring, Krzysztof Kozlowski, William Zhang, Anand Gore,
Kursad Oney, devicetree, linux-arm-kernel,
bcm-kernel-feedback-list, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
String "nand" was never a valid interrupt name. It was never documented
and never used in Linux or U-Boot driver. This mistake was propagated
from the bcm63138.dtsi.
The whole "interrupt-names" property is optional and can be skipped.
Fixes: 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi
index dac9d3b4e91d..ba1d44e98c32 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi
@@ -532,7 +532,6 @@ nand-controller@1800 {
reg = <0x1800 0x600>, <0x2000 0x10>;
reg-names = "nand", "nand-int-base";
interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "nand";
status = "okay";
nandcs: nand@0 {
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: broadcom: bcmbca: bcm4908: drop invalid "nand" interrupt name
2022-11-03 10:41 ` Rafał Miłecki
@ 2022-11-09 18:37 ` Florian Fainelli
-1 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2022-11-09 18:37 UTC (permalink / raw)
To: Rafał Miłecki, Florian Fainelli
Cc: Rob Herring, Krzysztof Kozlowski, William Zhang, Anand Gore,
Kursad Oney, devicetree, linux-arm-kernel,
bcm-kernel-feedback-list, Rafał Miłecki
On 11/3/22 03:41, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> String "nand" was never a valid interrupt name. It was never documented
> and never used in Linux or U-Boot driver. This mistake was propagated
> from the bcm63138.dtsi.
>
> The whole "interrupt-names" property is optional and can be skipped.
>
> Fixes: 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Do you still want me to apply this patch, or are we happy with renaming
that interrupt to "nand_ctlrdy" instead?
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: broadcom: bcmbca: bcm4908: drop invalid "nand" interrupt name
@ 2022-11-09 18:37 ` Florian Fainelli
0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2022-11-09 18:37 UTC (permalink / raw)
To: Rafał Miłecki, Florian Fainelli
Cc: Rob Herring, Krzysztof Kozlowski, William Zhang, Anand Gore,
Kursad Oney, devicetree, linux-arm-kernel,
bcm-kernel-feedback-list, Rafał Miłecki
On 11/3/22 03:41, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> String "nand" was never a valid interrupt name. It was never documented
> and never used in Linux or U-Boot driver. This mistake was propagated
> from the bcm63138.dtsi.
>
> The whole "interrupt-names" property is optional and can be skipped.
>
> Fixes: 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Do you still want me to apply this patch, or are we happy with renaming
that interrupt to "nand_ctlrdy" instead?
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: broadcom: bcmbca: bcm4908: drop invalid "nand" interrupt name
2022-11-09 18:37 ` Florian Fainelli
@ 2022-11-09 20:11 ` Rafał Miłecki
-1 siblings, 0 replies; 6+ messages in thread
From: Rafał Miłecki @ 2022-11-09 20:11 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rob Herring, Krzysztof Kozlowski, William Zhang, Anand Gore,
Kursad Oney, devicetree, linux-arm-kernel,
bcm-kernel-feedback-list, Rafał Miłecki
On 9.11.2022 19:37, Florian Fainelli wrote:
> On 11/3/22 03:41, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> String "nand" was never a valid interrupt name. It was never documented
>> and never used in Linux or U-Boot driver. This mistake was propagated
>> from the bcm63138.dtsi.
>>
>> The whole "interrupt-names" property is optional and can be skipped.
>>
>> Fixes: 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files")
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>
> Do you still want me to apply this patch, or are we happy with renaming that interrupt to "nand_ctlrdy" instead?
I don't have any real preference.
Since we already have this patch, we may just apply it. If you think
having "interrupt-names" with just "nand_ctlrdy" is cleaner, I can send
V2.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: broadcom: bcmbca: bcm4908: drop invalid "nand" interrupt name
@ 2022-11-09 20:11 ` Rafał Miłecki
0 siblings, 0 replies; 6+ messages in thread
From: Rafał Miłecki @ 2022-11-09 20:11 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rob Herring, Krzysztof Kozlowski, William Zhang, Anand Gore,
Kursad Oney, devicetree, linux-arm-kernel,
bcm-kernel-feedback-list, Rafał Miłecki
On 9.11.2022 19:37, Florian Fainelli wrote:
> On 11/3/22 03:41, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> String "nand" was never a valid interrupt name. It was never documented
>> and never used in Linux or U-Boot driver. This mistake was propagated
>> from the bcm63138.dtsi.
>>
>> The whole "interrupt-names" property is optional and can be skipped.
>>
>> Fixes: 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files")
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>
> Do you still want me to apply this patch, or are we happy with renaming that interrupt to "nand_ctlrdy" instead?
I don't have any real preference.
Since we already have this patch, we may just apply it. If you think
having "interrupt-names" with just "nand_ctlrdy" is cleaner, I can send
V2.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-09 20:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-03 10:41 [PATCH] arm64: dts: broadcom: bcmbca: bcm4908: drop invalid "nand" interrupt name Rafał Miłecki
2022-11-03 10:41 ` Rafał Miłecki
2022-11-09 18:37 ` Florian Fainelli
2022-11-09 18:37 ` Florian Fainelli
2022-11-09 20:11 ` Rafał Miłecki
2022-11-09 20:11 ` Rafał Miłecki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.