* [Intel-gfx] [PULL] gvt-next
@ 2022-11-11 8:59 Zhenyu Wang
2022-11-15 15:36 ` Rodrigo Vivi
0 siblings, 1 reply; 49+ messages in thread
From: Zhenyu Wang @ 2022-11-11 8:59 UTC (permalink / raw)
To: Tvrtko Ursulin, Joonas Lahtinen, Vivi, Rodrigo, Jani Nikula
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan
[-- Attachment #1: Type: text/plain, Size: 2368 bytes --]
Hi,
Here's current accumulated changes in gvt-next. Sorry that I delayed
to refresh them on time for upstream...It contains mostly kernel doc,
typo fixes and small code cleanups, as details below.
btw, one gvt change for next https://patchwork.freedesktop.org/patch/511118/
is still pending, I need a backmerge from linus tree e.g with recent vfio/mdev
consolidate change with gvt and Jason's fix for destroy device, to apply Zhi's
change cleanly. Pls help on that.
Thanks!
---
The following changes since commit a6ebd538364b1e9e6048faaafbc0188172ed50c3:
drm/i915/sdvo: Fix debug print (2022-10-28 14:46:21 +0300)
are available in the Git repository at:
https://github.com/intel/gvt-linux.git tags/gvt-next-2022-11-11
for you to fetch changes up to 50468ca2e2e1ce882f060a8c263f678affe112db:
drm/i915/gvt: Remove the unused function get_pt_type() (2022-11-08 15:34:06 +0800)
----------------------------------------------------------------
gvt-next-2022-11-11
- kernel doc fixes
- remove vgpu->released sanity check
- small clean up
----------------------------------------------------------------
Colin Ian King (1):
drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"
Jiapeng Chong (4):
drm/i915/gvt: Fix kernel-doc
drm/i915/gvt: Fix kernel-doc
drm/i915/gvt: Fix kernel-doc
drm/i915/gvt: Remove the unused function get_pt_type()
Julia Lawall (1):
drm/i915/gvt: fix typo in comment
Mauro Carvalho Chehab (1):
drm/i915: gvt: fix kernel-doc trivial warnings
Paulo Miguel Almeida (1):
i915/gvt: remove hardcoded value on crc32_start calculation
Zhi Wang (1):
drm/i915/gvt: remove the vgpu->released and its sanity check
wangjianli (1):
drm/i915: fix repeated words in comments
drivers/gpu/drm/i915/gvt/aperture_gm.c | 4 ++--
drivers/gpu/drm/i915/gvt/cfg_space.c | 2 +-
drivers/gpu/drm/i915/gvt/dmabuf.h | 2 +-
drivers/gpu/drm/i915/gvt/firmware.c | 2 +-
drivers/gpu/drm/i915/gvt/gtt.c | 9 ++-------
drivers/gpu/drm/i915/gvt/gvt.h | 2 --
drivers/gpu/drm/i915/gvt/handlers.c | 4 ++--
drivers/gpu/drm/i915/gvt/kvmgt.c | 4 ----
drivers/gpu/drm/i915/gvt/mmio_context.c | 2 +-
drivers/gpu/drm/i915/gvt/page_track.c | 2 +-
drivers/gpu/drm/i915/gvt/vgpu.c | 6 +++---
11 files changed, 14 insertions(+), 25 deletions(-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2022-11-11 8:59 [Intel-gfx] [PULL] gvt-next Zhenyu Wang
@ 2022-11-15 15:36 ` Rodrigo Vivi
2022-11-17 3:02 ` Zhenyu Wang
0 siblings, 1 reply; 49+ messages in thread
From: Rodrigo Vivi @ 2022-11-15 15:36 UTC (permalink / raw)
To: Zhenyu Wang; +Cc: Jani Nikula, intel-gfx, Lv, Zhiyuan, intel-gvt-dev
On Fri, Nov 11, 2022 at 04:59:03PM +0800, Zhenyu Wang wrote:
> Hi,
>
> Here's current accumulated changes in gvt-next. Sorry that I delayed
> to refresh them on time for upstream...It contains mostly kernel doc,
> typo fixes and small code cleanups, as details below.
>
> btw, one gvt change for next https://patchwork.freedesktop.org/patch/511118/
> is still pending, I need a backmerge from linus tree e.g with recent vfio/mdev
> consolidate change with gvt and Jason's fix for destroy device, to apply Zhi's
> change cleanly. Pls help on that.
>
> Thanks!
> ---
> The following changes since commit a6ebd538364b1e9e6048faaafbc0188172ed50c3:
>
> drm/i915/sdvo: Fix debug print (2022-10-28 14:46:21 +0300)
>
> are available in the Git repository at:
>
> https://github.com/intel/gvt-linux.git tags/gvt-next-2022-11-11
>
> for you to fetch changes up to 50468ca2e2e1ce882f060a8c263f678affe112db:
>
> drm/i915/gvt: Remove the unused function get_pt_type() (2022-11-08 15:34:06 +0800)
>
> ----------------------------------------------------------------
> gvt-next-2022-11-11
>
> - kernel doc fixes
> - remove vgpu->released sanity check
> - small clean up
>
> ----------------------------------------------------------------
> Colin Ian King (1):
> drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"
dim: d7e4e9579f01 ("drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported""): committer Signed-off-by missing.
could you please fix this before we can merge this pr?
>
> Jiapeng Chong (4):
> drm/i915/gvt: Fix kernel-doc
> drm/i915/gvt: Fix kernel-doc
> drm/i915/gvt: Fix kernel-doc
> drm/i915/gvt: Remove the unused function get_pt_type()
>
> Julia Lawall (1):
> drm/i915/gvt: fix typo in comment
>
> Mauro Carvalho Chehab (1):
> drm/i915: gvt: fix kernel-doc trivial warnings
>
> Paulo Miguel Almeida (1):
> i915/gvt: remove hardcoded value on crc32_start calculation
>
> Zhi Wang (1):
> drm/i915/gvt: remove the vgpu->released and its sanity check
>
> wangjianli (1):
> drm/i915: fix repeated words in comments
>
> drivers/gpu/drm/i915/gvt/aperture_gm.c | 4 ++--
> drivers/gpu/drm/i915/gvt/cfg_space.c | 2 +-
> drivers/gpu/drm/i915/gvt/dmabuf.h | 2 +-
> drivers/gpu/drm/i915/gvt/firmware.c | 2 +-
> drivers/gpu/drm/i915/gvt/gtt.c | 9 ++-------
> drivers/gpu/drm/i915/gvt/gvt.h | 2 --
> drivers/gpu/drm/i915/gvt/handlers.c | 4 ++--
> drivers/gpu/drm/i915/gvt/kvmgt.c | 4 ----
> drivers/gpu/drm/i915/gvt/mmio_context.c | 2 +-
> drivers/gpu/drm/i915/gvt/page_track.c | 2 +-
> drivers/gpu/drm/i915/gvt/vgpu.c | 6 +++---
> 11 files changed, 14 insertions(+), 25 deletions(-)
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2022-11-15 15:36 ` Rodrigo Vivi
@ 2022-11-17 3:02 ` Zhenyu Wang
2022-11-17 3:37 ` Vivi, Rodrigo
0 siblings, 1 reply; 49+ messages in thread
From: Zhenyu Wang @ 2022-11-17 3:02 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: Jani Nikula, intel-gfx, Lv, Zhiyuan, intel-gvt-dev
[-- Attachment #1: Type: text/plain, Size: 3229 bytes --]
On 2022.11.15 10:36:59 -0500, Rodrigo Vivi wrote:
> On Fri, Nov 11, 2022 at 04:59:03PM +0800, Zhenyu Wang wrote:
> > Hi,
> >
> > Here's current accumulated changes in gvt-next. Sorry that I delayed
> > to refresh them on time for upstream...It contains mostly kernel doc,
> > typo fixes and small code cleanups, as details below.
> >
> > btw, one gvt change for next https://patchwork.freedesktop.org/patch/511118/
> > is still pending, I need a backmerge from linus tree e.g with recent vfio/mdev
> > consolidate change with gvt and Jason's fix for destroy device, to apply Zhi's
> > change cleanly. Pls help on that.
> >
> > Thanks!
> > ---
> > The following changes since commit a6ebd538364b1e9e6048faaafbc0188172ed50c3:
> >
> > drm/i915/sdvo: Fix debug print (2022-10-28 14:46:21 +0300)
> >
> > are available in the Git repository at:
> >
> > https://github.com/intel/gvt-linux.git tags/gvt-next-2022-11-11
> >
> > for you to fetch changes up to 50468ca2e2e1ce882f060a8c263f678affe112db:
> >
> > drm/i915/gvt: Remove the unused function get_pt_type() (2022-11-08 15:34:06 +0800)
> >
> > ----------------------------------------------------------------
> > gvt-next-2022-11-11
> >
> > - kernel doc fixes
> > - remove vgpu->released sanity check
> > - small clean up
> >
> > ----------------------------------------------------------------
> > Colin Ian King (1):
> > drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"
>
> dim: d7e4e9579f01 ("drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported""): committer Signed-off-by missing.
>
> could you please fix this before we can merge this pr?
>
That should still be .mailmap issue for Colin's email...
But could we improve our dim script to grep mailmap in that case? So if s-o-b mail is valid
in mailmap, we should still allow it, right?
> >
> > Jiapeng Chong (4):
> > drm/i915/gvt: Fix kernel-doc
> > drm/i915/gvt: Fix kernel-doc
> > drm/i915/gvt: Fix kernel-doc
> > drm/i915/gvt: Remove the unused function get_pt_type()
> >
> > Julia Lawall (1):
> > drm/i915/gvt: fix typo in comment
> >
> > Mauro Carvalho Chehab (1):
> > drm/i915: gvt: fix kernel-doc trivial warnings
> >
> > Paulo Miguel Almeida (1):
> > i915/gvt: remove hardcoded value on crc32_start calculation
> >
> > Zhi Wang (1):
> > drm/i915/gvt: remove the vgpu->released and its sanity check
> >
> > wangjianli (1):
> > drm/i915: fix repeated words in comments
> >
> > drivers/gpu/drm/i915/gvt/aperture_gm.c | 4 ++--
> > drivers/gpu/drm/i915/gvt/cfg_space.c | 2 +-
> > drivers/gpu/drm/i915/gvt/dmabuf.h | 2 +-
> > drivers/gpu/drm/i915/gvt/firmware.c | 2 +-
> > drivers/gpu/drm/i915/gvt/gtt.c | 9 ++-------
> > drivers/gpu/drm/i915/gvt/gvt.h | 2 --
> > drivers/gpu/drm/i915/gvt/handlers.c | 4 ++--
> > drivers/gpu/drm/i915/gvt/kvmgt.c | 4 ----
> > drivers/gpu/drm/i915/gvt/mmio_context.c | 2 +-
> > drivers/gpu/drm/i915/gvt/page_track.c | 2 +-
> > drivers/gpu/drm/i915/gvt/vgpu.c | 6 +++---
> > 11 files changed, 14 insertions(+), 25 deletions(-)
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2022-11-17 3:02 ` Zhenyu Wang
@ 2022-11-17 3:37 ` Vivi, Rodrigo
2022-11-17 5:28 ` Zhenyu Wang
2022-11-17 6:41 ` Zhenyu Wang
0 siblings, 2 replies; 49+ messages in thread
From: Vivi, Rodrigo @ 2022-11-17 3:37 UTC (permalink / raw)
To: zhenyuw; +Cc: Nikula, Jani, intel-gfx, Lv, Zhiyuan, intel-gvt-dev
On Thu, 2022-11-17 at 11:02 +0800, Zhenyu Wang wrote:
> On 2022.11.15 10:36:59 -0500, Rodrigo Vivi wrote:
> > On Fri, Nov 11, 2022 at 04:59:03PM +0800, Zhenyu Wang wrote:
> > > Hi,
> > >
> > > Here's current accumulated changes in gvt-next. Sorry that I
> > > delayed
> > > to refresh them on time for upstream...It contains mostly kernel
> > > doc,
> > > typo fixes and small code cleanups, as details below.
> > >
> > > btw, one gvt change for next
> > > https://patchwork.freedesktop.org/patch/511118/
> > > is still pending, I need a backmerge from linus tree e.g with
> > > recent vfio/mdev
> > > consolidate change with gvt and Jason's fix for destroy device,
> > > to apply Zhi's
> > > change cleanly. Pls help on that.
> > >
> > > Thanks!
> > > ---
> > > The following changes since commit
> > > a6ebd538364b1e9e6048faaafbc0188172ed50c3:
> > >
> > > drm/i915/sdvo: Fix debug print (2022-10-28 14:46:21 +0300)
> > >
> > > are available in the Git repository at:
> > >
> > > https://github.com/intel/gvt-linux.git tags/gvt-next-2022-11-11
> > >
> > > for you to fetch changes up to
> > > 50468ca2e2e1ce882f060a8c263f678affe112db:
> > >
> > > drm/i915/gvt: Remove the unused function get_pt_type() (2022-
> > > 11-08 15:34:06 +0800)
> > >
> > > ----------------------------------------------------------------
> > > gvt-next-2022-11-11
> > >
> > > - kernel doc fixes
> > > - remove vgpu->released sanity check
> > > - small clean up
> > >
> > > ----------------------------------------------------------------
> > > Colin Ian King (1):
> > > drm/i915/reg: Fix spelling mistake "Unsupport" ->
> > > "Unsupported"
> >
> > dim: d7e4e9579f01 ("drm/i915/reg: Fix spelling mistake "Unsupport"
> > -> "Unsupported""): committer Signed-off-by missing.
> >
> > could you please fix this before we can merge this pr?
> >
>
> That should still be .mailmap issue for Colin's email...
> But could we improve our dim script to grep mailmap in that case? So
> if s-o-b mail is valid
> in mailmap, we should still allow it, right?
Based on what I could verify the commiter signature is really not
there. It looks like you later forced a rebase and while
rebasing you forgot to re-sign everything.
We need to fix this in your tree to avoid propagating that to other
trees later:
From tig view:
Commit: Zhenyu Wang <zhenyuw@linux.intel.com>
CommitDate: Tue Nov 8 15:04:53 2022 +0800
drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"
There is a spelling mistake in a gvt_vgpu_err error message. Fix
it.
Fixes: 695fbc08d80f ("drm/i915/gvt: replace the gvt_err with
gvt_vgpu_err")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
Link:
http://patchwork.freedesktop.org/patch/msgid/20220315202449.2952845-1-colin.i.king@gmail.com
Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>
no signature from you.
>
> > >
> > > Jiapeng Chong (4):
> > > drm/i915/gvt: Fix kernel-doc
> > > drm/i915/gvt: Fix kernel-doc
> > > drm/i915/gvt: Fix kernel-doc
> > > drm/i915/gvt: Remove the unused function get_pt_type()
> > >
> > > Julia Lawall (1):
> > > drm/i915/gvt: fix typo in comment
> > >
> > > Mauro Carvalho Chehab (1):
> > > drm/i915: gvt: fix kernel-doc trivial warnings
> > >
> > > Paulo Miguel Almeida (1):
> > > i915/gvt: remove hardcoded value on crc32_start calculation
> > >
> > > Zhi Wang (1):
> > > drm/i915/gvt: remove the vgpu->released and its sanity
> > > check
> > >
> > > wangjianli (1):
> > > drm/i915: fix repeated words in comments
> > >
> > > drivers/gpu/drm/i915/gvt/aperture_gm.c | 4 ++--
> > > drivers/gpu/drm/i915/gvt/cfg_space.c | 2 +-
> > > drivers/gpu/drm/i915/gvt/dmabuf.h | 2 +-
> > > drivers/gpu/drm/i915/gvt/firmware.c | 2 +-
> > > drivers/gpu/drm/i915/gvt/gtt.c | 9 ++-------
> > > drivers/gpu/drm/i915/gvt/gvt.h | 2 --
> > > drivers/gpu/drm/i915/gvt/handlers.c | 4 ++--
> > > drivers/gpu/drm/i915/gvt/kvmgt.c | 4 ----
> > > drivers/gpu/drm/i915/gvt/mmio_context.c | 2 +-
> > > drivers/gpu/drm/i915/gvt/page_track.c | 2 +-
> > > drivers/gpu/drm/i915/gvt/vgpu.c | 6 +++---
> > > 11 files changed, 14 insertions(+), 25 deletions(-)
> >
> >
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2022-11-17 3:37 ` Vivi, Rodrigo
@ 2022-11-17 5:28 ` Zhenyu Wang
2022-11-17 6:41 ` Zhenyu Wang
1 sibling, 0 replies; 49+ messages in thread
From: Zhenyu Wang @ 2022-11-17 5:28 UTC (permalink / raw)
To: Vivi, Rodrigo; +Cc: Nikula, Jani, intel-gfx, Lv, Zhiyuan, intel-gvt-dev
[-- Attachment #1: Type: text/plain, Size: 4888 bytes --]
On 2022.11.17 03:37:17 +0000, Vivi, Rodrigo wrote:
> On Thu, 2022-11-17 at 11:02 +0800, Zhenyu Wang wrote:
> > On 2022.11.15 10:36:59 -0500, Rodrigo Vivi wrote:
> > > On Fri, Nov 11, 2022 at 04:59:03PM +0800, Zhenyu Wang wrote:
> > > > Hi,
> > > >
> > > > Here's current accumulated changes in gvt-next. Sorry that I
> > > > delayed
> > > > to refresh them on time for upstream...It contains mostly kernel
> > > > doc,
> > > > typo fixes and small code cleanups, as details below.
> > > >
> > > > btw, one gvt change for next
> > > > https://patchwork.freedesktop.org/patch/511118/
> > > > is still pending, I need a backmerge from linus tree e.g with
> > > > recent vfio/mdev
> > > > consolidate change with gvt and Jason's fix for destroy device,
> > > > to apply Zhi's
> > > > change cleanly. Pls help on that.
> > > >
> > > > Thanks!
> > > > ---
> > > > The following changes since commit
> > > > a6ebd538364b1e9e6048faaafbc0188172ed50c3:
> > > >
> > > > ?? drm/i915/sdvo: Fix debug print (2022-10-28 14:46:21 +0300)
> > > >
> > > > are available in the Git repository at:
> > > >
> > > > ?? https://github.com/intel/gvt-linux.git??tags/gvt-next-2022-11-11
> > > >
> > > > for you to fetch changes up to
> > > > 50468ca2e2e1ce882f060a8c263f678affe112db:
> > > >
> > > > ?? drm/i915/gvt: Remove the unused function get_pt_type() (2022-
> > > > 11-08 15:34:06 +0800)
> > > >
> > > > ----------------------------------------------------------------
> > > > gvt-next-2022-11-11
> > > >
> > > > - kernel doc fixes
> > > > - remove vgpu->released sanity check
> > > > - small clean up
> > > >
> > > > ----------------------------------------------------------------
> > > > Colin Ian King (1):
> > > > ?????????? drm/i915/reg: Fix spelling mistake "Unsupport" ->
> > > > "Unsupported"
> > >
> > > dim: d7e4e9579f01 ("drm/i915/reg: Fix spelling mistake "Unsupport"
> > > -> "Unsupported""): committer Signed-off-by missing.
> > >
> > > could you please fix this before we can merge this pr?
> > >
> >
> > That should still be .mailmap issue for Colin's email...
> > But could we improve our dim script to grep mailmap in that case? So
> > if s-o-b mail is valid
> > in mailmap, we should still allow it, right?
>
> Based on what I could verify the commiter signature is really not
> there. It looks like you later forced a rebase and while
> rebasing you forgot to re-sign everything.
>
Oops! Sorry for that. I'll redo this.
> We need to fix this in your tree to avoid propagating that to other
> trees later:
>
> From tig view:
> Commit: Zhenyu Wang <zhenyuw@linux.intel.com>
> CommitDate: Tue Nov 8 15:04:53 2022 +0800
>
> drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"
>
> There is a spelling mistake in a gvt_vgpu_err error message. Fix
> it.
>
> Fixes: 695fbc08d80f ("drm/i915/gvt: replace the gvt_err with
> gvt_vgpu_err")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
> Link:
> http://patchwork.freedesktop.org/patch/msgid/20220315202449.2952845-1-colin.i.king@gmail.com
> Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>
>
> no signature from you.
>
> >
> > > >
> > > > Jiapeng Chong (4):
> > > > ?????????? drm/i915/gvt: Fix kernel-doc
> > > > ?????????? drm/i915/gvt: Fix kernel-doc
> > > > ?????????? drm/i915/gvt: Fix kernel-doc
> > > > ?????????? drm/i915/gvt: Remove the unused function get_pt_type()
> > > >
> > > > Julia Lawall (1):
> > > > ?????????? drm/i915/gvt: fix typo in comment
> > > >
> > > > Mauro Carvalho Chehab (1):
> > > > ?????????? drm/i915: gvt: fix kernel-doc trivial warnings
> > > >
> > > > Paulo Miguel Almeida (1):
> > > > ?????????? i915/gvt: remove hardcoded value on crc32_start calculation
> > > >
> > > > Zhi Wang (1):
> > > > ?????????? drm/i915/gvt: remove the vgpu->released and its sanity
> > > > check
> > > >
> > > > wangjianli (1):
> > > > ?????????? drm/i915: fix repeated words in comments
> > > >
> > > > ??drivers/gpu/drm/i915/gvt/aperture_gm.c?? | 4 ++--
> > > > ??drivers/gpu/drm/i915/gvt/cfg_space.c?????? | 2 +-
> > > > ??drivers/gpu/drm/i915/gvt/dmabuf.h???????????? | 2 +-
> > > > ??drivers/gpu/drm/i915/gvt/firmware.c???????? | 2 +-
> > > > ??drivers/gpu/drm/i915/gvt/gtt.c?????????????????? | 9 ++-------
> > > > ??drivers/gpu/drm/i915/gvt/gvt.h?????????????????? | 2 --
> > > > ??drivers/gpu/drm/i915/gvt/handlers.c???????? | 4 ++--
> > > > ??drivers/gpu/drm/i915/gvt/kvmgt.c?????????????? | 4 ----
> > > > ??drivers/gpu/drm/i915/gvt/mmio_context.c | 2 +-
> > > > ??drivers/gpu/drm/i915/gvt/page_track.c???? | 2 +-
> > > > ??drivers/gpu/drm/i915/gvt/vgpu.c???????????????? | 6 +++---
> > > > ??11 files changed, 14 insertions(+), 25 deletions(-)
> > >
> > >
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2022-11-17 3:37 ` Vivi, Rodrigo
2022-11-17 5:28 ` Zhenyu Wang
@ 2022-11-17 6:41 ` Zhenyu Wang
2022-11-17 13:49 ` Rodrigo Vivi
1 sibling, 1 reply; 49+ messages in thread
From: Zhenyu Wang @ 2022-11-17 6:41 UTC (permalink / raw)
To: Vivi, Rodrigo; +Cc: Nikula, Jani, intel-gfx, Lv, Zhiyuan, intel-gvt-dev
[-- Attachment #1: Type: text/plain, Size: 3018 bytes --]
On 2022.11.17 03:37:17 +0000, Vivi, Rodrigo wrote:
> On Thu, 2022-11-17 at 11:02 +0800, Zhenyu Wang wrote:
> > On 2022.11.15 10:36:59 -0500, Rodrigo Vivi wrote:
> > > On Fri, Nov 11, 2022 at 04:59:03PM +0800, Zhenyu Wang wrote:
> > > > Hi,
> > > >
> > > > Here's current accumulated changes in gvt-next. Sorry that I
> > > > delayed
> > > > to refresh them on time for upstream...It contains mostly kernel
> > > > doc,
> > > > typo fixes and small code cleanups, as details below.
> > > >
> > > > btw, one gvt change for next
> > > > https://patchwork.freedesktop.org/patch/511118/
> > > > is still pending, I need a backmerge from linus tree e.g with
> > > > recent vfio/mdev
> > > > consolidate change with gvt and Jason's fix for destroy device,
> > > > to apply Zhi's
> > > > change cleanly. Pls help on that.
> > > >
>
> Based on what I could verify the commiter signature is really not
> there. It looks like you later forced a rebase and while
> rebasing you forgot to re-sign everything.
>
Hi, pls re-pull this one.
thanks!
---
The following changes since commit a6ebd538364b1e9e6048faaafbc0188172ed50c3:
drm/i915/sdvo: Fix debug print (2022-10-28 14:46:21 +0300)
are available in the Git repository at:
https://github.com/intel/gvt-linux.git tags/gvt-next-2022-11-17
for you to fetch changes up to 04ec334e1a0381c3305da4d277cef9250769ca43:
drm/i915/gvt: Remove the unused function get_pt_type() (2022-11-17 14:07:09 +0800)
----------------------------------------------------------------
gvt-next-2022-11-17
- kernel doc fixes
- remove vgpu->released sanity check
- small clean up
----------------------------------------------------------------
Colin Ian King (1):
drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"
Jiapeng Chong (4):
drm/i915/gvt: Fix kernel-doc
drm/i915/gvt: Fix kernel-doc
drm/i915/gvt: Fix kernel-doc
drm/i915/gvt: Remove the unused function get_pt_type()
Julia Lawall (1):
drm/i915/gvt: fix typo in comment
Mauro Carvalho Chehab (1):
drm/i915: gvt: fix kernel-doc trivial warnings
Paulo Miguel Almeida (1):
i915/gvt: remove hardcoded value on crc32_start calculation
Zhi Wang (1):
drm/i915/gvt: remove the vgpu->released and its sanity check
wangjianli (1):
drm/i915: fix repeated words in comments
drivers/gpu/drm/i915/gvt/aperture_gm.c | 4 ++--
drivers/gpu/drm/i915/gvt/cfg_space.c | 2 +-
drivers/gpu/drm/i915/gvt/dmabuf.h | 2 +-
drivers/gpu/drm/i915/gvt/firmware.c | 2 +-
drivers/gpu/drm/i915/gvt/gtt.c | 9 ++-------
drivers/gpu/drm/i915/gvt/gvt.h | 2 --
drivers/gpu/drm/i915/gvt/handlers.c | 4 ++--
drivers/gpu/drm/i915/gvt/kvmgt.c | 4 ----
drivers/gpu/drm/i915/gvt/mmio_context.c | 2 +-
drivers/gpu/drm/i915/gvt/page_track.c | 2 +-
drivers/gpu/drm/i915/gvt/vgpu.c | 6 +++---
11 files changed, 14 insertions(+), 25 deletions(-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2022-11-17 6:41 ` Zhenyu Wang
@ 2022-11-17 13:49 ` Rodrigo Vivi
0 siblings, 0 replies; 49+ messages in thread
From: Rodrigo Vivi @ 2022-11-17 13:49 UTC (permalink / raw)
To: Zhenyu Wang; +Cc: Nikula, Jani, intel-gfx, Lv, Zhiyuan, intel-gvt-dev
On Thu, Nov 17, 2022 at 02:41:06PM +0800, Zhenyu Wang wrote:
> On 2022.11.17 03:37:17 +0000, Vivi, Rodrigo wrote:
> > On Thu, 2022-11-17 at 11:02 +0800, Zhenyu Wang wrote:
> > > On 2022.11.15 10:36:59 -0500, Rodrigo Vivi wrote:
> > > > On Fri, Nov 11, 2022 at 04:59:03PM +0800, Zhenyu Wang wrote:
> > > > > Hi,
> > > > >
> > > > > Here's current accumulated changes in gvt-next. Sorry that I
> > > > > delayed
> > > > > to refresh them on time for upstream...It contains mostly kernel
> > > > > doc,
> > > > > typo fixes and small code cleanups, as details below.
> > > > >
> > > > > btw, one gvt change for next
> > > > > https://patchwork.freedesktop.org/patch/511118/
> > > > > is still pending, I need a backmerge from linus tree e.g with
> > > > > recent vfio/mdev
> > > > > consolidate change with gvt and Jason's fix for destroy device,
> > > > > to apply Zhi's
> > > > > change cleanly. Pls help on that.
> > > > >
>
> >
> > Based on what I could verify the commiter signature is really not
> > there. It looks like you later forced a rebase and while
> > rebasing you forgot to re-sign everything.
> >
>
> Hi, pls re-pull this one.
This one worked out. Pulled, thanks!
>
> thanks!
> ---
> The following changes since commit a6ebd538364b1e9e6048faaafbc0188172ed50c3:
>
> drm/i915/sdvo: Fix debug print (2022-10-28 14:46:21 +0300)
>
> are available in the Git repository at:
>
> https://github.com/intel/gvt-linux.git tags/gvt-next-2022-11-17
>
> for you to fetch changes up to 04ec334e1a0381c3305da4d277cef9250769ca43:
>
> drm/i915/gvt: Remove the unused function get_pt_type() (2022-11-17 14:07:09 +0800)
>
> ----------------------------------------------------------------
> gvt-next-2022-11-17
>
> - kernel doc fixes
> - remove vgpu->released sanity check
> - small clean up
>
> ----------------------------------------------------------------
> Colin Ian King (1):
> drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"
>
> Jiapeng Chong (4):
> drm/i915/gvt: Fix kernel-doc
> drm/i915/gvt: Fix kernel-doc
> drm/i915/gvt: Fix kernel-doc
> drm/i915/gvt: Remove the unused function get_pt_type()
>
> Julia Lawall (1):
> drm/i915/gvt: fix typo in comment
>
> Mauro Carvalho Chehab (1):
> drm/i915: gvt: fix kernel-doc trivial warnings
>
> Paulo Miguel Almeida (1):
> i915/gvt: remove hardcoded value on crc32_start calculation
>
> Zhi Wang (1):
> drm/i915/gvt: remove the vgpu->released and its sanity check
>
> wangjianli (1):
> drm/i915: fix repeated words in comments
>
> drivers/gpu/drm/i915/gvt/aperture_gm.c | 4 ++--
> drivers/gpu/drm/i915/gvt/cfg_space.c | 2 +-
> drivers/gpu/drm/i915/gvt/dmabuf.h | 2 +-
> drivers/gpu/drm/i915/gvt/firmware.c | 2 +-
> drivers/gpu/drm/i915/gvt/gtt.c | 9 ++-------
> drivers/gpu/drm/i915/gvt/gvt.h | 2 --
> drivers/gpu/drm/i915/gvt/handlers.c | 4 ++--
> drivers/gpu/drm/i915/gvt/kvmgt.c | 4 ----
> drivers/gpu/drm/i915/gvt/mmio_context.c | 2 +-
> drivers/gpu/drm/i915/gvt/page_track.c | 2 +-
> drivers/gpu/drm/i915/gvt/vgpu.c | 6 +++---
> 11 files changed, 14 insertions(+), 25 deletions(-)
^ permalink raw reply [flat|nested] 49+ messages in thread
* [Intel-gfx] [PULL] gvt-next
@ 2022-04-26 7:58 Wang, Zhi A
2022-04-26 8:37 ` Jani Nikula
2022-04-26 15:53 ` Jason Gunthorpe
0 siblings, 2 replies; 49+ messages in thread
From: Wang, Zhi A @ 2022-04-26 7:58 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Vivi, Rodrigo, Alex Williamson,
Jason Gunthorpe, Christoph Hellwig, Tvrtko Ursulin
Cc: dri-devel, intel-gfx, intel-gvt-dev, linux-kernel
Hi folks:
Here is the pull of gvt-next which fixs the compilation error when i915 debug
is open after the GVT-g refactor patches.
Thanks so much for the efforts.
Thanks,
Zhi.
The following changes since commit 2917f53113be3b7a0f374e02cebe6d6b749366b5:
vfio/mdev: Remove mdev drvdata (2022-04-21 07:36:56 -0400)
are available in the Git repository at:
https://github.com/intel/gvt-linux tags/gvt-next-2022-04-26
for you to fetch changes up to 2da299cee780ea797b3f72558687868072cf5eb5:
drm/i915/gvt: Add missing export of symbols. (2022-04-25 18:03:04 -0400)
----------------------------------------------------------------
gvt-next-2022-04-26
- Add two missing exports of symbols when i915 debug is enabled.
----------------------------------------------------------------
Zhi Wang (1):
drm/i915/gvt: Add missing export of symbols.
drivers/gpu/drm/i915/intel_gvt.c | 2 ++
1 file changed, 2 insertions(+)
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2022-04-26 7:58 Wang, Zhi A
@ 2022-04-26 8:37 ` Jani Nikula
2022-04-26 8:38 ` Wang, Zhi A
2022-04-26 8:42 ` Wang, Zhi A
2022-04-26 15:53 ` Jason Gunthorpe
1 sibling, 2 replies; 49+ messages in thread
From: Jani Nikula @ 2022-04-26 8:37 UTC (permalink / raw)
To: Wang, Zhi A, Joonas Lahtinen, Vivi, Rodrigo, Alex Williamson,
Jason Gunthorpe, Christoph Hellwig, Tvrtko Ursulin
Cc: dri-devel, intel-gfx, intel-gvt-dev, linux-kernel
On Tue, 26 Apr 2022, "Wang, Zhi A" <zhi.a.wang@intel.com> wrote:
> Hi folks:
>
> Here is the pull of gvt-next which fixs the compilation error when i915 debug
> is open after the GVT-g refactor patches.
>
> Thanks so much for the efforts.
Pulled, thanks.
BR,
Jani.
>
> Thanks,
> Zhi.
>
> The following changes since commit 2917f53113be3b7a0f374e02cebe6d6b749366b5:
>
> vfio/mdev: Remove mdev drvdata (2022-04-21 07:36:56 -0400)
>
> are available in the Git repository at:
>
> https://github.com/intel/gvt-linux tags/gvt-next-2022-04-26
>
> for you to fetch changes up to 2da299cee780ea797b3f72558687868072cf5eb5:
>
> drm/i915/gvt: Add missing export of symbols. (2022-04-25 18:03:04 -0400)
>
> ----------------------------------------------------------------
> gvt-next-2022-04-26
>
> - Add two missing exports of symbols when i915 debug is enabled.
>
> ----------------------------------------------------------------
> Zhi Wang (1):
> drm/i915/gvt: Add missing export of symbols.
>
> drivers/gpu/drm/i915/intel_gvt.c | 2 ++
> 1 file changed, 2 insertions(+)
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2022-04-26 8:37 ` Jani Nikula
@ 2022-04-26 8:38 ` Wang, Zhi A
2022-04-26 8:42 ` Wang, Zhi A
1 sibling, 0 replies; 49+ messages in thread
From: Wang, Zhi A @ 2022-04-26 8:38 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Vivi, Rodrigo, Alex Williamson,
Jason Gunthorpe, Christoph Hellwig, Tvrtko Ursulin
Cc: dri-devel, intel-gfx, intel-gvt-dev, linux-kernel
On 4/26/22 8:37 AM, Jani Nikula wrote:
> On Tue, 26 Apr 2022, "Wang, Zhi A" <zhi.a.wang@intel.com> wrote:
>> Hi folks:
>>
>> Here is the pull of gvt-next which fixs the compilation error when i915 debug
>> is open after the GVT-g refactor patches.
>>
>> Thanks so much for the efforts.
>
> Pulled, thanks.
>
> BR,
> Jani.
>
>>
I just updated the branch. Can you check a little bit if you got the newest one?
>> Thanks,
>> Zhi.
>>
>> The following changes since commit 2917f53113be3b7a0f374e02cebe6d6b749366b5:
>>
>> vfio/mdev: Remove mdev drvdata (2022-04-21 07:36:56 -0400)
>>
>> are available in the Git repository at:
>>
>> https://github.com/intel/gvt-linux tags/gvt-next-2022-04-26
>>
>> for you to fetch changes up to 2da299cee780ea797b3f72558687868072cf5eb5:
>>
>> drm/i915/gvt: Add missing export of symbols. (2022-04-25 18:03:04 -0400)
>>
>> ----------------------------------------------------------------
>> gvt-next-2022-04-26
>>
>> - Add two missing exports of symbols when i915 debug is enabled.
>>
>> ----------------------------------------------------------------
>> Zhi Wang (1):
>> drm/i915/gvt: Add missing export of symbols.
>>
>> drivers/gpu/drm/i915/intel_gvt.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2022-04-26 8:37 ` Jani Nikula
2022-04-26 8:38 ` Wang, Zhi A
@ 2022-04-26 8:42 ` Wang, Zhi A
2022-04-26 11:52 ` Jason Gunthorpe
1 sibling, 1 reply; 49+ messages in thread
From: Wang, Zhi A @ 2022-04-26 8:42 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Vivi, Rodrigo, Alex Williamson,
Jason Gunthorpe, Christoph Hellwig, Tvrtko Ursulin
Cc: dri-devel, intel-gfx, intel-gvt-dev, linux-kernel
On 4/26/22 8:37 AM, Jani Nikula wrote:
> On Tue, 26 Apr 2022, "Wang, Zhi A" <zhi.a.wang@intel.com> wrote:
>> Hi folks:
>>
>> Here is the pull of gvt-next which fixs the compilation error when i915 debug
>> is open after the GVT-g refactor patches.
>>
>> Thanks so much for the efforts.
>
> Pulled, thanks.
>
> BR,
> Jani.
>
Thanks, looks good now. :)
thanks,
Zhi.
>>
>> Thanks,
>> Zhi.
>>
>> The following changes since commit 2917f53113be3b7a0f374e02cebe6d6b749366b5:
>>
>> vfio/mdev: Remove mdev drvdata (2022-04-21 07:36:56 -0400)
>>
>> are available in the Git repository at:
>>
>> https://github.com/intel/gvt-linux tags/gvt-next-2022-04-26
>>
>> for you to fetch changes up to 2da299cee780ea797b3f72558687868072cf5eb5:
>>
>> drm/i915/gvt: Add missing export of symbols. (2022-04-25 18:03:04 -0400)
>>
>> ----------------------------------------------------------------
>> gvt-next-2022-04-26
>>
>> - Add two missing exports of symbols when i915 debug is enabled.
>>
>> ----------------------------------------------------------------
>> Zhi Wang (1):
>> drm/i915/gvt: Add missing export of symbols.
>>
>> drivers/gpu/drm/i915/intel_gvt.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2022-04-26 8:42 ` Wang, Zhi A
@ 2022-04-26 11:52 ` Jason Gunthorpe
2022-04-28 21:35 ` Alex Williamson
0 siblings, 1 reply; 49+ messages in thread
From: Jason Gunthorpe @ 2022-04-26 11:52 UTC (permalink / raw)
To: Wang, Zhi A, Alex Williamson
Cc: dri-devel, intel-gfx, linux-kernel, Vivi, Rodrigo, intel-gvt-dev,
Christoph Hellwig
On Tue, Apr 26, 2022 at 08:42:25AM +0000, Wang, Zhi A wrote:
> On 4/26/22 8:37 AM, Jani Nikula wrote:
> > On Tue, 26 Apr 2022, "Wang, Zhi A" <zhi.a.wang@intel.com> wrote:
> >> Hi folks:
> >>
> >> Here is the pull of gvt-next which fixs the compilation error when i915 debug
> >> is open after the GVT-g refactor patches.
> >>
> >> Thanks so much for the efforts.
> >
> > Pulled, thanks.
> >
> > BR,
> > Jani.
> >
> Thanks, looks good now. :)
Great! Thanks everyone!
Alex, can you pull this to VFIO now too? The top commit should be:
commit 5e9ae5c47052e28a31fb4f55a6e735c28d4c3948
Author: Zhi Wang <zhi.wang.linux@gmail.com>
Date: Mon Apr 25 18:03:31 2022 -0400
drm/i915/gvt: Add missing symbol export.
When CONFIG_DRM_I915_DEBUG_RUNTIME and CONFIG_DRM_I915_DEBUG_PM
are enabled, two more extra symols in i915 are required to be
exported.
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20220425220331.24865-1-zhi.a.wang@intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Which was picked up here:
https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-next&id=f08699ec5bd924be4c9572e21fd0a806d3fb34c2
It will have these commits:
5e9ae5c47052e2 drm/i915/gvt: Add missing symbol export.
2917f53113be3b vfio/mdev: Remove mdev drvdata
2aa72ec97ce9eb vfio/mdev: Use the driver core to create the 'remove' file
6b42f491e17ce1 vfio/mdev: Remove mdev_parent_ops
e6486939d8ea22 vfio/mdev: Remove mdev_parent_ops dev_attr_groups
6c7f98b334a32d vfio/mdev: Remove vfio_mdev.c
cba619cb0d4d66 drm/i915/gvt: merge gvt.c into kvmgvt.c
978cf586ac35f3 drm/i915/gvt: convert to use vfio_register_emulated_iommu_dev
0e09f4066ad11b drm/i915/gvt: remove kvmgt_guest_{init,exit}
7f11e6893ff01b drm/i915/gvt: pass a struct intel_vgpu to the vfio read/write helpers
4456641232e2c1 drm/i915/gvt: streamline intel_vgpu_create
37e4bdbd5bad71 drm/i915/gvt: remove the extra vfio_device refcounting for dmabufs
5f8f3fe67cd908 drm/i915/gvt: remove struct intel_gvt_mpt
91879bbaf8890f drm/i915/gvt: devirtualize dma_pin_guest_page
8398eee85fd009 drm/i915/gvt: devirtualize ->dma_{,un}map_guest_page
4c2baaaf764bfb drm/i915/gvt: devirtualize ->{enable,disable}_page_track
4050dab5981cd4 drm/i915/gvt: devirtualize ->gfn_to_mfn
bd73b4b193d450 drm/i915/gvt: devirtualize ->is_valid_gfn
b3bece34956f86 drm/i915/gvt: devirtualize ->inject_msi
4c705ad0d784fd drm/i915/gvt: devirtualize ->detach_vgpu
f9399b0e4a9555 drm/i915/gvt: devirtualize ->set_edid and ->set_opregion
fe902f0ce686e8 drm/i915/gvt: devirtualize ->{get,put}_vfio_device
e3d7640eeeb306 drm/i915/gvt: devirtualize ->{read,write}_gpa
3c340d05868d98 drm/i915/gvt: remove vgpu->handle
10ddb96295f3bd drm/i915/gvt: merge struct kvmgt_guest_info into strut intel_vgpu
62980cacc37f58 drm/i915/gvt: merge struct kvmgt_vdev into struct intel_vgpu
3cbac24c2cdbfe drm/i915/gvt: remove the unused from_virt_to_mfn op
c977092a997708 drm/i915/gvt: remove the map_gfn_to_mfn and set_trap_area ops
675e5c4a33e20c drm/i915/gvt: remove intel_gvt_ops
8b750bf744181c drm/i915/gvt: move the gvt code into kvmgt.ko
f49fc35799fa63 drm/i915/gvt: rename intel_vgpu_ops to intel_vgpu_mdev_ops
367748066eeb37 drm/i915/gvt: remove enum hypervisor_type
a85749e12d66c2 drm/i915/gvt: remove module refcounting in intel_gvt_{,un}register_hypervisor
7f0cf30187cdb1 drm/i915/gvt: better align the Makefile with i915 Makefile
de5d437ae8696a drm/i915/gvt: fix trace TRACE_INCLUDE_PATH
1672991412dfef i915/gvt: Use the initial HW state snapshot saved in i915
66e7a8063381cb i915/gvt: Save the initial HW state snapshot in i915
e0f74ed4634d6d i915/gvt: Separate the MMIO tracking table from GVT-g
Thanks,
Jason
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2022-04-26 11:52 ` Jason Gunthorpe
@ 2022-04-28 21:35 ` Alex Williamson
2022-04-28 21:48 ` Alex Williamson
0 siblings, 1 reply; 49+ messages in thread
From: Alex Williamson @ 2022-04-28 21:35 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: dri-devel, intel-gfx, linux-kernel, Vivi, Rodrigo, intel-gvt-dev,
Christoph Hellwig
On Tue, 26 Apr 2022 08:52:58 -0300
Jason Gunthorpe <jgg@nvidia.com> wrote:
> On Tue, Apr 26, 2022 at 08:42:25AM +0000, Wang, Zhi A wrote:
> > On 4/26/22 8:37 AM, Jani Nikula wrote:
> > > On Tue, 26 Apr 2022, "Wang, Zhi A" <zhi.a.wang@intel.com> wrote:
> > >> Hi folks:
> > >>
> > >> Here is the pull of gvt-next which fixs the compilation error when i915 debug
> > >> is open after the GVT-g refactor patches.
> > >>
> > >> Thanks so much for the efforts.
> > >
> > > Pulled, thanks.
> > >
> > > BR,
> > > Jani.
> > >
> > Thanks, looks good now. :)
>
> Great! Thanks everyone!
>
> Alex, can you pull this to VFIO now too? The top commit should be:
I see a gvt-next-2022-04-29 tag adding the following fixes:
419f8299ddad i915/gvt: Fix NULL pointer dereference in init_mmio_block_handlers
5b95b9d58fb0 drm/i915/gvt: Fix the compiling error when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n
fa630c304b93 drm/i915/gvt: Make intel_gvt_match_device() static
I'm expecting that's my new merge target once a pull request is
completed for that. Please keep me cc'd. Thanks,
Alex
> commit 5e9ae5c47052e28a31fb4f55a6e735c28d4c3948
> Author: Zhi Wang <zhi.wang.linux@gmail.com>
> Date: Mon Apr 25 18:03:31 2022 -0400
>
> drm/i915/gvt: Add missing symbol export.
>
> When CONFIG_DRM_I915_DEBUG_RUNTIME and CONFIG_DRM_I915_DEBUG_PM
> are enabled, two more extra symols in i915 are required to be
> exported.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
> Link: http://patchwork.freedesktop.org/patch/msgid/20220425220331.24865-1-zhi.a.wang@intel.com
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Which was picked up here:
>
> https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-next&id=f08699ec5bd924be4c9572e21fd0a806d3fb34c2
>
> It will have these commits:
>
> 5e9ae5c47052e2 drm/i915/gvt: Add missing symbol export.
> 2917f53113be3b vfio/mdev: Remove mdev drvdata
> 2aa72ec97ce9eb vfio/mdev: Use the driver core to create the 'remove' file
> 6b42f491e17ce1 vfio/mdev: Remove mdev_parent_ops
> e6486939d8ea22 vfio/mdev: Remove mdev_parent_ops dev_attr_groups
> 6c7f98b334a32d vfio/mdev: Remove vfio_mdev.c
> cba619cb0d4d66 drm/i915/gvt: merge gvt.c into kvmgvt.c
> 978cf586ac35f3 drm/i915/gvt: convert to use vfio_register_emulated_iommu_dev
> 0e09f4066ad11b drm/i915/gvt: remove kvmgt_guest_{init,exit}
> 7f11e6893ff01b drm/i915/gvt: pass a struct intel_vgpu to the vfio read/write helpers
> 4456641232e2c1 drm/i915/gvt: streamline intel_vgpu_create
> 37e4bdbd5bad71 drm/i915/gvt: remove the extra vfio_device refcounting for dmabufs
> 5f8f3fe67cd908 drm/i915/gvt: remove struct intel_gvt_mpt
> 91879bbaf8890f drm/i915/gvt: devirtualize dma_pin_guest_page
> 8398eee85fd009 drm/i915/gvt: devirtualize ->dma_{,un}map_guest_page
> 4c2baaaf764bfb drm/i915/gvt: devirtualize ->{enable,disable}_page_track
> 4050dab5981cd4 drm/i915/gvt: devirtualize ->gfn_to_mfn
> bd73b4b193d450 drm/i915/gvt: devirtualize ->is_valid_gfn
> b3bece34956f86 drm/i915/gvt: devirtualize ->inject_msi
> 4c705ad0d784fd drm/i915/gvt: devirtualize ->detach_vgpu
> f9399b0e4a9555 drm/i915/gvt: devirtualize ->set_edid and ->set_opregion
> fe902f0ce686e8 drm/i915/gvt: devirtualize ->{get,put}_vfio_device
> e3d7640eeeb306 drm/i915/gvt: devirtualize ->{read,write}_gpa
> 3c340d05868d98 drm/i915/gvt: remove vgpu->handle
> 10ddb96295f3bd drm/i915/gvt: merge struct kvmgt_guest_info into strut intel_vgpu
> 62980cacc37f58 drm/i915/gvt: merge struct kvmgt_vdev into struct intel_vgpu
> 3cbac24c2cdbfe drm/i915/gvt: remove the unused from_virt_to_mfn op
> c977092a997708 drm/i915/gvt: remove the map_gfn_to_mfn and set_trap_area ops
> 675e5c4a33e20c drm/i915/gvt: remove intel_gvt_ops
> 8b750bf744181c drm/i915/gvt: move the gvt code into kvmgt.ko
> f49fc35799fa63 drm/i915/gvt: rename intel_vgpu_ops to intel_vgpu_mdev_ops
> 367748066eeb37 drm/i915/gvt: remove enum hypervisor_type
> a85749e12d66c2 drm/i915/gvt: remove module refcounting in intel_gvt_{,un}register_hypervisor
> 7f0cf30187cdb1 drm/i915/gvt: better align the Makefile with i915 Makefile
> de5d437ae8696a drm/i915/gvt: fix trace TRACE_INCLUDE_PATH
> 1672991412dfef i915/gvt: Use the initial HW state snapshot saved in i915
> 66e7a8063381cb i915/gvt: Save the initial HW state snapshot in i915
> e0f74ed4634d6d i915/gvt: Separate the MMIO tracking table from GVT-g
>
> Thanks,
> Jason
>
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2022-04-28 21:35 ` Alex Williamson
@ 2022-04-28 21:48 ` Alex Williamson
0 siblings, 0 replies; 49+ messages in thread
From: Alex Williamson @ 2022-04-28 21:48 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: dri-devel, intel-gfx, linux-kernel, Vivi, Rodrigo, intel-gvt-dev,
Christoph Hellwig
On Thu, 28 Apr 2022 15:35:58 -0600
Alex Williamson <alex.williamson@redhat.com> wrote:
> On Tue, 26 Apr 2022 08:52:58 -0300
> Jason Gunthorpe <jgg@nvidia.com> wrote:
>
> > On Tue, Apr 26, 2022 at 08:42:25AM +0000, Wang, Zhi A wrote:
> > > On 4/26/22 8:37 AM, Jani Nikula wrote:
> > > > On Tue, 26 Apr 2022, "Wang, Zhi A" <zhi.a.wang@intel.com> wrote:
> > > >> Hi folks:
> > > >>
> > > >> Here is the pull of gvt-next which fixs the compilation error when i915 debug
> > > >> is open after the GVT-g refactor patches.
> > > >>
> > > >> Thanks so much for the efforts.
> > > >
> > > > Pulled, thanks.
> > > >
> > > > BR,
> > > > Jani.
> > > >
> > > Thanks, looks good now. :)
> >
> > Great! Thanks everyone!
> >
> > Alex, can you pull this to VFIO now too? The top commit should be:
>
> I see a gvt-next-2022-04-29 tag adding the following fixes:
>
> 419f8299ddad i915/gvt: Fix NULL pointer dereference in init_mmio_block_handlers
> 5b95b9d58fb0 drm/i915/gvt: Fix the compiling error when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n
> fa630c304b93 drm/i915/gvt: Make intel_gvt_match_device() static
>
> I'm expecting that's my new merge target once a pull request is
> completed for that. Please keep me cc'd. Thanks,
Oops, I see the new pull request for this tag came in while I was
writing this. I'll keep an eye for it to be merged. Thanks,
Alex
> > commit 5e9ae5c47052e28a31fb4f55a6e735c28d4c3948
> > Author: Zhi Wang <zhi.wang.linux@gmail.com>
> > Date: Mon Apr 25 18:03:31 2022 -0400
> >
> > drm/i915/gvt: Add missing symbol export.
> >
> > When CONFIG_DRM_I915_DEBUG_RUNTIME and CONFIG_DRM_I915_DEBUG_PM
> > are enabled, two more extra symols in i915 are required to be
> > exported.
> >
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
> > Link: http://patchwork.freedesktop.org/patch/msgid/20220425220331.24865-1-zhi.a.wang@intel.com
> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> >
> > Which was picked up here:
> >
> > https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-next&id=f08699ec5bd924be4c9572e21fd0a806d3fb34c2
> >
> > It will have these commits:
> >
> > 5e9ae5c47052e2 drm/i915/gvt: Add missing symbol export.
> > 2917f53113be3b vfio/mdev: Remove mdev drvdata
> > 2aa72ec97ce9eb vfio/mdev: Use the driver core to create the 'remove' file
> > 6b42f491e17ce1 vfio/mdev: Remove mdev_parent_ops
> > e6486939d8ea22 vfio/mdev: Remove mdev_parent_ops dev_attr_groups
> > 6c7f98b334a32d vfio/mdev: Remove vfio_mdev.c
> > cba619cb0d4d66 drm/i915/gvt: merge gvt.c into kvmgvt.c
> > 978cf586ac35f3 drm/i915/gvt: convert to use vfio_register_emulated_iommu_dev
> > 0e09f4066ad11b drm/i915/gvt: remove kvmgt_guest_{init,exit}
> > 7f11e6893ff01b drm/i915/gvt: pass a struct intel_vgpu to the vfio read/write helpers
> > 4456641232e2c1 drm/i915/gvt: streamline intel_vgpu_create
> > 37e4bdbd5bad71 drm/i915/gvt: remove the extra vfio_device refcounting for dmabufs
> > 5f8f3fe67cd908 drm/i915/gvt: remove struct intel_gvt_mpt
> > 91879bbaf8890f drm/i915/gvt: devirtualize dma_pin_guest_page
> > 8398eee85fd009 drm/i915/gvt: devirtualize ->dma_{,un}map_guest_page
> > 4c2baaaf764bfb drm/i915/gvt: devirtualize ->{enable,disable}_page_track
> > 4050dab5981cd4 drm/i915/gvt: devirtualize ->gfn_to_mfn
> > bd73b4b193d450 drm/i915/gvt: devirtualize ->is_valid_gfn
> > b3bece34956f86 drm/i915/gvt: devirtualize ->inject_msi
> > 4c705ad0d784fd drm/i915/gvt: devirtualize ->detach_vgpu
> > f9399b0e4a9555 drm/i915/gvt: devirtualize ->set_edid and ->set_opregion
> > fe902f0ce686e8 drm/i915/gvt: devirtualize ->{get,put}_vfio_device
> > e3d7640eeeb306 drm/i915/gvt: devirtualize ->{read,write}_gpa
> > 3c340d05868d98 drm/i915/gvt: remove vgpu->handle
> > 10ddb96295f3bd drm/i915/gvt: merge struct kvmgt_guest_info into strut intel_vgpu
> > 62980cacc37f58 drm/i915/gvt: merge struct kvmgt_vdev into struct intel_vgpu
> > 3cbac24c2cdbfe drm/i915/gvt: remove the unused from_virt_to_mfn op
> > c977092a997708 drm/i915/gvt: remove the map_gfn_to_mfn and set_trap_area ops
> > 675e5c4a33e20c drm/i915/gvt: remove intel_gvt_ops
> > 8b750bf744181c drm/i915/gvt: move the gvt code into kvmgt.ko
> > f49fc35799fa63 drm/i915/gvt: rename intel_vgpu_ops to intel_vgpu_mdev_ops
> > 367748066eeb37 drm/i915/gvt: remove enum hypervisor_type
> > a85749e12d66c2 drm/i915/gvt: remove module refcounting in intel_gvt_{,un}register_hypervisor
> > 7f0cf30187cdb1 drm/i915/gvt: better align the Makefile with i915 Makefile
> > de5d437ae8696a drm/i915/gvt: fix trace TRACE_INCLUDE_PATH
> > 1672991412dfef i915/gvt: Use the initial HW state snapshot saved in i915
> > 66e7a8063381cb i915/gvt: Save the initial HW state snapshot in i915
> > e0f74ed4634d6d i915/gvt: Separate the MMIO tracking table from GVT-g
> >
> > Thanks,
> > Jason
> >
>
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2022-04-26 7:58 Wang, Zhi A
2022-04-26 8:37 ` Jani Nikula
@ 2022-04-26 15:53 ` Jason Gunthorpe
2022-04-26 16:58 ` Wang, Zhi A
1 sibling, 1 reply; 49+ messages in thread
From: Jason Gunthorpe @ 2022-04-26 15:53 UTC (permalink / raw)
To: Wang, Zhi A
Cc: dri-devel, intel-gfx, linux-kernel, Vivi, Rodrigo, intel-gvt-dev,
Christoph Hellwig
On Tue, Apr 26, 2022 at 07:58:59AM +0000, Wang, Zhi A wrote:
> Hi folks:
>
> Here is the pull of gvt-next which fixs the compilation error when i915 debug
> is open after the GVT-g refactor patches.
>
> Thanks so much for the efforts.
>
> Thanks,
> Zhi.
>
> The following changes since commit 2917f53113be3b7a0f374e02cebe6d6b749366b5:
>
> vfio/mdev: Remove mdev drvdata (2022-04-21 07:36:56 -0400)
>
> are available in the Git repository at:
>
> https://github.com/intel/gvt-linux tags/gvt-next-2022-04-26
>
> for you to fetch changes up to 2da299cee780ea797b3f72558687868072cf5eb5:
>
> drm/i915/gvt: Add missing export of symbols. (2022-04-25 18:03:04 -0400)
>
> gvt-next-2022-04-26
>
> - Add two missing exports of symbols when i915 debug is enabled.
>
> Zhi Wang (1):
> drm/i915/gvt: Add missing export of symbols.
>
> drivers/gpu/drm/i915/intel_gvt.c | 2 ++
> 1 file changed, 2 insertions(+)
This still has another compile problem:
ERROR: modpost: "intel_runtime_pm_put" [vmlinux] is a static EXPORT_SYMBOL_GPL
Because:
#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
void intel_runtime_pm_put(struct intel_runtime_pm *rpm, intel_wakeref_t wref);
#else
static inline void
intel_runtime_pm_put(struct intel_runtime_pm *rpm, intel_wakeref_t wref)
{
intel_runtime_pm_put_unchecked(rpm);
}
#endif
Looks like it happens if CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n
I think you probably want to #ifdef the export in the same way:
--- a/drivers/gpu/drm/i915/intel_gvt.c
+++ b/drivers/gpu/drm/i915/intel_gvt.c
@@ -309,7 +309,9 @@ EXPORT_SYMBOL_NS_GPL(__intel_context_do_pin, I915_GVT);
EXPORT_SYMBOL_NS_GPL(__intel_context_do_unpin, I915_GVT);
EXPORT_SYMBOL_NS_GPL(intel_ring_begin, I915_GVT);
EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_get, I915_GVT);
+#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_put, I915_GVT);
+#endif
EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_put_unchecked, I915_GVT);
EXPORT_SYMBOL_NS_GPL(intel_uncore_forcewake_for_reg, I915_GVT);
EXPORT_SYMBOL_NS_GPL(intel_uncore_forcewake_get, I915_GVT);
Jason
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2022-04-26 15:53 ` Jason Gunthorpe
@ 2022-04-26 16:58 ` Wang, Zhi A
2022-04-26 19:19 ` Robert Beckett
0 siblings, 1 reply; 49+ messages in thread
From: Wang, Zhi A @ 2022-04-26 16:58 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: intel-gfx, linux-kernel, dri-devel, Vivi, Rodrigo, intel-gvt-dev,
Christoph Hellwig
On 4/26/22 3:53 PM, Jason Gunthorpe wrote:
> On Tue, Apr 26, 2022 at 07:58:59AM +0000, Wang, Zhi A wrote:
>> Hi folks:
>>
>> Here is the pull of gvt-next which fixs the compilation error when i915 debug
>> is open after the GVT-g refactor patches.
>>
>> Thanks so much for the efforts.
>>
>> Thanks,
>> Zhi.
>>
>> The following changes since commit 2917f53113be3b7a0f374e02cebe6d6b749366b5:
>>
>> vfio/mdev: Remove mdev drvdata (2022-04-21 07:36:56 -0400)
>>
>> are available in the Git repository at:
>>
>> https://github.com/intel/gvt-linux tags/gvt-next-2022-04-26
>>
>> for you to fetch changes up to 2da299cee780ea797b3f72558687868072cf5eb5:
>>
>> drm/i915/gvt: Add missing export of symbols. (2022-04-25 18:03:04 -0400)
>>
>> gvt-next-2022-04-26
>>
>> - Add two missing exports of symbols when i915 debug is enabled.
>>
>> Zhi Wang (1):
>> drm/i915/gvt: Add missing export of symbols.
>>
>> drivers/gpu/drm/i915/intel_gvt.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> This still has another compile problem:
>
> ERROR: modpost: "intel_runtime_pm_put" [vmlinux] is a static EXPORT_SYMBOL_GPL
>
> Because:
>
> #if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
> void intel_runtime_pm_put(struct intel_runtime_pm *rpm, intel_wakeref_t wref);
> #else
> static inline void
> intel_runtime_pm_put(struct intel_runtime_pm *rpm, intel_wakeref_t wref)
> {
> intel_runtime_pm_put_unchecked(rpm);
> }
> #endif
>
> Looks like it happens if CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n
>
> I think you probably want to #ifdef the export in the same way:
>
> --- a/drivers/gpu/drm/i915/intel_gvt.c
> +++ b/drivers/gpu/drm/i915/intel_gvt.c
> @@ -309,7 +309,9 @@ EXPORT_SYMBOL_NS_GPL(__intel_context_do_pin, I915_GVT);
> EXPORT_SYMBOL_NS_GPL(__intel_context_do_unpin, I915_GVT);
> EXPORT_SYMBOL_NS_GPL(intel_ring_begin, I915_GVT);
> EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_get, I915_GVT);
> +#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
> EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_put, I915_GVT);
> +#endif
Sigh. That's tricky. Let me prepare another one.
> EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_put_unchecked, I915_GVT);
> EXPORT_SYMBOL_NS_GPL(intel_uncore_forcewake_for_reg, I915_GVT);
> EXPORT_SYMBOL_NS_GPL(intel_uncore_forcewake_get, I915_GVT);
>
> Jason
>
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2022-04-26 16:58 ` Wang, Zhi A
@ 2022-04-26 19:19 ` Robert Beckett
0 siblings, 0 replies; 49+ messages in thread
From: Robert Beckett @ 2022-04-26 19:19 UTC (permalink / raw)
To: Wang, Zhi A, Jason Gunthorpe
Cc: intel-gfx, linux-kernel, dri-devel, Vivi, Rodrigo, intel-gvt-dev,
Christoph Hellwig
On 26/04/2022 17:58, Wang, Zhi A wrote:
> On 4/26/22 3:53 PM, Jason Gunthorpe wrote:
>> On Tue, Apr 26, 2022 at 07:58:59AM +0000, Wang, Zhi A wrote:
>>> Hi folks:
>>>
>>> Here is the pull of gvt-next which fixs the compilation error when i915 debug
>>> is open after the GVT-g refactor patches.
>>>
>>> Thanks so much for the efforts.
>>>
>>> Thanks,
>>> Zhi.
>>>
>>> The following changes since commit 2917f53113be3b7a0f374e02cebe6d6b749366b5:
>>>
>>> vfio/mdev: Remove mdev drvdata (2022-04-21 07:36:56 -0400)
>>>
>>> are available in the Git repository at:
>>>
>>> https://github.com/intel/gvt-linux tags/gvt-next-2022-04-26
>>>
>>> for you to fetch changes up to 2da299cee780ea797b3f72558687868072cf5eb5:
>>>
>>> drm/i915/gvt: Add missing export of symbols. (2022-04-25 18:03:04 -0400)
>>>
>>> gvt-next-2022-04-26
>>>
>>> - Add two missing exports of symbols when i915 debug is enabled.
>>>
>>> Zhi Wang (1):
>>> drm/i915/gvt: Add missing export of symbols.
>>>
>>> drivers/gpu/drm/i915/intel_gvt.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>
>> This still has another compile problem:
>>
>> ERROR: modpost: "intel_runtime_pm_put" [vmlinux] is a static EXPORT_SYMBOL_GPL
>>
>> Because:
>>
>> #if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
>> void intel_runtime_pm_put(struct intel_runtime_pm *rpm, intel_wakeref_t wref);
>> #else
>> static inline void
>> intel_runtime_pm_put(struct intel_runtime_pm *rpm, intel_wakeref_t wref)
>> {
>> intel_runtime_pm_put_unchecked(rpm);
>> }
>> #endif
>>
>> Looks like it happens if CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n
>>
>> I think you probably want to #ifdef the export in the same way:
>>
>> --- a/drivers/gpu/drm/i915/intel_gvt.c
>> +++ b/drivers/gpu/drm/i915/intel_gvt.c
>> @@ -309,7 +309,9 @@ EXPORT_SYMBOL_NS_GPL(__intel_context_do_pin, I915_GVT);
>> EXPORT_SYMBOL_NS_GPL(__intel_context_do_unpin, I915_GVT);
>> EXPORT_SYMBOL_NS_GPL(intel_ring_begin, I915_GVT);
>> EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_get, I915_GVT);
>> +#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
>> EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_put, I915_GVT);
>> +#endif
> Sigh. That's tricky. Let me prepare another one.
Also the following compile error:
drivers/gpu/drm/i915/gvt/handlers.c:75:6: error: no previous prototype
for ‘intel_gvt_match_device’ [-Werror=missing-prototypes]
75 | bool intel_gvt_match_device(struct intel_gvt *gvt,
| ^~~~~~~~~~~~~~~~~~~~~~
it was removed from a header. The implementation should now be made static
>> EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_put_unchecked, I915_GVT);
>> EXPORT_SYMBOL_NS_GPL(intel_uncore_forcewake_for_reg, I915_GVT);
>> EXPORT_SYMBOL_NS_GPL(intel_uncore_forcewake_get, I915_GVT);
>>
>> Jason
>>
>
^ permalink raw reply [flat|nested] 49+ messages in thread
* [Intel-gfx] [PULL] gvt-next
@ 2022-04-20 8:04 Wang, Zhi A
2022-04-20 12:13 ` Jason Gunthorpe
0 siblings, 1 reply; 49+ messages in thread
From: Wang, Zhi A @ 2022-04-20 8:04 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Vivi, Rodrigo
Cc: intel-gfx, intel-gvt-dev, Christoph Hellwig, Jason Gunthorpe
Hi folks:
Here is the PR of gvt-next.
Mostly it includes the patch bundle of GVT-g re-factor patches for adapting the GVT-g with the
new MDEV interfaces:
- Separating the MMIO table from GVT-g. (Zhi)
- GVT-g re-factor. (Christoph)
- GVT-g mdev API cleanup. (Jason)
- GVT-g trace/makefile cleanup. (Jani)
Thanks so much for making this happen.
This PR has been tested as following and no problem shows up:
$dim update-branches
$dim apply-pull drm-intel-next < this_email.eml
The following changes since commit b39d2c6202426b560641e5800c5523851b5db586:
drm/i915/fbc: Call intel_fbc_activate() directly from frontbuffer flush (2022-04-13 17:20:49 +0300)
are available in the Git repository at:
https://github.com/intel/gvt-linux tags/gvt-next-2022-04-20
for you to fetch changes up to 888471711a80b22c53547f3a625f20f487714f28:
vfio/mdev: Remove mdev drvdata (2022-04-20 03:20:16 -0400)
----------------------------------------------------------------
gvt-next-2022-04-20
- Separating the MMIO table from GVT-g. (Zhi)
- GVT-g re-factor. (Christoph)
- GVT-g mdev API cleanup. (Jason)
- GVT-g trace/makefile cleanup. (Jani)
----------------------------------------------------------------
Christoph Hellwig (27):
drm/i915/gvt: remove module refcounting in intel_gvt_{,un}register_hypervisor
drm/i915/gvt: remove enum hypervisor_type
drm/i915/gvt: rename intel_vgpu_ops to intel_vgpu_mdev_ops
drm/i915/gvt: move the gvt code into kvmgt.ko
drm/i915/gvt: remove intel_gvt_ops
drm/i915/gvt: remove the map_gfn_to_mfn and set_trap_area ops
drm/i915/gvt: remove the unused from_virt_to_mfn op
drm/i915/gvt: merge struct kvmgt_vdev into struct intel_vgpu
drm/i915/gvt: merge struct kvmgt_guest_info into strut intel_vgpu
drm/i915/gvt: remove vgpu->handle
drm/i915/gvt: devirtualize ->{read,write}_gpa
drm/i915/gvt: devirtualize ->{get,put}_vfio_device
drm/i915/gvt: devirtualize ->set_edid and ->set_opregion
drm/i915/gvt: devirtualize ->detach_vgpu
drm/i915/gvt: devirtualize ->inject_msi
drm/i915/gvt: devirtualize ->is_valid_gfn
drm/i915/gvt: devirtualize ->gfn_to_mfn
drm/i915/gvt: devirtualize ->{enable,disable}_page_track
drm/i915/gvt: devirtualize ->dma_{,un}map_guest_page
drm/i915/gvt: devirtualize dma_pin_guest_page
drm/i915/gvt: remove struct intel_gvt_mpt
drm/i915/gvt: remove the extra vfio_device refcounting for dmabufs
drm/i915/gvt: streamline intel_vgpu_create
drm/i915/gvt: pass a struct intel_vgpu to the vfio read/write helpers
drm/i915/gvt: remove kvmgt_guest_{init,exit}
drm/i915/gvt: convert to use vfio_register_emulated_iommu_dev
drm/i915/gvt: merge gvt.c into kvmgvt.c
Jani Nikula (2):
drm/i915/gvt: fix trace TRACE_INCLUDE_PATH
drm/i915/gvt: better align the Makefile with i915 Makefile
Jason Gunthorpe (5):
vfio/mdev: Remove vfio_mdev.c
vfio/mdev: Remove mdev_parent_ops dev_attr_groups
vfio/mdev: Remove mdev_parent_ops
vfio/mdev: Use the driver core to create the 'remove' file
vfio/mdev: Remove mdev drvdata
Zhi Wang (3):
i915/gvt: Separate the MMIO tracking table from GVT-g
i915/gvt: Save the initial HW state snapshot in i915
i915/gvt: Use the initial HW state snapshot saved in i915
Documentation/driver-api/vfio-mediated-device.rst | 27 +-
drivers/gpu/drm/i915/Kconfig | 36 +-
drivers/gpu/drm/i915/Makefile | 8 +-
drivers/gpu/drm/i915/gvt/Makefile | 30 +-
drivers/gpu/drm/i915/gvt/cfg_space.c | 89 +-
drivers/gpu/drm/i915/gvt/cmd_parser.c | 4 +-
drivers/gpu/drm/i915/gvt/dmabuf.c | 36 +-
drivers/gpu/drm/i915/gvt/execlist.c | 12 +-
drivers/gpu/drm/i915/gvt/firmware.c | 25 +-
drivers/gpu/drm/i915/gvt/gtt.c | 55 +-
drivers/gpu/drm/i915/gvt/gvt.c | 340 ------
drivers/gpu/drm/i915/gvt/gvt.h | 128 +-
drivers/gpu/drm/i915/gvt/handlers.c | 1033 +++-------------
drivers/gpu/drm/i915/gvt/hypercall.h | 82 --
drivers/gpu/drm/i915/gvt/interrupt.c | 40 +-
drivers/gpu/drm/i915/gvt/kvmgt.c | 1097 +++++++++--------
drivers/gpu/drm/i915/gvt/mmio.c | 4 +-
drivers/gpu/drm/i915/gvt/mmio.h | 1 -
drivers/gpu/drm/i915/gvt/mpt.h | 400 -------
drivers/gpu/drm/i915/gvt/opregion.c | 148 +--
drivers/gpu/drm/i915/gvt/page_track.c | 8 +-
drivers/gpu/drm/i915/gvt/reg.h | 9 +-
drivers/gpu/drm/i915/gvt/scheduler.c | 37 +-
drivers/gpu/drm/i915/gvt/trace.h | 2 +-
drivers/gpu/drm/i915/gvt/vgpu.c | 22 +-
drivers/gpu/drm/i915/i915_driver.c | 7 -
drivers/gpu/drm/i915/i915_drv.h | 3 +
drivers/gpu/drm/i915/intel_gvt.c | 248 +++-
drivers/gpu/drm/i915/intel_gvt.h | 32 +-
drivers/gpu/drm/i915/intel_gvt_mmio_table.c | 1292 +++++++++++++++++++++
drivers/s390/cio/vfio_ccw_ops.c | 7 +-
drivers/s390/crypto/vfio_ap_ops.c | 9 +-
drivers/vfio/mdev/Makefile | 2 +-
drivers/vfio/mdev/mdev_core.c | 52 +-
drivers/vfio/mdev/mdev_driver.c | 10 -
drivers/vfio/mdev/mdev_private.h | 6 +-
drivers/vfio/mdev/mdev_sysfs.c | 37 +-
drivers/vfio/mdev/vfio_mdev.c | 152 ---
include/linux/mdev.h | 82 +-
samples/vfio-mdev/mbochs.c | 9 +-
samples/vfio-mdev/mdpy.c | 9 +-
samples/vfio-mdev/mtty.c | 39 +-
42 files changed, 2531 insertions(+), 3138 deletions(-)
delete mode 100644 drivers/gpu/drm/i915/gvt/gvt.c
delete mode 100644 drivers/gpu/drm/i915/gvt/hypercall.h
delete mode 100644 drivers/gpu/drm/i915/gvt/mpt.h
create mode 100644 drivers/gpu/drm/i915/intel_gvt_mmio_table.c
delete mode 100644 drivers/vfio/mdev/vfio_mdev.c
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2022-04-20 8:04 Wang, Zhi A
@ 2022-04-20 12:13 ` Jason Gunthorpe
2022-04-20 14:41 ` Wang, Zhi A
0 siblings, 1 reply; 49+ messages in thread
From: Jason Gunthorpe @ 2022-04-20 12:13 UTC (permalink / raw)
To: Wang, Zhi A; +Cc: intel-gfx, Vivi, Rodrigo, intel-gvt-dev, Christoph Hellwig
On Wed, Apr 20, 2022 at 08:04:31AM +0000, Wang, Zhi A wrote:
> Hi folks:
>
> Here is the PR of gvt-next.
>
> Mostly it includes the patch bundle of GVT-g re-factor patches for adapting the GVT-g with the
> new MDEV interfaces:
>
> - Separating the MMIO table from GVT-g. (Zhi)
> - GVT-g re-factor. (Christoph)
> - GVT-g mdev API cleanup. (Jason)
> - GVT-g trace/makefile cleanup. (Jani)
>
> Thanks so much for making this happen.
>
> This PR has been tested as following and no problem shows up:
>
> $dim update-branches
> $dim apply-pull drm-intel-next < this_email.eml
>
> The following changes since commit b39d2c6202426b560641e5800c5523851b5db586:
>
> drm/i915/fbc: Call intel_fbc_activate() directly from frontbuffer flush (2022-04-13 17:20:49 +0300)
??
Why did you rebase this again? It needs to be on a rc release tag as
you had in your github, not whatever this is.
Jason
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2022-04-20 12:13 ` Jason Gunthorpe
@ 2022-04-20 14:41 ` Wang, Zhi A
2022-04-20 15:02 ` Jason Gunthorpe
0 siblings, 1 reply; 49+ messages in thread
From: Wang, Zhi A @ 2022-04-20 14:41 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: intel-gfx, Vivi, Rodrigo, intel-gvt-dev, Christoph Hellwig
On 4/20/22 12:13 PM, Jason Gunthorpe wrote:
> On Wed, Apr 20, 2022 at 08:04:31AM +0000, Wang, Zhi A wrote:
>> Hi folks:
>>
>> Here is the PR of gvt-next.
>>
>> Mostly it includes the patch bundle of GVT-g re-factor patches for adapting the GVT-g with the
>> new MDEV interfaces:
>>
>> - Separating the MMIO table from GVT-g. (Zhi)
>> - GVT-g re-factor. (Christoph)
>> - GVT-g mdev API cleanup. (Jason)
>> - GVT-g trace/makefile cleanup. (Jani)
>>
>> Thanks so much for making this happen.
>>
>> This PR has been tested as following and no problem shows up:
>>
>> $dim update-branches
>> $dim apply-pull drm-intel-next < this_email.eml
>>
>> The following changes since commit b39d2c6202426b560641e5800c5523851b5db586:
>>
>> drm/i915/fbc: Call intel_fbc_activate() directly from frontbuffer flush (2022-04-13 17:20:49 +0300)
>
> ??
>
> Why did you rebase this again? It needs to be on a rc release tag as
> you had in your github, not whatever this is.
>
Hi Jason:
Here is what I understand, the pull going to the drm-intel-next needs to be based on drm-intel-next from the branch gvt-next. The pull going to the VFIO needs to be based on -rc, the topic/for-christoph brnach. So I did a merge from topic/for-christoph to my gvt-next branch and sent this pull, so that our QA can test these bundle on the gvt-staging branch.
Sorry this is way too complicated to me. Let me prepare the new pull as what you ask. Shall I send the exact same pull to i915 and VFIO ?
Thanks,
Zhi.
> Jason
>
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2022-04-20 14:41 ` Wang, Zhi A
@ 2022-04-20 15:02 ` Jason Gunthorpe
2022-04-20 16:13 ` Wang, Zhi A
0 siblings, 1 reply; 49+ messages in thread
From: Jason Gunthorpe @ 2022-04-20 15:02 UTC (permalink / raw)
To: Wang, Zhi A; +Cc: intel-gfx, Vivi, Rodrigo, intel-gvt-dev, Christoph Hellwig
On Wed, Apr 20, 2022 at 02:41:04PM +0000, Wang, Zhi A wrote:
> On 4/20/22 12:13 PM, Jason Gunthorpe wrote:
> > On Wed, Apr 20, 2022 at 08:04:31AM +0000, Wang, Zhi A wrote:
> >> Hi folks:
> >>
> >> Here is the PR of gvt-next.
> >>
> >> Mostly it includes the patch bundle of GVT-g re-factor patches for adapting the GVT-g with the
> >> new MDEV interfaces:
> >>
> >> - Separating the MMIO table from GVT-g. (Zhi)
> >> - GVT-g re-factor. (Christoph)
> >> - GVT-g mdev API cleanup. (Jason)
> >> - GVT-g trace/makefile cleanup. (Jani)
> >>
> >> Thanks so much for making this happen.
> >>
> >> This PR has been tested as following and no problem shows up:
> >>
> >> $dim update-branches
> >> $dim apply-pull drm-intel-next < this_email.eml
> >>
> >> The following changes since commit b39d2c6202426b560641e5800c5523851b5db586:
> >>
> >> drm/i915/fbc: Call intel_fbc_activate() directly from frontbuffer flush (2022-04-13 17:20:49 +0300)
> >
> > ??
> >
> > Why did you rebase this again? It needs to be on a rc release tag as
> > you had in your github, not whatever this is.
> >
> Hi Jason:
>
> Here is what I understand, the pull going to the drm-intel-next
> needs to be based on drm-intel-next from the branch gvt-next.
No, there cannot be two pulls, as I explained when using topic
branches you must never rebase.
> The pull going to the VFIO needs to be based on -rc, the
> topic/for-christoph brnach.
Yes, so what you need to do is:
# Get a clean tree on drm-intel-next
$ git worktree add /tmp/gvt-next
Preparing worktree (new branch 'gvt-next')
$ cd /tmp/gvt-next
$ git reset --hard b39d2c6202426b560641e5800c5523851b5db586 # drm-intel-next commit you tested
# Merge Christoph's topic:
$ git fetch https://github.com/intel/gvt-linux.git topic/for-christoph
$ git merge FETCH_HEAD
Auto-merging drivers/gpu/drm/i915/Makefile
Auto-merging drivers/gpu/drm/i915/gvt/handlers.c
Auto-merging drivers/gpu/drm/i915/i915_driver.c
Auto-merging drivers/gpu/drm/i915/i915_drv.h
Merge made by the 'ort' strategy.
[..
Merge branch 'topic/for-christoph' of https://github.com/intel/gvt-linux into gvt-next
# By Christoph Hellwig (27) and others
# Via Zhi Wang
* 'topic/for-christoph' of https://github.com/intel/gvt-linux: (37 commits)
]
And then check it against what you prepared in this PR here:
$ git diff HEAD 888471711a80b22c53547f3a625f20f487714f28
[empty]
*do not rebase a topic branch* this is very important.
Now - given that we can see there is no merge conflict you don't need
to do anything! Just send topic/for-christoph, exactly as-it-is to
drm-intel-next as a PR and that is all.
> Sorry this is way too complicated to me. Let me prepare the new pull
> as what you ask. Shall I send the exact same pull to i915 and VFIO ?
Yes, exact same, this is important.
You were very close before, the only issue was rebasing
topic/for-christoph instead of merging.
Jason
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2022-04-20 15:02 ` Jason Gunthorpe
@ 2022-04-20 16:13 ` Wang, Zhi A
0 siblings, 0 replies; 49+ messages in thread
From: Wang, Zhi A @ 2022-04-20 16:13 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: intel-gfx, Vivi, Rodrigo, intel-gvt-dev, Christoph Hellwig
On 4/20/22 3:02 PM, Jason Gunthorpe wrote:
> On Wed, Apr 20, 2022 at 02:41:04PM +0000, Wang, Zhi A wrote:
>> On 4/20/22 12:13 PM, Jason Gunthorpe wrote:
>>> On Wed, Apr 20, 2022 at 08:04:31AM +0000, Wang, Zhi A wrote:
>>>> Hi folks:
>>>>
>>>> Here is the PR of gvt-next.
>>>>
>>>> Mostly it includes the patch bundle of GVT-g re-factor patches for adapting the GVT-g with the
>>>> new MDEV interfaces:
>>>>
>>>> - Separating the MMIO table from GVT-g. (Zhi)
>>>> - GVT-g re-factor. (Christoph)
>>>> - GVT-g mdev API cleanup. (Jason)
>>>> - GVT-g trace/makefile cleanup. (Jani)
>>>>
>>>> Thanks so much for making this happen.
>>>>
>>>> This PR has been tested as following and no problem shows up:
>>>>
>>>> $dim update-branches
>>>> $dim apply-pull drm-intel-next < this_email.eml
>>>>
>>>> The following changes since commit b39d2c6202426b560641e5800c5523851b5db586:
>>>>
>>>> drm/i915/fbc: Call intel_fbc_activate() directly from frontbuffer flush (2022-04-13 17:20:49 +0300)
>>>
>>> ??
>>>
>>> Why did you rebase this again? It needs to be on a rc release tag as
>>> you had in your github, not whatever this is.
>>>
>> Hi Jason:
>>
>> Here is what I understand, the pull going to the drm-intel-next
>> needs to be based on drm-intel-next from the branch gvt-next.
>
> No, there cannot be two pulls, as I explained when using topic
> branches you must never rebase.
>
>> The pull going to the VFIO needs to be based on -rc, the
>> topic/for-christoph brnach.
>
> Yes, so what you need to do is:
>
> # Get a clean tree on drm-intel-next
> $ git worktree add /tmp/gvt-next
> Preparing worktree (new branch 'gvt-next')
> $ cd /tmp/gvt-next
> $ git reset --hard b39d2c6202426b560641e5800c5523851b5db586 # drm-intel-next commit you tested
>
> # Merge Christoph's topic:
> $ git fetch https://github.com/intel/gvt-linux.git topic/for-christoph
> $ git merge FETCH_HEAD
> Auto-merging drivers/gpu/drm/i915/Makefile
> Auto-merging drivers/gpu/drm/i915/gvt/handlers.c
> Auto-merging drivers/gpu/drm/i915/i915_driver.c
> Auto-merging drivers/gpu/drm/i915/i915_drv.h
> Merge made by the 'ort' strategy.
>
Exactly what I did on my branch except that I sent the pull request based on my gvt-next. :(
> [..
> Merge branch 'topic/for-christoph' of https://github.com/intel/gvt-linux into gvt-next
>
> # By Christoph Hellwig (27) and others
> # Via Zhi Wang
> * 'topic/for-christoph' of https://github.com/intel/gvt-linux: (37 commits)
> ]
>
> And then check it against what you prepared in this PR here:
>
> $ git diff HEAD 888471711a80b22c53547f3a625f20f487714f28
> [empty]
>
> *do not rebase a topic branch* this is very important.
>
> Now - given that we can see there is no merge conflict you don't need
> to do anything! Just send topic/for-christoph, exactly as-it-is to
> drm-intel-next as a PR and that is all.
>
>> Sorry this is way too complicated to me. Let me prepare the new pull
>> as what you ask. Shall I send the exact same pull to i915 and VFIO ?
>
> Yes, exact same, this is important.
>
> You were very close before, the only issue was rebasing
> topic/for-christoph instead of merging.
>
I will send it by the end of the day. Thanks so much for your patience.
> Jason
>
^ permalink raw reply [flat|nested] 49+ messages in thread
* [Intel-gfx] [PULL] gvt-next
@ 2021-03-16 7:43 Zhenyu Wang
2021-03-16 11:52 ` Jani Nikula
0 siblings, 1 reply; 49+ messages in thread
From: Zhenyu Wang @ 2021-03-16 7:43 UTC (permalink / raw)
To: Joonas Lahtinen, Vivi, Rodrigo, Jani Nikula
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
[-- Attachment #1.1: Type: text/plain, Size: 1729 bytes --]
Hi,
This is queued gvt-next pull for 5.13. Mostly it's for accurate
vGPU virtual display rate tracking and change for per-vGPU vblank
timer based on that, which brings accurate vblank injection.
Thanks
--
The following changes since commit c73927183f2b85bf1a06d75d2b51be72aff42358:
drm/i915/tgl+: Sanitize the DDI LANES/IO and AUX power domain names (2021-02-24 14:05:39 +0200)
are available in the Git repository at:
https://github.com/intel/gvt-linux.git tags/gvt-next-2021-03-16
for you to fetch changes up to 9317f356df83a5caeccae2e343d1a569929bcfc9:
drm/i915/gvt: Fixed couple of spellings in the file gtt.c (2021-03-01 14:02:14 +0800)
----------------------------------------------------------------
gvt-next-2021-03-16
- Parse accurate vGPU virtual display rate (Colin)
- Convert vblank timer as per-vGPU based on current rate (Colin)
- spelling fix (Bhaskar)
----------------------------------------------------------------
Bhaskar Chowdhury (1):
drm/i915/gvt: Fixed couple of spellings in the file gtt.c
Colin Xu (2):
drm/i915/gvt: Get accurate vGPU virtual display refresh rate from vreg
drm/i915/gvt: Refactor GVT vblank emulator for vGPU virtual display
drivers/gpu/drm/i915/gvt/display.c | 107 +++++++-------
drivers/gpu/drm/i915/gvt/display.h | 14 +-
drivers/gpu/drm/i915/gvt/gtt.c | 4 +-
drivers/gpu/drm/i915/gvt/gvt.c | 25 +++-
drivers/gpu/drm/i915/gvt/gvt.h | 13 +-
drivers/gpu/drm/i915/gvt/handlers.c | 261 ++++++++++++++++++++++++++++++++++-
drivers/gpu/drm/i915/gvt/interrupt.c | 37 -----
drivers/gpu/drm/i915/gvt/interrupt.h | 7 -
drivers/gpu/drm/i915/gvt/vgpu.c | 2 -
9 files changed, 355 insertions(+), 115 deletions(-)
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2021-03-16 7:43 Zhenyu Wang
@ 2021-03-16 11:52 ` Jani Nikula
0 siblings, 0 replies; 49+ messages in thread
From: Jani Nikula @ 2021-03-16 11:52 UTC (permalink / raw)
To: Zhenyu Wang, Joonas Lahtinen, Vivi, Rodrigo
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
On Tue, 16 Mar 2021, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> Hi,
>
> This is queued gvt-next pull for 5.13. Mostly it's for accurate
> vGPU virtual display rate tracking and change for per-vGPU vblank
> timer based on that, which brings accurate vblank injection.
Pulled to drm-intel-next.
BR,
Jani.
>
> Thanks
> --
> The following changes since commit c73927183f2b85bf1a06d75d2b51be72aff42358:
>
> drm/i915/tgl+: Sanitize the DDI LANES/IO and AUX power domain names (2021-02-24 14:05:39 +0200)
>
> are available in the Git repository at:
>
> https://github.com/intel/gvt-linux.git tags/gvt-next-2021-03-16
>
> for you to fetch changes up to 9317f356df83a5caeccae2e343d1a569929bcfc9:
>
> drm/i915/gvt: Fixed couple of spellings in the file gtt.c (2021-03-01 14:02:14 +0800)
>
> ----------------------------------------------------------------
> gvt-next-2021-03-16
>
> - Parse accurate vGPU virtual display rate (Colin)
> - Convert vblank timer as per-vGPU based on current rate (Colin)
> - spelling fix (Bhaskar)
>
> ----------------------------------------------------------------
> Bhaskar Chowdhury (1):
> drm/i915/gvt: Fixed couple of spellings in the file gtt.c
>
> Colin Xu (2):
> drm/i915/gvt: Get accurate vGPU virtual display refresh rate from vreg
> drm/i915/gvt: Refactor GVT vblank emulator for vGPU virtual display
>
> drivers/gpu/drm/i915/gvt/display.c | 107 +++++++-------
> drivers/gpu/drm/i915/gvt/display.h | 14 +-
> drivers/gpu/drm/i915/gvt/gtt.c | 4 +-
> drivers/gpu/drm/i915/gvt/gvt.c | 25 +++-
> drivers/gpu/drm/i915/gvt/gvt.h | 13 +-
> drivers/gpu/drm/i915/gvt/handlers.c | 261 ++++++++++++++++++++++++++++++++++-
> drivers/gpu/drm/i915/gvt/interrupt.c | 37 -----
> drivers/gpu/drm/i915/gvt/interrupt.h | 7 -
> drivers/gpu/drm/i915/gvt/vgpu.c | 2 -
> 9 files changed, 355 insertions(+), 115 deletions(-)
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* [Intel-gfx] [PULL] gvt-next
@ 2020-11-23 9:05 Zhenyu Wang
2020-11-23 9:32 ` Joonas Lahtinen
0 siblings, 1 reply; 49+ messages in thread
From: Zhenyu Wang @ 2020-11-23 9:05 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Vivi, Rodrigo
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
[-- Attachment #1.1: Type: text/plain, Size: 2454 bytes --]
Hi,
Here's gvt next pull for v5.11. Mostly it's for host suspend/resume
fix with vGPU active and with some other enhancement as details below.
Note that this includes some minor i915 driver change to add gvt hook
in suspend/resume function which has been sent and reviewed on
intel-gfx list.
I just generated against drm-intel-next-queued-2020-11-03 which this
tree bases on now. Let me know if there's any issue in merge.
Thanks
--
The following changes since commit 139caf7ca2866cd0a45814ff938cb0c33920a266:
drm/i915: Update DRIVER_DATE to 20201103 (2020-11-03 14:21:25 +0200)
are available in the Git repository at:
https://github.com/intel/gvt-linux tags/gvt-next-2020-11-23
for you to fetch changes up to 9a3a238b3de97b4210c6de66aa88b2d7021ac086:
drm/i915/gvt: treat intel_gvt_mpt as const in gvt code (2020-11-23 17:14:20 +0800)
----------------------------------------------------------------
gvt-next-2020-11-23
- Fix host suspend/resume with vGPU (Colin)
- optimize idr init (Varma)
- Change intel_gvt_mpt as const (Julian)
- One comment error fix (Yan)
----------------------------------------------------------------
Colin Xu (3):
drm/i915/gvt: Save/restore HW status to support GVT suspend/resume
drm/i915: Add GVT resume routine to i915
drm/i915/gvt: Fix virtual display setup for BXT/APL
Deepak R Varma (1):
drm/i915/gvt: replace idr_init() by idr_init_base()
Julian Stecklina (1):
drm/i915/gvt: treat intel_gvt_mpt as const in gvt code
Yan Zhao (1):
drm/i915/gvt: correct a false comment of flag F_UNALIGN
drivers/gpu/drm/i915/gvt/display.c | 179 ++++++++++++++++++++++++++++++++++++
drivers/gpu/drm/i915/gvt/gtt.c | 64 +++++++++++++
drivers/gpu/drm/i915/gvt/gtt.h | 4 +
drivers/gpu/drm/i915/gvt/gvt.c | 13 ++-
drivers/gpu/drm/i915/gvt/gvt.h | 7 +-
drivers/gpu/drm/i915/gvt/handlers.c | 44 ++++++++-
drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
drivers/gpu/drm/i915/gvt/mmio.c | 5 +
drivers/gpu/drm/i915/gvt/mmio.h | 4 +
drivers/gpu/drm/i915/gvt/mpt.h | 2 +-
drivers/gpu/drm/i915/gvt/vgpu.c | 2 +-
drivers/gpu/drm/i915/i915_drv.c | 2 +
drivers/gpu/drm/i915/intel_gvt.c | 15 +++
drivers/gpu/drm/i915/intel_gvt.h | 5 +
14 files changed, 338 insertions(+), 10 deletions(-)
--
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2020-11-23 9:05 Zhenyu Wang
@ 2020-11-23 9:32 ` Joonas Lahtinen
2020-11-24 3:13 ` Zhenyu Wang
0 siblings, 1 reply; 49+ messages in thread
From: Joonas Lahtinen @ 2020-11-23 9:32 UTC (permalink / raw)
To: Vivi, Rodrigo, Jani Nikula, Zhenyu Wang
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
Quoting Zhenyu Wang (2020-11-23 11:05:17)
>
> Hi,
>
> Here's gvt next pull for v5.11. Mostly it's for host suspend/resume
> fix with vGPU active and with some other enhancement as details below.
> Note that this includes some minor i915 driver change to add gvt hook
> in suspend/resume function which has been sent and reviewed on
> intel-gfx list.
>
> I just generated against drm-intel-next-queued-2020-11-03 which this
> tree bases on now. Let me know if there's any issue in merge.
Sometimes GVT changes are paired with changes related the i915 side
to adjust the running virtual clients. The changes are more often
related to GT side, but there's also been display related changes.
Going forward, would we want to continue to apply gvt-next to
drm-intel-next (-queued is planned to be deprecated) or
should we use drm-intel-gt-next?
Or should we always strictly apply the GVT changes to drm-intel-next,
and then any related i915 changes to drm-intel-next or drm-intel-gt-next
depending on which one they are related to?
Regards, Joonas
> Thanks
> --
> The following changes since commit 139caf7ca2866cd0a45814ff938cb0c33920a266:
>
> drm/i915: Update DRIVER_DATE to 20201103 (2020-11-03 14:21:25 +0200)
>
> are available in the Git repository at:
>
> https://github.com/intel/gvt-linux tags/gvt-next-2020-11-23
>
> for you to fetch changes up to 9a3a238b3de97b4210c6de66aa88b2d7021ac086:
>
> drm/i915/gvt: treat intel_gvt_mpt as const in gvt code (2020-11-23 17:14:20 +0800)
>
> ----------------------------------------------------------------
> gvt-next-2020-11-23
>
> - Fix host suspend/resume with vGPU (Colin)
> - optimize idr init (Varma)
> - Change intel_gvt_mpt as const (Julian)
> - One comment error fix (Yan)
>
> ----------------------------------------------------------------
> Colin Xu (3):
> drm/i915/gvt: Save/restore HW status to support GVT suspend/resume
> drm/i915: Add GVT resume routine to i915
> drm/i915/gvt: Fix virtual display setup for BXT/APL
>
> Deepak R Varma (1):
> drm/i915/gvt: replace idr_init() by idr_init_base()
>
> Julian Stecklina (1):
> drm/i915/gvt: treat intel_gvt_mpt as const in gvt code
>
> Yan Zhao (1):
> drm/i915/gvt: correct a false comment of flag F_UNALIGN
>
> drivers/gpu/drm/i915/gvt/display.c | 179 ++++++++++++++++++++++++++++++++++++
> drivers/gpu/drm/i915/gvt/gtt.c | 64 +++++++++++++
> drivers/gpu/drm/i915/gvt/gtt.h | 4 +
> drivers/gpu/drm/i915/gvt/gvt.c | 13 ++-
> drivers/gpu/drm/i915/gvt/gvt.h | 7 +-
> drivers/gpu/drm/i915/gvt/handlers.c | 44 ++++++++-
> drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
> drivers/gpu/drm/i915/gvt/mmio.c | 5 +
> drivers/gpu/drm/i915/gvt/mmio.h | 4 +
> drivers/gpu/drm/i915/gvt/mpt.h | 2 +-
> drivers/gpu/drm/i915/gvt/vgpu.c | 2 +-
> drivers/gpu/drm/i915/i915_drv.c | 2 +
> drivers/gpu/drm/i915/intel_gvt.c | 15 +++
> drivers/gpu/drm/i915/intel_gvt.h | 5 +
> 14 files changed, 338 insertions(+), 10 deletions(-)
>
> --
>
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2020-11-23 9:32 ` Joonas Lahtinen
@ 2020-11-24 3:13 ` Zhenyu Wang
2020-11-24 9:48 ` Jani Nikula
2020-11-27 13:26 ` Joonas Lahtinen
0 siblings, 2 replies; 49+ messages in thread
From: Zhenyu Wang @ 2020-11-24 3:13 UTC (permalink / raw)
To: Joonas Lahtinen
Cc: Jani Nikula, intel-gfx, Yuan, Hang, Lv, Zhiyuan, intel-gvt-dev
[-- Attachment #1.1: Type: text/plain, Size: 4179 bytes --]
On 2020.11.23 11:32:38 +0200, Joonas Lahtinen wrote:
> Quoting Zhenyu Wang (2020-11-23 11:05:17)
> >
> > Hi,
> >
> > Here's gvt next pull for v5.11. Mostly it's for host suspend/resume
> > fix with vGPU active and with some other enhancement as details below.
> > Note that this includes some minor i915 driver change to add gvt hook
> > in suspend/resume function which has been sent and reviewed on
> > intel-gfx list.
> >
> > I just generated against drm-intel-next-queued-2020-11-03 which this
> > tree bases on now. Let me know if there's any issue in merge.
>
> Sometimes GVT changes are paired with changes related the i915 side
> to adjust the running virtual clients. The changes are more often
> related to GT side, but there's also been display related changes.
>
> Going forward, would we want to continue to apply gvt-next to
> drm-intel-next (-queued is planned to be deprecated) or
> should we use drm-intel-gt-next?
>
Is there any clear criteria on patches for -next or -gt-next now?
Something might be only gvt specific, e.g we'll have some enhancement patches
for guest context parse, this might be considered as 'gt' part? I'm not sure.
But yes, I hope we just stick with one, currently thinking drm-intel-next.
> Or should we always strictly apply the GVT changes to drm-intel-next,
> and then any related i915 changes to drm-intel-next or drm-intel-gt-next
> depending on which one they are related to?
>
How about basically we just apply to drm-intel-next, but there might be gvt
specific pull required for -gt-next e.g ww-lock fixes? I think we can do that way
now to see if there'll be any real issue popup.
Thanks
>
> > Thanks
> > --
> > The following changes since commit 139caf7ca2866cd0a45814ff938cb0c33920a266:
> >
> > drm/i915: Update DRIVER_DATE to 20201103 (2020-11-03 14:21:25 +0200)
> >
> > are available in the Git repository at:
> >
> > https://github.com/intel/gvt-linux tags/gvt-next-2020-11-23
> >
> > for you to fetch changes up to 9a3a238b3de97b4210c6de66aa88b2d7021ac086:
> >
> > drm/i915/gvt: treat intel_gvt_mpt as const in gvt code (2020-11-23 17:14:20 +0800)
> >
> > ----------------------------------------------------------------
> > gvt-next-2020-11-23
> >
> > - Fix host suspend/resume with vGPU (Colin)
> > - optimize idr init (Varma)
> > - Change intel_gvt_mpt as const (Julian)
> > - One comment error fix (Yan)
> >
> > ----------------------------------------------------------------
> > Colin Xu (3):
> > drm/i915/gvt: Save/restore HW status to support GVT suspend/resume
> > drm/i915: Add GVT resume routine to i915
> > drm/i915/gvt: Fix virtual display setup for BXT/APL
> >
> > Deepak R Varma (1):
> > drm/i915/gvt: replace idr_init() by idr_init_base()
> >
> > Julian Stecklina (1):
> > drm/i915/gvt: treat intel_gvt_mpt as const in gvt code
> >
> > Yan Zhao (1):
> > drm/i915/gvt: correct a false comment of flag F_UNALIGN
> >
> > drivers/gpu/drm/i915/gvt/display.c | 179 ++++++++++++++++++++++++++++++++++++
> > drivers/gpu/drm/i915/gvt/gtt.c | 64 +++++++++++++
> > drivers/gpu/drm/i915/gvt/gtt.h | 4 +
> > drivers/gpu/drm/i915/gvt/gvt.c | 13 ++-
> > drivers/gpu/drm/i915/gvt/gvt.h | 7 +-
> > drivers/gpu/drm/i915/gvt/handlers.c | 44 ++++++++-
> > drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
> > drivers/gpu/drm/i915/gvt/mmio.c | 5 +
> > drivers/gpu/drm/i915/gvt/mmio.h | 4 +
> > drivers/gpu/drm/i915/gvt/mpt.h | 2 +-
> > drivers/gpu/drm/i915/gvt/vgpu.c | 2 +-
> > drivers/gpu/drm/i915/i915_drv.c | 2 +
> > drivers/gpu/drm/i915/intel_gvt.c | 15 +++
> > drivers/gpu/drm/i915/intel_gvt.h | 5 +
> > 14 files changed, 338 insertions(+), 10 deletions(-)
> >
> > --
> >
> > $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
--
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2020-11-24 3:13 ` Zhenyu Wang
@ 2020-11-24 9:48 ` Jani Nikula
2020-11-27 13:26 ` Joonas Lahtinen
1 sibling, 0 replies; 49+ messages in thread
From: Jani Nikula @ 2020-11-24 9:48 UTC (permalink / raw)
To: Zhenyu Wang, Joonas Lahtinen
Cc: intel-gfx, Yuan, Hang, Lv, Zhiyuan, intel-gvt-dev
On Tue, 24 Nov 2020, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> On 2020.11.23 11:32:38 +0200, Joonas Lahtinen wrote:
>> Quoting Zhenyu Wang (2020-11-23 11:05:17)
>> >
>> > Hi,
>> >
>> > Here's gvt next pull for v5.11. Mostly it's for host suspend/resume
>> > fix with vGPU active and with some other enhancement as details below.
>> > Note that this includes some minor i915 driver change to add gvt hook
>> > in suspend/resume function which has been sent and reviewed on
>> > intel-gfx list.
>> >
>> > I just generated against drm-intel-next-queued-2020-11-03 which this
>> > tree bases on now. Let me know if there's any issue in merge.
>>
>> Sometimes GVT changes are paired with changes related the i915 side
>> to adjust the running virtual clients. The changes are more often
>> related to GT side, but there's also been display related changes.
>>
>> Going forward, would we want to continue to apply gvt-next to
>> drm-intel-next (-queued is planned to be deprecated) or
>> should we use drm-intel-gt-next?
>>
>
> Is there any clear criteria on patches for -next or -gt-next now?
> Something might be only gvt specific, e.g we'll have some enhancement patches
> for guest context parse, this might be considered as 'gt' part? I'm not sure.
> But yes, I hope we just stick with one, currently thinking drm-intel-next.
>
>> Or should we always strictly apply the GVT changes to drm-intel-next,
>> and then any related i915 changes to drm-intel-next or drm-intel-gt-next
>> depending on which one they are related to?
>>
>
> How about basically we just apply to drm-intel-next, but there might be gvt
> specific pull required for -gt-next e.g ww-lock fixes? I think we can do that way
> now to see if there'll be any real issue popup.
Pulled to drm-intel-next-queued now.
Thanks,
Jani.
>
> Thanks
>
>>
>> > Thanks
>> > --
>> > The following changes since commit 139caf7ca2866cd0a45814ff938cb0c33920a266:
>> >
>> > drm/i915: Update DRIVER_DATE to 20201103 (2020-11-03 14:21:25 +0200)
>> >
>> > are available in the Git repository at:
>> >
>> > https://github.com/intel/gvt-linux tags/gvt-next-2020-11-23
>> >
>> > for you to fetch changes up to 9a3a238b3de97b4210c6de66aa88b2d7021ac086:
>> >
>> > drm/i915/gvt: treat intel_gvt_mpt as const in gvt code (2020-11-23 17:14:20 +0800)
>> >
>> > ----------------------------------------------------------------
>> > gvt-next-2020-11-23
>> >
>> > - Fix host suspend/resume with vGPU (Colin)
>> > - optimize idr init (Varma)
>> > - Change intel_gvt_mpt as const (Julian)
>> > - One comment error fix (Yan)
>> >
>> > ----------------------------------------------------------------
>> > Colin Xu (3):
>> > drm/i915/gvt: Save/restore HW status to support GVT suspend/resume
>> > drm/i915: Add GVT resume routine to i915
>> > drm/i915/gvt: Fix virtual display setup for BXT/APL
>> >
>> > Deepak R Varma (1):
>> > drm/i915/gvt: replace idr_init() by idr_init_base()
>> >
>> > Julian Stecklina (1):
>> > drm/i915/gvt: treat intel_gvt_mpt as const in gvt code
>> >
>> > Yan Zhao (1):
>> > drm/i915/gvt: correct a false comment of flag F_UNALIGN
>> >
>> > drivers/gpu/drm/i915/gvt/display.c | 179 ++++++++++++++++++++++++++++++++++++
>> > drivers/gpu/drm/i915/gvt/gtt.c | 64 +++++++++++++
>> > drivers/gpu/drm/i915/gvt/gtt.h | 4 +
>> > drivers/gpu/drm/i915/gvt/gvt.c | 13 ++-
>> > drivers/gpu/drm/i915/gvt/gvt.h | 7 +-
>> > drivers/gpu/drm/i915/gvt/handlers.c | 44 ++++++++-
>> > drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
>> > drivers/gpu/drm/i915/gvt/mmio.c | 5 +
>> > drivers/gpu/drm/i915/gvt/mmio.h | 4 +
>> > drivers/gpu/drm/i915/gvt/mpt.h | 2 +-
>> > drivers/gpu/drm/i915/gvt/vgpu.c | 2 +-
>> > drivers/gpu/drm/i915/i915_drv.c | 2 +
>> > drivers/gpu/drm/i915/intel_gvt.c | 15 +++
>> > drivers/gpu/drm/i915/intel_gvt.h | 5 +
>> > 14 files changed, 338 insertions(+), 10 deletions(-)
>> >
>> > --
>> >
>> > $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
>> _______________________________________________
>> intel-gvt-dev mailing list
>> intel-gvt-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2020-11-24 3:13 ` Zhenyu Wang
2020-11-24 9:48 ` Jani Nikula
@ 2020-11-27 13:26 ` Joonas Lahtinen
1 sibling, 0 replies; 49+ messages in thread
From: Joonas Lahtinen @ 2020-11-27 13:26 UTC (permalink / raw)
To: Zhenyu Wang
Cc: Jani Nikula, intel-gfx, Yuan, Hang, Lv, Zhiyuan, intel-gvt-dev
Quoting Zhenyu Wang (2020-11-24 05:13:59)
> On 2020.11.23 11:32:38 +0200, Joonas Lahtinen wrote:
> > Quoting Zhenyu Wang (2020-11-23 11:05:17)
> > >
> > > Hi,
> > >
> > > Here's gvt next pull for v5.11. Mostly it's for host suspend/resume
> > > fix with vGPU active and with some other enhancement as details below.
> > > Note that this includes some minor i915 driver change to add gvt hook
> > > in suspend/resume function which has been sent and reviewed on
> > > intel-gfx list.
> > >
> > > I just generated against drm-intel-next-queued-2020-11-03 which this
> > > tree bases on now. Let me know if there's any issue in merge.
> >
> > Sometimes GVT changes are paired with changes related the i915 side
> > to adjust the running virtual clients. The changes are more often
> > related to GT side, but there's also been display related changes.
> >
> > Going forward, would we want to continue to apply gvt-next to
> > drm-intel-next (-queued is planned to be deprecated) or
> > should we use drm-intel-gt-next?
> >
>
> Is there any clear criteria on patches for -next or -gt-next now?
> Something might be only gvt specific, e.g we'll have some enhancement patches
> for guest context parse, this might be considered as 'gt' part? I'm not sure.
> But yes, I hope we just stick with one, currently thinking drm-intel-next.
For anything self-contained in gvt directory only, we can make a choice.
I think the patches that concern vgpu, have most often been around the GT
related code (opposed to display and PM).
That kind of makes me think we would get away with least amount of topic
branches and backmerges in the future if we also merged gvt-next to
drm-intel-gt-next. Thoughts?
That'd just mean a shift in timeline to send gvt-next latest early in -rc4
week.
Regards, Joonas
> > Or should we always strictly apply the GVT changes to drm-intel-next,
> > and then any related i915 changes to drm-intel-next or drm-intel-gt-next
> > depending on which one they are related to?
> >
>
> How about basically we just apply to drm-intel-next, but there might be gvt
> specific pull required for -gt-next e.g ww-lock fixes? I think we can do that way
> now to see if there'll be any real issue popup.
>
> Thanks
>
> >
> > > Thanks
> > > --
> > > The following changes since commit 139caf7ca2866cd0a45814ff938cb0c33920a266:
> > >
> > > drm/i915: Update DRIVER_DATE to 20201103 (2020-11-03 14:21:25 +0200)
> > >
> > > are available in the Git repository at:
> > >
> > > https://github.com/intel/gvt-linux tags/gvt-next-2020-11-23
> > >
> > > for you to fetch changes up to 9a3a238b3de97b4210c6de66aa88b2d7021ac086:
> > >
> > > drm/i915/gvt: treat intel_gvt_mpt as const in gvt code (2020-11-23 17:14:20 +0800)
> > >
> > > ----------------------------------------------------------------
> > > gvt-next-2020-11-23
> > >
> > > - Fix host suspend/resume with vGPU (Colin)
> > > - optimize idr init (Varma)
> > > - Change intel_gvt_mpt as const (Julian)
> > > - One comment error fix (Yan)
> > >
> > > ----------------------------------------------------------------
> > > Colin Xu (3):
> > > drm/i915/gvt: Save/restore HW status to support GVT suspend/resume
> > > drm/i915: Add GVT resume routine to i915
> > > drm/i915/gvt: Fix virtual display setup for BXT/APL
> > >
> > > Deepak R Varma (1):
> > > drm/i915/gvt: replace idr_init() by idr_init_base()
> > >
> > > Julian Stecklina (1):
> > > drm/i915/gvt: treat intel_gvt_mpt as const in gvt code
> > >
> > > Yan Zhao (1):
> > > drm/i915/gvt: correct a false comment of flag F_UNALIGN
> > >
> > > drivers/gpu/drm/i915/gvt/display.c | 179 ++++++++++++++++++++++++++++++++++++
> > > drivers/gpu/drm/i915/gvt/gtt.c | 64 +++++++++++++
> > > drivers/gpu/drm/i915/gvt/gtt.h | 4 +
> > > drivers/gpu/drm/i915/gvt/gvt.c | 13 ++-
> > > drivers/gpu/drm/i915/gvt/gvt.h | 7 +-
> > > drivers/gpu/drm/i915/gvt/handlers.c | 44 ++++++++-
> > > drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
> > > drivers/gpu/drm/i915/gvt/mmio.c | 5 +
> > > drivers/gpu/drm/i915/gvt/mmio.h | 4 +
> > > drivers/gpu/drm/i915/gvt/mpt.h | 2 +-
> > > drivers/gpu/drm/i915/gvt/vgpu.c | 2 +-
> > > drivers/gpu/drm/i915/i915_drv.c | 2 +
> > > drivers/gpu/drm/i915/intel_gvt.c | 15 +++
> > > drivers/gpu/drm/i915/intel_gvt.h | 5 +
> > > 14 files changed, 338 insertions(+), 10 deletions(-)
> > >
> > > --
> > >
> > > $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
> > _______________________________________________
> > intel-gvt-dev mailing list
> > intel-gvt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
>
> --
>
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* [Intel-gfx] [PULL] gvt-next
@ 2020-09-10 5:37 Zhenyu Wang
2020-09-11 23:58 ` Rodrigo Vivi
0 siblings, 1 reply; 49+ messages in thread
From: Zhenyu Wang @ 2020-09-10 5:37 UTC (permalink / raw)
To: Vivi, Rodrigo, Joonas Lahtinen, Jani Nikula
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
[-- Attachment #1.1: Type: text/plain, Size: 1878 bytes --]
Hi,
As we split pull request for 5.10 this time, here's gvt-next pull
for 5.10. For gvt ww lock fix, Zhi would send another pull based
on gem-next.
This includes current command access flag cleanup for
handlers which would be used for next refined cmd scan. And also
two more recent fixes on workaround cmd access and MIA reset state.
Thanks
--
The following changes since commit ced026e959bec5046afa310d6474e147b6294da2:
drm/i915: Update DRIVER_DATE to 20200824 (2020-08-24 14:26:38 -0400)
are available in the Git repository at:
https://github.com/intel/gvt-linux tags/gvt-next-2020-09-10
for you to fetch changes up to df398e33b8fd3ac28b3c7166de555e38d26e7391:
drm/i915/gvt: Init vreg GUC_STATUS to GS_MIA_IN_RESET (2020-09-10 13:49:05 +0800)
----------------------------------------------------------------
gvt-next-2020-09-10
- Cleanup command access flag (Yan)
- New workaround cmd access fix (Colin)
- MIA reset state fix (Colin)
----------------------------------------------------------------
Colin Xu (2):
drm/i915/gvt: Add F_CMD_ACCESS for some GEN9 SKU WA MMIO access
drm/i915/gvt: Init vreg GUC_STATUS to GS_MIA_IN_RESET
Yan Zhao (4):
drm/i915/gvt: rename F_IN_CTX flag to F_SR_IN_CTX
drm/i915/gvt: remove flag F_CMD_ACCESSED
drm/i915/gvt: add/modify interfaces for flag F_CMD_ACCESS
drm/i915/gvt: remove F_CMD_ACCESS flag for some registers
drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 ++---
drivers/gpu/drm/i915/gvt/gvt.h | 44 +++++++++++++++++++--------------
drivers/gpu/drm/i915/gvt/handlers.c | 32 +++++++++++++-----------
drivers/gpu/drm/i915/gvt/mmio.c | 3 +++
drivers/gpu/drm/i915/gvt/mmio_context.c | 2 +-
5 files changed, 49 insertions(+), 38 deletions(-)
--
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2020-09-10 5:37 Zhenyu Wang
@ 2020-09-11 23:58 ` Rodrigo Vivi
2020-09-14 2:34 ` Zhenyu Wang
0 siblings, 1 reply; 49+ messages in thread
From: Rodrigo Vivi @ 2020-09-11 23:58 UTC (permalink / raw)
To: Zhenyu Wang
Cc: Jani Nikula, intel-gfx, Yuan, Hang, Lv, Zhiyuan, intel-gvt-dev
On Thu, Sep 10, 2020 at 01:37:20PM +0800, Zhenyu Wang wrote:
>
> Hi,
>
> As we split pull request for 5.10 this time, here's gvt-next pull
> for 5.10. For gvt ww lock fix, Zhi would send another pull based
> on gem-next.
>
> This includes current command access flag cleanup for
> handlers which would be used for next refined cmd scan. And also
> two more recent fixes on workaround cmd access and MIA reset state.
>
> Thanks
> --
> The following changes since commit ced026e959bec5046afa310d6474e147b6294da2:
>
> drm/i915: Update DRIVER_DATE to 20200824 (2020-08-24 14:26:38 -0400)
>
> are available in the Git repository at:
>
> https://github.com/intel/gvt-linux tags/gvt-next-2020-09-10
This is a malformed pull request line which dim doesn't recognize.
Could you please regenerate it?
$ cat /tmp/gvt-next/cur/1599868544.259925_1.rdvivi-losangeles\:2\,S | dim apply-pull drm-intel-next-queued
dim: no pull request found
>
> for you to fetch changes up to df398e33b8fd3ac28b3c7166de555e38d26e7391:
>
> drm/i915/gvt: Init vreg GUC_STATUS to GS_MIA_IN_RESET (2020-09-10 13:49:05 +0800)
>
> ----------------------------------------------------------------
> gvt-next-2020-09-10
>
> - Cleanup command access flag (Yan)
> - New workaround cmd access fix (Colin)
> - MIA reset state fix (Colin)
>
> ----------------------------------------------------------------
> Colin Xu (2):
> drm/i915/gvt: Add F_CMD_ACCESS for some GEN9 SKU WA MMIO access
> drm/i915/gvt: Init vreg GUC_STATUS to GS_MIA_IN_RESET
>
> Yan Zhao (4):
> drm/i915/gvt: rename F_IN_CTX flag to F_SR_IN_CTX
> drm/i915/gvt: remove flag F_CMD_ACCESSED
> drm/i915/gvt: add/modify interfaces for flag F_CMD_ACCESS
> drm/i915/gvt: remove F_CMD_ACCESS flag for some registers
>
> drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 ++---
> drivers/gpu/drm/i915/gvt/gvt.h | 44 +++++++++++++++++++--------------
> drivers/gpu/drm/i915/gvt/handlers.c | 32 +++++++++++++-----------
> drivers/gpu/drm/i915/gvt/mmio.c | 3 +++
> drivers/gpu/drm/i915/gvt/mmio_context.c | 2 +-
> 5 files changed, 49 insertions(+), 38 deletions(-)
>
> --
>
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2020-09-11 23:58 ` Rodrigo Vivi
@ 2020-09-14 2:34 ` Zhenyu Wang
2020-09-14 18:39 ` Vivi, Rodrigo
0 siblings, 1 reply; 49+ messages in thread
From: Zhenyu Wang @ 2020-09-14 2:34 UTC (permalink / raw)
To: Rodrigo Vivi
Cc: Jani Nikula, intel-gfx, Yuan, Hang, Lv, Zhiyuan, intel-gvt-dev
[-- Attachment #1.1: Type: text/plain, Size: 2879 bytes --]
On 2020.09.11 19:58:25 -0400, Rodrigo Vivi wrote:
> On Thu, Sep 10, 2020 at 01:37:20PM +0800, Zhenyu Wang wrote:
> >
> > Hi,
> >
> > As we split pull request for 5.10 this time, here's gvt-next pull
> > for 5.10. For gvt ww lock fix, Zhi would send another pull based
> > on gem-next.
> >
> > This includes current command access flag cleanup for
> > handlers which would be used for next refined cmd scan. And also
> > two more recent fixes on workaround cmd access and MIA reset state.
> >
> > Thanks
> > --
> > The following changes since commit ced026e959bec5046afa310d6474e147b6294da2:
> >
> > drm/i915: Update DRIVER_DATE to 20200824 (2020-08-24 14:26:38 -0400)
> >
> > are available in the Git repository at:
> >
> > https://github.com/intel/gvt-linux tags/gvt-next-2020-09-10
>
> This is a malformed pull request line which dim doesn't recognize.
> Could you please regenerate it?
>
> $ cat /tmp/gvt-next/cur/1599868544.259925_1.rdvivi-losangeles\:2\,S | dim apply-pull drm-intel-next-queued
> dim: no pull request found
>
Hmm, strange, it pulls fine here when I tried this in local. I just copied in mutt and
cat /tmp/gvt-next.0910 | ./dim apply-pull drm-intel-next-queued
> >
> > for you to fetch changes up to df398e33b8fd3ac28b3c7166de555e38d26e7391:
> >
> > drm/i915/gvt: Init vreg GUC_STATUS to GS_MIA_IN_RESET (2020-09-10 13:49:05 +0800)
> >
> > ----------------------------------------------------------------
> > gvt-next-2020-09-10
> >
> > - Cleanup command access flag (Yan)
> > - New workaround cmd access fix (Colin)
> > - MIA reset state fix (Colin)
> >
> > ----------------------------------------------------------------
> > Colin Xu (2):
> > drm/i915/gvt: Add F_CMD_ACCESS for some GEN9 SKU WA MMIO access
> > drm/i915/gvt: Init vreg GUC_STATUS to GS_MIA_IN_RESET
> >
> > Yan Zhao (4):
> > drm/i915/gvt: rename F_IN_CTX flag to F_SR_IN_CTX
> > drm/i915/gvt: remove flag F_CMD_ACCESSED
> > drm/i915/gvt: add/modify interfaces for flag F_CMD_ACCESS
> > drm/i915/gvt: remove F_CMD_ACCESS flag for some registers
> >
> > drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 ++---
> > drivers/gpu/drm/i915/gvt/gvt.h | 44 +++++++++++++++++++--------------
> > drivers/gpu/drm/i915/gvt/handlers.c | 32 +++++++++++++-----------
> > drivers/gpu/drm/i915/gvt/mmio.c | 3 +++
> > drivers/gpu/drm/i915/gvt/mmio_context.c | 2 +-
> > 5 files changed, 49 insertions(+), 38 deletions(-)
> >
> > --
> >
> > $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
>
>
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
--
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2020-09-14 2:34 ` Zhenyu Wang
@ 2020-09-14 18:39 ` Vivi, Rodrigo
0 siblings, 0 replies; 49+ messages in thread
From: Vivi, Rodrigo @ 2020-09-14 18:39 UTC (permalink / raw)
To: Zhenyu Wang
Cc: Nikula, Jani, intel-gfx, dim-tools, Yuan, Hang, Lv, Zhiyuan,
intel-gvt-dev
> On Sep 13, 2020, at 7:34 PM, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
>
> On 2020.09.11 19:58:25 -0400, Rodrigo Vivi wrote:
>> On Thu, Sep 10, 2020 at 01:37:20PM +0800, Zhenyu Wang wrote:
>>>
>>> Hi,
>>>
>>> As we split pull request for 5.10 this time, here's gvt-next pull
>>> for 5.10. For gvt ww lock fix, Zhi would send another pull based
>>> on gem-next.
>>>
>>> This includes current command access flag cleanup for
>>> handlers which would be used for next refined cmd scan. And also
>>> two more recent fixes on workaround cmd access and MIA reset state.
>>>
>>> Thanks
>>> --
>>> The following changes since commit ced026e959bec5046afa310d6474e147b6294da2:
>>>
>>> drm/i915: Update DRIVER_DATE to 20200824 (2020-08-24 14:26:38 -0400)
>>>
>>> are available in the Git repository at:
>>>
>>> https://github.com/intel/gvt-linux tags/gvt-next-2020-09-10
>>
>> This is a malformed pull request line which dim doesn't recognize.
>> Could you please regenerate it?
>>
>> $ cat /tmp/gvt-next/cur/1599868544.259925_1.rdvivi-losangeles\:2\,S | dim apply-pull drm-intel-next-queued
>> dim: no pull request found
>>
>
> Hmm, strange, it pulls fine here when I tried this in local. I just copied in mutt and
> cat /tmp/gvt-next.0910 | ./dim apply-pull drm-intel-next-queued
sorry... it was dim's fault ;)
dim now accepts python3, but a function used on email parser doesn't work in
the same way...
pulled now, thanks
>
>>>
>>> for you to fetch changes up to df398e33b8fd3ac28b3c7166de555e38d26e7391:
>>>
>>> drm/i915/gvt: Init vreg GUC_STATUS to GS_MIA_IN_RESET (2020-09-10 13:49:05 +0800)
>>>
>>> ----------------------------------------------------------------
>>> gvt-next-2020-09-10
>>>
>>> - Cleanup command access flag (Yan)
>>> - New workaround cmd access fix (Colin)
>>> - MIA reset state fix (Colin)
>>>
>>> ----------------------------------------------------------------
>>> Colin Xu (2):
>>> drm/i915/gvt: Add F_CMD_ACCESS for some GEN9 SKU WA MMIO access
>>> drm/i915/gvt: Init vreg GUC_STATUS to GS_MIA_IN_RESET
>>>
>>> Yan Zhao (4):
>>> drm/i915/gvt: rename F_IN_CTX flag to F_SR_IN_CTX
>>> drm/i915/gvt: remove flag F_CMD_ACCESSED
>>> drm/i915/gvt: add/modify interfaces for flag F_CMD_ACCESS
>>> drm/i915/gvt: remove F_CMD_ACCESS flag for some registers
>>>
>>> drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 ++---
>>> drivers/gpu/drm/i915/gvt/gvt.h | 44 +++++++++++++++++++--------------
>>> drivers/gpu/drm/i915/gvt/handlers.c | 32 +++++++++++++-----------
>>> drivers/gpu/drm/i915/gvt/mmio.c | 3 +++
>>> drivers/gpu/drm/i915/gvt/mmio_context.c | 2 +-
>>> 5 files changed, 49 insertions(+), 38 deletions(-)
>>>
>>> --
>>>
>>> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
>>
>>
>> _______________________________________________
>> intel-gvt-dev mailing list
>> intel-gvt-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
>
> --
>
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* [Intel-gfx] [PULL] gvt-next
@ 2020-07-20 8:05 Zhenyu Wang
2020-07-21 11:04 ` Joonas Lahtinen
0 siblings, 1 reply; 49+ messages in thread
From: Zhenyu Wang @ 2020-07-20 8:05 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Vivi, Rodrigo
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
[-- Attachment #1.1: Type: text/plain, Size: 1540 bytes --]
Hi,
Sorry that this might be a bit late as last week our QA people were
busy on something else..So this is gvt changes queued for 5.9 which is
to improve guest suspend/resume with proper PCI PM state tracking for
resource handling, e.g ppgtt. Hopefully this could still be in queue
for 5.9.
Thanks
--
The following changes since commit d524b87f77364db096855d7eb714ffacec974ddf:
drm/i915: Update DRIVER_DATE to 20200702 (2020-07-02 21:25:28 +0300)
are available in the Git repository at:
https://github.com/intel/gvt-linux tags/gvt-next-2020-07-20
for you to fetch changes up to 02b5fc1527c0bb26a1012c6a806dc033f3b125a6:
drm/i915/gvt: Remove intel_vgpu_reset_gtt() since no one use it. (2020-07-14 16:42:14 +0800)
----------------------------------------------------------------
gvt-next-2020-07-20
- Improve guest suspend/resume handling (Colin)
----------------------------------------------------------------
Colin Xu (3):
drm/i915/gvt: Do not destroy ppgtt_mm during vGPU D3->D0.
drm/i915/gvt: Do not reset pv_notified when vGPU transit from D3->D0
drm/i915/gvt: Remove intel_vgpu_reset_gtt() since no one use it.
drivers/gpu/drm/i915/gvt/cfg_space.c | 24 ++++++++++++++++++++++++
drivers/gpu/drm/i915/gvt/gtt.c | 20 +-------------------
drivers/gpu/drm/i915/gvt/gtt.h | 3 ++-
drivers/gpu/drm/i915/gvt/gvt.h | 3 +++
drivers/gpu/drm/i915/gvt/vgpu.c | 20 +++++++++++++++++---
5 files changed, 47 insertions(+), 23 deletions(-)
--
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2020-07-20 8:05 Zhenyu Wang
@ 2020-07-21 11:04 ` Joonas Lahtinen
2020-07-22 0:42 ` Zhenyu Wang
0 siblings, 1 reply; 49+ messages in thread
From: Joonas Lahtinen @ 2020-07-21 11:04 UTC (permalink / raw)
To: Vivi, Rodrigo, Jani Nikula, Zhenyu Wang
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
Quoting Zhenyu Wang (2020-07-20 11:05:41)
>
> Hi,
>
> Sorry that this might be a bit late as last week our QA people were
> busy on something else..So this is gvt changes queued for 5.9 which is
> to improve guest suspend/resume with proper PCI PM state tracking for
> resource handling, e.g ppgtt. Hopefully this could still be in queue
> for 5.9.
Is this a regression fix to a problem introduced by previous
gvt-next PR targeting 5.9?
Or is it an incremental improvement over 5.8?
Regards, Joonas
>
> Thanks
> --
> The following changes since commit d524b87f77364db096855d7eb714ffacec974ddf:
>
> drm/i915: Update DRIVER_DATE to 20200702 (2020-07-02 21:25:28 +0300)
>
> are available in the Git repository at:
>
> https://github.com/intel/gvt-linux tags/gvt-next-2020-07-20
>
> for you to fetch changes up to 02b5fc1527c0bb26a1012c6a806dc033f3b125a6:
>
> drm/i915/gvt: Remove intel_vgpu_reset_gtt() since no one use it. (2020-07-14 16:42:14 +0800)
>
> ----------------------------------------------------------------
> gvt-next-2020-07-20
>
> - Improve guest suspend/resume handling (Colin)
>
> ----------------------------------------------------------------
> Colin Xu (3):
> drm/i915/gvt: Do not destroy ppgtt_mm during vGPU D3->D0.
> drm/i915/gvt: Do not reset pv_notified when vGPU transit from D3->D0
> drm/i915/gvt: Remove intel_vgpu_reset_gtt() since no one use it.
>
> drivers/gpu/drm/i915/gvt/cfg_space.c | 24 ++++++++++++++++++++++++
> drivers/gpu/drm/i915/gvt/gtt.c | 20 +-------------------
> drivers/gpu/drm/i915/gvt/gtt.h | 3 ++-
> drivers/gpu/drm/i915/gvt/gvt.h | 3 +++
> drivers/gpu/drm/i915/gvt/vgpu.c | 20 +++++++++++++++++---
> 5 files changed, 47 insertions(+), 23 deletions(-)
> --
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2020-07-21 11:04 ` Joonas Lahtinen
@ 2020-07-22 0:42 ` Zhenyu Wang
2020-07-27 16:39 ` Vivi, Rodrigo
0 siblings, 1 reply; 49+ messages in thread
From: Zhenyu Wang @ 2020-07-22 0:42 UTC (permalink / raw)
To: Joonas Lahtinen
Cc: Jani Nikula, intel-gfx, Yuan, Hang, Lv, Zhiyuan, intel-gvt-dev
[-- Attachment #1.1: Type: text/plain, Size: 2246 bytes --]
On 2020.07.21 14:04:41 +0300, Joonas Lahtinen wrote:
> Quoting Zhenyu Wang (2020-07-20 11:05:41)
> >
> > Hi,
> >
> > Sorry that this might be a bit late as last week our QA people were
> > busy on something else..So this is gvt changes queued for 5.9 which is
> > to improve guest suspend/resume with proper PCI PM state tracking for
> > resource handling, e.g ppgtt. Hopefully this could still be in queue
> > for 5.9.
>
> Is this a regression fix to a problem introduced by previous
> gvt-next PR targeting 5.9?
>
> Or is it an incremental improvement over 5.8?
>
Second case. This is incremental improvement. Guest suspend/resume
did work somehow before but has bad performance and possible failure
with some guest versions.
Thanks
>
> >
> > Thanks
> > --
> > The following changes since commit d524b87f77364db096855d7eb714ffacec974ddf:
> >
> > drm/i915: Update DRIVER_DATE to 20200702 (2020-07-02 21:25:28 +0300)
> >
> > are available in the Git repository at:
> >
> > https://github.com/intel/gvt-linux tags/gvt-next-2020-07-20
> >
> > for you to fetch changes up to 02b5fc1527c0bb26a1012c6a806dc033f3b125a6:
> >
> > drm/i915/gvt: Remove intel_vgpu_reset_gtt() since no one use it. (2020-07-14 16:42:14 +0800)
> >
> > ----------------------------------------------------------------
> > gvt-next-2020-07-20
> >
> > - Improve guest suspend/resume handling (Colin)
> >
> > ----------------------------------------------------------------
> > Colin Xu (3):
> > drm/i915/gvt: Do not destroy ppgtt_mm during vGPU D3->D0.
> > drm/i915/gvt: Do not reset pv_notified when vGPU transit from D3->D0
> > drm/i915/gvt: Remove intel_vgpu_reset_gtt() since no one use it.
> >
> > drivers/gpu/drm/i915/gvt/cfg_space.c | 24 ++++++++++++++++++++++++
> > drivers/gpu/drm/i915/gvt/gtt.c | 20 +-------------------
> > drivers/gpu/drm/i915/gvt/gtt.h | 3 ++-
> > drivers/gpu/drm/i915/gvt/gvt.h | 3 +++
> > drivers/gpu/drm/i915/gvt/vgpu.c | 20 +++++++++++++++++---
> > 5 files changed, 47 insertions(+), 23 deletions(-)
> > --
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2020-07-22 0:42 ` Zhenyu Wang
@ 2020-07-27 16:39 ` Vivi, Rodrigo
2020-07-28 3:18 ` Zhenyu Wang
0 siblings, 1 reply; 49+ messages in thread
From: Vivi, Rodrigo @ 2020-07-27 16:39 UTC (permalink / raw)
To: Zhenyu Wang
Cc: Nikula, Jani, intel-gfx, Yuan, Hang, Lv, Zhiyuan, intel-gvt-dev
> On Jul 21, 2020, at 5:42 PM, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
>
> On 2020.07.21 14:04:41 +0300, Joonas Lahtinen wrote:
>> Quoting Zhenyu Wang (2020-07-20 11:05:41)
>>>
>>> Hi,
>>>
>>> Sorry that this might be a bit late as last week our QA people were
>>> busy on something else..So this is gvt changes queued for 5.9 which is
>>> to improve guest suspend/resume with proper PCI PM state tracking for
>>> resource handling, e.g ppgtt. Hopefully this could still be in queue
>>> for 5.9.
>>
>> Is this a regression fix to a problem introduced by previous
>> gvt-next PR targeting 5.9?
>>
>> Or is it an incremental improvement over 5.8?
>>
>
> Second case. This is incremental improvement. Guest suspend/resume
> did work somehow before but has bad performance and possible failure
> with some guest versions.
I'm afraid Jani already sent the last pull request towards 5.9.
So if there are fixes inside this pull request this should move to the -next-fixes
and the remaining improvements to another 5.10 pull request
Thanks,
Rodrigo.
>
> Thanks
>
>>
>>>
>>> Thanks
>>> --
>>> The following changes since commit d524b87f77364db096855d7eb714ffacec974ddf:
>>>
>>> drm/i915: Update DRIVER_DATE to 20200702 (2020-07-02 21:25:28 +0300)
>>>
>>> are available in the Git repository at:
>>>
>>> https://github.com/intel/gvt-linux tags/gvt-next-2020-07-20
>>>
>>> for you to fetch changes up to 02b5fc1527c0bb26a1012c6a806dc033f3b125a6:
>>>
>>> drm/i915/gvt: Remove intel_vgpu_reset_gtt() since no one use it. (2020-07-14 16:42:14 +0800)
>>>
>>> ----------------------------------------------------------------
>>> gvt-next-2020-07-20
>>>
>>> - Improve guest suspend/resume handling (Colin)
>>>
>>> ----------------------------------------------------------------
>>> Colin Xu (3):
>>> drm/i915/gvt: Do not destroy ppgtt_mm during vGPU D3->D0.
>>> drm/i915/gvt: Do not reset pv_notified when vGPU transit from D3->D0
>>> drm/i915/gvt: Remove intel_vgpu_reset_gtt() since no one use it.
>>>
>>> drivers/gpu/drm/i915/gvt/cfg_space.c | 24 ++++++++++++++++++++++++
>>> drivers/gpu/drm/i915/gvt/gtt.c | 20 +-------------------
>>> drivers/gpu/drm/i915/gvt/gtt.h | 3 ++-
>>> drivers/gpu/drm/i915/gvt/gvt.h | 3 +++
>>> drivers/gpu/drm/i915/gvt/vgpu.c | 20 +++++++++++++++++---
>>> 5 files changed, 47 insertions(+), 23 deletions(-)
>>> --
>
> --
> Open Source Technology Center, Intel ltd.
>
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2020-07-27 16:39 ` Vivi, Rodrigo
@ 2020-07-28 3:18 ` Zhenyu Wang
0 siblings, 0 replies; 49+ messages in thread
From: Zhenyu Wang @ 2020-07-28 3:18 UTC (permalink / raw)
To: Vivi, Rodrigo
Cc: Nikula, Jani, intel-gfx, Yuan, Hang, Lv, Zhiyuan, intel-gvt-dev
[-- Attachment #1.1: Type: text/plain, Size: 1250 bytes --]
On 2020.07.27 16:39:58 +0000, Vivi, Rodrigo wrote:
>
>
> > On Jul 21, 2020, at 5:42 PM, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> >
> > On 2020.07.21 14:04:41 +0300, Joonas Lahtinen wrote:
> >> Quoting Zhenyu Wang (2020-07-20 11:05:41)
> >>>
> >>> Hi,
> >>>
> >>> Sorry that this might be a bit late as last week our QA people were
> >>> busy on something else..So this is gvt changes queued for 5.9 which is
> >>> to improve guest suspend/resume with proper PCI PM state tracking for
> >>> resource handling, e.g ppgtt. Hopefully this could still be in queue
> >>> for 5.9.
> >>
> >> Is this a regression fix to a problem introduced by previous
> >> gvt-next PR targeting 5.9?
> >>
> >> Or is it an incremental improvement over 5.8?
> >>
> >
> > Second case. This is incremental improvement. Guest suspend/resume
> > did work somehow before but has bad performance and possible failure
> > with some guest versions.
>
> I'm afraid Jani already sent the last pull request towards 5.9.
> So if there are fixes inside this pull request this should move to the -next-fixes
>
> and the remaining improvements to another 5.10 pull request
>
Got it. I'll split out those fixes for another pull.
Thanks
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* [Intel-gfx] [PULL] gvt-next
@ 2020-05-12 9:40 Zhenyu Wang
2020-05-14 16:04 ` Joonas Lahtinen
0 siblings, 1 reply; 49+ messages in thread
From: Zhenyu Wang @ 2020-05-12 9:40 UTC (permalink / raw)
To: Joonas Lahtinen, Vivi, Rodrigo, Jani Nikula
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
[-- Attachment #1.1: Type: text/plain, Size: 1738 bytes --]
Hi,
This includes support for ppgtt update by LRI command which gvt
replaces by shadow ppgtt, another small optimization for shadow
ctx and one workload destroy cleanup.
Thanks
--
The following changes since commit fb55c735522352704c35d899d0b253453cf0e799:
drm/i915/gvt: skip populate shadow context if guest context not changed (2020-04-17 17:31:22 +0800)
are available in the Git repository at:
https://github.com/intel/gvt-linux tags/gvt-next-2020-05-12
for you to fetch changes up to 47e51832ae93534d872511ba557115722582d94c:
drm/i915/gvt: use context lrc_reg_state for shadow ppgtt override (2020-05-08 12:37:14 +0800)
----------------------------------------------------------------
gvt-next-2020-05-12
- Support PPGTT update via LRI cmd (Zhenyu)
- Remove extra kmap for shadow ctx update (Zhenyu)
- Move workload cleanup out of execlist handling code (Zhenyu)
----------------------------------------------------------------
Zhenyu Wang (3):
drm/i915/gvt: move workload destroy out of execlist complete
drm/i915/gvt: Support PPGTT table load command
drm/i915/gvt: use context lrc_reg_state for shadow ppgtt override
drivers/gpu/drm/i915/gvt/cmd_parser.c | 45 +++++++++++++
drivers/gpu/drm/i915/gvt/execlist.c | 2 -
drivers/gpu/drm/i915/gvt/gtt.c | 1 +
drivers/gpu/drm/i915/gvt/gtt.h | 1 +
drivers/gpu/drm/i915/gvt/handlers.c | 2 +-
drivers/gpu/drm/i915/gvt/scheduler.c | 115 +++++++++++++++++++++++++++++++---
drivers/gpu/drm/i915/gvt/scheduler.h | 1 +
7 files changed, 155 insertions(+), 12 deletions(-)
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2020-05-12 9:40 Zhenyu Wang
@ 2020-05-14 16:04 ` Joonas Lahtinen
0 siblings, 0 replies; 49+ messages in thread
From: Joonas Lahtinen @ 2020-05-14 16:04 UTC (permalink / raw)
To: Vivi, Rodrigo, Jani Nikula, Zhenyu Wang
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
Quoting Zhenyu Wang (2020-05-12 12:40:17)
>
> Hi,
>
> This includes support for ppgtt update by LRI command which gvt
> replaces by shadow ppgtt, another small optimization for shadow
> ctx and one workload destroy cleanup.
This is now pulled. Thanks for the PR.
Regards, Joonas
>
> Thanks
> --
>
> The following changes since commit fb55c735522352704c35d899d0b253453cf0e799:
>
> drm/i915/gvt: skip populate shadow context if guest context not changed (2020-04-17 17:31:22 +0800)
>
> are available in the Git repository at:
>
> https://github.com/intel/gvt-linux tags/gvt-next-2020-05-12
>
> for you to fetch changes up to 47e51832ae93534d872511ba557115722582d94c:
>
> drm/i915/gvt: use context lrc_reg_state for shadow ppgtt override (2020-05-08 12:37:14 +0800)
>
> ----------------------------------------------------------------
> gvt-next-2020-05-12
>
> - Support PPGTT update via LRI cmd (Zhenyu)
> - Remove extra kmap for shadow ctx update (Zhenyu)
> - Move workload cleanup out of execlist handling code (Zhenyu)
>
> ----------------------------------------------------------------
> Zhenyu Wang (3):
> drm/i915/gvt: move workload destroy out of execlist complete
> drm/i915/gvt: Support PPGTT table load command
> drm/i915/gvt: use context lrc_reg_state for shadow ppgtt override
>
> drivers/gpu/drm/i915/gvt/cmd_parser.c | 45 +++++++++++++
> drivers/gpu/drm/i915/gvt/execlist.c | 2 -
> drivers/gpu/drm/i915/gvt/gtt.c | 1 +
> drivers/gpu/drm/i915/gvt/gtt.h | 1 +
> drivers/gpu/drm/i915/gvt/handlers.c | 2 +-
> drivers/gpu/drm/i915/gvt/scheduler.c | 115 +++++++++++++++++++++++++++++++---
> drivers/gpu/drm/i915/gvt/scheduler.h | 1 +
> 7 files changed, 155 insertions(+), 12 deletions(-)
>
> --
> Open Source Technology Center, Intel ltd.
>
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* [Intel-gfx] [PULL] gvt-next
@ 2020-04-22 5:12 Zhenyu Wang
2020-04-26 2:46 ` Zhenyu Wang
0 siblings, 1 reply; 49+ messages in thread
From: Zhenyu Wang @ 2020-04-22 5:12 UTC (permalink / raw)
To: Joonas Lahtinen, Vivi, Rodrigo, Jani Nikula
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
[-- Attachment #1.1: Type: text/plain, Size: 1700 bytes --]
Hi,
Here's current gvt-next. This removes left non-upstream xen support bits
which will be kept out of tree instead. And several guest context shadow
optimizations from Yan.
Thanks
--
The following changes since commit a61ac1e75105a077ec1efd6923ae3c619f862304:
drm/i915/gvt: Wean gvt off using dev_priv (2020-03-06 10:08:10 +0800)
are available in the Git repository at:
https://github.com/intel/gvt-linux tags/gvt-next-2020-04-22
for you to fetch changes up to fb55c735522352704c35d899d0b253453cf0e799:
drm/i915/gvt: skip populate shadow context if guest context not changed (2020-04-17 17:31:22 +0800)
----------------------------------------------------------------
gvt-next-2020-04-22
- remove non-upstream xen support bits (Christoph)
- guest context shadow copy optimization (Yan)
- guest context tracking for shadow skip optimization (Yan)
----------------------------------------------------------------
Christoph Hellwig (1):
i915/gvt: remove unused xen bits
Yan Zhao (3):
drm/i915/gvt: access shadow ctx via its virtual address directly
drm/i915/gvt: combine access to consecutive guest context pages
drm/i915/gvt: skip populate shadow context if guest context not changed
drivers/gpu/drm/i915/gvt/gtt.c | 15 +++++
drivers/gpu/drm/i915/gvt/gvt.c | 1 -
drivers/gpu/drm/i915/gvt/gvt.h | 5 ++
drivers/gpu/drm/i915/gvt/hypercall.h | 2 -
drivers/gpu/drm/i915/gvt/scheduler.c | 127 ++++++++++++++++++++++++++---------
5 files changed, 114 insertions(+), 36 deletions(-)
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2020-04-22 5:12 Zhenyu Wang
@ 2020-04-26 2:46 ` Zhenyu Wang
2020-04-30 12:38 ` Joonas Lahtinen
0 siblings, 1 reply; 49+ messages in thread
From: Zhenyu Wang @ 2020-04-26 2:46 UTC (permalink / raw)
To: Joonas Lahtinen, Jani Nikula, Vivi, Rodrigo
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
[-- Attachment #1.1: Type: text/plain, Size: 2169 bytes --]
On 2020.04.22 13:12:30 +0800, Zhenyu Wang wrote:
>
> Hi,
>
> Here's current gvt-next. This removes left non-upstream xen support bits
> which will be kept out of tree instead. And several guest context shadow
> optimizations from Yan.
>
> Thanks
> --
Ping for merge..
>
> The following changes since commit a61ac1e75105a077ec1efd6923ae3c619f862304:
>
> drm/i915/gvt: Wean gvt off using dev_priv (2020-03-06 10:08:10 +0800)
>
> are available in the Git repository at:
>
> https://github.com/intel/gvt-linux tags/gvt-next-2020-04-22
>
> for you to fetch changes up to fb55c735522352704c35d899d0b253453cf0e799:
>
> drm/i915/gvt: skip populate shadow context if guest context not changed (2020-04-17 17:31:22 +0800)
>
> ----------------------------------------------------------------
> gvt-next-2020-04-22
>
> - remove non-upstream xen support bits (Christoph)
> - guest context shadow copy optimization (Yan)
> - guest context tracking for shadow skip optimization (Yan)
>
> ----------------------------------------------------------------
> Christoph Hellwig (1):
> i915/gvt: remove unused xen bits
>
> Yan Zhao (3):
> drm/i915/gvt: access shadow ctx via its virtual address directly
> drm/i915/gvt: combine access to consecutive guest context pages
> drm/i915/gvt: skip populate shadow context if guest context not changed
>
> drivers/gpu/drm/i915/gvt/gtt.c | 15 +++++
> drivers/gpu/drm/i915/gvt/gvt.c | 1 -
> drivers/gpu/drm/i915/gvt/gvt.h | 5 ++
> drivers/gpu/drm/i915/gvt/hypercall.h | 2 -
> drivers/gpu/drm/i915/gvt/scheduler.c | 127 ++++++++++++++++++++++++++---------
> 5 files changed, 114 insertions(+), 36 deletions(-)
>
> --
> Open Source Technology Center, Intel ltd.
>
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2020-04-26 2:46 ` Zhenyu Wang
@ 2020-04-30 12:38 ` Joonas Lahtinen
0 siblings, 0 replies; 49+ messages in thread
From: Joonas Lahtinen @ 2020-04-30 12:38 UTC (permalink / raw)
To: Vivi, Rodrigo, Jani Nikula, Zhenyu Wang
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
Quoting Zhenyu Wang (2020-04-26 05:46:19)
> On 2020.04.22 13:12:30 +0800, Zhenyu Wang wrote:
> >
> > Hi,
> >
> > Here's current gvt-next. This removes left non-upstream xen support bits
> > which will be kept out of tree instead. And several guest context shadow
> > optimizations from Yan.
> >
> > Thanks
> > --
>
> Ping for merge..
Pulled now. Thanks for the PR.
Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* [Intel-gfx] [PULL] gvt-next
@ 2020-03-10 8:19 Zhenyu Wang
2020-03-10 22:50 ` Rodrigo Vivi
0 siblings, 1 reply; 49+ messages in thread
From: Zhenyu Wang @ 2020-03-10 8:19 UTC (permalink / raw)
To: Vivi, Rodrigo, Jani Nikula, Joonas Lahtinen
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
[-- Attachment #1.1: Type: text/plain, Size: 2835 bytes --]
Hi,
Here's more gvt change for -next. Mostly rebase and fix Chris's
cleanup on intel engine and dev_priv usage. And also one fix for CFL
after VFIO edid enabled in last gvt-next pull.
thanks
--
The following changes since commit a8bb49b64c4f4284fb36169bdd9fc6efd62eb26a:
drm/i915/gvt: Fix drm_WARN issue where vgpu ptr is unavailable (2020-02-25 16:13:04 +0800)
are available in the Git repository at:
https://github.com/intel/gvt-linux tags/gvt-next-2020-03-10
for you to fetch changes up to a61ac1e75105a077ec1efd6923ae3c619f862304:
drm/i915/gvt: Wean gvt off using dev_priv (2020-03-06 10:08:10 +0800)
----------------------------------------------------------------
gvt-next-2020-03-10
- Fix CFL dmabuf display after vfio edid enabling (Tina)
- Clean up scan non-priv batch debugfs entry (Chris)
- Use intel engines initialized in gvt, cleanup previous ring id (Chris)
- Use intel_gt instead (Chris)
----------------------------------------------------------------
Chris Wilson (3):
drm/i915/gvt: cleanup debugfs scan_nonprivbb
drm/i915/gvt: Wean gvt off dev_priv->engine[]
drm/i915/gvt: Wean gvt off using dev_priv
Tina Zhang (1):
drm/i915/gvt: Fix dma-buf display blur issue on CFL
drivers/gpu/drm/i915/gvt/aperture_gm.c | 84 ++++++-----
drivers/gpu/drm/i915/gvt/cfg_space.c | 8 +-
drivers/gpu/drm/i915/gvt/cmd_parser.c | 204 ++++++++++++--------------
drivers/gpu/drm/i915/gvt/debugfs.c | 45 +-----
drivers/gpu/drm/i915/gvt/display.c | 21 +--
drivers/gpu/drm/i915/gvt/dmabuf.c | 4 +-
drivers/gpu/drm/i915/gvt/edid.c | 16 +-
drivers/gpu/drm/i915/gvt/execlist.c | 103 +++++++------
drivers/gpu/drm/i915/gvt/execlist.h | 5 +-
drivers/gpu/drm/i915/gvt/fb_decoder.c | 6 +-
drivers/gpu/drm/i915/gvt/firmware.c | 16 +-
drivers/gpu/drm/i915/gvt/gtt.c | 50 +++----
drivers/gpu/drm/i915/gvt/gvt.c | 38 ++---
drivers/gpu/drm/i915/gvt/gvt.h | 25 ++--
drivers/gpu/drm/i915/gvt/handlers.c | 193 ++++++++++++-------------
drivers/gpu/drm/i915/gvt/interrupt.c | 14 +-
drivers/gpu/drm/i915/gvt/kvmgt.c | 10 +-
drivers/gpu/drm/i915/gvt/mmio.c | 6 +-
drivers/gpu/drm/i915/gvt/mmio.h | 4 +-
drivers/gpu/drm/i915/gvt/mmio_context.c | 127 ++++++++--------
drivers/gpu/drm/i915/gvt/mmio_context.h | 5 +-
drivers/gpu/drm/i915/gvt/sched_policy.c | 25 ++--
drivers/gpu/drm/i915/gvt/scheduler.c | 249 +++++++++++++++-----------------
drivers/gpu/drm/i915/gvt/scheduler.h | 9 +-
drivers/gpu/drm/i915/gvt/vgpu.c | 12 +-
25 files changed, 601 insertions(+), 678 deletions(-)
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2020-03-10 8:19 Zhenyu Wang
@ 2020-03-10 22:50 ` Rodrigo Vivi
0 siblings, 0 replies; 49+ messages in thread
From: Rodrigo Vivi @ 2020-03-10 22:50 UTC (permalink / raw)
To: Zhenyu Wang
Cc: Jani Nikula, intel-gfx, Yuan, Hang, Lv, Zhiyuan, intel-gvt-dev
On Tue, Mar 10, 2020 at 04:19:28PM +0800, Zhenyu Wang wrote:
>
> Hi,
>
> Here's more gvt change for -next. Mostly rebase and fix Chris's
> cleanup on intel engine and dev_priv usage. And also one fix for CFL
> after VFIO edid enabled in last gvt-next pull.
pulled to dinq,
Thanks,
Rodrigo.
>
> thanks
> --
> The following changes since commit a8bb49b64c4f4284fb36169bdd9fc6efd62eb26a:
>
> drm/i915/gvt: Fix drm_WARN issue where vgpu ptr is unavailable (2020-02-25 16:13:04 +0800)
>
> are available in the Git repository at:
>
> https://github.com/intel/gvt-linux tags/gvt-next-2020-03-10
>
> for you to fetch changes up to a61ac1e75105a077ec1efd6923ae3c619f862304:
>
> drm/i915/gvt: Wean gvt off using dev_priv (2020-03-06 10:08:10 +0800)
>
> ----------------------------------------------------------------
> gvt-next-2020-03-10
>
> - Fix CFL dmabuf display after vfio edid enabling (Tina)
> - Clean up scan non-priv batch debugfs entry (Chris)
> - Use intel engines initialized in gvt, cleanup previous ring id (Chris)
> - Use intel_gt instead (Chris)
>
> ----------------------------------------------------------------
> Chris Wilson (3):
> drm/i915/gvt: cleanup debugfs scan_nonprivbb
> drm/i915/gvt: Wean gvt off dev_priv->engine[]
> drm/i915/gvt: Wean gvt off using dev_priv
>
> Tina Zhang (1):
> drm/i915/gvt: Fix dma-buf display blur issue on CFL
>
> drivers/gpu/drm/i915/gvt/aperture_gm.c | 84 ++++++-----
> drivers/gpu/drm/i915/gvt/cfg_space.c | 8 +-
> drivers/gpu/drm/i915/gvt/cmd_parser.c | 204 ++++++++++++--------------
> drivers/gpu/drm/i915/gvt/debugfs.c | 45 +-----
> drivers/gpu/drm/i915/gvt/display.c | 21 +--
> drivers/gpu/drm/i915/gvt/dmabuf.c | 4 +-
> drivers/gpu/drm/i915/gvt/edid.c | 16 +-
> drivers/gpu/drm/i915/gvt/execlist.c | 103 +++++++------
> drivers/gpu/drm/i915/gvt/execlist.h | 5 +-
> drivers/gpu/drm/i915/gvt/fb_decoder.c | 6 +-
> drivers/gpu/drm/i915/gvt/firmware.c | 16 +-
> drivers/gpu/drm/i915/gvt/gtt.c | 50 +++----
> drivers/gpu/drm/i915/gvt/gvt.c | 38 ++---
> drivers/gpu/drm/i915/gvt/gvt.h | 25 ++--
> drivers/gpu/drm/i915/gvt/handlers.c | 193 ++++++++++++-------------
> drivers/gpu/drm/i915/gvt/interrupt.c | 14 +-
> drivers/gpu/drm/i915/gvt/kvmgt.c | 10 +-
> drivers/gpu/drm/i915/gvt/mmio.c | 6 +-
> drivers/gpu/drm/i915/gvt/mmio.h | 4 +-
> drivers/gpu/drm/i915/gvt/mmio_context.c | 127 ++++++++--------
> drivers/gpu/drm/i915/gvt/mmio_context.h | 5 +-
> drivers/gpu/drm/i915/gvt/sched_policy.c | 25 ++--
> drivers/gpu/drm/i915/gvt/scheduler.c | 249 +++++++++++++++-----------------
> drivers/gpu/drm/i915/gvt/scheduler.h | 9 +-
> drivers/gpu/drm/i915/gvt/vgpu.c | 12 +-
> 25 files changed, 601 insertions(+), 678 deletions(-)
>
> --
> Open Source Technology Center, Intel ltd.
>
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* [Intel-gfx] [PULL] gvt-next
@ 2020-02-26 10:38 Zhenyu Wang
2020-02-26 11:58 ` Jani Nikula
2020-02-26 23:10 ` Rodrigo Vivi
0 siblings, 2 replies; 49+ messages in thread
From: Zhenyu Wang @ 2020-02-26 10:38 UTC (permalink / raw)
To: Vivi, Rodrigo, Jani Nikula, Joonas Lahtinen
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
[-- Attachment #1.1: Type: text/plain, Size: 2644 bytes --]
Hi,
Here's gvt-next pull. Mostly for cleanup and kvmgt specific struct
has been moved to its own module, also enable VFIO edid for all platform
including CML. Pls see details below.
Thanks
--
The following changes since commit e24bcd34c1dd7dabde4a8546920537f7137e3c5f:
drm/i915/dp: Add all tiled and port sync conns to modeset (2020-02-20 13:55:02 +0530)
are available in the Git repository at:
https://github.com/intel/gvt-linux tags/gvt-next-2020-02-26
for you to fetch changes up to a8bb49b64c4f4284fb36169bdd9fc6efd62eb26a:
drm/i915/gvt: Fix drm_WARN issue where vgpu ptr is unavailable (2020-02-25 16:13:04 +0800)
----------------------------------------------------------------
gvt-next-2020-02-26
- Enable VFIO edid for all platform (Zhenyu)
- Code cleanup for attr group and unused vblank complete (Zhenyu, Julian)
- Make gvt oblivious of kvmgt data structures (Julian)
- Make WARN* drm specific (Pankaj)
----------------------------------------------------------------
Julian Stecklina (2):
drm/i915/gvt: remove unused vblank_done completion
drm/i915/gvt: make gvt oblivious of kvmgt data structures
Pankaj Bharadiya (2):
drm/i915/gvt: Make WARN* drm specific where drm_priv ptr is available
drm/i915/gvt: Make WARN* drm specific where vgpu ptr is available
Tina Zhang (1):
drm/i915/gvt: Fix drm_WARN issue where vgpu ptr is unavailable
Zhenyu Wang (3):
drm/i915/gvt: remove unused type attributes
drm/i915/gvt: Enable vfio edid for all GVT supported platform
Merge drm-intel-next-queued into gvt-next
drivers/gpu/drm/i915/gvt/aperture_gm.c | 6 +-
drivers/gpu/drm/i915/gvt/cfg_space.c | 23 ++-
drivers/gpu/drm/i915/gvt/cmd_parser.c | 4 +-
drivers/gpu/drm/i915/gvt/display.c | 6 +-
drivers/gpu/drm/i915/gvt/dmabuf.c | 4 +-
drivers/gpu/drm/i915/gvt/edid.c | 19 +-
drivers/gpu/drm/i915/gvt/gtt.c | 21 ++-
drivers/gpu/drm/i915/gvt/gvt.c | 8 +-
drivers/gpu/drm/i915/gvt/gvt.h | 37 +---
drivers/gpu/drm/i915/gvt/handlers.c | 22 ++-
drivers/gpu/drm/i915/gvt/interrupt.c | 15 +-
drivers/gpu/drm/i915/gvt/kvmgt.c | 303 +++++++++++++++++++-------------
drivers/gpu/drm/i915/gvt/mmio.c | 30 ++--
drivers/gpu/drm/i915/gvt/mmio_context.c | 6 +-
drivers/gpu/drm/i915/gvt/scheduler.c | 6 +-
drivers/gpu/drm/i915/gvt/vgpu.c | 10 +-
16 files changed, 304 insertions(+), 216 deletions(-)
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [Intel-gfx] [PULL] gvt-next
2020-02-26 10:38 Zhenyu Wang
@ 2020-02-26 11:58 ` Jani Nikula
2020-02-27 9:31 ` Zhenyu Wang
2020-02-26 23:10 ` Rodrigo Vivi
1 sibling, 1 reply; 49+ messages in thread
From: Jani Nikula @ 2020-02-26 11:58 UTC (permalink / raw)
To: Zhenyu Wang, Vivi, Rodrigo, Joonas Lahtinen
Cc: intel-gfx, intel-gvt-dev, Lv, Zhiyuan, Yuan, Hang
On Wed, 26 Feb 2020, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> Hi,
>
> Here's gvt-next pull. Mostly for cleanup and kvmgt specific struct
> has been moved to its own module, also enable VFIO edid for all platform
> including CML. Pls see details below.
What happened with [1]? Would've liked to see that moving forward.
BR,
Jani.
[1] http://patchwork.freedesktop.org/patch/msgid/20200117153554.3104278-1-chris@chris-wilson.co.uk
>
> Thanks
> --
> The following changes since commit e24bcd34c1dd7dabde4a8546920537f7137e3c5f:
>
> drm/i915/dp: Add all tiled and port sync conns to modeset (2020-02-20 13:55:02 +0530)
>
> are available in the Git repository at:
>
> https://github.com/intel/gvt-linux tags/gvt-next-2020-02-26
>
> for you to fetch changes up to a8bb49b64c4f4284fb36169bdd9fc6efd62eb26a:
>
> drm/i915/gvt: Fix drm_WARN issue where vgpu ptr is unavailable (2020-02-25 16:13:04 +0800)
>
> ----------------------------------------------------------------
> gvt-next-2020-02-26
>
> - Enable VFIO edid for all platform (Zhenyu)
> - Code cleanup for attr group and unused vblank complete (Zhenyu, Julian)
> - Make gvt oblivious of kvmgt data structures (Julian)
> - Make WARN* drm specific (Pankaj)
>
> ----------------------------------------------------------------
> Julian Stecklina (2):
> drm/i915/gvt: remove unused vblank_done completion
> drm/i915/gvt: make gvt oblivious of kvmgt data structures
>
> Pankaj Bharadiya (2):
> drm/i915/gvt: Make WARN* drm specific where drm_priv ptr is available
> drm/i915/gvt: Make WARN* drm specific where vgpu ptr is available
>
> Tina Zhang (1):
> drm/i915/gvt: Fix drm_WARN issue where vgpu ptr is unavailable
>
> Zhenyu Wang (3):
> drm/i915/gvt: remove unused type attributes
> drm/i915/gvt: Enable vfio edid for all GVT supported platform
> Merge drm-intel-next-queued into gvt-next
>
> drivers/gpu/drm/i915/gvt/aperture_gm.c | 6 +-
> drivers/gpu/drm/i915/gvt/cfg_space.c | 23 ++-
> drivers/gpu/drm/i915/gvt/cmd_parser.c | 4 +-
> drivers/gpu/drm/i915/gvt/display.c | 6 +-
> drivers/gpu/drm/i915/gvt/dmabuf.c | 4 +-
> drivers/gpu/drm/i915/gvt/edid.c | 19 +-
> drivers/gpu/drm/i915/gvt/gtt.c | 21 ++-
> drivers/gpu/drm/i915/gvt/gvt.c | 8 +-
> drivers/gpu/drm/i915/gvt/gvt.h | 37 +---
> drivers/gpu/drm/i915/gvt/handlers.c | 22 ++-
> drivers/gpu/drm/i915/gvt/interrupt.c | 15 +-
> drivers/gpu/drm/i915/gvt/kvmgt.c | 303 +++++++++++++++++++-------------
> drivers/gpu/drm/i915/gvt/mmio.c | 30 ++--
> drivers/gpu/drm/i915/gvt/mmio_context.c | 6 +-
> drivers/gpu/drm/i915/gvt/scheduler.c | 6 +-
> drivers/gpu/drm/i915/gvt/vgpu.c | 10 +-
> 16 files changed, 304 insertions(+), 216 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2020-02-26 11:58 ` Jani Nikula
@ 2020-02-27 9:31 ` Zhenyu Wang
0 siblings, 0 replies; 49+ messages in thread
From: Zhenyu Wang @ 2020-02-27 9:31 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, Yuan, Hang, Lv, Zhiyuan, intel-gvt-dev
[-- Attachment #1.1: Type: text/plain, Size: 3438 bytes --]
On 2020.02.26 13:58:32 +0200, Jani Nikula wrote:
> On Wed, 26 Feb 2020, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> > Hi,
> >
> > Here's gvt-next pull. Mostly for cleanup and kvmgt specific struct
> > has been moved to its own module, also enable VFIO edid for all platform
> > including CML. Pls see details below.
>
> What happened with [1]? Would've liked to see that moving forward.
>
>
> [1] http://patchwork.freedesktop.org/patch/msgid/20200117153554.3104278-1-chris@chris-wilson.co.uk
>
I just pinged Zhuocheng for who I asked to help on verifying that, but
looks still have problem to bring up and there're more warnings.. We'll
try to resolve it asap. Sorry for the delay.
> >
> > Thanks
> > --
> > The following changes since commit e24bcd34c1dd7dabde4a8546920537f7137e3c5f:
> >
> > drm/i915/dp: Add all tiled and port sync conns to modeset (2020-02-20 13:55:02 +0530)
> >
> > are available in the Git repository at:
> >
> > https://github.com/intel/gvt-linux tags/gvt-next-2020-02-26
> >
> > for you to fetch changes up to a8bb49b64c4f4284fb36169bdd9fc6efd62eb26a:
> >
> > drm/i915/gvt: Fix drm_WARN issue where vgpu ptr is unavailable (2020-02-25 16:13:04 +0800)
> >
> > ----------------------------------------------------------------
> > gvt-next-2020-02-26
> >
> > - Enable VFIO edid for all platform (Zhenyu)
> > - Code cleanup for attr group and unused vblank complete (Zhenyu, Julian)
> > - Make gvt oblivious of kvmgt data structures (Julian)
> > - Make WARN* drm specific (Pankaj)
> >
> > ----------------------------------------------------------------
> > Julian Stecklina (2):
> > drm/i915/gvt: remove unused vblank_done completion
> > drm/i915/gvt: make gvt oblivious of kvmgt data structures
> >
> > Pankaj Bharadiya (2):
> > drm/i915/gvt: Make WARN* drm specific where drm_priv ptr is available
> > drm/i915/gvt: Make WARN* drm specific where vgpu ptr is available
> >
> > Tina Zhang (1):
> > drm/i915/gvt: Fix drm_WARN issue where vgpu ptr is unavailable
> >
> > Zhenyu Wang (3):
> > drm/i915/gvt: remove unused type attributes
> > drm/i915/gvt: Enable vfio edid for all GVT supported platform
> > Merge drm-intel-next-queued into gvt-next
> >
> > drivers/gpu/drm/i915/gvt/aperture_gm.c | 6 +-
> > drivers/gpu/drm/i915/gvt/cfg_space.c | 23 ++-
> > drivers/gpu/drm/i915/gvt/cmd_parser.c | 4 +-
> > drivers/gpu/drm/i915/gvt/display.c | 6 +-
> > drivers/gpu/drm/i915/gvt/dmabuf.c | 4 +-
> > drivers/gpu/drm/i915/gvt/edid.c | 19 +-
> > drivers/gpu/drm/i915/gvt/gtt.c | 21 ++-
> > drivers/gpu/drm/i915/gvt/gvt.c | 8 +-
> > drivers/gpu/drm/i915/gvt/gvt.h | 37 +---
> > drivers/gpu/drm/i915/gvt/handlers.c | 22 ++-
> > drivers/gpu/drm/i915/gvt/interrupt.c | 15 +-
> > drivers/gpu/drm/i915/gvt/kvmgt.c | 303 +++++++++++++++++++-------------
> > drivers/gpu/drm/i915/gvt/mmio.c | 30 ++--
> > drivers/gpu/drm/i915/gvt/mmio_context.c | 6 +-
> > drivers/gpu/drm/i915/gvt/scheduler.c | 6 +-
> > drivers/gpu/drm/i915/gvt/vgpu.c | 10 +-
> > 16 files changed, 304 insertions(+), 216 deletions(-)
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [Intel-gfx] [PULL] gvt-next
2020-02-26 10:38 Zhenyu Wang
2020-02-26 11:58 ` Jani Nikula
@ 2020-02-26 23:10 ` Rodrigo Vivi
1 sibling, 0 replies; 49+ messages in thread
From: Rodrigo Vivi @ 2020-02-26 23:10 UTC (permalink / raw)
To: Zhenyu Wang
Cc: Jani Nikula, intel-gfx, Yuan, Hang, Lv, Zhiyuan, intel-gvt-dev
On Wed, Feb 26, 2020 at 06:38:40PM +0800, Zhenyu Wang wrote:
>
> Hi,
>
> Here's gvt-next pull. Mostly for cleanup and kvmgt specific struct
> has been moved to its own module, also enable VFIO edid for all platform
> including CML. Pls see details below.
pulled, thanks
>
> Thanks
> --
> The following changes since commit e24bcd34c1dd7dabde4a8546920537f7137e3c5f:
>
> drm/i915/dp: Add all tiled and port sync conns to modeset (2020-02-20 13:55:02 +0530)
>
> are available in the Git repository at:
>
> https://github.com/intel/gvt-linux tags/gvt-next-2020-02-26
>
> for you to fetch changes up to a8bb49b64c4f4284fb36169bdd9fc6efd62eb26a:
>
> drm/i915/gvt: Fix drm_WARN issue where vgpu ptr is unavailable (2020-02-25 16:13:04 +0800)
>
> ----------------------------------------------------------------
> gvt-next-2020-02-26
>
> - Enable VFIO edid for all platform (Zhenyu)
> - Code cleanup for attr group and unused vblank complete (Zhenyu, Julian)
> - Make gvt oblivious of kvmgt data structures (Julian)
> - Make WARN* drm specific (Pankaj)
>
> ----------------------------------------------------------------
> Julian Stecklina (2):
> drm/i915/gvt: remove unused vblank_done completion
> drm/i915/gvt: make gvt oblivious of kvmgt data structures
>
> Pankaj Bharadiya (2):
> drm/i915/gvt: Make WARN* drm specific where drm_priv ptr is available
> drm/i915/gvt: Make WARN* drm specific where vgpu ptr is available
>
> Tina Zhang (1):
> drm/i915/gvt: Fix drm_WARN issue where vgpu ptr is unavailable
>
> Zhenyu Wang (3):
> drm/i915/gvt: remove unused type attributes
> drm/i915/gvt: Enable vfio edid for all GVT supported platform
> Merge drm-intel-next-queued into gvt-next
>
> drivers/gpu/drm/i915/gvt/aperture_gm.c | 6 +-
> drivers/gpu/drm/i915/gvt/cfg_space.c | 23 ++-
> drivers/gpu/drm/i915/gvt/cmd_parser.c | 4 +-
> drivers/gpu/drm/i915/gvt/display.c | 6 +-
> drivers/gpu/drm/i915/gvt/dmabuf.c | 4 +-
> drivers/gpu/drm/i915/gvt/edid.c | 19 +-
> drivers/gpu/drm/i915/gvt/gtt.c | 21 ++-
> drivers/gpu/drm/i915/gvt/gvt.c | 8 +-
> drivers/gpu/drm/i915/gvt/gvt.h | 37 +---
> drivers/gpu/drm/i915/gvt/handlers.c | 22 ++-
> drivers/gpu/drm/i915/gvt/interrupt.c | 15 +-
> drivers/gpu/drm/i915/gvt/kvmgt.c | 303 +++++++++++++++++++-------------
> drivers/gpu/drm/i915/gvt/mmio.c | 30 ++--
> drivers/gpu/drm/i915/gvt/mmio_context.c | 6 +-
> drivers/gpu/drm/i915/gvt/scheduler.c | 6 +-
> drivers/gpu/drm/i915/gvt/vgpu.c | 10 +-
> 16 files changed, 304 insertions(+), 216 deletions(-)
>
>
> --
> Open Source Technology Center, Intel ltd.
>
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 49+ messages in thread
end of thread, other threads:[~2022-11-17 13:49 UTC | newest]
Thread overview: 49+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-11 8:59 [Intel-gfx] [PULL] gvt-next Zhenyu Wang
2022-11-15 15:36 ` Rodrigo Vivi
2022-11-17 3:02 ` Zhenyu Wang
2022-11-17 3:37 ` Vivi, Rodrigo
2022-11-17 5:28 ` Zhenyu Wang
2022-11-17 6:41 ` Zhenyu Wang
2022-11-17 13:49 ` Rodrigo Vivi
-- strict thread matches above, loose matches on Subject: below --
2022-04-26 7:58 Wang, Zhi A
2022-04-26 8:37 ` Jani Nikula
2022-04-26 8:38 ` Wang, Zhi A
2022-04-26 8:42 ` Wang, Zhi A
2022-04-26 11:52 ` Jason Gunthorpe
2022-04-28 21:35 ` Alex Williamson
2022-04-28 21:48 ` Alex Williamson
2022-04-26 15:53 ` Jason Gunthorpe
2022-04-26 16:58 ` Wang, Zhi A
2022-04-26 19:19 ` Robert Beckett
2022-04-20 8:04 Wang, Zhi A
2022-04-20 12:13 ` Jason Gunthorpe
2022-04-20 14:41 ` Wang, Zhi A
2022-04-20 15:02 ` Jason Gunthorpe
2022-04-20 16:13 ` Wang, Zhi A
2021-03-16 7:43 Zhenyu Wang
2021-03-16 11:52 ` Jani Nikula
2020-11-23 9:05 Zhenyu Wang
2020-11-23 9:32 ` Joonas Lahtinen
2020-11-24 3:13 ` Zhenyu Wang
2020-11-24 9:48 ` Jani Nikula
2020-11-27 13:26 ` Joonas Lahtinen
2020-09-10 5:37 Zhenyu Wang
2020-09-11 23:58 ` Rodrigo Vivi
2020-09-14 2:34 ` Zhenyu Wang
2020-09-14 18:39 ` Vivi, Rodrigo
2020-07-20 8:05 Zhenyu Wang
2020-07-21 11:04 ` Joonas Lahtinen
2020-07-22 0:42 ` Zhenyu Wang
2020-07-27 16:39 ` Vivi, Rodrigo
2020-07-28 3:18 ` Zhenyu Wang
2020-05-12 9:40 Zhenyu Wang
2020-05-14 16:04 ` Joonas Lahtinen
2020-04-22 5:12 Zhenyu Wang
2020-04-26 2:46 ` Zhenyu Wang
2020-04-30 12:38 ` Joonas Lahtinen
2020-03-10 8:19 Zhenyu Wang
2020-03-10 22:50 ` Rodrigo Vivi
2020-02-26 10:38 Zhenyu Wang
2020-02-26 11:58 ` Jani Nikula
2020-02-27 9:31 ` Zhenyu Wang
2020-02-26 23:10 ` Rodrigo Vivi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.