From: "Noralf Trønnes via B4 Submission Endpoint" <devnull+noralf.tronnes.org@kernel.org> To: "Thomas Zimmermann" <tzimmermann@suse.de>, "Javier Martinez Canillas" <javierm@redhat.com>, dri-devel@lists.freedesktop.org, "Maxime Ripard" <mripard@kernel.org>, stable@kernel.org, Noralf =?unknown-8bit?q?Tr=C3=B8nnes?= <noralf@tronnes.org> Subject: [PATCH v2 6/6] drm/gud: Enable synchronous flushing by default Date: Wed, 30 Nov 2022 20:26:54 +0100 [thread overview] Message-ID: <20221122-gud-shadow-plane-v2-6-435037990a83@tronnes.org> (raw) In-Reply-To: <20221122-gud-shadow-plane-v2-0-435037990a83@tronnes.org> From: Noralf Trønnes <noralf@tronnes.org> gud has a module parameter that controls whether framebuffer flushing happens synchronously during the commit or asynchronously in a worker. GNOME before version 3.38 handled all displays in the same rendering loop. This lead to gud slowing down the refresh rate for a faster monitor. This has now been fixed so lets change the default. The plan is to remove async flushing in the future. The code is now structured in a way that makes it easy to do this. Link: https://blogs.gnome.org/shell-dev/2020/07/02/splitting-up-the-frame-clock/ Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Noralf Trønnes <noralf@tronnes.org> --- drivers/gpu/drm/gud/gud_pipe.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/gud/gud_pipe.c b/drivers/gpu/drm/gud/gud_pipe.c index 92189474a7ed..62c43d3632d4 100644 --- a/drivers/gpu/drm/gud/gud_pipe.c +++ b/drivers/gpu/drm/gud/gud_pipe.c @@ -25,17 +25,13 @@ #include "gud_internal.h" /* - * Some userspace rendering loops runs all displays in the same loop. + * Some userspace rendering loops run all displays in the same loop. * This means that a fast display will have to wait for a slow one. - * For this reason gud does flushing asynchronous by default. - * The down side is that in e.g. a single display setup userspace thinks - * the display is insanely fast since the driver reports back immediately - * that the flush/pageflip is done. This wastes CPU and power. - * Such users might want to set this module parameter to false. + * Such users might want to enable this module parameter. */ -static bool gud_async_flush = true; +static bool gud_async_flush; module_param_named(async_flush, gud_async_flush, bool, 0644); -MODULE_PARM_DESC(async_flush, "Enable asynchronous flushing [default=true]"); +MODULE_PARM_DESC(async_flush, "Enable asynchronous flushing [default=0]"); /* * FIXME: The driver is probably broken on Big Endian machines. -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Noralf Trønnes <noralf@tronnes.org> To: Thomas Zimmermann <tzimmermann@suse.de>, Javier Martinez Canillas <javierm@redhat.com>, dri-devel@lists.freedesktop.org, Maxime Ripard <mripard@kernel.org>, stable@vger.kernel.org, Noralf Trønnes <noralf@tronnes.org> Subject: [PATCH v2 6/6] drm/gud: Enable synchronous flushing by default Date: Wed, 30 Nov 2022 20:26:54 +0100 [thread overview] Message-ID: <20221122-gud-shadow-plane-v2-6-435037990a83@tronnes.org> (raw) In-Reply-To: <20221122-gud-shadow-plane-v2-0-435037990a83@tronnes.org> gud has a module parameter that controls whether framebuffer flushing happens synchronously during the commit or asynchronously in a worker. GNOME before version 3.38 handled all displays in the same rendering loop. This lead to gud slowing down the refresh rate for a faster monitor. This has now been fixed so lets change the default. The plan is to remove async flushing in the future. The code is now structured in a way that makes it easy to do this. Link: https://blogs.gnome.org/shell-dev/2020/07/02/splitting-up-the-frame-clock/ Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Noralf Trønnes <noralf@tronnes.org> --- drivers/gpu/drm/gud/gud_pipe.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/gud/gud_pipe.c b/drivers/gpu/drm/gud/gud_pipe.c index 92189474a7ed..62c43d3632d4 100644 --- a/drivers/gpu/drm/gud/gud_pipe.c +++ b/drivers/gpu/drm/gud/gud_pipe.c @@ -25,17 +25,13 @@ #include "gud_internal.h" /* - * Some userspace rendering loops runs all displays in the same loop. + * Some userspace rendering loops run all displays in the same loop. * This means that a fast display will have to wait for a slow one. - * For this reason gud does flushing asynchronous by default. - * The down side is that in e.g. a single display setup userspace thinks - * the display is insanely fast since the driver reports back immediately - * that the flush/pageflip is done. This wastes CPU and power. - * Such users might want to set this module parameter to false. + * Such users might want to enable this module parameter. */ -static bool gud_async_flush = true; +static bool gud_async_flush; module_param_named(async_flush, gud_async_flush, bool, 0644); -MODULE_PARM_DESC(async_flush, "Enable asynchronous flushing [default=true]"); +MODULE_PARM_DESC(async_flush, "Enable asynchronous flushing [default=0]"); /* * FIXME: The driver is probably broken on Big Endian machines. -- 2.34.1
next prev parent reply other threads:[~2022-11-30 19:27 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-30 19:26 [PATCH v2 0/6] drm/gud: Use the shadow plane helper Noralf Trønnes via B4 Submission Endpoint 2022-11-30 19:26 ` Noralf Trønnes 2022-11-30 19:26 ` [PATCH v2 1/6] drm/gud: Fix UBSAN warning Noralf Trønnes via B4 Submission Endpoint 2022-11-30 19:26 ` Noralf Trønnes 2022-11-30 19:26 ` [PATCH v2 2/6] drm/gud: Don't retry a failed framebuffer flush Noralf Trønnes via B4 Submission Endpoint 2022-11-30 19:26 ` Noralf Trønnes 2022-11-30 19:26 ` [PATCH v2 3/6] drm/gud: Split up gud_flush_work() Noralf Trønnes via B4 Submission Endpoint 2022-11-30 19:26 ` Noralf Trønnes 2022-11-30 19:26 ` [PATCH v2 4/6] drm/gud: Prepare buffer for CPU access in gud_flush_work() Noralf Trønnes via B4 Submission Endpoint 2022-11-30 19:26 ` Noralf Trønnes 2022-12-01 8:51 ` Thomas Zimmermann 2022-11-30 19:26 ` [PATCH v2 5/6] drm/gud: Use the shadow plane helper Noralf Trønnes via B4 Submission Endpoint 2022-11-30 19:26 ` Noralf Trønnes 2022-12-01 8:55 ` Thomas Zimmermann 2022-11-30 19:26 ` Noralf Trønnes via B4 Submission Endpoint [this message] 2022-11-30 19:26 ` [PATCH v2 6/6] drm/gud: Enable synchronous flushing by default Noralf Trønnes 2022-12-01 8:57 ` Thomas Zimmermann 2022-12-01 5:55 ` [PATCH v2 0/6] drm/gud: Use the shadow plane helper Greg KH 2022-12-01 10:00 ` Noralf Trønnes 2022-12-01 10:00 ` Noralf Trønnes 2022-12-01 12:12 ` Greg KH 2022-12-01 12:12 ` Greg KH 2022-12-01 13:14 ` Noralf Trønnes 2022-12-01 13:14 ` Noralf Trønnes 2022-12-01 13:21 ` Greg KH 2022-12-01 13:21 ` Greg KH 2022-12-01 13:34 ` Javier Martinez Canillas 2022-12-01 13:34 ` Javier Martinez Canillas 2022-12-01 14:16 ` Konstantin Ryabitsev 2022-12-01 14:16 ` Konstantin Ryabitsev 2022-12-01 14:20 ` Javier Martinez Canillas 2022-12-01 14:20 ` Javier Martinez Canillas 2022-12-01 14:27 ` Vlastimil Babka 2022-12-01 14:27 ` Vlastimil Babka 2022-12-01 14:32 ` Mark Brown 2022-12-01 14:32 ` Mark Brown 2023-01-05 12:35 ` Daniel Vetter 2023-01-05 12:35 ` Daniel Vetter 2023-01-05 16:00 ` Konstantin Ryabitsev 2023-01-05 16:00 ` Konstantin Ryabitsev 2022-12-01 20:52 ` Noralf Trønnes 2022-12-01 20:52 ` Noralf Trønnes 2022-12-06 15:57 ` Noralf Trønnes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221122-gud-shadow-plane-v2-6-435037990a83@tronnes.org \ --to=devnull+noralf.tronnes.org@kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=javierm@redhat.com \ --cc=mripard@kernel.org \ --cc=noralf@tronnes.org \ --cc=stable@kernel.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.