From: Greg KH <gregkh@linuxfoundation.org> To: "Noralf Trønnes" <noralf@tronnes.org> Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>, Thomas Zimmermann <tzimmermann@suse.de>, Javier Martinez Canillas <javierm@redhat.com>, dri-devel@lists.freedesktop.org, Maxime Ripard <mripard@kernel.org>, stable@kernel.org, tools@linux.kernel.org Subject: Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper Date: Thu, 1 Dec 2022 13:12:40 +0100 [thread overview] Message-ID: <Y4iaODY6hMVNsfP1@kroah.com> (raw) In-Reply-To: <1cb40762-5f0a-1739-1670-155f59ec7110@tronnes.org> On Thu, Dec 01, 2022 at 11:00:44AM +0100, Noralf Trønnes wrote: > > > Den 01.12.2022 06.55, skrev Greg KH: > > On Wed, Nov 30, 2022 at 08:26:48PM +0100, Noralf Trønnes via B4 Submission Endpoint wrote: > >> Hi, > >> > >> I have started to look at igt for testing and want to use CRC tests. To > >> implement support for this I need to move away from the simple kms > >> helper. > >> > >> When looking around for examples I came across Thomas' nice shadow > >> helper and thought, yes this is perfect for drm/gud. So I'll switch to > >> that before I move away from the simple kms helper. > >> > >> The async framebuffer flushing code path now uses a shadow buffer and > >> doesn't touch the framebuffer when it shouldn't. I have also taken the > >> opportunity to inline the synchronous flush code path and make this the > >> default flushing stategy. > >> > >> Noralf. > >> > >> Cc: Maxime Ripard <mripard@kernel.org> > >> Cc: Thomas Zimmermann <tzimmermann@suse.de> > >> Cc: dri-devel@lists.freedesktop.org > >> Signed-off-by: Noralf Trønnes <noralf@tronnes.org> > >> > >> --- > >> Changes in v2: > >> - Drop patch (Thomas): > >> drm/gem: shadow_fb_access: Prepare imported buffers for CPU access > >> - Use src as variable name for iosys_map (Thomas) > >> - Prepare imported buffer for CPU access in the driver (Thomas) > >> - New patch: make sync flushing the default (Thomas) > >> - Link to v1: https://lore.kernel.org/r/20221122-gud-shadow-plane-v1-0-9de3afa3383e@tronnes.org > > > > <formletter> > > > > This is not the correct way to submit patches for inclusion in the > > stable kernel tree. Please read: > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > for how to do this properly. > > > > </formletter> > > Care to elaborate? > Is it because stable got the whole patchset and not just the one fix > patch that cc'ed stable? That is what triggered this, yes. > This patchset was sent using the b4 tool and I can't control this > aspect. Everyone mentioned in the patches gets the whole set. Fair enough, but watch out, bots will report this as being a problem as they can't always read through all patches in a series to notice this... thanks, greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org> To: "Noralf Trønnes" <noralf@tronnes.org> Cc: tools@linux.kernel.org, Javier Martinez Canillas <javierm@redhat.com>, dri-devel@lists.freedesktop.org, Thomas Zimmermann <tzimmermann@suse.de>, stable@kernel.org, Konstantin Ryabitsev <konstantin@linuxfoundation.org> Subject: Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper Date: Thu, 1 Dec 2022 13:12:40 +0100 [thread overview] Message-ID: <Y4iaODY6hMVNsfP1@kroah.com> (raw) In-Reply-To: <1cb40762-5f0a-1739-1670-155f59ec7110@tronnes.org> On Thu, Dec 01, 2022 at 11:00:44AM +0100, Noralf Trønnes wrote: > > > Den 01.12.2022 06.55, skrev Greg KH: > > On Wed, Nov 30, 2022 at 08:26:48PM +0100, Noralf Trønnes via B4 Submission Endpoint wrote: > >> Hi, > >> > >> I have started to look at igt for testing and want to use CRC tests. To > >> implement support for this I need to move away from the simple kms > >> helper. > >> > >> When looking around for examples I came across Thomas' nice shadow > >> helper and thought, yes this is perfect for drm/gud. So I'll switch to > >> that before I move away from the simple kms helper. > >> > >> The async framebuffer flushing code path now uses a shadow buffer and > >> doesn't touch the framebuffer when it shouldn't. I have also taken the > >> opportunity to inline the synchronous flush code path and make this the > >> default flushing stategy. > >> > >> Noralf. > >> > >> Cc: Maxime Ripard <mripard@kernel.org> > >> Cc: Thomas Zimmermann <tzimmermann@suse.de> > >> Cc: dri-devel@lists.freedesktop.org > >> Signed-off-by: Noralf Trønnes <noralf@tronnes.org> > >> > >> --- > >> Changes in v2: > >> - Drop patch (Thomas): > >> drm/gem: shadow_fb_access: Prepare imported buffers for CPU access > >> - Use src as variable name for iosys_map (Thomas) > >> - Prepare imported buffer for CPU access in the driver (Thomas) > >> - New patch: make sync flushing the default (Thomas) > >> - Link to v1: https://lore.kernel.org/r/20221122-gud-shadow-plane-v1-0-9de3afa3383e@tronnes.org > > > > <formletter> > > > > This is not the correct way to submit patches for inclusion in the > > stable kernel tree. Please read: > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > for how to do this properly. > > > > </formletter> > > Care to elaborate? > Is it because stable got the whole patchset and not just the one fix > patch that cc'ed stable? That is what triggered this, yes. > This patchset was sent using the b4 tool and I can't control this > aspect. Everyone mentioned in the patches gets the whole set. Fair enough, but watch out, bots will report this as being a problem as they can't always read through all patches in a series to notice this... thanks, greg k-h
next prev parent reply other threads:[~2022-12-01 12:12 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-30 19:26 [PATCH v2 0/6] drm/gud: Use the shadow plane helper Noralf Trønnes via B4 Submission Endpoint 2022-11-30 19:26 ` Noralf Trønnes 2022-11-30 19:26 ` [PATCH v2 1/6] drm/gud: Fix UBSAN warning Noralf Trønnes via B4 Submission Endpoint 2022-11-30 19:26 ` Noralf Trønnes 2022-11-30 19:26 ` [PATCH v2 2/6] drm/gud: Don't retry a failed framebuffer flush Noralf Trønnes via B4 Submission Endpoint 2022-11-30 19:26 ` Noralf Trønnes 2022-11-30 19:26 ` [PATCH v2 3/6] drm/gud: Split up gud_flush_work() Noralf Trønnes via B4 Submission Endpoint 2022-11-30 19:26 ` Noralf Trønnes 2022-11-30 19:26 ` [PATCH v2 4/6] drm/gud: Prepare buffer for CPU access in gud_flush_work() Noralf Trønnes via B4 Submission Endpoint 2022-11-30 19:26 ` Noralf Trønnes 2022-12-01 8:51 ` Thomas Zimmermann 2022-11-30 19:26 ` [PATCH v2 5/6] drm/gud: Use the shadow plane helper Noralf Trønnes via B4 Submission Endpoint 2022-11-30 19:26 ` Noralf Trønnes 2022-12-01 8:55 ` Thomas Zimmermann 2022-11-30 19:26 ` [PATCH v2 6/6] drm/gud: Enable synchronous flushing by default Noralf Trønnes via B4 Submission Endpoint 2022-11-30 19:26 ` Noralf Trønnes 2022-12-01 8:57 ` Thomas Zimmermann 2022-12-01 5:55 ` [PATCH v2 0/6] drm/gud: Use the shadow plane helper Greg KH 2022-12-01 10:00 ` Noralf Trønnes 2022-12-01 10:00 ` Noralf Trønnes 2022-12-01 12:12 ` Greg KH [this message] 2022-12-01 12:12 ` Greg KH 2022-12-01 13:14 ` Noralf Trønnes 2022-12-01 13:14 ` Noralf Trønnes 2022-12-01 13:21 ` Greg KH 2022-12-01 13:21 ` Greg KH 2022-12-01 13:34 ` Javier Martinez Canillas 2022-12-01 13:34 ` Javier Martinez Canillas 2022-12-01 14:16 ` Konstantin Ryabitsev 2022-12-01 14:16 ` Konstantin Ryabitsev 2022-12-01 14:20 ` Javier Martinez Canillas 2022-12-01 14:20 ` Javier Martinez Canillas 2022-12-01 14:27 ` Vlastimil Babka 2022-12-01 14:27 ` Vlastimil Babka 2022-12-01 14:32 ` Mark Brown 2022-12-01 14:32 ` Mark Brown 2023-01-05 12:35 ` Daniel Vetter 2023-01-05 12:35 ` Daniel Vetter 2023-01-05 16:00 ` Konstantin Ryabitsev 2023-01-05 16:00 ` Konstantin Ryabitsev 2022-12-01 20:52 ` Noralf Trønnes 2022-12-01 20:52 ` Noralf Trønnes 2022-12-06 15:57 ` Noralf Trønnes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y4iaODY6hMVNsfP1@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=javierm@redhat.com \ --cc=konstantin@linuxfoundation.org \ --cc=mripard@kernel.org \ --cc=noralf@tronnes.org \ --cc=stable@kernel.org \ --cc=tools@linux.kernel.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.