All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zev Weiss <zweiss@equinix.com>
To: Jammy Huang <jammy_huang@aspeedtech.com>
Cc: "eajames@linux.ibm.com" <eajames@linux.ibm.com>,
	"mchehab@kernel.org" <mchehab@kernel.org>,
	"joel@jms.id.au" <joel@jms.id.au>,
	"andrew@aj.id.au" <andrew@aj.id.au>,
	"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
	"zev@bewilderbeest.net" <zev@bewilderbeest.net>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: aspeed: Use v4l2_dbg to replace v4l2_warn to avoid log spam
Date: Tue, 22 Nov 2022 23:12:51 +0000	[thread overview]
Message-ID: <20221122231216.GF18848@packtop> (raw)
In-Reply-To: <20221110095611.522-1-jammy_huang@aspeedtech.com>

On Thu, Nov 10, 2022 at 01:56:11AM PST, Jammy Huang wrote:
>If the host is powered off, there will be many warning log. To avoid the
>log spam in this condition, replace v4l2_warn with v4l2_dbg.
>
>Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
>---
> drivers/media/platform/aspeed/aspeed-video.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>

Thanks Jammy -- after dropping the one hunk that wasn't applicable (due
to not having all the prerequisite patches) this definitely fixed the
log noise problems I'd been having.

I'm assuming the prerequisite patches are from your aspeed-jpeg support
patch series?  If so, since this is a smaller/simpler patch, I think it
might make sense to reorder things to try to get this merged first and
then fixing up that patchset to use v4l2_dbg() instead of v4l2_warn(),
rather than introducing a new instance of it and then patching it back
out later with this one.


Thanks,
Zev

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Zev Weiss <zweiss@equinix.com>
To: Jammy Huang <jammy_huang@aspeedtech.com>
Cc: "eajames@linux.ibm.com" <eajames@linux.ibm.com>,
	"mchehab@kernel.org" <mchehab@kernel.org>,
	"joel@jms.id.au" <joel@jms.id.au>,
	"andrew@aj.id.au" <andrew@aj.id.au>,
	"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
	"zev@bewilderbeest.net" <zev@bewilderbeest.net>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: aspeed: Use v4l2_dbg to replace v4l2_warn to avoid log spam
Date: Tue, 22 Nov 2022 23:12:51 +0000	[thread overview]
Message-ID: <20221122231216.GF18848@packtop> (raw)
In-Reply-To: <20221110095611.522-1-jammy_huang@aspeedtech.com>

On Thu, Nov 10, 2022 at 01:56:11AM PST, Jammy Huang wrote:
>If the host is powered off, there will be many warning log. To avoid the
>log spam in this condition, replace v4l2_warn with v4l2_dbg.
>
>Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
>---
> drivers/media/platform/aspeed/aspeed-video.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>

Thanks Jammy -- after dropping the one hunk that wasn't applicable (due
to not having all the prerequisite patches) this definitely fixed the
log noise problems I'd been having.

I'm assuming the prerequisite patches are from your aspeed-jpeg support
patch series?  If so, since this is a smaller/simpler patch, I think it
might make sense to reorder things to try to get this merged first and
then fixing up that patchset to use v4l2_dbg() instead of v4l2_warn(),
rather than introducing a new instance of it and then patching it back
out later with this one.


Thanks,
Zev

WARNING: multiple messages have this Message-ID (diff)
From: Zev Weiss <zweiss@equinix.com>
To: Jammy Huang <jammy_huang@aspeedtech.com>
Cc: "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"zev@bewilderbeest.net" <zev@bewilderbeest.net>,
	"andrew@aj.id.au" <andrew@aj.id.au>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	"eajames@linux.ibm.com" <eajames@linux.ibm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"joel@jms.id.au" <joel@jms.id.au>,
	"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
	"mchehab@kernel.org" <mchehab@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH] media: aspeed: Use v4l2_dbg to replace v4l2_warn to avoid log spam
Date: Tue, 22 Nov 2022 23:12:51 +0000	[thread overview]
Message-ID: <20221122231216.GF18848@packtop> (raw)
In-Reply-To: <20221110095611.522-1-jammy_huang@aspeedtech.com>

On Thu, Nov 10, 2022 at 01:56:11AM PST, Jammy Huang wrote:
>If the host is powered off, there will be many warning log. To avoid the
>log spam in this condition, replace v4l2_warn with v4l2_dbg.
>
>Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
>---
> drivers/media/platform/aspeed/aspeed-video.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>

Thanks Jammy -- after dropping the one hunk that wasn't applicable (due
to not having all the prerequisite patches) this definitely fixed the
log noise problems I'd been having.

I'm assuming the prerequisite patches are from your aspeed-jpeg support
patch series?  If so, since this is a smaller/simpler patch, I think it
might make sense to reorder things to try to get this merged first and
then fixing up that patchset to use v4l2_dbg() instead of v4l2_warn(),
rather than introducing a new instance of it and then patching it back
out later with this one.


Thanks,
Zev

  reply	other threads:[~2022-11-22 23:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10  9:56 [PATCH] media: aspeed: Use v4l2_dbg to replace v4l2_warn to avoid log spam Jammy Huang
2022-11-10  9:56 ` Jammy Huang
2022-11-22 23:12 ` Zev Weiss [this message]
2022-11-22 23:12   ` Zev Weiss
2022-11-22 23:12   ` Zev Weiss
2022-11-25  3:59   ` Jammy Huang
2022-11-25  3:59     ` Jammy Huang
2022-11-25  3:59     ` Jammy Huang
2022-11-23  8:08 ` Paul Menzel
2022-11-23  8:08   ` Paul Menzel
2022-11-23  8:08   ` Paul Menzel
2022-11-25  3:23   ` Jammy Huang
2022-11-25  3:23     ` Jammy Huang
2022-11-25  3:23     ` Jammy Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221122231216.GF18848@packtop \
    --to=zweiss@equinix.com \
    --cc=andrew@aj.id.au \
    --cc=eajames@linux.ibm.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=jammy_huang@aspeedtech.com \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=zev@bewilderbeest.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.