[PATCH] arm64: dts: qcom: msm8996-tone: Fix USB taking 6 minutes to wake up

[PATCH] arm64: dts: qcom: msm8996-tone: Fix USB taking 6 minutes to wake up

[Konrad Dybcio]

The hardware turns out to be pretty sluggish at assuming it can only
do USB2 with just a USB2 phy assigned to it - before it needed about
6 minutes to acknowledge that.

Limit it to USB-HS explicitly to make USB come up about 720x faster.

Fixes: 9da65e441d4d ("arm64: dts: qcom: Add support for SONY Xperia X Performance / XZ / XZs (msm8996, Tone platform)")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
No words.

 arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi b/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi
index 12a7b6d91dbe..0ab9687f3406 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi
@@ -991,10 +991,6 @@ touch_int_sleep: touch-int-sleep-state {
 	};
 };
 
-/*
- * For reasons that are currently unknown (but probably related to fusb301), USB takes about
- * 6 minutes to wake up (nothing interesting in kernel logs), but then it works as it should.
- */
 &usb3 {
 	status = "okay";
 	qcom,select-utmi-as-pipe-clk;
@@ -1003,6 +999,7 @@ &usb3 {
 &usb3_dwc3 {
 	extcon = <&usb3_id>;
 	dr_mode = "peripheral";
+	maximum-speed = "high-speed";
 	phys = <&hsusb_phy1>;
 	phy-names = "usb2-phy";
 	snps,hird-threshold = /bits/ 8 <0>;
-- 
2.38.1

Re: [PATCH] arm64: dts: qcom: msm8996-tone: Fix USB taking 6 minutes to wake up

[Neil Armstrong]

On 24/11/2022 23:01, Konrad Dybcio wrote:
> The hardware turns out to be pretty sluggish at assuming it can only
> do USB2 with just a USB2 phy assigned to it - before it needed about
> 6 minutes to acknowledge that.
> 
> Limit it to USB-HS explicitly to make USB come up about 720x faster.
> 
> Fixes: 9da65e441d4d ("arm64: dts: qcom: Add support for SONY Xperia X Performance / XZ / XZs (msm8996, Tone platform)")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> No words.
> 
>   arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi b/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi
> index 12a7b6d91dbe..0ab9687f3406 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi
> @@ -991,10 +991,6 @@ touch_int_sleep: touch-int-sleep-state {
>   	};
>   };
>   
> -/*
> - * For reasons that are currently unknown (but probably related to fusb301), USB takes about
> - * 6 minutes to wake up (nothing interesting in kernel logs), but then it works as it should.
> - */
>   &usb3 {
>   	status = "okay";
>   	qcom,select-utmi-as-pipe-clk;
> @@ -1003,6 +999,7 @@ &usb3 {
>   &usb3_dwc3 {
>   	extcon = <&usb3_id>;
>   	dr_mode = "peripheral";
> +	maximum-speed = "high-speed";
>   	phys = <&hsusb_phy1>;
>   	phy-names = "usb2-phy";
>   	snps,hird-threshold = /bits/ 8 <0>;


Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Re: [PATCH] arm64: dts: qcom: msm8996-tone: Fix USB taking 6 minutes to wake up

[Bjorn Andersson]

On Thu, 24 Nov 2022 23:01:47 +0100, Konrad Dybcio wrote:
> The hardware turns out to be pretty sluggish at assuming it can only
> do USB2 with just a USB2 phy assigned to it - before it needed about
> 6 minutes to acknowledge that.
> 
> Limit it to USB-HS explicitly to make USB come up about 720x faster.
> 
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: msm8996-tone: Fix USB taking 6 minutes to wake up
      commit: 43069b9cd358aebc692e654de91ee06ff66e26af

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>