* [PATCH-for-8.0] block/nbd: Add missing <qemu/bswap.h> include
@ 2022-11-25 17:53 Philippe Mathieu-Daudé
2022-11-25 21:13 ` Vladimir Sementsov-Ogievskiy
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-11-25 17:53 UTC (permalink / raw)
To: qemu-devel
Cc: Eric Blake, qemu-block, Kevin Wolf, Vladimir Sementsov-Ogievskiy,
qemu-trivial, Hanna Reitz, Philippe Mathieu-Daudé
The inlined nbd_readXX() functions call beXX_to_cpu(), themselves
declared in <qemu/bswap.h>. This fixes when refactoring:
In file included from ../../block/nbd.c:44:
include/block/nbd.h: In function 'nbd_read16':
include/block/nbd.h:383:12: error: implicit declaration of function 'be16_to_cpu' [-Werror=implicit-function-declaration]
383 | *val = be##bits##_to_cpu(*val); \
| ^~
include/block/nbd.h:387:1: note: in expansion of macro 'DEF_NBD_READ_N'
387 | DEF_NBD_READ_N(16) /* Defines nbd_read16(). */
| ^~~~~~~~~~~~~~
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/block/nbd.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/block/nbd.h b/include/block/nbd.h
index 4ede3b2bd0..a4c98169c3 100644
--- a/include/block/nbd.h
+++ b/include/block/nbd.h
@@ -24,6 +24,7 @@
#include "io/channel-socket.h"
#include "crypto/tlscreds.h"
#include "qapi/error.h"
+#include "qemu/bswap.h"
extern const BlockExportDriver blk_exp_nbd;
--
2.38.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH-for-8.0] block/nbd: Add missing <qemu/bswap.h> include
2022-11-25 17:53 [PATCH-for-8.0] block/nbd: Add missing <qemu/bswap.h> include Philippe Mathieu-Daudé
@ 2022-11-25 21:13 ` Vladimir Sementsov-Ogievskiy
2023-01-12 12:00 ` Philippe Mathieu-Daudé
2023-01-19 13:00 ` Kevin Wolf
2 siblings, 0 replies; 5+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2022-11-25 21:13 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Eric Blake, qemu-block, Kevin Wolf, qemu-trivial, Hanna Reitz
On 11/25/22 20:53, Philippe Mathieu-Daudé wrote:
> The inlined nbd_readXX() functions call beXX_to_cpu(), themselves
> declared in <qemu/bswap.h>. This fixes when refactoring:
>
> In file included from ../../block/nbd.c:44:
> include/block/nbd.h: In function 'nbd_read16':
> include/block/nbd.h:383:12: error: implicit declaration of function 'be16_to_cpu' [-Werror=implicit-function-declaration]
> 383 | *val = be##bits##_to_cpu(*val); \
> | ^~
> include/block/nbd.h:387:1: note: in expansion of macro 'DEF_NBD_READ_N'
> 387 | DEF_NBD_READ_N(16) /* Defines nbd_read16(). */
> | ^~~~~~~~~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
--
Best regards,
Vladimir
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH-for-8.0] block/nbd: Add missing <qemu/bswap.h> include
2022-11-25 17:53 [PATCH-for-8.0] block/nbd: Add missing <qemu/bswap.h> include Philippe Mathieu-Daudé
2022-11-25 21:13 ` Vladimir Sementsov-Ogievskiy
@ 2023-01-12 12:00 ` Philippe Mathieu-Daudé
2023-01-16 17:35 ` Laurent Vivier
2023-01-19 13:00 ` Kevin Wolf
2 siblings, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-01-12 12:00 UTC (permalink / raw)
To: qemu-devel
Cc: Eric Blake, qemu-block, Kevin Wolf, Vladimir Sementsov-Ogievskiy,
qemu-trivial, Hanna Reitz
Hi, can this reviewed patch get merged via a block tree?
On 25/11/22 18:53, Philippe Mathieu-Daudé wrote:
> The inlined nbd_readXX() functions call beXX_to_cpu(), themselves
> declared in <qemu/bswap.h>. This fixes when refactoring:
>
> In file included from ../../block/nbd.c:44:
> include/block/nbd.h: In function 'nbd_read16':
> include/block/nbd.h:383:12: error: implicit declaration of function 'be16_to_cpu' [-Werror=implicit-function-declaration]
> 383 | *val = be##bits##_to_cpu(*val); \
> | ^~
> include/block/nbd.h:387:1: note: in expansion of macro 'DEF_NBD_READ_N'
> 387 | DEF_NBD_READ_N(16) /* Defines nbd_read16(). */
> | ^~~~~~~~~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/block/nbd.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/block/nbd.h b/include/block/nbd.h
> index 4ede3b2bd0..a4c98169c3 100644
> --- a/include/block/nbd.h
> +++ b/include/block/nbd.h
> @@ -24,6 +24,7 @@
> #include "io/channel-socket.h"
> #include "crypto/tlscreds.h"
> #include "qapi/error.h"
> +#include "qemu/bswap.h"
>
> extern const BlockExportDriver blk_exp_nbd;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH-for-8.0] block/nbd: Add missing <qemu/bswap.h> include
2023-01-12 12:00 ` Philippe Mathieu-Daudé
@ 2023-01-16 17:35 ` Laurent Vivier
0 siblings, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2023-01-16 17:35 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Eric Blake, qemu-block, Kevin Wolf, Vladimir Sementsov-Ogievskiy,
qemu-trivial, Hanna Reitz
Le 12/01/2023 à 13:00, Philippe Mathieu-Daudé a écrit :
> Hi, can this reviewed patch get merged via a block tree?
I can take this via trivial.
Thanks,
Laurent
>
> On 25/11/22 18:53, Philippe Mathieu-Daudé wrote:
>> The inlined nbd_readXX() functions call beXX_to_cpu(), themselves
>> declared in <qemu/bswap.h>. This fixes when refactoring:
>>
>> In file included from ../../block/nbd.c:44:
>> include/block/nbd.h: In function 'nbd_read16':
>> include/block/nbd.h:383:12: error: implicit declaration of function 'be16_to_cpu'
>> [-Werror=implicit-function-declaration]
>> 383 | *val = be##bits##_to_cpu(*val); \
>> | ^~
>> include/block/nbd.h:387:1: note: in expansion of macro 'DEF_NBD_READ_N'
>> 387 | DEF_NBD_READ_N(16) /* Defines nbd_read16(). */
>> | ^~~~~~~~~~~~~~
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> include/block/nbd.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/block/nbd.h b/include/block/nbd.h
>> index 4ede3b2bd0..a4c98169c3 100644
>> --- a/include/block/nbd.h
>> +++ b/include/block/nbd.h
>> @@ -24,6 +24,7 @@
>> #include "io/channel-socket.h"
>> #include "crypto/tlscreds.h"
>> #include "qapi/error.h"
>> +#include "qemu/bswap.h"
>> extern const BlockExportDriver blk_exp_nbd;
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH-for-8.0] block/nbd: Add missing <qemu/bswap.h> include
2022-11-25 17:53 [PATCH-for-8.0] block/nbd: Add missing <qemu/bswap.h> include Philippe Mathieu-Daudé
2022-11-25 21:13 ` Vladimir Sementsov-Ogievskiy
2023-01-12 12:00 ` Philippe Mathieu-Daudé
@ 2023-01-19 13:00 ` Kevin Wolf
2 siblings, 0 replies; 5+ messages in thread
From: Kevin Wolf @ 2023-01-19 13:00 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-devel, Eric Blake, qemu-block, Vladimir Sementsov-Ogievskiy,
qemu-trivial, Hanna Reitz
Am 25.11.2022 um 18:53 hat Philippe Mathieu-Daudé geschrieben:
> The inlined nbd_readXX() functions call beXX_to_cpu(), themselves
> declared in <qemu/bswap.h>. This fixes when refactoring:
>
> In file included from ../../block/nbd.c:44:
> include/block/nbd.h: In function 'nbd_read16':
> include/block/nbd.h:383:12: error: implicit declaration of function 'be16_to_cpu' [-Werror=implicit-function-declaration]
> 383 | *val = be##bits##_to_cpu(*val); \
> | ^~
> include/block/nbd.h:387:1: note: in expansion of macro 'DEF_NBD_READ_N'
> 387 | DEF_NBD_READ_N(16) /* Defines nbd_read16(). */
> | ^~~~~~~~~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-19 13:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-25 17:53 [PATCH-for-8.0] block/nbd: Add missing <qemu/bswap.h> include Philippe Mathieu-Daudé
2022-11-25 21:13 ` Vladimir Sementsov-Ogievskiy
2023-01-12 12:00 ` Philippe Mathieu-Daudé
2023-01-16 17:35 ` Laurent Vivier
2023-01-19 13:00 ` Kevin Wolf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.