All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jagan Teki <jagan@amarulasolutions.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
	Inki Dae <inki.dae@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Fancy Fang <chen.fang@nxp.com>,
	Tim Harvey <tharvey@gateworks.com>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Adam Ford <aford173@gmail.com>,
	Neil Armstrong <narmstrong@linaro.org>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Tommaso Merciai <tommaso.merciai@amarulasolutions.com>,
	Marek Vasut <marex@denx.de>
Cc: Matteo Lisi <matteo.lisi@engicam.com>,
	dri-devel@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-amarula <linux-amarula@amarulasolutions.com>,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH v10 10/18] drm: exynos: dsi: Add input_bus_flags
Date: Wed, 14 Dec 2022 18:28:59 +0530	[thread overview]
Message-ID: <20221214125907.376148-11-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20221214125907.376148-1-jagan@amarulasolutions.com>

LCDIF-DSIM glue logic inverts the HS/VS/DE signals and expecting
the i.MX8M Mini/Nano DSI host to add additional Data Enable signal
active low (DE_LOW). This makes the valid data transfer on each
horizontal line.

So, add additional bus flags DE_LOW setting via input_bus_flags
for i.MX8M Mini/Nano platforms.

Suggested-by: Marek Vasut <marex@denx.de>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v10, v9:
- none
Changes for v8:
- add DE_LOW for i.MX8M Mini/Nano platforms.
Changes for v7, v6:
- none
Changes for v5:
- rebased based on updated bridge changes
Changes for v4 - v1:
- none

 drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 12a40576f937..36820a7b5884 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1692,6 +1692,10 @@ static const struct component_ops exynos_dsi_component_ops = {
 	.unbind	= exynos_dsi_unbind,
 };
 
+static const struct drm_bridge_timings dsim_bridge_timings_de_low = {
+	.input_bus_flags = DRM_BUS_FLAG_DE_LOW,
+};
+
 static int exynos_dsi_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
@@ -1778,6 +1782,10 @@ static int exynos_dsi_probe(struct platform_device *pdev)
 	dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;
 	dsi->bridge.pre_enable_prev_first = true;
 
+	/* DE_LOW: i.MX8M Mini/Nano LCDIF-DSIM glue logic inverts HS/VS/DE */
+	if (dsi->plat_data->hw_type == DSIM_TYPE_IMX8MM)
+		dsi->bridge.timings = &dsim_bridge_timings_de_low;
+
 	ret = component_add(dev, &exynos_dsi_component_ops);
 	if (ret)
 		goto err_disable_runtime;
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Jagan Teki <jagan@amarulasolutions.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
	Inki Dae <inki.dae@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Fancy Fang <chen.fang@nxp.com>,
	Tim Harvey <tharvey@gateworks.com>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Adam Ford <aford173@gmail.com>,
	Neil Armstrong <narmstrong@linaro.org>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Tommaso Merciai <tommaso.merciai@amarulasolutions.com>,
	Marek Vasut <marex@denx.de>
Cc: linux-samsung-soc@vger.kernel.org,
	Matteo Lisi <matteo.lisi@engicam.com>,
	dri-devel@lists.freedesktop.org,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-amarula <linux-amarula@amarulasolutions.com>,
	linux-arm-kernel@lists.infradead.org,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH v10 10/18] drm: exynos: dsi: Add input_bus_flags
Date: Wed, 14 Dec 2022 18:28:59 +0530	[thread overview]
Message-ID: <20221214125907.376148-11-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20221214125907.376148-1-jagan@amarulasolutions.com>

LCDIF-DSIM glue logic inverts the HS/VS/DE signals and expecting
the i.MX8M Mini/Nano DSI host to add additional Data Enable signal
active low (DE_LOW). This makes the valid data transfer on each
horizontal line.

So, add additional bus flags DE_LOW setting via input_bus_flags
for i.MX8M Mini/Nano platforms.

Suggested-by: Marek Vasut <marex@denx.de>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v10, v9:
- none
Changes for v8:
- add DE_LOW for i.MX8M Mini/Nano platforms.
Changes for v7, v6:
- none
Changes for v5:
- rebased based on updated bridge changes
Changes for v4 - v1:
- none

 drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 12a40576f937..36820a7b5884 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1692,6 +1692,10 @@ static const struct component_ops exynos_dsi_component_ops = {
 	.unbind	= exynos_dsi_unbind,
 };
 
+static const struct drm_bridge_timings dsim_bridge_timings_de_low = {
+	.input_bus_flags = DRM_BUS_FLAG_DE_LOW,
+};
+
 static int exynos_dsi_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
@@ -1778,6 +1782,10 @@ static int exynos_dsi_probe(struct platform_device *pdev)
 	dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;
 	dsi->bridge.pre_enable_prev_first = true;
 
+	/* DE_LOW: i.MX8M Mini/Nano LCDIF-DSIM glue logic inverts HS/VS/DE */
+	if (dsi->plat_data->hw_type == DSIM_TYPE_IMX8MM)
+		dsi->bridge.timings = &dsim_bridge_timings_de_low;
+
 	ret = component_add(dev, &exynos_dsi_component_ops);
 	if (ret)
 		goto err_disable_runtime;
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Jagan Teki <jagan@amarulasolutions.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
	Inki Dae <inki.dae@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Fancy Fang <chen.fang@nxp.com>,
	Tim Harvey <tharvey@gateworks.com>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Adam Ford <aford173@gmail.com>,
	Neil Armstrong <narmstrong@linaro.org>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Tommaso Merciai <tommaso.merciai@amarulasolutions.com>,
	Marek Vasut <marex@denx.de>
Cc: Matteo Lisi <matteo.lisi@engicam.com>,
	dri-devel@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-amarula <linux-amarula@amarulasolutions.com>,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH v10 10/18] drm: exynos: dsi: Add input_bus_flags
Date: Wed, 14 Dec 2022 18:28:59 +0530	[thread overview]
Message-ID: <20221214125907.376148-11-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20221214125907.376148-1-jagan@amarulasolutions.com>

LCDIF-DSIM glue logic inverts the HS/VS/DE signals and expecting
the i.MX8M Mini/Nano DSI host to add additional Data Enable signal
active low (DE_LOW). This makes the valid data transfer on each
horizontal line.

So, add additional bus flags DE_LOW setting via input_bus_flags
for i.MX8M Mini/Nano platforms.

Suggested-by: Marek Vasut <marex@denx.de>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v10, v9:
- none
Changes for v8:
- add DE_LOW for i.MX8M Mini/Nano platforms.
Changes for v7, v6:
- none
Changes for v5:
- rebased based on updated bridge changes
Changes for v4 - v1:
- none

 drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 12a40576f937..36820a7b5884 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1692,6 +1692,10 @@ static const struct component_ops exynos_dsi_component_ops = {
 	.unbind	= exynos_dsi_unbind,
 };
 
+static const struct drm_bridge_timings dsim_bridge_timings_de_low = {
+	.input_bus_flags = DRM_BUS_FLAG_DE_LOW,
+};
+
 static int exynos_dsi_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
@@ -1778,6 +1782,10 @@ static int exynos_dsi_probe(struct platform_device *pdev)
 	dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;
 	dsi->bridge.pre_enable_prev_first = true;
 
+	/* DE_LOW: i.MX8M Mini/Nano LCDIF-DSIM glue logic inverts HS/VS/DE */
+	if (dsi->plat_data->hw_type == DSIM_TYPE_IMX8MM)
+		dsi->bridge.timings = &dsim_bridge_timings_de_low;
+
 	ret = component_add(dev, &exynos_dsi_component_ops);
 	if (ret)
 		goto err_disable_runtime;
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-12-14 13:01 UTC|newest]

Thread overview: 130+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-14 12:58 [PATCH v10 00/18] drm: Add Samsung MIPI DSIM bridge Jagan Teki
2022-12-14 12:58 ` Jagan Teki
2022-12-14 12:58 ` Jagan Teki
2022-12-14 12:58 ` [PATCH v10 01/18] drm: of: Lookup if child node has DSI panel or bridge Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-14 12:58 ` [PATCH v10 02/18] drm: bridge: panel: Add devm_drm_of_dsi_get_bridge helper Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-14 12:58 ` [PATCH v10 03/18] drm: exynos: dsi: Drop explicit call to bridge detach Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-14 12:58 ` [PATCH v10 04/18] drm: exynos: dsi: Switch to devm_drm_of_dsi_get_bridge Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-14 12:58 ` [PATCH v10 05/18] drm: exynos: dsi: Mark PHY as optional Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-15  8:33   ` Frieder Schrempf
2022-12-15  8:33     ` Frieder Schrempf
2022-12-15  8:33     ` Frieder Schrempf
2022-12-14 12:58 ` [PATCH v10 06/18] drm: exynos: dsi: Add platform PLL_P (PMS_P) offset Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-14 12:58 ` [PATCH v10 07/18] drm: exynos: dsi: Introduce hw_type platform data Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-15  8:35   ` Frieder Schrempf
2022-12-15  8:35     ` Frieder Schrempf
2022-12-15  8:35     ` Frieder Schrempf
2022-12-14 12:58 ` [PATCH v10 08/18] drm: exynos: dsi: Handle proper host initialization Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-15  8:37   ` Frieder Schrempf
2022-12-15  8:37     ` Frieder Schrempf
2022-12-15  8:37     ` Frieder Schrempf
2022-12-14 12:58 ` [PATCH v10 09/18] drm: exynos: dsi: Add atomic check Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-15  8:39   ` Frieder Schrempf
2022-12-15  8:39     ` Frieder Schrempf
2022-12-15  8:39     ` Frieder Schrempf
2022-12-15  8:40     ` Frieder Schrempf
2022-12-15  8:40       ` Frieder Schrempf
2022-12-15  8:40       ` Frieder Schrempf
2022-12-14 12:58 ` Jagan Teki [this message]
2022-12-14 12:58   ` [PATCH v10 10/18] drm: exynos: dsi: Add input_bus_flags Jagan Teki
2022-12-14 12:58   ` Jagan Teki
2022-12-15  8:42   ` Frieder Schrempf
2022-12-15  8:42     ` Frieder Schrempf
2022-12-15  8:42     ` Frieder Schrempf
2022-12-14 12:59 ` [PATCH v10 11/18] drm: exynos: dsi: Add atomic_get_input_bus_fmts Jagan Teki
2022-12-14 12:59   ` Jagan Teki
2022-12-14 12:59   ` Jagan Teki
2022-12-15  8:57   ` Frieder Schrempf
2022-12-15  8:57     ` Frieder Schrempf
2022-12-15  8:57     ` Frieder Schrempf
2022-12-14 12:59 ` [PATCH v10 12/18] drm: exynos: dsi: Consolidate component and bridge Jagan Teki
2022-12-14 12:59   ` Jagan Teki
2022-12-14 12:59   ` Jagan Teki
2022-12-14 12:59 ` [PATCH v10 13/18] drm: exynos: dsi: Add Exynos based host irq hooks Jagan Teki
2022-12-14 12:59   ` Jagan Teki
2022-12-14 12:59   ` Jagan Teki
2022-12-14 12:59 ` [PATCH v10 14/18] drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge Jagan Teki
2022-12-14 12:59 ` [PATCH v10 15/18] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support Jagan Teki
2022-12-14 12:59   ` Jagan Teki
2022-12-14 12:59   ` Jagan Teki
2022-12-14 12:59 ` [PATCH v10 16/18] drm: bridge: samsung-dsim: Add " Jagan Teki
2022-12-14 12:59   ` Jagan Teki
2022-12-14 12:59   ` Jagan Teki
2022-12-15  9:22   ` Frieder Schrempf
2022-12-15  9:22     ` Frieder Schrempf
2022-12-15  9:22     ` Frieder Schrempf
2022-12-15 11:39     ` Robert Foss
2022-12-15 11:39       ` Robert Foss
2022-12-15 11:39       ` Robert Foss
2022-12-14 12:59 ` [PATCH v10 17/18] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support Jagan Teki
2022-12-14 12:59   ` Jagan Teki
2022-12-14 12:59   ` Jagan Teki
2022-12-20 17:26   ` Rob Herring
2022-12-20 17:26     ` Rob Herring
2022-12-20 17:26     ` Rob Herring
2022-12-14 12:59 ` [PATCH v10 18/18] drm: bridge: samsung-dsim: Add " Jagan Teki
2022-12-14 12:59   ` Jagan Teki
2022-12-14 12:59   ` Jagan Teki
2022-12-15  9:23   ` Frieder Schrempf
2022-12-15  9:23     ` Frieder Schrempf
2022-12-15  9:23     ` Frieder Schrempf
2022-12-15 11:39     ` Robert Foss
2022-12-15 11:39       ` Robert Foss
2022-12-15 11:39       ` Robert Foss
2023-01-05 10:24 ` [PATCH v10 00/18] drm: Add Samsung MIPI DSIM bridge Jagan Teki
2023-01-05 10:24   ` Jagan Teki
2023-01-05 10:24   ` Jagan Teki
2023-01-06 14:34   ` Adam Ford
2023-01-06 14:34     ` Adam Ford
2023-01-06 14:34     ` Adam Ford
2023-01-06 14:42     ` Fabio Estevam
2023-01-06 14:42       ` Fabio Estevam
2023-01-06 14:42       ` Fabio Estevam
2023-01-19 17:27   ` Fabio Estevam
2023-01-19 17:27     ` Fabio Estevam
2023-01-19 17:27     ` Fabio Estevam
2023-01-19 17:58     ` Jagan Teki
2023-01-19 17:58       ` Jagan Teki
2023-01-19 17:58       ` Jagan Teki
2023-01-20 12:06       ` Fabio Estevam
2023-01-20 12:06         ` Fabio Estevam
2023-01-20 12:06         ` Fabio Estevam
2023-01-20 14:41         ` Jagan Teki
2023-01-20 14:41           ` Jagan Teki
2023-01-20 14:41           ` Jagan Teki
2023-01-20 15:06           ` Marek Vasut
2023-01-20 15:06             ` Marek Vasut
2023-01-20 15:06             ` Marek Vasut
2023-01-20 18:54             ` Jagan Teki
2023-01-20 18:54               ` Jagan Teki
2023-01-20 18:54               ` Jagan Teki
2023-01-20 19:08               ` Marek Vasut
2023-01-20 19:08                 ` Marek Vasut
2023-01-20 19:08                 ` Marek Vasut
2023-01-20 18:59             ` Dave Stevenson
2023-01-20 18:59               ` Dave Stevenson
2023-01-20 18:59               ` Dave Stevenson
2023-01-23 12:22               ` Jagan Teki
2023-01-23 12:22                 ` Jagan Teki
2023-01-23 12:22                 ` Jagan Teki
2023-01-23 15:48             ` Jagan Teki
2023-01-23 15:48               ` Jagan Teki
2023-01-23 15:48               ` Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221214125907.376148-11-jagan@amarulasolutions.com \
    --to=jagan@amarulasolutions.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=aford173@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=chen.fang@nxp.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frieder.schrempf@kontron.de \
    --cc=inki.dae@samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=marex@denx.de \
    --cc=matteo.lisi@engicam.com \
    --cc=michael@amarulasolutions.com \
    --cc=narmstrong@linaro.org \
    --cc=robert.foss@linaro.org \
    --cc=sw0312.kim@samsung.com \
    --cc=tharvey@gateworks.com \
    --cc=tommaso.merciai@amarulasolutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.