All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Lu <roger.lu@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
	Enric Balletbo Serra <eballetbo@gmail.com>,
	Kevin Hilman <khilman@kernel.org>,
	Nicolas Boichat <drinkcat@google.com>
Cc: Fan Chen <fan.chen@mediatek.com>,
	Roger Lu <roger.lu@mediatek.com>,
	Jia-wei Chang <jia-wei.chang@mediatek.com>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: [PATCH v1 10/13] soc: mediatek: mtk-svs: restore default voltages when svs init02 fail
Date: Mon, 26 Dec 2022 17:42:45 +0800	[thread overview]
Message-ID: <20221226094248.4506-11-roger.lu@mediatek.com> (raw)
In-Reply-To: <20221226094248.4506-1-roger.lu@mediatek.com>

If svs init02 fail, it means we cannot rely on svs bank voltages anymore.
We need to disable svs function and restore DVFS opp voltages back to the
default voltages for making sure we have enough DVFS voltages.

Signed-off-by: Roger Lu <roger.lu@mediatek.com>
---
 drivers/soc/mediatek/mtk-svs.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index c4b36c908eda..3a2be5ced8e6 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -1467,6 +1467,7 @@ static int svs_init02(struct svs_platform *svsp)
 {
 	struct svs_bank *svsb;
 	unsigned long flags, time_left;
+	int ret;
 	u32 idx;
 
 	for (idx = 0; idx < svsp->bank_max; idx++) {
@@ -1485,7 +1486,8 @@ static int svs_init02(struct svs_platform *svsp)
 							msecs_to_jiffies(5000));
 		if (!time_left) {
 			dev_err(svsb->dev, "init02 completion timeout\n");
-			return -EBUSY;
+			ret = -EBUSY;
+			goto out_of_init02;
 		}
 	}
 
@@ -1503,12 +1505,21 @@ static int svs_init02(struct svs_platform *svsp)
 		if (svsb->type == SVSB_HIGH || svsb->type == SVSB_LOW) {
 			if (svs_sync_bank_volts_from_opp(svsb)) {
 				dev_err(svsb->dev, "sync volt fail\n");
-				return -EPERM;
+				ret = -EPERM;
+				goto out_of_init02;
 			}
 		}
 	}
 
 	return 0;
+
+out_of_init02:
+	for (idx = 0; idx < svsp->bank_max; idx++) {
+		svsb = &svsp->banks[idx];
+		svs_bank_disable_and_restore_default_volts(svsp, svsb);
+	}
+
+	return ret;
 }
 
 static void svs_mon_mode(struct svs_platform *svsp)
-- 
2.18.0


WARNING: multiple messages have this Message-ID (diff)
From: Roger Lu <roger.lu@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
	Enric Balletbo Serra <eballetbo@gmail.com>,
	Kevin Hilman <khilman@kernel.org>,
	Nicolas Boichat <drinkcat@google.com>
Cc: Fan Chen <fan.chen@mediatek.com>,
	Roger Lu <roger.lu@mediatek.com>,
	Jia-wei Chang <jia-wei.chang@mediatek.com>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: [PATCH v1 10/13] soc: mediatek: mtk-svs: restore default voltages when svs init02 fail
Date: Mon, 26 Dec 2022 17:42:45 +0800	[thread overview]
Message-ID: <20221226094248.4506-11-roger.lu@mediatek.com> (raw)
In-Reply-To: <20221226094248.4506-1-roger.lu@mediatek.com>

If svs init02 fail, it means we cannot rely on svs bank voltages anymore.
We need to disable svs function and restore DVFS opp voltages back to the
default voltages for making sure we have enough DVFS voltages.

Signed-off-by: Roger Lu <roger.lu@mediatek.com>
---
 drivers/soc/mediatek/mtk-svs.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index c4b36c908eda..3a2be5ced8e6 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -1467,6 +1467,7 @@ static int svs_init02(struct svs_platform *svsp)
 {
 	struct svs_bank *svsb;
 	unsigned long flags, time_left;
+	int ret;
 	u32 idx;
 
 	for (idx = 0; idx < svsp->bank_max; idx++) {
@@ -1485,7 +1486,8 @@ static int svs_init02(struct svs_platform *svsp)
 							msecs_to_jiffies(5000));
 		if (!time_left) {
 			dev_err(svsb->dev, "init02 completion timeout\n");
-			return -EBUSY;
+			ret = -EBUSY;
+			goto out_of_init02;
 		}
 	}
 
@@ -1503,12 +1505,21 @@ static int svs_init02(struct svs_platform *svsp)
 		if (svsb->type == SVSB_HIGH || svsb->type == SVSB_LOW) {
 			if (svs_sync_bank_volts_from_opp(svsb)) {
 				dev_err(svsb->dev, "sync volt fail\n");
-				return -EPERM;
+				ret = -EPERM;
+				goto out_of_init02;
 			}
 		}
 	}
 
 	return 0;
+
+out_of_init02:
+	for (idx = 0; idx < svsp->bank_max; idx++) {
+		svsb = &svsp->banks[idx];
+		svs_bank_disable_and_restore_default_volts(svsp, svsb);
+	}
+
+	return ret;
 }
 
 static void svs_mon_mode(struct svs_platform *svsp)
-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-12-26  9:43 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-26  9:42 [PATCH v1 0/13] Enahance SVS's robustness Roger Lu
2022-12-26  9:42 ` Roger Lu
2022-12-26  9:42 ` [PATCH v1 01/13] soc: mediatek: mtk-svs: enable the IRQ later Roger Lu
2022-12-26  9:42   ` Roger Lu
2022-12-26  9:42 ` [PATCH v1 02/13] soc: mediatek: mtk-svs: clean up platform probing Roger Lu
2022-12-26  9:42   ` Roger Lu
2022-12-26  9:42 ` [PATCH v1 03/13] soc: mediatek: mtk-svs: improve readability of platform_probe Roger Lu
2022-12-26  9:42   ` Roger Lu
2022-12-26  9:42 ` [PATCH v1 04/13] soc: mediatek: mtk-svs: move svs_platform_probe into probe Roger Lu
2022-12-26  9:42   ` Roger Lu
2022-12-26  9:42 ` [PATCH v1 05/13] soc: mediatek: mtk-svs: delete superfluous platform data entries Roger Lu
2022-12-26  9:42   ` Roger Lu
2022-12-26  9:42 ` [PATCH v1 06/13] soc: mediatek: mtk-svs: use svs get efuse common function Roger Lu
2022-12-26  9:42   ` Roger Lu
2022-12-26  9:42 ` [PATCH v1 07/13] soc: mtk-svs: mt8183: refactor o_slope calculation Roger Lu
2022-12-26  9:42   ` Roger Lu
2023-01-03 12:49   ` AngeloGioacchino Del Regno
2023-01-03 12:49     ` AngeloGioacchino Del Regno
2022-12-26  9:42 ` [PATCH v1 08/13] soc: mediatek: mtk-svs: add main_clk check during system-wide suspend Roger Lu
2022-12-26  9:42   ` Roger Lu
2022-12-26  9:42 ` [PATCH v1 09/13] soc: mediatek: mtk-svs: use common function to disable restore voltages Roger Lu
2022-12-26  9:42   ` Roger Lu
2023-01-03 12:49   ` AngeloGioacchino Del Regno
2023-01-03 12:49     ` AngeloGioacchino Del Regno
2022-12-26  9:42 ` Roger Lu [this message]
2022-12-26  9:42   ` [PATCH v1 10/13] soc: mediatek: mtk-svs: restore default voltages when svs init02 fail Roger Lu
2023-01-03 12:49   ` AngeloGioacchino Del Regno
2023-01-03 12:49     ` AngeloGioacchino Del Regno
2023-01-10  5:30     ` Roger Lu (陸瑞傑)
2023-01-10  5:30       ` Roger Lu (陸瑞傑)
2022-12-26  9:42 ` [PATCH v1 11/13] soc: mediatek: mtk-svs: add thermal voltage compensation if needed Roger Lu
2022-12-26  9:42   ` Roger Lu
2023-01-03 12:49   ` AngeloGioacchino Del Regno
2023-01-03 12:49     ` AngeloGioacchino Del Regno
2022-12-26  9:42 ` [PATCH v1 12/13] soc: mediatek: mtk-svs: Use pm_runtime_resume_and_get() in svs_init01() Roger Lu
2022-12-26  9:42   ` Roger Lu
2023-01-03 12:49   ` AngeloGioacchino Del Regno
2023-01-03 12:49     ` AngeloGioacchino Del Regno
2022-12-26  9:42 ` [PATCH v1 13/13] soc: mediatek: mtk-svs: keep svs alive even though debug cmd create fail Roger Lu
2022-12-26  9:42   ` Roger Lu
2023-01-03 12:49   ` AngeloGioacchino Del Regno
2023-01-03 12:49     ` AngeloGioacchino Del Regno
2023-01-10  5:35     ` Roger Lu (陸瑞傑)
2023-01-10  5:35       ` Roger Lu (陸瑞傑)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221226094248.4506-11-roger.lu@mediatek.com \
    --to=roger.lu@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@google.com \
    --cc=eballetbo@gmail.com \
    --cc=fan.chen@mediatek.com \
    --cc=jia-wei.chang@mediatek.com \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.