From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: Roger Lu <roger.lu@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com>, Enric Balletbo Serra <eballetbo@gmail.com>, Kevin Hilman <khilman@kernel.org>, Nicolas Boichat <drinkcat@google.com> Cc: Fan Chen <fan.chen@mediatek.com>, Jia-wei Chang <jia-wei.chang@mediatek.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v1 13/13] soc: mediatek: mtk-svs: keep svs alive even though debug cmd create fail Date: Tue, 3 Jan 2023 13:49:36 +0100 [thread overview] Message-ID: <2f4a78f8-9cdd-9e44-20a2-b3bd6abd5cc7@collabora.com> (raw) In-Reply-To: <20221226094248.4506-14-roger.lu@mediatek.com> Il 26/12/22 10:42, Roger Lu ha scritto: > Some projects might not support DEBUG_FS but still needs svs to be > supported. Therefore, keep svs alive even though debug cmd create fail. > > Signed-off-by: Roger Lu <roger.lu@mediatek.com> > --- > drivers/soc/mediatek/mtk-svs.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c > index af3a12e29e78..c780a115543e 100644 > --- a/drivers/soc/mediatek/mtk-svs.c > +++ b/drivers/soc/mediatek/mtk-svs.c > @@ -2390,10 +2390,8 @@ static int svs_probe(struct platform_device *pdev) > } > Instead of ignoring a planned failure, it's sensible to not fail at all: enclose this call and the svs_create_debug_cmds() function in an ifdef. #ifdef CONFIG_DEBUG_FS > ret = svs_create_debug_cmds(svsp); > - if (ret) { > + if (ret) > dev_err(svsp->dev, "svs create debug cmds fail: %d\n", ret); > - goto svs_probe_iounmap; > - } #endif > > return 0; > > Regards, Angelo
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: Roger Lu <roger.lu@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com>, Enric Balletbo Serra <eballetbo@gmail.com>, Kevin Hilman <khilman@kernel.org>, Nicolas Boichat <drinkcat@google.com> Cc: Fan Chen <fan.chen@mediatek.com>, Jia-wei Chang <jia-wei.chang@mediatek.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v1 13/13] soc: mediatek: mtk-svs: keep svs alive even though debug cmd create fail Date: Tue, 3 Jan 2023 13:49:36 +0100 [thread overview] Message-ID: <2f4a78f8-9cdd-9e44-20a2-b3bd6abd5cc7@collabora.com> (raw) In-Reply-To: <20221226094248.4506-14-roger.lu@mediatek.com> Il 26/12/22 10:42, Roger Lu ha scritto: > Some projects might not support DEBUG_FS but still needs svs to be > supported. Therefore, keep svs alive even though debug cmd create fail. > > Signed-off-by: Roger Lu <roger.lu@mediatek.com> > --- > drivers/soc/mediatek/mtk-svs.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c > index af3a12e29e78..c780a115543e 100644 > --- a/drivers/soc/mediatek/mtk-svs.c > +++ b/drivers/soc/mediatek/mtk-svs.c > @@ -2390,10 +2390,8 @@ static int svs_probe(struct platform_device *pdev) > } > Instead of ignoring a planned failure, it's sensible to not fail at all: enclose this call and the svs_create_debug_cmds() function in an ifdef. #ifdef CONFIG_DEBUG_FS > ret = svs_create_debug_cmds(svsp); > - if (ret) { > + if (ret) > dev_err(svsp->dev, "svs create debug cmds fail: %d\n", ret); > - goto svs_probe_iounmap; > - } #endif > > return 0; > > Regards, Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-03 12:54 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-26 9:42 [PATCH v1 0/13] Enahance SVS's robustness Roger Lu 2022-12-26 9:42 ` Roger Lu 2022-12-26 9:42 ` [PATCH v1 01/13] soc: mediatek: mtk-svs: enable the IRQ later Roger Lu 2022-12-26 9:42 ` Roger Lu 2022-12-26 9:42 ` [PATCH v1 02/13] soc: mediatek: mtk-svs: clean up platform probing Roger Lu 2022-12-26 9:42 ` Roger Lu 2022-12-26 9:42 ` [PATCH v1 03/13] soc: mediatek: mtk-svs: improve readability of platform_probe Roger Lu 2022-12-26 9:42 ` Roger Lu 2022-12-26 9:42 ` [PATCH v1 04/13] soc: mediatek: mtk-svs: move svs_platform_probe into probe Roger Lu 2022-12-26 9:42 ` Roger Lu 2022-12-26 9:42 ` [PATCH v1 05/13] soc: mediatek: mtk-svs: delete superfluous platform data entries Roger Lu 2022-12-26 9:42 ` Roger Lu 2022-12-26 9:42 ` [PATCH v1 06/13] soc: mediatek: mtk-svs: use svs get efuse common function Roger Lu 2022-12-26 9:42 ` Roger Lu 2022-12-26 9:42 ` [PATCH v1 07/13] soc: mtk-svs: mt8183: refactor o_slope calculation Roger Lu 2022-12-26 9:42 ` Roger Lu 2023-01-03 12:49 ` AngeloGioacchino Del Regno 2023-01-03 12:49 ` AngeloGioacchino Del Regno 2022-12-26 9:42 ` [PATCH v1 08/13] soc: mediatek: mtk-svs: add main_clk check during system-wide suspend Roger Lu 2022-12-26 9:42 ` Roger Lu 2022-12-26 9:42 ` [PATCH v1 09/13] soc: mediatek: mtk-svs: use common function to disable restore voltages Roger Lu 2022-12-26 9:42 ` Roger Lu 2023-01-03 12:49 ` AngeloGioacchino Del Regno 2023-01-03 12:49 ` AngeloGioacchino Del Regno 2022-12-26 9:42 ` [PATCH v1 10/13] soc: mediatek: mtk-svs: restore default voltages when svs init02 fail Roger Lu 2022-12-26 9:42 ` Roger Lu 2023-01-03 12:49 ` AngeloGioacchino Del Regno 2023-01-03 12:49 ` AngeloGioacchino Del Regno 2023-01-10 5:30 ` Roger Lu (陸瑞傑) 2023-01-10 5:30 ` Roger Lu (陸瑞傑) 2022-12-26 9:42 ` [PATCH v1 11/13] soc: mediatek: mtk-svs: add thermal voltage compensation if needed Roger Lu 2022-12-26 9:42 ` Roger Lu 2023-01-03 12:49 ` AngeloGioacchino Del Regno 2023-01-03 12:49 ` AngeloGioacchino Del Regno 2022-12-26 9:42 ` [PATCH v1 12/13] soc: mediatek: mtk-svs: Use pm_runtime_resume_and_get() in svs_init01() Roger Lu 2022-12-26 9:42 ` Roger Lu 2023-01-03 12:49 ` AngeloGioacchino Del Regno 2023-01-03 12:49 ` AngeloGioacchino Del Regno 2022-12-26 9:42 ` [PATCH v1 13/13] soc: mediatek: mtk-svs: keep svs alive even though debug cmd create fail Roger Lu 2022-12-26 9:42 ` Roger Lu 2023-01-03 12:49 ` AngeloGioacchino Del Regno [this message] 2023-01-03 12:49 ` AngeloGioacchino Del Regno 2023-01-10 5:35 ` Roger Lu (陸瑞傑) 2023-01-10 5:35 ` Roger Lu (陸瑞傑)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2f4a78f8-9cdd-9e44-20a2-b3bd6abd5cc7@collabora.com \ --to=angelogioacchino.delregno@collabora.com \ --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=drinkcat@google.com \ --cc=eballetbo@gmail.com \ --cc=fan.chen@mediatek.com \ --cc=jia-wei.chang@mediatek.com \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=matthias.bgg@gmail.com \ --cc=roger.lu@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.