From: "Michael S. Tsirkin" <mst@redhat.com> To: Shunsuke Mie <mie@igel.co.jp> Cc: Jason Wang <jasowang@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/9] vringh: remove vringh_iov and unite to vringh_kiov Date: Tue, 27 Dec 2022 02:56:04 -0500 [thread overview] Message-ID: <20221227025534-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <CANXvt5pXkS=TTOU0+Lkx6CjcV7xvDHRS6FbFikJ4Ww8832sg8g@mail.gmail.com> On Tue, Dec 27, 2022 at 04:13:49PM +0900, Shunsuke Mie wrote: > 2022年12月27日(火) 16:05 Michael S. Tsirkin <mst@redhat.com>: > > > > On Tue, Dec 27, 2022 at 02:04:03PM +0800, Jason Wang wrote: > > > On Tue, Dec 27, 2022 at 10:25 AM Shunsuke Mie <mie@igel.co.jp> wrote: > > > > > > > > struct vringh_iov is defined to hold userland addresses. However, to use > > > > common function, __vring_iov, finally the vringh_iov converts to the > > > > vringh_kiov with simple cast. It includes compile time check code to make > > > > sure it can be cast correctly. > > > > > > > > To simplify the code, this patch removes the struct vringh_iov and unifies > > > > APIs to struct vringh_kiov. > > > > > > > > Signed-off-by: Shunsuke Mie <mie@igel.co.jp> > > > > > > While at this, I wonder if we need to go further, that is, switch to > > > using an iov iterator instead of a vringh customized one. > > > > > > Thanks > > > > Possibly, but when doing changes like this one needs to be careful > > to avoid breaking all the inlining tricks vringh relies on for > > performance. > Definitely, I'm evaluating the performance using vringh_test. I'll add a > result of the evaluation. But, If there are other evaluation methods, could you > please tell me? high level tests over virtio blk and net are possible, but let's start with vringh_test. > > -- > > MST > > > > Best, > Shunsuke
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: Shunsuke Mie <mie@igel.co.jp> Cc: kvm@vger.kernel.org, netdev@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [RFC PATCH 2/9] vringh: remove vringh_iov and unite to vringh_kiov Date: Tue, 27 Dec 2022 02:56:04 -0500 [thread overview] Message-ID: <20221227025534-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <CANXvt5pXkS=TTOU0+Lkx6CjcV7xvDHRS6FbFikJ4Ww8832sg8g@mail.gmail.com> On Tue, Dec 27, 2022 at 04:13:49PM +0900, Shunsuke Mie wrote: > 2022年12月27日(火) 16:05 Michael S. Tsirkin <mst@redhat.com>: > > > > On Tue, Dec 27, 2022 at 02:04:03PM +0800, Jason Wang wrote: > > > On Tue, Dec 27, 2022 at 10:25 AM Shunsuke Mie <mie@igel.co.jp> wrote: > > > > > > > > struct vringh_iov is defined to hold userland addresses. However, to use > > > > common function, __vring_iov, finally the vringh_iov converts to the > > > > vringh_kiov with simple cast. It includes compile time check code to make > > > > sure it can be cast correctly. > > > > > > > > To simplify the code, this patch removes the struct vringh_iov and unifies > > > > APIs to struct vringh_kiov. > > > > > > > > Signed-off-by: Shunsuke Mie <mie@igel.co.jp> > > > > > > While at this, I wonder if we need to go further, that is, switch to > > > using an iov iterator instead of a vringh customized one. > > > > > > Thanks > > > > Possibly, but when doing changes like this one needs to be careful > > to avoid breaking all the inlining tricks vringh relies on for > > performance. > Definitely, I'm evaluating the performance using vringh_test. I'll add a > result of the evaluation. But, If there are other evaluation methods, could you > please tell me? high level tests over virtio blk and net are possible, but let's start with vringh_test. > > -- > > MST > > > > Best, > Shunsuke _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-12-27 7:57 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-27 2:25 [RFC PATCH 0/6] Introduce a vringh accessor for IO memory Shunsuke Mie 2022-12-27 2:25 ` Shunsuke Mie 2022-12-27 2:25 ` [RFC PATCH 1/9] vringh: fix a typo in comments for vringh_kiov Shunsuke Mie 2022-12-27 2:25 ` Shunsuke Mie 2022-12-27 2:25 ` [RFC PATCH 2/9] vringh: remove vringh_iov and unite to vringh_kiov Shunsuke Mie 2022-12-27 2:25 ` Shunsuke Mie 2022-12-27 6:04 ` Jason Wang 2022-12-27 6:04 ` Jason Wang 2022-12-27 7:05 ` Michael S. Tsirkin 2022-12-27 7:05 ` Michael S. Tsirkin 2022-12-27 7:13 ` Shunsuke Mie 2022-12-27 7:13 ` Shunsuke Mie 2022-12-27 7:56 ` Michael S. Tsirkin [this message] 2022-12-27 7:56 ` Michael S. Tsirkin 2022-12-27 7:57 ` Shunsuke Mie 2022-12-27 7:57 ` Shunsuke Mie 2022-12-27 7:05 ` Shunsuke Mie 2022-12-27 7:05 ` Shunsuke Mie 2022-12-28 6:36 ` Jason Wang 2022-12-28 6:36 ` Jason Wang 2023-01-11 3:26 ` Shunsuke Mie 2023-01-11 3:26 ` Shunsuke Mie 2023-01-11 5:54 ` Jason Wang 2023-01-11 5:54 ` Jason Wang 2023-01-11 6:19 ` Shunsuke Mie 2023-01-11 6:19 ` Shunsuke Mie 2022-12-27 2:25 ` [RFC PATCH 3/9] tools/virtio: convert to new vringh user APIs Shunsuke Mie 2022-12-27 2:25 ` Shunsuke Mie 2022-12-27 2:25 ` [RFC PATCH 4/9] vringh: unify the APIs for all accessors Shunsuke Mie 2022-12-27 2:25 ` Shunsuke Mie 2022-12-27 7:04 ` Michael S. Tsirkin 2022-12-27 7:04 ` Michael S. Tsirkin 2022-12-27 7:49 ` Shunsuke Mie 2022-12-27 7:49 ` Shunsuke Mie 2022-12-27 10:22 ` Shunsuke Mie 2022-12-27 10:22 ` Shunsuke Mie 2022-12-27 14:37 ` Michael S. Tsirkin 2022-12-27 14:37 ` Michael S. Tsirkin 2022-12-28 2:24 ` Shunsuke Mie 2022-12-28 2:24 ` Shunsuke Mie 2022-12-28 7:20 ` Michael S. Tsirkin 2022-12-28 7:20 ` Michael S. Tsirkin 2023-01-11 4:10 ` Shunsuke Mie 2023-01-11 4:10 ` Shunsuke Mie 2022-12-27 2:25 ` [RFC PATCH 5/9] tools/virtio: convert to use new unified vringh APIs Shunsuke Mie 2022-12-27 2:25 ` Shunsuke Mie 2022-12-27 2:25 ` [RFC PATCH 6/9] caif_virtio: convert to " Shunsuke Mie 2022-12-27 2:25 ` Shunsuke Mie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221227025534-mutt-send-email-mst@kernel.org \ --to=mst@redhat.com \ --cc=jasowang@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mie@igel.co.jp \ --cc=netdev@vger.kernel.org \ --cc=rusty@rustcorp.com.au \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.