From: Vladimir Oltean <olteanv@gmail.com> To: Michael Walle <michael@walle.cc> Cc: Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Jose Abreu <Jose.Abreu@synopsys.com>, Sergey Shtylyov <s.shtylyov@omp.ru>, Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>, Clark Wang <xiaoning.wang@nxp.com>, NXP Linux Team <linux-imx@nxp.com>, Sean Wang <sean.wang@mediatek.com>, Landen Chao <Landen.Chao@mediatek.com>, DENG Qingfang <dqfext@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, Matthias Brugger <matthias.bgg@gmail.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Lunn <andrew@lunn.ch>, Geert Uytterhoeven <geert+renesas@glider.be> Subject: Re: [PATCH RFC net-next v2 08/12] net: ethernet: freescale: xgmac: Separate C22 and C45 transactions for xgmac Date: Tue, 3 Jan 2023 15:55:19 +0200 [thread overview] Message-ID: <20230103135519.oai43rj3waigqi54@skbuf> (raw) In-Reply-To: <20221227-v6-2-rc1-c45-seperation-v2-8-ddb37710e5a7@walle.cc> Commit message can be: "net/fsl: xgmac_mdio: Separate C22 and C45 transactions". On Wed, Dec 28, 2022 at 12:07:24AM +0100, Michael Walle wrote: > From: Andrew Lunn <andrew@lunn.ch> > > The xgmac MDIO bus driver can perform both C22 and C45 transfers. > Create separate functions for each and register the C45 versions using > the new API calls where appropriate. > > Signed-off-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Michael Walle <michael@walle.cc> > --- > v2: > - [al] Move the masking of regnum into the variable declarations > - [al] Remove a couple of blank lines Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com> > > -/* > - * Reads from register regnum in the PHY for device dev, returning the value. > +/* Reads from register regnum in the PHY for device dev, returning the value. > * Clears miimcom first. All PHY configuration has to be done through the > * TSEC1 MIIM regs. > */ I have some reservations regarding the utility of the comments in this driver. It's surely not worth duplicating them between C22 and C45. It might also be more productive to just delete them, because: - miimcom is a register accessed by fsl_pq_mdio.c, not by xgmac_mdio.c - "device dev" doesn't really refer to anything (maybe "dev_addr"). - I don't understand what is meant by the comment "All PHY configuration has to be done through the TSEC1 MIIM regs". Or rather said, I think I understand, but it is irrelevant to the driver for 2 reasons: * TSEC devices use the fsl_pq_mdio.c driver, not this one * It doesn't matter to this driver whose TSEC registers are used for MDIO access. The driver just works with the registers it's given, which is a concern for the device tree. - barring the above, the rest just describes the MDIO bus API, which is superfluous
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Oltean <olteanv@gmail.com> To: Michael Walle <michael@walle.cc> Cc: Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Jose Abreu <Jose.Abreu@synopsys.com>, Sergey Shtylyov <s.shtylyov@omp.ru>, Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>, Clark Wang <xiaoning.wang@nxp.com>, NXP Linux Team <linux-imx@nxp.com>, Sean Wang <sean.wang@mediatek.com>, Landen Chao <Landen.Chao@mediatek.com>, DENG Qingfang <dqfext@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, Matthias Brugger <matthias.bgg@gmail.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Lunn <andrew@lunn.ch>, Geert Uytterhoeven <geert+renesas@glider.be> Subject: Re: [PATCH RFC net-next v2 08/12] net: ethernet: freescale: xgmac: Separate C22 and C45 transactions for xgmac Date: Tue, 3 Jan 2023 15:55:19 +0200 [thread overview] Message-ID: <20230103135519.oai43rj3waigqi54@skbuf> (raw) In-Reply-To: <20221227-v6-2-rc1-c45-seperation-v2-8-ddb37710e5a7@walle.cc> Commit message can be: "net/fsl: xgmac_mdio: Separate C22 and C45 transactions". On Wed, Dec 28, 2022 at 12:07:24AM +0100, Michael Walle wrote: > From: Andrew Lunn <andrew@lunn.ch> > > The xgmac MDIO bus driver can perform both C22 and C45 transfers. > Create separate functions for each and register the C45 versions using > the new API calls where appropriate. > > Signed-off-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Michael Walle <michael@walle.cc> > --- > v2: > - [al] Move the masking of regnum into the variable declarations > - [al] Remove a couple of blank lines Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com> > > -/* > - * Reads from register regnum in the PHY for device dev, returning the value. > +/* Reads from register regnum in the PHY for device dev, returning the value. > * Clears miimcom first. All PHY configuration has to be done through the > * TSEC1 MIIM regs. > */ I have some reservations regarding the utility of the comments in this driver. It's surely not worth duplicating them between C22 and C45. It might also be more productive to just delete them, because: - miimcom is a register accessed by fsl_pq_mdio.c, not by xgmac_mdio.c - "device dev" doesn't really refer to anything (maybe "dev_addr"). - I don't understand what is meant by the comment "All PHY configuration has to be done through the TSEC1 MIIM regs". Or rather said, I think I understand, but it is irrelevant to the driver for 2 reasons: * TSEC devices use the fsl_pq_mdio.c driver, not this one * It doesn't matter to this driver whose TSEC registers are used for MDIO access. The driver just works with the registers it's given, which is a concern for the device tree. - barring the above, the rest just describes the MDIO bus API, which is superfluous _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-03 13:55 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-27 23:07 [PATCH RFC net-next v2 00/12] net: mdio: Start separating C22 and C45 Michael Walle 2022-12-27 23:07 ` Michael Walle 2022-12-27 23:07 ` [PATCH RFC net-next v2 01/12] net: mdio: Add dedicated C45 API to MDIO bus drivers Michael Walle 2022-12-27 23:07 ` Michael Walle 2022-12-27 23:07 ` [PATCH RFC net-next v2 02/12] net: pcs: pcs-xpcs: Use C45 MDIO API Michael Walle 2022-12-27 23:07 ` Michael Walle 2023-01-03 13:28 ` Vladimir Oltean 2023-01-03 13:28 ` Vladimir Oltean 2022-12-27 23:07 ` [PATCH RFC net-next v2 03/12] net: mdio: mdiobus_register: update validation test Michael Walle 2022-12-27 23:07 ` Michael Walle 2023-01-03 10:13 ` Russell King (Oracle) 2023-01-03 10:13 ` Russell King (Oracle) 2023-01-03 10:21 ` Michael Walle 2023-01-03 10:21 ` Michael Walle 2023-01-03 22:19 ` Russell King (Oracle) 2023-01-03 22:19 ` Russell King (Oracle) 2023-01-09 12:35 ` Michael Walle 2023-01-09 12:35 ` Michael Walle 2023-01-09 12:41 ` Vladimir Oltean 2023-01-09 12:41 ` Vladimir Oltean 2022-12-27 23:07 ` [PATCH RFC net-next v2 04/12] net: mdio: C22 is now optional, EOPNOTSUPP if not provided Michael Walle 2022-12-27 23:07 ` Michael Walle 2022-12-27 23:07 ` [PATCH RFC net-next v2 05/12] net: mdio: Move mdiobus_c45_addr() next to users Michael Walle 2022-12-27 23:07 ` Michael Walle 2022-12-27 23:07 ` [PATCH RFC net-next v2 06/12] net: mdio: mdio-bitbang: Separate C22 and C45 transactions Michael Walle 2022-12-27 23:07 ` Michael Walle 2022-12-28 5:46 ` kernel test robot 2022-12-28 5:46 ` kernel test robot 2023-01-03 13:15 ` Vladimir Oltean 2023-01-03 13:15 ` Vladimir Oltean 2023-01-03 13:27 ` Michael Walle 2023-01-03 13:27 ` Michael Walle 2022-12-27 23:07 ` [PATCH RFC net-next v2 07/12] net: mdio: mvmdio: Convert XSMI bus to new API Michael Walle 2022-12-27 23:07 ` Michael Walle 2022-12-27 23:07 ` [PATCH RFC net-next v2 08/12] net: ethernet: freescale: xgmac: Separate C22 and C45 transactions for xgmac Michael Walle 2022-12-27 23:07 ` Michael Walle 2023-01-03 13:55 ` Vladimir Oltean [this message] 2023-01-03 13:55 ` Vladimir Oltean 2022-12-27 23:07 ` [PATCH RFC net-next v2 09/12] net: ethernet: freescale: fec: " Michael Walle 2022-12-27 23:07 ` Michael Walle 2022-12-28 3:31 ` Wei Fang 2022-12-28 3:31 ` Wei Fang 2023-01-03 13:57 ` Vladimir Oltean 2023-01-03 13:57 ` Vladimir Oltean 2022-12-27 23:07 ` [PATCH RFC net-next v2 10/12] net: mdio: add mdiobus_c45_read/write_nested helpers Michael Walle 2022-12-27 23:07 ` Michael Walle 2022-12-27 23:07 ` [PATCH RFC net-next v2 11/12] net: dsa: Separate C22 and C45 MDIO bus transaction methods Michael Walle 2022-12-27 23:07 ` Michael Walle 2023-01-03 15:31 ` Vladimir Oltean 2023-01-03 15:31 ` Vladimir Oltean 2023-01-03 15:48 ` Andrew Lunn 2023-01-03 15:48 ` Andrew Lunn 2023-01-03 15:56 ` Vladimir Oltean 2023-01-03 15:56 ` Vladimir Oltean 2023-01-16 7:51 ` Michael Walle 2023-01-16 7:51 ` Michael Walle 2023-01-16 19:28 ` Vladimir Oltean 2023-01-16 19:28 ` Vladimir Oltean 2022-12-27 23:07 ` [PATCH RFC net-next v2 12/12] net: dsa: mv88e6xxx: Separate C22 and C45 transactions Michael Walle 2022-12-27 23:07 ` Michael Walle 2023-01-03 16:20 ` Vladimir Oltean 2023-01-03 16:20 ` Vladimir Oltean
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230103135519.oai43rj3waigqi54@skbuf \ --to=olteanv@gmail.com \ --cc=Jose.Abreu@synopsys.com \ --cc=Landen.Chao@mediatek.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=dqfext@gmail.com \ --cc=edumazet@google.com \ --cc=f.fainelli@gmail.com \ --cc=geert+renesas@glider.be \ --cc=hkallweit1@gmail.com \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=matthias.bgg@gmail.com \ --cc=michael@walle.cc \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=s.shtylyov@omp.ru \ --cc=sean.wang@mediatek.com \ --cc=shenwei.wang@nxp.com \ --cc=wei.fang@nxp.com \ --cc=xiaoning.wang@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.