From: Michael Walle <michael@walle.cc> To: "Russell King (Oracle)" <linux@armlinux.org.uk> Cc: Heiner Kallweit <hkallweit1@gmail.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Jose Abreu <Jose.Abreu@synopsys.com>, Sergey Shtylyov <s.shtylyov@omp.ru>, Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>, Clark Wang <xiaoning.wang@nxp.com>, NXP Linux Team <linux-imx@nxp.com>, Sean Wang <sean.wang@mediatek.com>, Landen Chao <Landen.Chao@mediatek.com>, DENG Qingfang <dqfext@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, Vladimir Oltean <olteanv@gmail.com>, Matthias Brugger <matthias.bgg@gmail.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Lunn <andrew@lunn.ch>, Geert Uytterhoeven <geert+renesas@glider.be> Subject: Re: [PATCH RFC net-next v2 03/12] net: mdio: mdiobus_register: update validation test Date: Tue, 03 Jan 2023 11:21:08 +0100 [thread overview] Message-ID: <37247c17e5e555dddbc37c3c63a2cadb@walle.cc> (raw) In-Reply-To: <Y7P/45Owf2IezIpO@shell.armlinux.org.uk> Hi Russell, Am 2023-01-03 11:13, schrieb Russell King (Oracle): > On Wed, Dec 28, 2022 at 12:07:19AM +0100, Michael Walle wrote: >> + if (!bus || !bus->name) >> + return -EINVAL; >> + >> + /* An access method always needs both read and write operations */ >> + if ((bus->read && !bus->write) || >> + (!bus->read && bus->write) || >> + (bus->read_c45 && !bus->write_c45) || >> + (!bus->read_c45 && bus->write_c45)) > > I wonder whether the following would be even more readable: > > if (!bus->read != !bus->write || !bus->read_c45 != !bus->write_c45) That's what Andrew had originally. But there was a comment from Sergey [1] which I agree with. I had a hard time wrapping my head around that, so I just listed all the possible bad cases. I don't have a strong opinion, though. > which essentially asserts that the boolean of !method for the read and > write methods must match. Maybe with that as a comment? -michael [1] https://lore.kernel.org/netdev/ae79823f-3697-feee-32e6-645c6f4b4e93@omp.ru/
WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc> To: "Russell King (Oracle)" <linux@armlinux.org.uk> Cc: Heiner Kallweit <hkallweit1@gmail.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Jose Abreu <Jose.Abreu@synopsys.com>, Sergey Shtylyov <s.shtylyov@omp.ru>, Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>, Clark Wang <xiaoning.wang@nxp.com>, NXP Linux Team <linux-imx@nxp.com>, Sean Wang <sean.wang@mediatek.com>, Landen Chao <Landen.Chao@mediatek.com>, DENG Qingfang <dqfext@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, Vladimir Oltean <olteanv@gmail.com>, Matthias Brugger <matthias.bgg@gmail.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Lunn <andrew@lunn.ch>, Geert Uytterhoeven <geert+renesas@glider.be> Subject: Re: [PATCH RFC net-next v2 03/12] net: mdio: mdiobus_register: update validation test Date: Tue, 03 Jan 2023 11:21:08 +0100 [thread overview] Message-ID: <37247c17e5e555dddbc37c3c63a2cadb@walle.cc> (raw) In-Reply-To: <Y7P/45Owf2IezIpO@shell.armlinux.org.uk> Hi Russell, Am 2023-01-03 11:13, schrieb Russell King (Oracle): > On Wed, Dec 28, 2022 at 12:07:19AM +0100, Michael Walle wrote: >> + if (!bus || !bus->name) >> + return -EINVAL; >> + >> + /* An access method always needs both read and write operations */ >> + if ((bus->read && !bus->write) || >> + (!bus->read && bus->write) || >> + (bus->read_c45 && !bus->write_c45) || >> + (!bus->read_c45 && bus->write_c45)) > > I wonder whether the following would be even more readable: > > if (!bus->read != !bus->write || !bus->read_c45 != !bus->write_c45) That's what Andrew had originally. But there was a comment from Sergey [1] which I agree with. I had a hard time wrapping my head around that, so I just listed all the possible bad cases. I don't have a strong opinion, though. > which essentially asserts that the boolean of !method for the read and > write methods must match. Maybe with that as a comment? -michael [1] https://lore.kernel.org/netdev/ae79823f-3697-feee-32e6-645c6f4b4e93@omp.ru/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-03 10:22 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-27 23:07 [PATCH RFC net-next v2 00/12] net: mdio: Start separating C22 and C45 Michael Walle 2022-12-27 23:07 ` Michael Walle 2022-12-27 23:07 ` [PATCH RFC net-next v2 01/12] net: mdio: Add dedicated C45 API to MDIO bus drivers Michael Walle 2022-12-27 23:07 ` Michael Walle 2022-12-27 23:07 ` [PATCH RFC net-next v2 02/12] net: pcs: pcs-xpcs: Use C45 MDIO API Michael Walle 2022-12-27 23:07 ` Michael Walle 2023-01-03 13:28 ` Vladimir Oltean 2023-01-03 13:28 ` Vladimir Oltean 2022-12-27 23:07 ` [PATCH RFC net-next v2 03/12] net: mdio: mdiobus_register: update validation test Michael Walle 2022-12-27 23:07 ` Michael Walle 2023-01-03 10:13 ` Russell King (Oracle) 2023-01-03 10:13 ` Russell King (Oracle) 2023-01-03 10:21 ` Michael Walle [this message] 2023-01-03 10:21 ` Michael Walle 2023-01-03 22:19 ` Russell King (Oracle) 2023-01-03 22:19 ` Russell King (Oracle) 2023-01-09 12:35 ` Michael Walle 2023-01-09 12:35 ` Michael Walle 2023-01-09 12:41 ` Vladimir Oltean 2023-01-09 12:41 ` Vladimir Oltean 2022-12-27 23:07 ` [PATCH RFC net-next v2 04/12] net: mdio: C22 is now optional, EOPNOTSUPP if not provided Michael Walle 2022-12-27 23:07 ` Michael Walle 2022-12-27 23:07 ` [PATCH RFC net-next v2 05/12] net: mdio: Move mdiobus_c45_addr() next to users Michael Walle 2022-12-27 23:07 ` Michael Walle 2022-12-27 23:07 ` [PATCH RFC net-next v2 06/12] net: mdio: mdio-bitbang: Separate C22 and C45 transactions Michael Walle 2022-12-27 23:07 ` Michael Walle 2022-12-28 5:46 ` kernel test robot 2022-12-28 5:46 ` kernel test robot 2023-01-03 13:15 ` Vladimir Oltean 2023-01-03 13:15 ` Vladimir Oltean 2023-01-03 13:27 ` Michael Walle 2023-01-03 13:27 ` Michael Walle 2022-12-27 23:07 ` [PATCH RFC net-next v2 07/12] net: mdio: mvmdio: Convert XSMI bus to new API Michael Walle 2022-12-27 23:07 ` Michael Walle 2022-12-27 23:07 ` [PATCH RFC net-next v2 08/12] net: ethernet: freescale: xgmac: Separate C22 and C45 transactions for xgmac Michael Walle 2022-12-27 23:07 ` Michael Walle 2023-01-03 13:55 ` Vladimir Oltean 2023-01-03 13:55 ` Vladimir Oltean 2022-12-27 23:07 ` [PATCH RFC net-next v2 09/12] net: ethernet: freescale: fec: " Michael Walle 2022-12-27 23:07 ` Michael Walle 2022-12-28 3:31 ` Wei Fang 2022-12-28 3:31 ` Wei Fang 2023-01-03 13:57 ` Vladimir Oltean 2023-01-03 13:57 ` Vladimir Oltean 2022-12-27 23:07 ` [PATCH RFC net-next v2 10/12] net: mdio: add mdiobus_c45_read/write_nested helpers Michael Walle 2022-12-27 23:07 ` Michael Walle 2022-12-27 23:07 ` [PATCH RFC net-next v2 11/12] net: dsa: Separate C22 and C45 MDIO bus transaction methods Michael Walle 2022-12-27 23:07 ` Michael Walle 2023-01-03 15:31 ` Vladimir Oltean 2023-01-03 15:31 ` Vladimir Oltean 2023-01-03 15:48 ` Andrew Lunn 2023-01-03 15:48 ` Andrew Lunn 2023-01-03 15:56 ` Vladimir Oltean 2023-01-03 15:56 ` Vladimir Oltean 2023-01-16 7:51 ` Michael Walle 2023-01-16 7:51 ` Michael Walle 2023-01-16 19:28 ` Vladimir Oltean 2023-01-16 19:28 ` Vladimir Oltean 2022-12-27 23:07 ` [PATCH RFC net-next v2 12/12] net: dsa: mv88e6xxx: Separate C22 and C45 transactions Michael Walle 2022-12-27 23:07 ` Michael Walle 2023-01-03 16:20 ` Vladimir Oltean 2023-01-03 16:20 ` Vladimir Oltean
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=37247c17e5e555dddbc37c3c63a2cadb@walle.cc \ --to=michael@walle.cc \ --cc=Jose.Abreu@synopsys.com \ --cc=Landen.Chao@mediatek.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=dqfext@gmail.com \ --cc=edumazet@google.com \ --cc=f.fainelli@gmail.com \ --cc=geert+renesas@glider.be \ --cc=hkallweit1@gmail.com \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=matthias.bgg@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=olteanv@gmail.com \ --cc=pabeni@redhat.com \ --cc=s.shtylyov@omp.ru \ --cc=sean.wang@mediatek.com \ --cc=shenwei.wang@nxp.com \ --cc=wei.fang@nxp.com \ --cc=xiaoning.wang@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.