* [PATCH RESEND linux-next v4 0/4] Used onboard HUB to reset and add power to hub
@ 2023-01-25 7:26 Anand Moon
2023-01-25 7:26 ` Anand Moon
` (3 more replies)
0 siblings, 4 replies; 20+ messages in thread
From: Anand Moon @ 2023-01-25 7:26 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-amlogic
Amlogic board use gpio-hog to reset the USB hub.
so using onboard hub we could reset the USB hub and
also enable power to the USB hub.
v4: rebased on linux-next
Fixed some small changes like the subject.
Dropped the merge patches.
v3: Fix some small changes in $subject
address the input from Neil
fix the vialab device tree binding as per Krzysztof inputs.
[2] https://lore.kernel.org/all/20230121175639.12818-2-linux.amoon@gmail.com
v2: Odroid C1 / C2 : usb hub reset working as expected.
Odroid N2 : dropped usb hub changes, since my board USB hub
is hitting regression.
Odroid C4 : Fix the device tree binding and used peer-hub for
usb2.0 and usb3.0 hub.
[1] https://lore.kernel.org/all/20230118044418.875-10-linux.amoon@gmail.com
v1: Odroid C1 / C2 : were not working as expected.
Odroid N2 : used single USB 3.0 hub reset.
Odroid C4 : used single USB 3.0 hub reset.
[0] https://patchwork.kernel.org/project/linux-amlogic/list/?series=707292
Any inputs for these changes ?
Thanks
-Anand
Anand Moon (4):
ARM: dts: amlogic: Drop superfluous dr_mode in usb node on odroid C1
arm64: dts: amlogic: Drop superfluous dr_mode in usb node on odroid c2
arm64: dts: meson: move usb-hub node under dwc3 node on Odroid C4
dt-bindings: usb: Fix properties for VL817 hub controller
.../devicetree/bindings/usb/vialab,vl817.yaml | 18 ++++----
arch/arm/boot/dts/meson8b-odroidc1.dts | 1 -
.../boot/dts/amlogic/meson-gxbb-odroidc2.dts | 1 -
.../boot/dts/amlogic/meson-sm1-odroid-c4.dts | 41 +++++++++----------
4 files changed, 30 insertions(+), 31 deletions(-)
--
2.38.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH RESEND linux-next v4 1/4] ARM: dts: amlogic: Drop superfluous dr_mode in usb node on odroid C1
2023-01-25 7:26 [PATCH RESEND linux-next v4 0/4] Used onboard HUB to reset and add power to hub Anand Moon
2023-01-25 7:26 ` Anand Moon
@ 2023-01-25 7:26 ` Anand Moon
2023-01-25 7:26 ` Anand Moon
2023-01-25 7:26 ` Anand Moon
3 siblings, 0 replies; 20+ messages in thread
From: Anand Moon @ 2023-01-25 7:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: linux-amlogic, devicetree, linux-arm-kernel, linux-kernel
Drop superfluous dr_mode="host" as it is the default in meson.dtsi
Fixes: 3325f3e4534c ("ARM: dts: amlogic: Used onboard usb hub reset to enable usb hub")
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm/boot/dts/meson8b-odroidc1.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
index 941682844faf..1097b35b7a49 100644
--- a/arch/arm/boot/dts/meson8b-odroidc1.dts
+++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
@@ -368,7 +368,6 @@ &usb1_phy {
};
&usb1 {
- dr_mode = "host";
#address-cells = <1>;
#size-cells = <0>;
status = "okay";
--
2.38.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH RESEND linux-next v4 1/4] ARM: dts: amlogic: Drop superfluous dr_mode in usb node on odroid C1
@ 2023-01-25 7:26 ` Anand Moon
0 siblings, 0 replies; 20+ messages in thread
From: Anand Moon @ 2023-01-25 7:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: linux-amlogic, devicetree, linux-arm-kernel, linux-kernel
Drop superfluous dr_mode="host" as it is the default in meson.dtsi
Fixes: 3325f3e4534c ("ARM: dts: amlogic: Used onboard usb hub reset to enable usb hub")
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm/boot/dts/meson8b-odroidc1.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
index 941682844faf..1097b35b7a49 100644
--- a/arch/arm/boot/dts/meson8b-odroidc1.dts
+++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
@@ -368,7 +368,6 @@ &usb1_phy {
};
&usb1 {
- dr_mode = "host";
#address-cells = <1>;
#size-cells = <0>;
status = "okay";
--
2.38.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH RESEND linux-next v4 1/4] ARM: dts: amlogic: Drop superfluous dr_mode in usb node on odroid C1
@ 2023-01-25 7:26 ` Anand Moon
0 siblings, 0 replies; 20+ messages in thread
From: Anand Moon @ 2023-01-25 7:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: linux-amlogic, devicetree, linux-arm-kernel, linux-kernel
Drop superfluous dr_mode="host" as it is the default in meson.dtsi
Fixes: 3325f3e4534c ("ARM: dts: amlogic: Used onboard usb hub reset to enable usb hub")
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm/boot/dts/meson8b-odroidc1.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
index 941682844faf..1097b35b7a49 100644
--- a/arch/arm/boot/dts/meson8b-odroidc1.dts
+++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
@@ -368,7 +368,6 @@ &usb1_phy {
};
&usb1 {
- dr_mode = "host";
#address-cells = <1>;
#size-cells = <0>;
status = "okay";
--
2.38.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH RESEND linux-next v4 2/4] arm64: dts: amlogic: Drop superfluous dr_mode in usb node on odroid c2
2023-01-25 7:26 [PATCH RESEND linux-next v4 0/4] Used onboard HUB to reset and add power to hub Anand Moon
2023-01-25 7:26 ` Anand Moon
@ 2023-01-25 7:26 ` Anand Moon
2023-01-25 7:26 ` Anand Moon
2023-01-25 7:26 ` Anand Moon
3 siblings, 0 replies; 20+ messages in thread
From: Anand Moon @ 2023-01-25 7:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: linux-amlogic, devicetree, linux-arm-kernel, linux-kernel
Drop superfluous dr_mode="host" as it is the default in meson-gxbb.dtsi
Fixes: f24859bbec8a ("arm64: dts: amlogic: Used onboard usb hub reset on odroid c2")
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 01356437a077..70b10934a811 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -399,7 +399,6 @@ &usb0 {
};
&usb1 {
- dr_mode = "host";
#address-cells = <1>;
#size-cells = <0>;
status = "okay";
--
2.38.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH RESEND linux-next v4 2/4] arm64: dts: amlogic: Drop superfluous dr_mode in usb node on odroid c2
@ 2023-01-25 7:26 ` Anand Moon
0 siblings, 0 replies; 20+ messages in thread
From: Anand Moon @ 2023-01-25 7:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: linux-amlogic, devicetree, linux-arm-kernel, linux-kernel
Drop superfluous dr_mode="host" as it is the default in meson-gxbb.dtsi
Fixes: f24859bbec8a ("arm64: dts: amlogic: Used onboard usb hub reset on odroid c2")
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 01356437a077..70b10934a811 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -399,7 +399,6 @@ &usb0 {
};
&usb1 {
- dr_mode = "host";
#address-cells = <1>;
#size-cells = <0>;
status = "okay";
--
2.38.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH RESEND linux-next v4 2/4] arm64: dts: amlogic: Drop superfluous dr_mode in usb node on odroid c2
@ 2023-01-25 7:26 ` Anand Moon
0 siblings, 0 replies; 20+ messages in thread
From: Anand Moon @ 2023-01-25 7:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: linux-amlogic, devicetree, linux-arm-kernel, linux-kernel
Drop superfluous dr_mode="host" as it is the default in meson-gxbb.dtsi
Fixes: f24859bbec8a ("arm64: dts: amlogic: Used onboard usb hub reset on odroid c2")
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 01356437a077..70b10934a811 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -399,7 +399,6 @@ &usb0 {
};
&usb1 {
- dr_mode = "host";
#address-cells = <1>;
#size-cells = <0>;
status = "okay";
--
2.38.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH RESEND linux-next v4 3/4] arm64: dts: meson: move usb-hub node under dwc3 node on Odroid C4
2023-01-25 7:26 [PATCH RESEND linux-next v4 0/4] Used onboard HUB to reset and add power to hub Anand Moon
2023-01-25 7:26 ` Anand Moon
@ 2023-01-25 7:26 ` Anand Moon
2023-01-25 7:26 ` Anand Moon
2023-01-25 7:26 ` Anand Moon
3 siblings, 0 replies; 20+ messages in thread
From: Anand Moon @ 2023-01-25 7:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: linux-amlogic, devicetree, linux-arm-kernel, linux-kernel
Move the usb-hub node under dwc3 node and drop superfluous
dr_mode as it is the default in meson-g12-common.dtsi.
Fixes: 71593b2020b3 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid c4")
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
.../boot/dts/amlogic/meson-sm1-odroid-c4.dts | 41 +++++++++----------
1 file changed, 20 insertions(+), 21 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
index d04768a66bfe..a988015dd2d5 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
@@ -26,30 +26,29 @@ led-blue {
sound {
model = "ODROID-C4";
};
+};
+&dwc3 {
/* USB hub supports both USB 2.0 and USB 3.0 root hub */
- usb-hub {
- dr_mode = "host";
- #address-cells = <1>;
- #size-cells = <0>;
-
- /* 2.0 hub on port 1 */
- hub_2_0: hub@1 {
- compatible = "usb2109,2817";
- reg = <1>;
- peer-hub = <&hub_3_0>;
- reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
- vdd-supply = <&vcc_5v>;
- };
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* 2.0 hub on port 1 */
+ hub_2_0: hub@1 {
+ compatible = "usb2109,2817";
+ reg = <1>;
+ peer-hub = <&hub_3_0>;
+ reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+ vdd-supply = <&vcc_5v>;
+ };
- /* 3.1 hub on port 4 */
- hub_3_0: hub@2 {
- compatible = "usb2109,817";
- reg = <2>;
- peer-hub = <&hub_2_0>;
- reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
- vdd-supply = <&vcc_5v>;
- };
+ /* 3.1 hub on port 4 */
+ hub_3_0: hub@2 {
+ compatible = "usb2109,817";
+ reg = <2>;
+ peer-hub = <&hub_2_0>;
+ reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+ vdd-supply = <&vcc_5v>;
};
};
--
2.38.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH RESEND linux-next v4 3/4] arm64: dts: meson: move usb-hub node under dwc3 node on Odroid C4
@ 2023-01-25 7:26 ` Anand Moon
0 siblings, 0 replies; 20+ messages in thread
From: Anand Moon @ 2023-01-25 7:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: linux-amlogic, devicetree, linux-arm-kernel, linux-kernel
Move the usb-hub node under dwc3 node and drop superfluous
dr_mode as it is the default in meson-g12-common.dtsi.
Fixes: 71593b2020b3 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid c4")
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
.../boot/dts/amlogic/meson-sm1-odroid-c4.dts | 41 +++++++++----------
1 file changed, 20 insertions(+), 21 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
index d04768a66bfe..a988015dd2d5 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
@@ -26,30 +26,29 @@ led-blue {
sound {
model = "ODROID-C4";
};
+};
+&dwc3 {
/* USB hub supports both USB 2.0 and USB 3.0 root hub */
- usb-hub {
- dr_mode = "host";
- #address-cells = <1>;
- #size-cells = <0>;
-
- /* 2.0 hub on port 1 */
- hub_2_0: hub@1 {
- compatible = "usb2109,2817";
- reg = <1>;
- peer-hub = <&hub_3_0>;
- reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
- vdd-supply = <&vcc_5v>;
- };
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* 2.0 hub on port 1 */
+ hub_2_0: hub@1 {
+ compatible = "usb2109,2817";
+ reg = <1>;
+ peer-hub = <&hub_3_0>;
+ reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+ vdd-supply = <&vcc_5v>;
+ };
- /* 3.1 hub on port 4 */
- hub_3_0: hub@2 {
- compatible = "usb2109,817";
- reg = <2>;
- peer-hub = <&hub_2_0>;
- reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
- vdd-supply = <&vcc_5v>;
- };
+ /* 3.1 hub on port 4 */
+ hub_3_0: hub@2 {
+ compatible = "usb2109,817";
+ reg = <2>;
+ peer-hub = <&hub_2_0>;
+ reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+ vdd-supply = <&vcc_5v>;
};
};
--
2.38.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH RESEND linux-next v4 3/4] arm64: dts: meson: move usb-hub node under dwc3 node on Odroid C4
@ 2023-01-25 7:26 ` Anand Moon
0 siblings, 0 replies; 20+ messages in thread
From: Anand Moon @ 2023-01-25 7:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: linux-amlogic, devicetree, linux-arm-kernel, linux-kernel
Move the usb-hub node under dwc3 node and drop superfluous
dr_mode as it is the default in meson-g12-common.dtsi.
Fixes: 71593b2020b3 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid c4")
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
.../boot/dts/amlogic/meson-sm1-odroid-c4.dts | 41 +++++++++----------
1 file changed, 20 insertions(+), 21 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
index d04768a66bfe..a988015dd2d5 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
@@ -26,30 +26,29 @@ led-blue {
sound {
model = "ODROID-C4";
};
+};
+&dwc3 {
/* USB hub supports both USB 2.0 and USB 3.0 root hub */
- usb-hub {
- dr_mode = "host";
- #address-cells = <1>;
- #size-cells = <0>;
-
- /* 2.0 hub on port 1 */
- hub_2_0: hub@1 {
- compatible = "usb2109,2817";
- reg = <1>;
- peer-hub = <&hub_3_0>;
- reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
- vdd-supply = <&vcc_5v>;
- };
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* 2.0 hub on port 1 */
+ hub_2_0: hub@1 {
+ compatible = "usb2109,2817";
+ reg = <1>;
+ peer-hub = <&hub_3_0>;
+ reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+ vdd-supply = <&vcc_5v>;
+ };
- /* 3.1 hub on port 4 */
- hub_3_0: hub@2 {
- compatible = "usb2109,817";
- reg = <2>;
- peer-hub = <&hub_2_0>;
- reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
- vdd-supply = <&vcc_5v>;
- };
+ /* 3.1 hub on port 4 */
+ hub_3_0: hub@2 {
+ compatible = "usb2109,817";
+ reg = <2>;
+ peer-hub = <&hub_2_0>;
+ reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+ vdd-supply = <&vcc_5v>;
};
};
--
2.38.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH RESEND linux-next v4 4/4] dt-bindings: usb: Fix properties for VL817 hub controller
2023-01-25 7:26 [PATCH RESEND linux-next v4 0/4] Used onboard HUB to reset and add power to hub Anand Moon
@ 2023-01-25 7:26 ` Anand Moon
2023-01-25 7:26 ` Anand Moon
` (2 subsequent siblings)
3 siblings, 0 replies; 20+ messages in thread
From: Anand Moon @ 2023-01-25 7:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski
Cc: linux-amlogic, Krzysztof Kozlowski, linux-usb, devicetree, linux-kernel
Cleanup by removing unneeded quotes from refs and
add maxItems to reset-gpios and fix the required list.
Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller")
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
.../devicetree/bindings/usb/vialab,vl817.yaml | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
index 5f9771e22058..23a13e1d5c7a 100644
--- a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
+++ b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
@@ -14,29 +14,32 @@ allOf:
properties:
compatible:
- items:
- - enum:
- - usb2109,2817
- - usb2109,817
+ enum:
+ - usb2109,2817
+ - usb2109,817
reg: true
reset-gpios:
- description: GPIO controlling the RESET# pin.
+ maxItems: 1
+ description:
+ GPIO controlling the RESET# pin.
vdd-supply:
description:
phandle to the regulator that provides power to the hub.
peer-hub:
- $ref: '/schemas/types.yaml#/definitions/phandle'
+ $ref: /schemas/types.yaml#/definitions/phandle
description:
phandle to the peer hub on the controller.
required:
- - peer-hub
- compatible
- reg
+ - reset-gpios
+ - vdd-supply
+ - peer-hub
additionalProperties: false
@@ -45,7 +48,6 @@ examples:
#include <dt-bindings/gpio/gpio.h>
usb {
- dr_mode = "host";
#address-cells = <1>;
#size-cells = <0>;
--
2.38.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH RESEND linux-next v4 4/4] dt-bindings: usb: Fix properties for VL817 hub controller
@ 2023-01-25 7:26 ` Anand Moon
0 siblings, 0 replies; 20+ messages in thread
From: Anand Moon @ 2023-01-25 7:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski
Cc: linux-amlogic, Krzysztof Kozlowski, linux-usb, devicetree, linux-kernel
Cleanup by removing unneeded quotes from refs and
add maxItems to reset-gpios and fix the required list.
Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller")
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
.../devicetree/bindings/usb/vialab,vl817.yaml | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
index 5f9771e22058..23a13e1d5c7a 100644
--- a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
+++ b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
@@ -14,29 +14,32 @@ allOf:
properties:
compatible:
- items:
- - enum:
- - usb2109,2817
- - usb2109,817
+ enum:
+ - usb2109,2817
+ - usb2109,817
reg: true
reset-gpios:
- description: GPIO controlling the RESET# pin.
+ maxItems: 1
+ description:
+ GPIO controlling the RESET# pin.
vdd-supply:
description:
phandle to the regulator that provides power to the hub.
peer-hub:
- $ref: '/schemas/types.yaml#/definitions/phandle'
+ $ref: /schemas/types.yaml#/definitions/phandle
description:
phandle to the peer hub on the controller.
required:
- - peer-hub
- compatible
- reg
+ - reset-gpios
+ - vdd-supply
+ - peer-hub
additionalProperties: false
@@ -45,7 +48,6 @@ examples:
#include <dt-bindings/gpio/gpio.h>
usb {
- dr_mode = "host";
#address-cells = <1>;
#size-cells = <0>;
--
2.38.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH RESEND linux-next v4 4/4] dt-bindings: usb: Fix properties for VL817 hub controller
2023-01-25 7:26 ` Anand Moon
@ 2023-01-25 7:40 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 20+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-25 7:40 UTC (permalink / raw)
To: Anand Moon, Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski
Cc: linux-amlogic, linux-usb, devicetree, linux-kernel
On 25/01/2023 08:26, Anand Moon wrote:
> Cleanup by removing unneeded quotes from refs and
> add maxItems to reset-gpios and fix the required list.
>
> Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller")
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
NAK.
You ignored my feedback. Please help me understand how my tag appeared here.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH RESEND linux-next v4 4/4] dt-bindings: usb: Fix properties for VL817 hub controller
@ 2023-01-25 7:40 ` Krzysztof Kozlowski
0 siblings, 0 replies; 20+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-25 7:40 UTC (permalink / raw)
To: Anand Moon, Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski
Cc: linux-amlogic, linux-usb, devicetree, linux-kernel
On 25/01/2023 08:26, Anand Moon wrote:
> Cleanup by removing unneeded quotes from refs and
> add maxItems to reset-gpios and fix the required list.
>
> Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller")
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
NAK.
You ignored my feedback. Please help me understand how my tag appeared here.
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH RESEND linux-next v4 4/4] dt-bindings: usb: Fix properties for VL817 hub controller
2023-01-25 7:40 ` Krzysztof Kozlowski
@ 2023-01-25 9:43 ` Anand Moon
-1 siblings, 0 replies; 20+ messages in thread
From: Anand Moon @ 2023-01-25 9:43 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
linux-amlogic, linux-usb, devicetree, linux-kernel
Hi Krzysztof,
On Wed, 25 Jan 2023 at 13:10, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 25/01/2023 08:26, Anand Moon wrote:
> > Cleanup by removing unneeded quotes from refs and
> > add maxItems to reset-gpios and fix the required list.
> >
> > Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller")
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> NAK.
>
> You ignored my feedback. Please help me understand how my tag appeared here.
>
I have followed your feedback and modified the below patch
I thought you review these changes see below.
[0] https://lore.kernel.org/all/df1c8545-01d0-3821-0c19-07a369e40472@linaro.org/
> Best regards,
> Krzysztof
>
Thanks
-Anand
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH RESEND linux-next v4 4/4] dt-bindings: usb: Fix properties for VL817 hub controller
@ 2023-01-25 9:43 ` Anand Moon
0 siblings, 0 replies; 20+ messages in thread
From: Anand Moon @ 2023-01-25 9:43 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
linux-amlogic, linux-usb, devicetree, linux-kernel
Hi Krzysztof,
On Wed, 25 Jan 2023 at 13:10, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 25/01/2023 08:26, Anand Moon wrote:
> > Cleanup by removing unneeded quotes from refs and
> > add maxItems to reset-gpios and fix the required list.
> >
> > Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller")
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> NAK.
>
> You ignored my feedback. Please help me understand how my tag appeared here.
>
I have followed your feedback and modified the below patch
I thought you review these changes see below.
[0] https://lore.kernel.org/all/df1c8545-01d0-3821-0c19-07a369e40472@linaro.org/
> Best regards,
> Krzysztof
>
Thanks
-Anand
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH RESEND linux-next v4 4/4] dt-bindings: usb: Fix properties for VL817 hub controller
2023-01-25 9:43 ` Anand Moon
@ 2023-01-25 9:57 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 20+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-25 9:57 UTC (permalink / raw)
To: Anand Moon
Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
linux-amlogic, linux-usb, devicetree, linux-kernel
On 25/01/2023 10:43, Anand Moon wrote:
> Hi Krzysztof,
>
> On Wed, 25 Jan 2023 at 13:10, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 25/01/2023 08:26, Anand Moon wrote:
>>> Cleanup by removing unneeded quotes from refs and
>>> add maxItems to reset-gpios and fix the required list.
>>>
>>> Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller")
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> NAK.
>>
>> You ignored my feedback. Please help me understand how my tag appeared here.
>>
> I have followed your feedback and modified the below patch
> I thought you review these changes see below.
>
> [0] https://lore.kernel.org/all/df1c8545-01d0-3821-0c19-07a369e40472@linaro.org/
This was entirely different patch. You cannot take reviews from
something else and apply to other patch.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH RESEND linux-next v4 4/4] dt-bindings: usb: Fix properties for VL817 hub controller
@ 2023-01-25 9:57 ` Krzysztof Kozlowski
0 siblings, 0 replies; 20+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-25 9:57 UTC (permalink / raw)
To: Anand Moon
Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
linux-amlogic, linux-usb, devicetree, linux-kernel
On 25/01/2023 10:43, Anand Moon wrote:
> Hi Krzysztof,
>
> On Wed, 25 Jan 2023 at 13:10, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 25/01/2023 08:26, Anand Moon wrote:
>>> Cleanup by removing unneeded quotes from refs and
>>> add maxItems to reset-gpios and fix the required list.
>>>
>>> Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller")
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> NAK.
>>
>> You ignored my feedback. Please help me understand how my tag appeared here.
>>
> I have followed your feedback and modified the below patch
> I thought you review these changes see below.
>
> [0] https://lore.kernel.org/all/df1c8545-01d0-3821-0c19-07a369e40472@linaro.org/
This was entirely different patch. You cannot take reviews from
something else and apply to other patch.
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH RESEND linux-next v4 4/4] dt-bindings: usb: Fix properties for VL817 hub controller
2023-01-25 9:57 ` Krzysztof Kozlowski
@ 2023-01-25 14:24 ` Anand Moon
-1 siblings, 0 replies; 20+ messages in thread
From: Anand Moon @ 2023-01-25 14:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
linux-amlogic, linux-usb, devicetree, linux-kernel
Hi Krzysztof,
On Wed, 25 Jan 2023 at 15:27, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 25/01/2023 10:43, Anand Moon wrote:
> > Hi Krzysztof,
> >
> > On Wed, 25 Jan 2023 at 13:10, Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 25/01/2023 08:26, Anand Moon wrote:
> >>> Cleanup by removing unneeded quotes from refs and
> >>> add maxItems to reset-gpios and fix the required list.
> >>>
> >>> Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller")
> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>
> >> NAK.
> >>
> >> You ignored my feedback. Please help me understand how my tag appeared here.
> >>
> > I have followed your feedback and modified the below patch
> > I thought you review these changes see below.
> >
> > [0] https://lore.kernel.org/all/df1c8545-01d0-3821-0c19-07a369e40472@linaro.org/
>
> This was entirely different patch. You cannot take reviews from
> something else and apply to other patch.
>
> Best regards,
> Krzysztof
>
ok, I will keep this in my mind.
Thanks
-Anand
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH RESEND linux-next v4 4/4] dt-bindings: usb: Fix properties for VL817 hub controller
@ 2023-01-25 14:24 ` Anand Moon
0 siblings, 0 replies; 20+ messages in thread
From: Anand Moon @ 2023-01-25 14:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
linux-amlogic, linux-usb, devicetree, linux-kernel
Hi Krzysztof,
On Wed, 25 Jan 2023 at 15:27, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 25/01/2023 10:43, Anand Moon wrote:
> > Hi Krzysztof,
> >
> > On Wed, 25 Jan 2023 at 13:10, Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 25/01/2023 08:26, Anand Moon wrote:
> >>> Cleanup by removing unneeded quotes from refs and
> >>> add maxItems to reset-gpios and fix the required list.
> >>>
> >>> Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller")
> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>
> >> NAK.
> >>
> >> You ignored my feedback. Please help me understand how my tag appeared here.
> >>
> > I have followed your feedback and modified the below patch
> > I thought you review these changes see below.
> >
> > [0] https://lore.kernel.org/all/df1c8545-01d0-3821-0c19-07a369e40472@linaro.org/
>
> This was entirely different patch. You cannot take reviews from
> something else and apply to other patch.
>
> Best regards,
> Krzysztof
>
ok, I will keep this in my mind.
Thanks
-Anand
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2023-01-25 14:25 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-25 7:26 [PATCH RESEND linux-next v4 0/4] Used onboard HUB to reset and add power to hub Anand Moon
2023-01-25 7:26 ` [PATCH RESEND linux-next v4 1/4] ARM: dts: amlogic: Drop superfluous dr_mode in usb node on odroid C1 Anand Moon
2023-01-25 7:26 ` Anand Moon
2023-01-25 7:26 ` Anand Moon
2023-01-25 7:26 ` [PATCH RESEND linux-next v4 2/4] arm64: dts: amlogic: Drop superfluous dr_mode in usb node on odroid c2 Anand Moon
2023-01-25 7:26 ` Anand Moon
2023-01-25 7:26 ` Anand Moon
2023-01-25 7:26 ` [PATCH RESEND linux-next v4 3/4] arm64: dts: meson: move usb-hub node under dwc3 node on Odroid C4 Anand Moon
2023-01-25 7:26 ` Anand Moon
2023-01-25 7:26 ` Anand Moon
2023-01-25 7:26 ` [PATCH RESEND linux-next v4 4/4] dt-bindings: usb: Fix properties for VL817 hub controller Anand Moon
2023-01-25 7:26 ` Anand Moon
2023-01-25 7:40 ` Krzysztof Kozlowski
2023-01-25 7:40 ` Krzysztof Kozlowski
2023-01-25 9:43 ` Anand Moon
2023-01-25 9:43 ` Anand Moon
2023-01-25 9:57 ` Krzysztof Kozlowski
2023-01-25 9:57 ` Krzysztof Kozlowski
2023-01-25 14:24 ` Anand Moon
2023-01-25 14:24 ` Anand Moon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.