* [RESEND PATCH] configs: imx8mn_bsh_smm_s2: remove console from bootargs
@ 2023-01-28 16:08 Dario Binacchi
2023-01-28 17:50 ` Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Dario Binacchi @ 2023-01-28 16:08 UTC (permalink / raw)
To: u-boot
Cc: Fabio Estevam, Tom Rini, Stefano Babic, Dario Binacchi,
Ariel D'Alessandro, Michael Trimarchi, linux-amarula
The Linux kernel device tree already specifies the device to be used for
boot console output with a stdout-path property under /chosen.
Fixes: 36b661dc919da ("Merge branch 'next'")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
include/configs/imx8mn_bsh_smm_s2.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/imx8mn_bsh_smm_s2.h b/include/configs/imx8mn_bsh_smm_s2.h
index e97b8e871d22..deeed9c2f582 100644
--- a/include/configs/imx8mn_bsh_smm_s2.h
+++ b/include/configs/imx8mn_bsh_smm_s2.h
@@ -14,7 +14,7 @@
#include <config_distro_bootcmd.h>
#define NANDARGS \
- "nandargs=setenv bootargs console=${console} " \
+ "nandargs=setenv bootargs " \
"${optargs} " \
"mtdparts=${mtdparts} " \
"root=${nandroot} " \
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH] configs: imx8mn_bsh_smm_s2: remove console from bootargs
2023-01-28 16:08 [RESEND PATCH] configs: imx8mn_bsh_smm_s2: remove console from bootargs Dario Binacchi
@ 2023-01-28 17:50 ` Fabio Estevam
2023-01-29 16:47 ` Dario Binacchi
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2023-01-28 17:50 UTC (permalink / raw)
To: Dario Binacchi
Cc: u-boot, Tom Rini, Stefano Babic, Ariel D'Alessandro,
Michael Trimarchi, linux-amarula
Hi Dario,
On Sat, Jan 28, 2023 at 1:09 PM Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:
>
> The Linux kernel device tree already specifies the device to be used for
> boot console output with a stdout-path property under /chosen.
>
> Fixes: 36b661dc919da ("Merge branch 'next'")
The patch looks good, but I don't understand why this needs a Fixes tag.
Reviewed-by: Fabio Estevam <festevam@denx.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH] configs: imx8mn_bsh_smm_s2: remove console from bootargs
2023-01-28 17:50 ` Fabio Estevam
@ 2023-01-29 16:47 ` Dario Binacchi
2023-01-29 19:46 ` Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Dario Binacchi @ 2023-01-29 16:47 UTC (permalink / raw)
To: Fabio Estevam
Cc: u-boot, Tom Rini, Stefano Babic, Ariel D'Alessandro,
Michael Trimarchi, linux-amarula
Hi Fabio,
On Sat, Jan 28, 2023 at 6:50 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Dario,
>
> On Sat, Jan 28, 2023 at 1:09 PM Dario Binacchi
> <dario.binacchi@amarulasolutions.com> wrote:
> >
> > The Linux kernel device tree already specifies the device to be used for
> > boot console output with a stdout-path property under /chosen.
> >
> > Fixes: 36b661dc919da ("Merge branch 'next'")
>
> The patch looks good, but I don't understand why this needs a Fixes tag.
The patch re-added 'console=${console}':
diff --cc include/configs/imx8mn_bsh_smm_s2.h
index d09c2ab01610,84c19824bdca..c6b296281424
--- a/include/configs/imx8mn_bsh_smm_s2.h
+++ b/include/configs/imx8mn_bsh_smm_s2.h
@@@ -14,11 -14,8 +14,9 @@@
#include <config_distro_bootcmd.h>
#define NANDARGS \
- "mtdids=" CONFIG_MTDIDS_DEFAULT "\0" \
- "mtdparts=" CONFIG_MTDPARTS_DEFAULT "\0" \
- "nandargs=setenv bootargs " \
+ "nandargs=setenv bootargs console=${console} " \
"${optargs} " \
+ "mtdparts=${mtdparts} " \
"root=${nandroot} " \
"rootfstype=${nandrootfstype}\0" \
"nandroot=ubi0:root rw ubi.mtd=nandrootfs\0" \
that I already removed in the commit:
bede82f75075 ("configs: imx8mn_bsh_smm_s2: remove console from bootargs").
This is why I decided to add the fix tag.
Thanks and regards,
Dario
>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
--
Dario Binacchi
Senior Embedded Linux Developer
dario.binacchi@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH] configs: imx8mn_bsh_smm_s2: remove console from bootargs
2023-01-29 16:47 ` Dario Binacchi
@ 2023-01-29 19:46 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2023-01-29 19:46 UTC (permalink / raw)
To: Dario Binacchi
Cc: u-boot, Tom Rini, Stefano Babic, Ariel D'Alessandro,
Michael Trimarchi, linux-amarula
On Sun, Jan 29, 2023 at 1:47 PM Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:
> The patch re-added 'console=${console}':
> diff --cc include/configs/imx8mn_bsh_smm_s2.h
> index d09c2ab01610,84c19824bdca..c6b296281424
> --- a/include/configs/imx8mn_bsh_smm_s2.h
> +++ b/include/configs/imx8mn_bsh_smm_s2.h
> @@@ -14,11 -14,8 +14,9 @@@
> #include <config_distro_bootcmd.h>
>
> #define NANDARGS \
> - "mtdids=" CONFIG_MTDIDS_DEFAULT "\0" \
> - "mtdparts=" CONFIG_MTDPARTS_DEFAULT "\0" \
> - "nandargs=setenv bootargs " \
> + "nandargs=setenv bootargs console=${console} " \
> "${optargs} " \
> + "mtdparts=${mtdparts} " \
> "root=${nandroot} " \
> "rootfstype=${nandrootfstype}\0" \
> "nandroot=ubi0:root rw ubi.mtd=nandrootfs\0" \
>
> that I already removed in the commit:
> bede82f75075 ("configs: imx8mn_bsh_smm_s2: remove console from bootargs").
> This is why I decided to add the fix tag.
Understood.
It would be nice to have such an explanation in the commit log.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-29 19:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-28 16:08 [RESEND PATCH] configs: imx8mn_bsh_smm_s2: remove console from bootargs Dario Binacchi
2023-01-28 17:50 ` Fabio Estevam
2023-01-29 16:47 ` Dario Binacchi
2023-01-29 19:46 ` Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.