* [PATCH] ARM: Allow DEBUG_UNCOMPRESS on ARCH_MULTIPLATFORM
@ 2023-01-29 16:00 ` Jonathan Neuschäfer
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Neuschäfer @ 2023-01-29 16:00 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Jonathan Neuschäfer, Russell King, Arnd Bergmann,
William Zhang, Michael Walle, Florian Fainelli, Tony Lindgren,
Kavyasree Kotagiri, Ard Biesheuvel, linux-kernel
A kernel with DEBUG_UNCOMPRESS=y will only work on one platform, but
that is already the case with DEBUG_LL=y (and documented in its help
text), and DEBUG_UNCOMPRESS depends on DEBUG_LL. Therefore, I don't
think users need to be prevented from enabling DEBUG_UNCOMPRESS on
ARCH_MULTIPLATFORM kernels.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
arch/arm/Kconfig.debug | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index c345775f035bc..655f84ada30f4 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -1904,7 +1904,6 @@ config DEBUG_UART_8250_PALMCHIP
config DEBUG_UNCOMPRESS
bool "Enable decompressor debugging via DEBUG_LL output"
- depends on !ARCH_MULTIPLATFORM
depends on !(ARCH_FOOTBRIDGE || ARCH_RPC || ARCH_SA1100)
depends on DEBUG_LL && !DEBUG_OMAP2PLUS_UART && \
(!DEBUG_TEGRA_UART || !ZBOOT_ROM) && \
--
2.39.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: Allow DEBUG_UNCOMPRESS on ARCH_MULTIPLATFORM
@ 2023-01-29 16:00 ` Jonathan Neuschäfer
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Neuschäfer @ 2023-01-29 16:00 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Jonathan Neuschäfer, Russell King, Arnd Bergmann,
William Zhang, Michael Walle, Florian Fainelli, Tony Lindgren,
Kavyasree Kotagiri, Ard Biesheuvel, linux-kernel
A kernel with DEBUG_UNCOMPRESS=y will only work on one platform, but
that is already the case with DEBUG_LL=y (and documented in its help
text), and DEBUG_UNCOMPRESS depends on DEBUG_LL. Therefore, I don't
think users need to be prevented from enabling DEBUG_UNCOMPRESS on
ARCH_MULTIPLATFORM kernels.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
arch/arm/Kconfig.debug | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index c345775f035bc..655f84ada30f4 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -1904,7 +1904,6 @@ config DEBUG_UART_8250_PALMCHIP
config DEBUG_UNCOMPRESS
bool "Enable decompressor debugging via DEBUG_LL output"
- depends on !ARCH_MULTIPLATFORM
depends on !(ARCH_FOOTBRIDGE || ARCH_RPC || ARCH_SA1100)
depends on DEBUG_LL && !DEBUG_OMAP2PLUS_UART && \
(!DEBUG_TEGRA_UART || !ZBOOT_ROM) && \
--
2.39.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: Allow DEBUG_UNCOMPRESS on ARCH_MULTIPLATFORM
2023-01-29 16:00 ` Jonathan Neuschäfer
@ 2023-01-30 8:08 ` Arnd Bergmann
-1 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-01-30 8:08 UTC (permalink / raw)
To: Jonathan Neuschäfer, linux-arm-kernel
Cc: Russell King, William Zhang, Michael Walle, Florian Fainelli,
Tony Lindgren, Kavyasree Kotagiri, Ard Biesheuvel, linux-kernel
On Sun, Jan 29, 2023, at 17:00, Jonathan Neuschäfer wrote:
> A kernel with DEBUG_UNCOMPRESS=y will only work on one platform, but
> that is already the case with DEBUG_LL=y (and documented in its help
> text), and DEBUG_UNCOMPRESS depends on DEBUG_LL. Therefore, I don't
> think users need to be prevented from enabling DEBUG_UNCOMPRESS on
> ARCH_MULTIPLATFORM kernels.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
I think we should instead change the help text for CONFIG_DEBUG_LL.
There is a very significant difference between the requirements
of DEBUG_LL compared to DEBUG_UNCOMPRESS. The former only provides
the platform specific functions but does not call them unless
a user explicitly passes the "earlyprintk" command line argument
or adds explicit function calls to printascii(), while the latter
makes the kernel immediately unbootable.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: Allow DEBUG_UNCOMPRESS on ARCH_MULTIPLATFORM
@ 2023-01-30 8:08 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-01-30 8:08 UTC (permalink / raw)
To: Jonathan Neuschäfer, linux-arm-kernel
Cc: Russell King, William Zhang, Michael Walle, Florian Fainelli,
Tony Lindgren, Kavyasree Kotagiri, Ard Biesheuvel, linux-kernel
On Sun, Jan 29, 2023, at 17:00, Jonathan Neuschäfer wrote:
> A kernel with DEBUG_UNCOMPRESS=y will only work on one platform, but
> that is already the case with DEBUG_LL=y (and documented in its help
> text), and DEBUG_UNCOMPRESS depends on DEBUG_LL. Therefore, I don't
> think users need to be prevented from enabling DEBUG_UNCOMPRESS on
> ARCH_MULTIPLATFORM kernels.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
I think we should instead change the help text for CONFIG_DEBUG_LL.
There is a very significant difference between the requirements
of DEBUG_LL compared to DEBUG_UNCOMPRESS. The former only provides
the platform specific functions but does not call them unless
a user explicitly passes the "earlyprintk" command line argument
or adds explicit function calls to printascii(), while the latter
makes the kernel immediately unbootable.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-30 8:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-29 16:00 [PATCH] ARM: Allow DEBUG_UNCOMPRESS on ARCH_MULTIPLATFORM Jonathan Neuschäfer
2023-01-29 16:00 ` Jonathan Neuschäfer
2023-01-30 8:08 ` Arnd Bergmann
2023-01-30 8:08 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.