From: Jesse Brandeburg <jesse.brandeburg@intel.com> To: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, edumazet@google.com, Jesse Brandeburg <jesse.brandeburg@intel.com> Subject: [PATCH net-next v1 2/2] net/core: refactor promiscuous mode message Date: Tue, 14 Feb 2023 13:01:17 -0800 [thread overview] Message-ID: <20230214210117.23123-3-jesse.brandeburg@intel.com> (raw) In-Reply-To: <20230214210117.23123-1-jesse.brandeburg@intel.com> The kernel stack can be more consistent by printing the IFF_PROMISC aka promiscuous enable/disable messages with the standard netdev_info message which can include bus and driver info as well as the device. typical command usage from user space looks like: ip link set eth0 promisc <on|off> But lots of utilities such as bridge, tcpdump, etc put the interface into promiscuous mode. old message: [ 406.034418] device eth0 entered promiscuous mode [ 408.424703] device eth0 left promiscuous mode new message: [ 406.034431] ice 0000:17:00.0 eth0: entered promiscuous mode [ 408.424715] ice 0000:17:00.0 eth0: left promiscuous mode Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- I'm unsure about this one because it's changing a long standard kernel message to a slightly different format. I think the new way looks better and has more information. --- net/core/dev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index ad1e6482e1c1..357081b0113c 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -8321,9 +8321,8 @@ static int __dev_set_promiscuity(struct net_device *dev, int inc, bool notify) } } if (dev->flags != old_flags) { - pr_info("device %s %s promiscuous mode\n", - dev->name, - dev->flags & IFF_PROMISC ? "entered" : "left"); + netdev_info(dev, "%s promiscuous mode\n", + dev->flags & IFF_PROMISC ? "entered" : "left"); if (audit_enabled) { current_uid_gid(&uid, &gid); audit_log(audit_context(), GFP_ATOMIC, -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Jesse Brandeburg <jesse.brandeburg@intel.com> To: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com Cc: netdev@vger.kernel.org, edumazet@google.com, intel-wired-lan@lists.osuosl.org, Jesse Brandeburg <jesse.brandeburg@intel.com> Subject: [Intel-wired-lan] [PATCH net-next v1 2/2] net/core: refactor promiscuous mode message Date: Tue, 14 Feb 2023 13:01:17 -0800 [thread overview] Message-ID: <20230214210117.23123-3-jesse.brandeburg@intel.com> (raw) In-Reply-To: <20230214210117.23123-1-jesse.brandeburg@intel.com> The kernel stack can be more consistent by printing the IFF_PROMISC aka promiscuous enable/disable messages with the standard netdev_info message which can include bus and driver info as well as the device. typical command usage from user space looks like: ip link set eth0 promisc <on|off> But lots of utilities such as bridge, tcpdump, etc put the interface into promiscuous mode. old message: [ 406.034418] device eth0 entered promiscuous mode [ 408.424703] device eth0 left promiscuous mode new message: [ 406.034431] ice 0000:17:00.0 eth0: entered promiscuous mode [ 408.424715] ice 0000:17:00.0 eth0: left promiscuous mode Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- I'm unsure about this one because it's changing a long standard kernel message to a slightly different format. I think the new way looks better and has more information. --- net/core/dev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index ad1e6482e1c1..357081b0113c 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -8321,9 +8321,8 @@ static int __dev_set_promiscuity(struct net_device *dev, int inc, bool notify) } } if (dev->flags != old_flags) { - pr_info("device %s %s promiscuous mode\n", - dev->name, - dev->flags & IFF_PROMISC ? "entered" : "left"); + netdev_info(dev, "%s promiscuous mode\n", + dev->flags & IFF_PROMISC ? "entered" : "left"); if (audit_enabled) { current_uid_gid(&uid, &gid); audit_log(audit_context(), GFP_ATOMIC, -- 2.31.1 _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-02-14 21:01 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-14 21:01 [PATCH net-next v1 0/2] net/core: commmon prints for promisc Jesse Brandeburg 2023-02-14 21:01 ` [Intel-wired-lan] " Jesse Brandeburg 2023-02-14 21:01 ` [PATCH net-next v1 1/2] net/core: print message for allmulticast Jesse Brandeburg 2023-02-14 21:01 ` [Intel-wired-lan] " Jesse Brandeburg 2023-02-14 21:01 ` Jesse Brandeburg [this message] 2023-02-14 21:01 ` [Intel-wired-lan] [PATCH net-next v1 2/2] net/core: refactor promiscuous mode message Jesse Brandeburg 2023-02-16 9:10 ` Paolo Abeni 2023-02-16 9:10 ` Paolo Abeni 2023-02-16 9:40 ` [Intel-wired-lan] [PATCH net-next v1 0/2] net/core: commmon prints for promisc patchwork-bot+netdevbpf 2023-02-16 9:40 ` patchwork-bot+netdevbpf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230214210117.23123-3-jesse.brandeburg@intel.com \ --to=jesse.brandeburg@intel.com \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=kuba@kernel.org \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.