All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>,
	kuba@kernel.org,  davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com,
	intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH net-next v1 2/2] net/core: refactor promiscuous mode message
Date: Thu, 16 Feb 2023 10:10:50 +0100	[thread overview]
Message-ID: <89c60b9f14e3450f14a5337e8dfd6c3972c7be22.camel@redhat.com> (raw)
In-Reply-To: <20230214210117.23123-3-jesse.brandeburg@intel.com>

On Tue, 2023-02-14 at 13:01 -0800, Jesse Brandeburg wrote:
> The kernel stack can be more consistent by printing the IFF_PROMISC
> aka promiscuous enable/disable messages with the standard netdev_info
> message which can include bus and driver info as well as the device.
> 
> typical command usage from user space looks like:
> ip link set eth0 promisc <on|off>
> 
> But lots of utilities such as bridge, tcpdump, etc put the interface into
> promiscuous mode.
> 
> old message:
> [  406.034418] device eth0 entered promiscuous mode
> [  408.424703] device eth0 left promiscuous mode
> 
> new message:
> [  406.034431] ice 0000:17:00.0 eth0: entered promiscuous mode
> [  408.424715] ice 0000:17:00.0 eth0: left promiscuous mode
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> ---
> I'm unsure about this one because it's changing a long standard kernel
> message to a slightly different format. I think the new way looks better
> and has more information.

I guess the relevant question here is if such kind of messages are
somewhat implicitly part of uAPI.

AFAIK the answer is "no", at least for info-level msg, so the patch
LGTM.

Thanks,

Paolo


_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Abeni <pabeni@redhat.com>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>,
	kuba@kernel.org, davem@davemloft.net
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
	edumazet@google.com
Subject: Re: [PATCH net-next v1 2/2] net/core: refactor promiscuous mode message
Date: Thu, 16 Feb 2023 10:10:50 +0100	[thread overview]
Message-ID: <89c60b9f14e3450f14a5337e8dfd6c3972c7be22.camel@redhat.com> (raw)
In-Reply-To: <20230214210117.23123-3-jesse.brandeburg@intel.com>

On Tue, 2023-02-14 at 13:01 -0800, Jesse Brandeburg wrote:
> The kernel stack can be more consistent by printing the IFF_PROMISC
> aka promiscuous enable/disable messages with the standard netdev_info
> message which can include bus and driver info as well as the device.
> 
> typical command usage from user space looks like:
> ip link set eth0 promisc <on|off>
> 
> But lots of utilities such as bridge, tcpdump, etc put the interface into
> promiscuous mode.
> 
> old message:
> [  406.034418] device eth0 entered promiscuous mode
> [  408.424703] device eth0 left promiscuous mode
> 
> new message:
> [  406.034431] ice 0000:17:00.0 eth0: entered promiscuous mode
> [  408.424715] ice 0000:17:00.0 eth0: left promiscuous mode
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> ---
> I'm unsure about this one because it's changing a long standard kernel
> message to a slightly different format. I think the new way looks better
> and has more information.

I guess the relevant question here is if such kind of messages are
somewhat implicitly part of uAPI.

AFAIK the answer is "no", at least for info-level msg, so the patch
LGTM.

Thanks,

Paolo



  reply	other threads:[~2023-02-16  9:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 21:01 [PATCH net-next v1 0/2] net/core: commmon prints for promisc Jesse Brandeburg
2023-02-14 21:01 ` [Intel-wired-lan] " Jesse Brandeburg
2023-02-14 21:01 ` [PATCH net-next v1 1/2] net/core: print message for allmulticast Jesse Brandeburg
2023-02-14 21:01   ` [Intel-wired-lan] " Jesse Brandeburg
2023-02-14 21:01 ` [PATCH net-next v1 2/2] net/core: refactor promiscuous mode message Jesse Brandeburg
2023-02-14 21:01   ` [Intel-wired-lan] " Jesse Brandeburg
2023-02-16  9:10   ` Paolo Abeni [this message]
2023-02-16  9:10     ` Paolo Abeni
2023-02-16  9:40 ` [Intel-wired-lan] [PATCH net-next v1 0/2] net/core: commmon prints for promisc patchwork-bot+netdevbpf
2023-02-16  9:40   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89c60b9f14e3450f14a5337e8dfd6c3972c7be22.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.