All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-serial <linux-serial@vger.kernel.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] serial: imx: Drop a few unneeded casts
Date: Thu, 2 Mar 2023 17:06:37 +0100	[thread overview]
Message-ID: <20230302160637.etw3a4qk4jb7oktf@pengutronix.de> (raw)
In-Reply-To: <6e66bc69-52b7-bea5-1e2c-ad5ed819a6@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 923 bytes --]

Hello Ilpo,

On Thu, Mar 02, 2023 at 05:35:17PM +0200, Ilpo Järvinen wrote:
> On Thu, 2 Mar 2023, Uwe Kleine-König wrote:
> 
> > There is no point in casting a struct uart_port to a struct imx_port
> > just to access the first member of the latter (a struct uart_port).
> > 
> > This introduces code changes.
> 
> I don't know what this sentence is supposed to mean (did you forgot to 
> add a negation into it)?
> 
> The code changes :-) are okay though:

Yes, I intended to write:

	This introduces no changes to the generated binary.

> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Thanks.

Greg isn't in patch collecting mood currently anyhow, so I will wait a
bit before sending out a fixed patch.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-serial <linux-serial@vger.kernel.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] serial: imx: Drop a few unneeded casts
Date: Thu, 2 Mar 2023 17:06:37 +0100	[thread overview]
Message-ID: <20230302160637.etw3a4qk4jb7oktf@pengutronix.de> (raw)
In-Reply-To: <6e66bc69-52b7-bea5-1e2c-ad5ed819a6@linux.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 923 bytes --]

Hello Ilpo,

On Thu, Mar 02, 2023 at 05:35:17PM +0200, Ilpo Järvinen wrote:
> On Thu, 2 Mar 2023, Uwe Kleine-König wrote:
> 
> > There is no point in casting a struct uart_port to a struct imx_port
> > just to access the first member of the latter (a struct uart_port).
> > 
> > This introduces code changes.
> 
> I don't know what this sentence is supposed to mean (did you forgot to 
> add a negation into it)?
> 
> The code changes :-) are okay though:

Yes, I intended to write:

	This introduces no changes to the generated binary.

> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Thanks.

Greg isn't in patch collecting mood currently anyhow, so I will wait a
bit before sending out a fixed patch.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-02 16:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02 11:54 [PATCH] serial: imx: Drop a few unneeded casts Uwe Kleine-König
2023-03-02 11:54 ` Uwe Kleine-König
2023-03-02 15:35 ` Ilpo Järvinen
2023-03-02 15:35   ` Ilpo Järvinen
2023-03-02 16:06   ` Uwe Kleine-König [this message]
2023-03-02 16:06     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230302160637.etw3a4qk4jb7oktf@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.