All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-serial <linux-serial@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] serial: imx: Drop a few unneeded casts
Date: Thu, 2 Mar 2023 17:35:17 +0200 (EET)	[thread overview]
Message-ID: <6e66bc69-52b7-bea5-1e2c-ad5ed819a6@linux.intel.com> (raw)
In-Reply-To: <20230302115417.1860210-1-u.kleine-koenig@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 2348 bytes --]

On Thu, 2 Mar 2023, Uwe Kleine-König wrote:

> There is no point in casting a struct uart_port to a struct imx_port
> just to access the first member of the latter (a struct uart_port).
> 
> This introduces code changes.

I don't know what this sentence is supposed to mean (did you forgot to 
add a negation into it)?

The code changes :-) are okay though:

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>


-- 
 i.

> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/tty/serial/imx.c | 17 ++++++-----------
>  1 file changed, 6 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 523f296d5747..84bc0e768726 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -1808,9 +1808,7 @@ imx_uart_set_termios(struct uart_port *port, struct ktermios *termios,
>  
>  static const char *imx_uart_type(struct uart_port *port)
>  {
> -	struct imx_port *sport = (struct imx_port *)port;
> -
> -	return sport->port.type == PORT_IMX ? "IMX" : NULL;
> +	return port->type == PORT_IMX ? "IMX" : NULL;
>  }
>  
>  /*
> @@ -1818,10 +1816,8 @@ static const char *imx_uart_type(struct uart_port *port)
>   */
>  static void imx_uart_config_port(struct uart_port *port, int flags)
>  {
> -	struct imx_port *sport = (struct imx_port *)port;
> -
>  	if (flags & UART_CONFIG_TYPE)
> -		sport->port.type = PORT_IMX;
> +		port->type = PORT_IMX;
>  }
>  
>  /*
> @@ -1832,20 +1828,19 @@ static void imx_uart_config_port(struct uart_port *port, int flags)
>  static int
>  imx_uart_verify_port(struct uart_port *port, struct serial_struct *ser)
>  {
> -	struct imx_port *sport = (struct imx_port *)port;
>  	int ret = 0;
>  
>  	if (ser->type != PORT_UNKNOWN && ser->type != PORT_IMX)
>  		ret = -EINVAL;
> -	if (sport->port.irq != ser->irq)
> +	if (port->irq != ser->irq)
>  		ret = -EINVAL;
>  	if (ser->io_type != UPIO_MEM)
>  		ret = -EINVAL;
> -	if (sport->port.uartclk / 16 != ser->baud_base)
> +	if (port->uartclk / 16 != ser->baud_base)
>  		ret = -EINVAL;
> -	if (sport->port.mapbase != (unsigned long)ser->iomem_base)
> +	if (port->mapbase != (unsigned long)ser->iomem_base)
>  		ret = -EINVAL;
> -	if (sport->port.iobase != ser->port)
> +	if (port->iobase != ser->port)
>  		ret = -EINVAL;
>  	if (ser->hub6 != 0)
>  		ret = -EINVAL;
> 

WARNING: multiple messages have this Message-ID (diff)
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Jiri Slaby <jirislaby@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	 Pengutronix Kernel Team <kernel@pengutronix.de>,
	 Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	 linux-serial <linux-serial@vger.kernel.org>,
	 linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] serial: imx: Drop a few unneeded casts
Date: Thu, 2 Mar 2023 17:35:17 +0200 (EET)	[thread overview]
Message-ID: <6e66bc69-52b7-bea5-1e2c-ad5ed819a6@linux.intel.com> (raw)
In-Reply-To: <20230302115417.1860210-1-u.kleine-koenig@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 2348 bytes --]

On Thu, 2 Mar 2023, Uwe Kleine-König wrote:

> There is no point in casting a struct uart_port to a struct imx_port
> just to access the first member of the latter (a struct uart_port).
> 
> This introduces code changes.

I don't know what this sentence is supposed to mean (did you forgot to 
add a negation into it)?

The code changes :-) are okay though:

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>


-- 
 i.

> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/tty/serial/imx.c | 17 ++++++-----------
>  1 file changed, 6 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 523f296d5747..84bc0e768726 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -1808,9 +1808,7 @@ imx_uart_set_termios(struct uart_port *port, struct ktermios *termios,
>  
>  static const char *imx_uart_type(struct uart_port *port)
>  {
> -	struct imx_port *sport = (struct imx_port *)port;
> -
> -	return sport->port.type == PORT_IMX ? "IMX" : NULL;
> +	return port->type == PORT_IMX ? "IMX" : NULL;
>  }
>  
>  /*
> @@ -1818,10 +1816,8 @@ static const char *imx_uart_type(struct uart_port *port)
>   */
>  static void imx_uart_config_port(struct uart_port *port, int flags)
>  {
> -	struct imx_port *sport = (struct imx_port *)port;
> -
>  	if (flags & UART_CONFIG_TYPE)
> -		sport->port.type = PORT_IMX;
> +		port->type = PORT_IMX;
>  }
>  
>  /*
> @@ -1832,20 +1828,19 @@ static void imx_uart_config_port(struct uart_port *port, int flags)
>  static int
>  imx_uart_verify_port(struct uart_port *port, struct serial_struct *ser)
>  {
> -	struct imx_port *sport = (struct imx_port *)port;
>  	int ret = 0;
>  
>  	if (ser->type != PORT_UNKNOWN && ser->type != PORT_IMX)
>  		ret = -EINVAL;
> -	if (sport->port.irq != ser->irq)
> +	if (port->irq != ser->irq)
>  		ret = -EINVAL;
>  	if (ser->io_type != UPIO_MEM)
>  		ret = -EINVAL;
> -	if (sport->port.uartclk / 16 != ser->baud_base)
> +	if (port->uartclk / 16 != ser->baud_base)
>  		ret = -EINVAL;
> -	if (sport->port.mapbase != (unsigned long)ser->iomem_base)
> +	if (port->mapbase != (unsigned long)ser->iomem_base)
>  		ret = -EINVAL;
> -	if (sport->port.iobase != ser->port)
> +	if (port->iobase != ser->port)
>  		ret = -EINVAL;
>  	if (ser->hub6 != 0)
>  		ret = -EINVAL;
> 

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-02 15:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02 11:54 [PATCH] serial: imx: Drop a few unneeded casts Uwe Kleine-König
2023-03-02 11:54 ` Uwe Kleine-König
2023-03-02 15:35 ` Ilpo Järvinen [this message]
2023-03-02 15:35   ` Ilpo Järvinen
2023-03-02 16:06   ` Uwe Kleine-König
2023-03-02 16:06     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e66bc69-52b7-bea5-1e2c-ad5ed819a6@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.