All of lore.kernel.org
 help / color / mirror / Atom feed
From: Halil Pasic <pasic@linux.ibm.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"cohuck@redhat.com" <cohuck@redhat.com>,
	"virtio-comment@lists.oasis-open.org"
	<virtio-comment@lists.oasis-open.org>,
	Shahaf Shuler <shahafs@nvidia.com>,
	Yuri Benditovich <yuri.benditovich@daynix.com>,
	Halil Pasic <pasic@linux.ibm.com>
Subject: [virtio-dev] Re: [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number
Date: Fri, 3 Mar 2023 16:38:02 +0100	[thread overview]
Message-ID: <20230303163802.588dfbb0.pasic@linux.ibm.com> (raw)
In-Reply-To: <PH0PR12MB54810632DAE7C0D8BEABC9E9DCB29@PH0PR12MB5481.namprd12.prod.outlook.com>

On Thu, 2 Mar 2023 16:12:48 +0000
Parav Pandit <parav@nvidia.com> wrote:

> > >
> > > is the index same as vq number? or something different?  
> > 
> > It is something different. The full paragraph sound like this
> > 
> > """
> > Field \field{unclassified_queue} contains the 0-based index of the receive
> > virtqueue to place unclassified packets in. Index 0 corresponds to receiveq1.
> > """  
> With vqn it can be as simply written as.
> Field \field{unclassified_queue} contains the receive virtqueue number to use for unclassified incoming packets.
> 
> Similarly rss description can be simplified.

But that would change the semantics of the interface (and the ABI). And
we really should refrain from that.

We could also say 

Field \field{unclassified_queue} contains the 0-based index of the receive
virtqueue to place unclassified packets in. Index N corresponds to receiveqN
and thus to virtqueue index 2N.

Provided that we decide to change the naming of the receive queues so
that receiveqN becomes receiveqN-1, and provided that we go with the
virtqueue index and not with the virtqueue number wording.

We could also just drop the name and just say that it corresponds to the
virtqueue index 2N like Michael has pointed out. But I would prefer the
former.

Regards,
Halil

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


WARNING: multiple messages have this Message-ID (diff)
From: Halil Pasic <pasic@linux.ibm.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"cohuck@redhat.com" <cohuck@redhat.com>,
	"virtio-comment@lists.oasis-open.org"
	<virtio-comment@lists.oasis-open.org>,
	Shahaf Shuler <shahafs@nvidia.com>,
	Yuri Benditovich <yuri.benditovich@daynix.com>,
	Halil Pasic <pasic@linux.ibm.com>
Subject: Re: [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number
Date: Fri, 3 Mar 2023 16:38:02 +0100	[thread overview]
Message-ID: <20230303163802.588dfbb0.pasic@linux.ibm.com> (raw)
In-Reply-To: <PH0PR12MB54810632DAE7C0D8BEABC9E9DCB29@PH0PR12MB5481.namprd12.prod.outlook.com>

On Thu, 2 Mar 2023 16:12:48 +0000
Parav Pandit <parav@nvidia.com> wrote:

> > >
> > > is the index same as vq number? or something different?  
> > 
> > It is something different. The full paragraph sound like this
> > 
> > """
> > Field \field{unclassified_queue} contains the 0-based index of the receive
> > virtqueue to place unclassified packets in. Index 0 corresponds to receiveq1.
> > """  
> With vqn it can be as simply written as.
> Field \field{unclassified_queue} contains the receive virtqueue number to use for unclassified incoming packets.
> 
> Similarly rss description can be simplified.

But that would change the semantics of the interface (and the ABI). And
we really should refrain from that.

We could also say 

Field \field{unclassified_queue} contains the 0-based index of the receive
virtqueue to place unclassified packets in. Index N corresponds to receiveqN
and thus to virtqueue index 2N.

Provided that we decide to change the naming of the receive queues so
that receiveqN becomes receiveqN-1, and provided that we go with the
virtqueue index and not with the virtqueue number wording.

We could also just drop the name and just say that it corresponds to the
virtqueue index 2N like Michael has pointed out. But I would prefer the
former.

Regards,
Halil

This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


  parent reply	other threads:[~2023-03-03 15:38 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23  5:46 [PATCH 0/3] Rename queue index to queue number Parav Pandit
2023-02-23  5:46 ` [PATCH 1/3] transport-pci: Refer to the vq by its number Parav Pandit
2023-02-24 10:05   ` [virtio-dev] " Jiri Pirko
2023-02-23  5:46 ` [PATCH 2/3] transport-mmio: Rename QueueNum register Parav Pandit
2023-02-24 10:06   ` [virtio-dev] " Jiri Pirko
2023-02-27 17:36   ` Michael S. Tsirkin
2023-02-27 17:36     ` [virtio-dev] " Michael S. Tsirkin
2023-02-23  5:46 ` [PATCH 3/3] transport-mmio: Refer to the vq by its number Parav Pandit
2023-02-24 10:06   ` [virtio-dev] " Jiri Pirko
2023-02-27  8:45 ` [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number Cornelia Huck
2023-02-27  8:45   ` [virtio-dev] " Cornelia Huck
2023-02-27 16:00   ` Parav Pandit
2023-02-27 16:00     ` [virtio-dev] " Parav Pandit
2023-02-27 17:33     ` [virtio-dev] " Michael S. Tsirkin
2023-03-01 17:22   ` [virtio-dev] Re: [virtio-comment] " Halil Pasic
2023-03-01 17:37     ` Michael S. Tsirkin
2023-03-02 13:42       ` [virtio-dev] " Parav Pandit
2023-03-02 15:06       ` [virtio-dev] " Cornelia Huck
2023-03-02 15:58         ` Halil Pasic
2023-03-03  7:42         ` Michael S. Tsirkin
2023-03-03 21:49           ` Halil Pasic
2023-03-03 21:49             ` [virtio-comment] " Halil Pasic
2023-03-05  9:51             ` Michael S. Tsirkin
2023-03-05  9:51               ` [virtio-comment] " Michael S. Tsirkin
2023-03-09 16:46               ` Halil Pasic
2023-03-09 16:46                 ` [virtio-comment] " Halil Pasic
2023-03-09 16:53                 ` Michael S. Tsirkin
2023-03-09 16:53                   ` [virtio-comment] " Michael S. Tsirkin
2023-03-10 14:05                   ` Halil Pasic
2023-03-10 14:05                     ` Halil Pasic
2023-02-27 17:39 ` Michael S. Tsirkin
2023-02-27 17:39   ` [virtio-dev] " Michael S. Tsirkin
2023-03-02 15:52   ` [virtio-dev] Re: [virtio-comment] " Halil Pasic
2023-03-02 16:12     ` [virtio-dev] " Parav Pandit
2023-03-02 23:38       ` [virtio-dev] " Michael S. Tsirkin
2023-03-07 15:20         ` [virtio-dev] " Parav Pandit
2023-03-07 15:20           ` Parav Pandit
2023-03-03 15:38       ` Halil Pasic [this message]
2023-03-03 15:38         ` Halil Pasic
2023-03-05  9:29         ` [virtio-dev] " Michael S. Tsirkin
2023-03-05  9:29           ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230303163802.588dfbb0.pasic@linux.ibm.com \
    --to=pasic@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.