From: "Michael S. Tsirkin" <mst@redhat.com> To: Halil Pasic <pasic@linux.ibm.com> Cc: Cornelia Huck <cohuck@redhat.com>, Parav Pandit <parav@nvidia.com>, virtio-dev@lists.oasis-open.org, virtio-comment@lists.oasis-open.org, shahafs@nvidia.com Subject: Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number Date: Thu, 9 Mar 2023 11:53:34 -0500 [thread overview] Message-ID: <20230309115110-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <20230309174650.7093f020.pasic@linux.ibm.com> On Thu, Mar 09, 2023 at 05:46:50PM +0100, Halil Pasic wrote: > To uniquely identify an element we need both the index (a value) and > the array/table that is being indexed. And I believe this is what we > need to improve on. I don't think calling indexes into the conceptual > array of receive queues (or receive virtqueues) "index of the receive > virtqueue", indexes into the conceptual array of virtqueues that belong > to a certain device a "vq number", indexes into the descriptor table > "descriptor keys", and indexes into the used rings "used ring element > ids" would really help -- to make an attempt at using reduction ad > absurdum ;) Right. I think Parav said he's converting everything to just refer to "VQ number". > > > > I feel there's less of a chance of a confusion between VQ size and > > its number. But it's not a strong prefrence, RSS is relatively young > > and it's the only incompatible user of index so far. > > I don't understand why is RSS incompatible with "index". > > Regards, > Halil It uses the word "index" in a way that is different from what you suggest. Anyway, both "number" and "index" require cleanup work, whoever is going to do it gets to decide which way it will go. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: Halil Pasic <pasic@linux.ibm.com> Cc: Cornelia Huck <cohuck@redhat.com>, Parav Pandit <parav@nvidia.com>, virtio-dev@lists.oasis-open.org, virtio-comment@lists.oasis-open.org, shahafs@nvidia.com Subject: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number Date: Thu, 9 Mar 2023 11:53:34 -0500 [thread overview] Message-ID: <20230309115110-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <20230309174650.7093f020.pasic@linux.ibm.com> On Thu, Mar 09, 2023 at 05:46:50PM +0100, Halil Pasic wrote: > To uniquely identify an element we need both the index (a value) and > the array/table that is being indexed. And I believe this is what we > need to improve on. I don't think calling indexes into the conceptual > array of receive queues (or receive virtqueues) "index of the receive > virtqueue", indexes into the conceptual array of virtqueues that belong > to a certain device a "vq number", indexes into the descriptor table > "descriptor keys", and indexes into the used rings "used ring element > ids" would really help -- to make an attempt at using reduction ad > absurdum ;) Right. I think Parav said he's converting everything to just refer to "VQ number". > > > > I feel there's less of a chance of a confusion between VQ size and > > its number. But it's not a strong prefrence, RSS is relatively young > > and it's the only incompatible user of index so far. > > I don't understand why is RSS incompatible with "index". > > Regards, > Halil It uses the word "index" in a way that is different from what you suggest. Anyway, both "number" and "index" require cleanup work, whoever is going to do it gets to decide which way it will go. -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/
next prev parent reply other threads:[~2023-03-09 16:53 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-23 5:46 [PATCH 0/3] Rename queue index to queue number Parav Pandit 2023-02-23 5:46 ` [PATCH 1/3] transport-pci: Refer to the vq by its number Parav Pandit 2023-02-24 10:05 ` [virtio-dev] " Jiri Pirko 2023-02-23 5:46 ` [PATCH 2/3] transport-mmio: Rename QueueNum register Parav Pandit 2023-02-24 10:06 ` [virtio-dev] " Jiri Pirko 2023-02-27 17:36 ` Michael S. Tsirkin 2023-02-27 17:36 ` [virtio-dev] " Michael S. Tsirkin 2023-02-23 5:46 ` [PATCH 3/3] transport-mmio: Refer to the vq by its number Parav Pandit 2023-02-24 10:06 ` [virtio-dev] " Jiri Pirko 2023-02-27 8:45 ` [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number Cornelia Huck 2023-02-27 8:45 ` [virtio-dev] " Cornelia Huck 2023-02-27 16:00 ` Parav Pandit 2023-02-27 16:00 ` [virtio-dev] " Parav Pandit 2023-02-27 17:33 ` [virtio-dev] " Michael S. Tsirkin 2023-03-01 17:22 ` [virtio-dev] Re: [virtio-comment] " Halil Pasic 2023-03-01 17:37 ` Michael S. Tsirkin 2023-03-02 13:42 ` [virtio-dev] " Parav Pandit 2023-03-02 15:06 ` [virtio-dev] " Cornelia Huck 2023-03-02 15:58 ` Halil Pasic 2023-03-03 7:42 ` Michael S. Tsirkin 2023-03-03 21:49 ` Halil Pasic 2023-03-03 21:49 ` [virtio-comment] " Halil Pasic 2023-03-05 9:51 ` Michael S. Tsirkin 2023-03-05 9:51 ` [virtio-comment] " Michael S. Tsirkin 2023-03-09 16:46 ` Halil Pasic 2023-03-09 16:46 ` [virtio-comment] " Halil Pasic 2023-03-09 16:53 ` Michael S. Tsirkin [this message] 2023-03-09 16:53 ` Michael S. Tsirkin 2023-03-10 14:05 ` Halil Pasic 2023-03-10 14:05 ` Halil Pasic 2023-02-27 17:39 ` Michael S. Tsirkin 2023-02-27 17:39 ` [virtio-dev] " Michael S. Tsirkin 2023-03-02 15:52 ` [virtio-dev] Re: [virtio-comment] " Halil Pasic 2023-03-02 16:12 ` [virtio-dev] " Parav Pandit 2023-03-02 23:38 ` [virtio-dev] " Michael S. Tsirkin 2023-03-07 15:20 ` [virtio-dev] " Parav Pandit 2023-03-07 15:20 ` Parav Pandit 2023-03-03 15:38 ` [virtio-dev] " Halil Pasic 2023-03-03 15:38 ` Halil Pasic 2023-03-05 9:29 ` [virtio-dev] " Michael S. Tsirkin 2023-03-05 9:29 ` Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230309115110-mutt-send-email-mst@kernel.org \ --to=mst@redhat.com \ --cc=cohuck@redhat.com \ --cc=parav@nvidia.com \ --cc=pasic@linux.ibm.com \ --cc=shahafs@nvidia.com \ --cc=virtio-comment@lists.oasis-open.org \ --cc=virtio-dev@lists.oasis-open.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.