Re: [RFC PATCH v2 5/7] scsi: ufs: ufs-qcom: Switch to the new ICE API

[kernel test robot <lkp@intel.com>]

Hi Abel,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on robh/for-next]
[also build test WARNING on mkp-scsi/for-next jejb-scsi/for-next linus/master v6.3-rc1 next-20230309]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Abel-Vesa/dt-bindings-soc-qcom-Add-schema-for-Inline-Crypto-Engine/20230309-000152
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20230308155838.1094920-6-abel.vesa%40linaro.org
patch subject: [RFC PATCH v2 5/7] scsi: ufs: ufs-qcom: Switch to the new ICE API
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20230309/202303091636.YScXypO8-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/bb84d6d7e112dd442be7821917a4f66fc42fe33a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Abel-Vesa/dt-bindings-soc-qcom-Add-schema-for-Inline-Crypto-Engine/20230309-000152
        git checkout bb84d6d7e112dd442be7821917a4f66fc42fe33a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/ufs/host/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303091636.YScXypO8-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/ufs/host/ufs-qcom.c:1408:5: warning: no previous prototype for 'ufs_qcom_program_key' [-Wmissing-prototypes]
    1408 | int ufs_qcom_program_key(struct ufs_hba *hba,
         |     ^~~~~~~~~~~~~~~~~~~~


vim +/ufs_qcom_program_key +1408 drivers/ufs/host/ufs-qcom.c

  1406	
  1407	#ifdef CONFIG_SCSI_UFS_CRYPTO
> 1408	int ufs_qcom_program_key(struct ufs_hba *hba,
  1409				 const union ufs_crypto_cfg_entry *cfg, int slot)
  1410	{
  1411		struct ufs_qcom_host *host = ufshcd_get_variant(hba);
  1412		union ufs_crypto_cap_entry cap;
  1413		bool config_enable =
  1414			cfg->config_enable & UFS_CRYPTO_CONFIGURATION_ENABLE;
  1415	
  1416		/* Only AES-256-XTS has been tested so far. */
  1417		cap = hba->crypto_cap_array[cfg->crypto_cap_idx];
  1418		if (cap.algorithm_id != UFS_CRYPTO_ALG_AES_XTS ||
  1419			cap.key_size != UFS_CRYPTO_KEY_SIZE_256)
  1420			return -EINVAL;
  1421	
  1422		if (config_enable)
  1423			return qcom_ice_program_key(host->ice,
  1424						    cfg->crypto_cap_idx,
  1425						    QCOM_ICE_CRYPTO_ALG_AES_XTS,
  1426						    QCOM_ICE_CRYPTO_KEY_SIZE_256,
  1427						    cfg->crypto_key,
  1428						    cfg->data_unit_size, slot);
  1429		else
  1430			return qcom_ice_evict_key(host->ice, slot);
  1431	}
  1432	#endif
  1433	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests