From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Abel Vesa <abel.vesa@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/7] dt-bindings: soc: qcom: Add schema for Inline Crypto Engine
Date: Thu, 9 Mar 2023 11:25:16 +0100 [thread overview]
Message-ID: <b85c414d-6970-f1a1-a847-bd49f18edc22@linaro.org> (raw)
In-Reply-To: <20230308155838.1094920-2-abel.vesa@linaro.org>
On 08/03/2023 16:58, Abel Vesa wrote:
> Add schema file for new Qualcomm Inline Crypto Engine driver.
Subject: drop second/last, redundant "schema for". The "dt-bindings"
prefix is already stating that these are bindings.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>
> This patch was not part of the v1.
>
> .../soc/qcom/qcom,inline-crypto-engine.yaml | 42 +++++++++++++++++++
> 1 file changed, 42 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,inline-crypto-engine.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,inline-crypto-engine.yaml
> new file mode 100644
> index 000000000000..359f80dd97cb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,inline-crypto-engine.yaml
soc should not be placeholder for everything. Put it in crypto/
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/qcom/qcom,inline-crypto-engine.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies, Inc. (QTI) Inline Crypto Engine
> +
> +maintainers:
> + - Bjorn Andersson <andersson@kernel.org>
> +
> +description:
> + Inline Crypto Engine
Please add useful description or drop.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,inline-crypto-engine
You need SoC specific compatible(s).
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,gcc-sm8450.h>
> +
> + ice: inline-crypto-engine@1d88000 {
Just: crypto
Also drop the label
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-09 10:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 15:58 [RFC PATCH v2 0/7] Add dedicated Qcom ICE driver Abel Vesa
2023-03-08 15:58 ` [RFC PATCH v2 1/7] dt-bindings: soc: qcom: Add schema for Inline Crypto Engine Abel Vesa
2023-03-09 10:25 ` Krzysztof Kozlowski [this message]
2023-03-08 15:58 ` [RFC PATCH v2 2/7] dt-bindings: ufs: qcom: Add ICE phandle and drop core clock Abel Vesa
2023-03-09 10:26 ` Krzysztof Kozlowski
2023-03-08 15:58 ` [RFC PATCH v2 3/7] dt-bindings: mmc: sdhci-msm: " Abel Vesa
2023-03-09 10:27 ` Krzysztof Kozlowski
2023-03-08 15:58 ` [RFC PATCH v2 4/7] soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver Abel Vesa
2023-03-08 20:01 ` Eric Biggers
2023-03-08 21:44 ` Abel Vesa
2023-03-08 23:10 ` Eric Biggers
2023-03-08 20:50 ` kernel test robot
2023-03-08 15:58 ` [RFC PATCH v2 5/7] scsi: ufs: ufs-qcom: Switch to the new ICE API Abel Vesa
2023-03-09 9:10 ` kernel test robot
2023-03-08 15:58 ` [RFC PATCH v2 6/7] mmc: sdhci-msm: " Abel Vesa
2023-03-10 12:45 ` Adrian Hunter
2023-03-08 15:58 ` [RFC PATCH v2 7/7] arm64: dts: qcom: Add the Inline Crypto Engine nodes Abel Vesa
2023-03-09 10:31 ` Krzysztof Kozlowski
2023-03-09 18:31 ` Eric Biggers
2023-03-10 8:13 ` Krzysztof Kozlowski
2023-03-10 9:21 ` Abel Vesa
2023-03-10 9:27 ` Krzysztof Kozlowski
2023-03-10 9:34 ` Abel Vesa
2023-03-10 9:37 ` Krzysztof Kozlowski
2023-03-10 9:42 ` Abel Vesa
2023-03-10 20:00 ` Eric Biggers
2023-03-08 20:03 ` [RFC PATCH v2 0/7] Add dedicated Qcom ICE driver Eric Biggers
2023-03-08 21:55 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b85c414d-6970-f1a1-a847-bd49f18edc22@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=devicetree@vger.kernel.org \
--cc=jejb@linux.ibm.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.