From: Andi Shyti <andi.shyti@kernel.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: Andrew Jeffery <andrew@aj.id.au>,
Brendan Higgins <brendan.higgins@linux.dev>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joel Stanley <joel@jms.id.au>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2
Date: Sat, 18 Mar 2023 10:09:36 +0100 [thread overview]
Message-ID: <20230318090936.qvqozqfskpe5lja7@intel.intel> (raw)
In-Reply-To: <20230226031321.3126756-2-ryan_chen@aspeedtech.com>
Hi Ryan,
On Sun, Feb 26, 2023 at 11:13:20AM +0800, Ryan Chen wrote:
> Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,timeout
> aspeed,xfer-mode description for ast2600-i2cv2.
>
> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> ---
> .../devicetree/bindings/i2c/aspeed,i2c.yaml | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> index f597f73ccd87..75de3ce41cf5 100644
> --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> @@ -49,6 +49,25 @@ properties:
> description:
> states that there is another master active on this bus
>
> + aspeed,timeout:
> + type: boolean
> + description: I2C bus timeout enable for master/slave mode
Finally you can proceed with this. Please remove "aspeed,timeout"
and use "i2c-scl-has-clk-low-timeout" instead.
Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@kernel.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: Andrew Jeffery <andrew@aj.id.au>,
Brendan Higgins <brendan.higgins@linux.dev>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joel Stanley <joel@jms.id.au>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2
Date: Sat, 18 Mar 2023 10:09:36 +0100 [thread overview]
Message-ID: <20230318090936.qvqozqfskpe5lja7@intel.intel> (raw)
In-Reply-To: <20230226031321.3126756-2-ryan_chen@aspeedtech.com>
Hi Ryan,
On Sun, Feb 26, 2023 at 11:13:20AM +0800, Ryan Chen wrote:
> Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,timeout
> aspeed,xfer-mode description for ast2600-i2cv2.
>
> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> ---
> .../devicetree/bindings/i2c/aspeed,i2c.yaml | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> index f597f73ccd87..75de3ce41cf5 100644
> --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> @@ -49,6 +49,25 @@ properties:
> description:
> states that there is another master active on this bus
>
> + aspeed,timeout:
> + type: boolean
> + description: I2C bus timeout enable for master/slave mode
Finally you can proceed with this. Please remove "aspeed,timeout"
and use "i2c-scl-has-clk-low-timeout" instead.
Andi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@kernel.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: devicetree@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-aspeed@lists.ozlabs.org, Andrew Jeffery <andrew@aj.id.au>,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Brendan Higgins <brendan.higgins@linux.dev>,
Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2
Date: Sat, 18 Mar 2023 10:09:36 +0100 [thread overview]
Message-ID: <20230318090936.qvqozqfskpe5lja7@intel.intel> (raw)
In-Reply-To: <20230226031321.3126756-2-ryan_chen@aspeedtech.com>
Hi Ryan,
On Sun, Feb 26, 2023 at 11:13:20AM +0800, Ryan Chen wrote:
> Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,timeout
> aspeed,xfer-mode description for ast2600-i2cv2.
>
> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> ---
> .../devicetree/bindings/i2c/aspeed,i2c.yaml | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> index f597f73ccd87..75de3ce41cf5 100644
> --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> @@ -49,6 +49,25 @@ properties:
> description:
> states that there is another master active on this bus
>
> + aspeed,timeout:
> + type: boolean
> + description: I2C bus timeout enable for master/slave mode
Finally you can proceed with this. Please remove "aspeed,timeout"
and use "i2c-scl-has-clk-low-timeout" instead.
Andi
next prev parent reply other threads:[~2023-03-18 9:09 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 3:13 [PATCH v6 0/2] Add ASPEED AST2600 I2Cv2 controller driver Ryan Chen
2023-02-26 3:13 ` Ryan Chen
2023-02-26 3:13 ` [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 Ryan Chen
2023-02-26 3:13 ` Ryan Chen
2023-02-26 7:04 ` Jeremy Kerr
2023-02-26 7:04 ` Jeremy Kerr
2023-02-27 4:12 ` Ryan Chen
2023-02-27 4:12 ` Ryan Chen
2023-02-27 5:40 ` Jeremy Kerr
2023-02-27 5:40 ` Jeremy Kerr
2023-03-01 3:02 ` Ryan Chen
2023-03-01 3:02 ` Ryan Chen
2023-03-01 3:23 ` Jeremy Kerr
2023-03-01 3:23 ` Jeremy Kerr
2023-03-01 3:40 ` Ryan Chen
2023-03-01 3:40 ` Ryan Chen
2023-02-27 8:25 ` Krzysztof Kozlowski
2023-02-27 8:25 ` Krzysztof Kozlowski
2023-03-01 5:57 ` Ryan Chen
2023-03-01 5:57 ` Ryan Chen
2023-03-03 8:20 ` Krzysztof Kozlowski
2023-03-03 8:20 ` Krzysztof Kozlowski
2023-03-03 8:28 ` Ryan Chen
2023-03-03 8:28 ` Ryan Chen
2023-03-03 8:28 ` Ryan Chen
2023-03-03 8:50 ` Krzysztof Kozlowski
2023-03-03 8:50 ` Krzysztof Kozlowski
2023-03-03 8:55 ` Ryan Chen
2023-03-03 8:55 ` Ryan Chen
2023-03-03 8:55 ` Ryan Chen
2023-03-03 9:26 ` Krzysztof Kozlowski
2023-03-03 9:26 ` Krzysztof Kozlowski
2023-03-03 10:16 ` Ryan Chen
2023-03-03 10:16 ` Ryan Chen
2023-03-03 10:16 ` Ryan Chen
2023-03-03 10:41 ` Krzysztof Kozlowski
2023-03-03 10:41 ` Krzysztof Kozlowski
2023-03-04 1:33 ` Ryan Chen
2023-03-04 1:33 ` Ryan Chen
2023-03-04 1:33 ` Ryan Chen
2023-03-05 9:49 ` Krzysztof Kozlowski
2023-03-05 9:49 ` Krzysztof Kozlowski
2023-03-06 0:48 ` Ryan Chen
2023-03-06 0:48 ` Ryan Chen
2023-03-06 0:48 ` Ryan Chen
2023-03-07 8:11 ` Krzysztof Kozlowski
2023-03-07 8:11 ` Krzysztof Kozlowski
2023-03-07 10:09 ` Ryan Chen
2023-03-07 10:09 ` Ryan Chen
2023-03-07 10:09 ` Ryan Chen
2023-03-09 8:51 ` Krzysztof Kozlowski
2023-03-09 8:51 ` Krzysztof Kozlowski
2023-03-09 9:15 ` Ryan Chen
2023-03-09 9:15 ` Ryan Chen
2023-03-09 9:15 ` Ryan Chen
2023-03-12 12:33 ` Andi Shyti
2023-03-12 12:33 ` Andi Shyti
2023-03-12 12:33 ` Andi Shyti
2023-03-18 9:09 ` Andi Shyti [this message]
2023-03-18 9:09 ` Andi Shyti
2023-03-18 9:09 ` Andi Shyti
2023-03-19 2:05 ` Ryan Chen
2023-03-19 2:05 ` Ryan Chen
2023-03-19 2:05 ` Ryan Chen
2023-02-26 3:13 ` [PATCH v6 2/2] i2c: aspeed: support ast2600 i2cv new register mode driver Ryan Chen
2023-02-26 3:13 ` Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230318090936.qvqozqfskpe5lja7@intel.intel \
--to=andi.shyti@kernel.org \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=brendan.higgins@linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.