* [PATCH v2 0/6] MediaTek Helio X10 MT6795 - MT6331/6332 PMIC Wrapper
@ 2023-03-24 9:41 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-24 9:41 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, amergnat, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno
Changes in v2:
- Rebased on next-20230323
- Changed pwrap.txt addition to new yaml file addition
In an effort to give some love to the apparently forgotten MT6795 SoC,
I am upstreaming more components that are necessary to support platforms
powered by this one apart from a simple boot to serial console.
This series introduces support in the PMIC Wrapper for a different PMIC
topology, which is commonly found on smartphone boards, using one main
PMIC and one Companion/Sub PMIC, both accessible *only* through the pwrap;
be aware that this kind of topology is not *specific to* the Helio X10
SoC, but common across many kinds of MediaTek smartphone oriented SoCs
and board designs.
That said, support for the PMIC combo MT6331+MT6332 is provided in this
series in a form that will be able to initialize the PMICs with crypto
and DualIO but nothing else: these PMICs are very featureful, so I have
decided to add this support in more than just one step, as there will
be multiple patches for multiple different subsystems (..it's a mfd!..).
Tested on a MT6795 Sony Xperia M5 (codename "Holly") smartphone.
AngeloGioacchino Del Regno (6):
dt-bindings: soc: mediatek: pwrap: Add compatible for MT6795 Helio X10
soc: mediatek: pwrap: Move PMIC read test sequence in function
soc: mediatek: pwrap: Add kerneldoc for struct pwrap_slv_type
soc: mediatek: mtk-pmic-wrap: Add support for companion PMICs
soc: mediatek: mtk-pmic-wrap: Add support for MT6331 w/ MT6332
companion
soc: mediatek: pwrap: Add support for MT6795 Helio X10
.../bindings/soc/mediatek/mediatek,pwrap.yaml | 1 +
drivers/soc/mediatek/mtk-pmic-wrap.c | 287 ++++++++++++++++--
2 files changed, 262 insertions(+), 26 deletions(-)
--
2.40.0
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH v2 0/6] MediaTek Helio X10 MT6795 - MT6331/6332 PMIC Wrapper
@ 2023-03-24 9:41 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-24 9:41 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, amergnat, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno
Changes in v2:
- Rebased on next-20230323
- Changed pwrap.txt addition to new yaml file addition
In an effort to give some love to the apparently forgotten MT6795 SoC,
I am upstreaming more components that are necessary to support platforms
powered by this one apart from a simple boot to serial console.
This series introduces support in the PMIC Wrapper for a different PMIC
topology, which is commonly found on smartphone boards, using one main
PMIC and one Companion/Sub PMIC, both accessible *only* through the pwrap;
be aware that this kind of topology is not *specific to* the Helio X10
SoC, but common across many kinds of MediaTek smartphone oriented SoCs
and board designs.
That said, support for the PMIC combo MT6331+MT6332 is provided in this
series in a form that will be able to initialize the PMICs with crypto
and DualIO but nothing else: these PMICs are very featureful, so I have
decided to add this support in more than just one step, as there will
be multiple patches for multiple different subsystems (..it's a mfd!..).
Tested on a MT6795 Sony Xperia M5 (codename "Holly") smartphone.
AngeloGioacchino Del Regno (6):
dt-bindings: soc: mediatek: pwrap: Add compatible for MT6795 Helio X10
soc: mediatek: pwrap: Move PMIC read test sequence in function
soc: mediatek: pwrap: Add kerneldoc for struct pwrap_slv_type
soc: mediatek: mtk-pmic-wrap: Add support for companion PMICs
soc: mediatek: mtk-pmic-wrap: Add support for MT6331 w/ MT6332
companion
soc: mediatek: pwrap: Add support for MT6795 Helio X10
.../bindings/soc/mediatek/mediatek,pwrap.yaml | 1 +
drivers/soc/mediatek/mtk-pmic-wrap.c | 287 ++++++++++++++++--
2 files changed, 262 insertions(+), 26 deletions(-)
--
2.40.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH v2 1/6] dt-bindings: soc: mediatek: pwrap: Add compatible for MT6795 Helio X10
2023-03-24 9:41 ` AngeloGioacchino Del Regno
@ 2023-03-24 9:42 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-24 9:42 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, amergnat, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno
Add a compatible for the PMIC Wrapper found on the MT6795 Helio X10 SoC.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
index 3fefd634bc69..a06ac2177444 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
+++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
@@ -33,6 +33,7 @@ properties:
- mediatek,mt2701-pwrap
- mediatek,mt6765-pwrap
- mediatek,mt6779-pwrap
+ - mediatek,mt6795-pwrap
- mediatek,mt6797-pwrap
- mediatek,mt6873-pwrap
- mediatek,mt7622-pwrap
--
2.40.0
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v2 1/6] dt-bindings: soc: mediatek: pwrap: Add compatible for MT6795 Helio X10
@ 2023-03-24 9:42 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-24 9:42 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, amergnat, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno
Add a compatible for the PMIC Wrapper found on the MT6795 Helio X10 SoC.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
index 3fefd634bc69..a06ac2177444 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
+++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
@@ -33,6 +33,7 @@ properties:
- mediatek,mt2701-pwrap
- mediatek,mt6765-pwrap
- mediatek,mt6779-pwrap
+ - mediatek,mt6795-pwrap
- mediatek,mt6797-pwrap
- mediatek,mt6873-pwrap
- mediatek,mt7622-pwrap
--
2.40.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v2 2/6] soc: mediatek: pwrap: Move PMIC read test sequence in function
2023-03-24 9:41 ` AngeloGioacchino Del Regno
@ 2023-03-24 9:42 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-24 9:42 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, amergnat, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno
The PMIC read test is performed in two places: pwrap_init_dual_io()
and pwrap_init_sidly().
In preparation for adding support for PMICs requiring a companion
part, move this sequence to a new function pwrap_pmic_read_test().
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/soc/mediatek/mtk-pmic-wrap.c | 32 +++++++++++++++++-----------
1 file changed, 20 insertions(+), 12 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 15789a03e6c6..5c500be48f7c 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -1455,6 +1455,18 @@ static int pwrap_regmap_write(void *context, u32 adr, u32 wdata)
return pwrap_write(context, adr, wdata);
}
+static bool pwrap_pmic_read_test(struct pmic_wrapper *wrp, const u32 *dew_regs,
+ u16 read_test_val)
+{
+ bool is_success;
+ u32 rdata;
+
+ pwrap_read(wrp, dew_regs[PWRAP_DEW_READ_TEST], &rdata);
+ is_success = ((rdata & U16_MAX) == read_test_val);
+
+ return is_success;
+}
+
static int pwrap_reset_spislave(struct pmic_wrapper *wrp)
{
bool tmp;
@@ -1498,18 +1510,18 @@ static int pwrap_reset_spislave(struct pmic_wrapper *wrp)
*/
static int pwrap_init_sidly(struct pmic_wrapper *wrp)
{
- u32 rdata;
u32 i;
u32 pass = 0;
+ bool read_ok;
signed char dly[16] = {
-1, 0, 1, 0, 2, -1, 1, 1, 3, -1, -1, -1, 3, -1, 2, 1
};
for (i = 0; i < 4; i++) {
pwrap_writel(wrp, i, PWRAP_SIDLY);
- pwrap_read(wrp, wrp->slave->dew_regs[PWRAP_DEW_READ_TEST],
- &rdata);
- if (rdata == PWRAP_DEW_READ_TEST_VAL) {
+ read_ok = pwrap_pmic_read_test(wrp, wrp->slave->dew_regs,
+ PWRAP_DEW_READ_TEST_VAL);
+ if (read_ok) {
dev_dbg(wrp->dev, "[Read Test] pass, SIDLY=%x\n", i);
pass |= 1 << i;
}
@@ -1529,8 +1541,7 @@ static int pwrap_init_sidly(struct pmic_wrapper *wrp)
static int pwrap_init_dual_io(struct pmic_wrapper *wrp)
{
int ret;
- bool tmp;
- u32 rdata;
+ bool read_ok, tmp;
/* Enable dual IO mode */
pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_DIO_EN], 1);
@@ -1546,12 +1557,9 @@ static int pwrap_init_dual_io(struct pmic_wrapper *wrp)
pwrap_writel(wrp, 1, PWRAP_DIO_EN);
/* Read Test */
- pwrap_read(wrp,
- wrp->slave->dew_regs[PWRAP_DEW_READ_TEST], &rdata);
- if (rdata != PWRAP_DEW_READ_TEST_VAL) {
- dev_err(wrp->dev,
- "Read failed on DIO mode: 0x%04x!=0x%04x\n",
- PWRAP_DEW_READ_TEST_VAL, rdata);
+ read_ok = pwrap_pmic_read_test(wrp, wrp->slave->dew_regs, PWRAP_DEW_READ_TEST_VAL);
+ if (!read_ok) {
+ dev_err(wrp->dev, "Read failed on DIO mode.\n");
return -EFAULT;
}
--
2.40.0
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v2 2/6] soc: mediatek: pwrap: Move PMIC read test sequence in function
@ 2023-03-24 9:42 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-24 9:42 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, amergnat, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno
The PMIC read test is performed in two places: pwrap_init_dual_io()
and pwrap_init_sidly().
In preparation for adding support for PMICs requiring a companion
part, move this sequence to a new function pwrap_pmic_read_test().
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/soc/mediatek/mtk-pmic-wrap.c | 32 +++++++++++++++++-----------
1 file changed, 20 insertions(+), 12 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 15789a03e6c6..5c500be48f7c 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -1455,6 +1455,18 @@ static int pwrap_regmap_write(void *context, u32 adr, u32 wdata)
return pwrap_write(context, adr, wdata);
}
+static bool pwrap_pmic_read_test(struct pmic_wrapper *wrp, const u32 *dew_regs,
+ u16 read_test_val)
+{
+ bool is_success;
+ u32 rdata;
+
+ pwrap_read(wrp, dew_regs[PWRAP_DEW_READ_TEST], &rdata);
+ is_success = ((rdata & U16_MAX) == read_test_val);
+
+ return is_success;
+}
+
static int pwrap_reset_spislave(struct pmic_wrapper *wrp)
{
bool tmp;
@@ -1498,18 +1510,18 @@ static int pwrap_reset_spislave(struct pmic_wrapper *wrp)
*/
static int pwrap_init_sidly(struct pmic_wrapper *wrp)
{
- u32 rdata;
u32 i;
u32 pass = 0;
+ bool read_ok;
signed char dly[16] = {
-1, 0, 1, 0, 2, -1, 1, 1, 3, -1, -1, -1, 3, -1, 2, 1
};
for (i = 0; i < 4; i++) {
pwrap_writel(wrp, i, PWRAP_SIDLY);
- pwrap_read(wrp, wrp->slave->dew_regs[PWRAP_DEW_READ_TEST],
- &rdata);
- if (rdata == PWRAP_DEW_READ_TEST_VAL) {
+ read_ok = pwrap_pmic_read_test(wrp, wrp->slave->dew_regs,
+ PWRAP_DEW_READ_TEST_VAL);
+ if (read_ok) {
dev_dbg(wrp->dev, "[Read Test] pass, SIDLY=%x\n", i);
pass |= 1 << i;
}
@@ -1529,8 +1541,7 @@ static int pwrap_init_sidly(struct pmic_wrapper *wrp)
static int pwrap_init_dual_io(struct pmic_wrapper *wrp)
{
int ret;
- bool tmp;
- u32 rdata;
+ bool read_ok, tmp;
/* Enable dual IO mode */
pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_DIO_EN], 1);
@@ -1546,12 +1557,9 @@ static int pwrap_init_dual_io(struct pmic_wrapper *wrp)
pwrap_writel(wrp, 1, PWRAP_DIO_EN);
/* Read Test */
- pwrap_read(wrp,
- wrp->slave->dew_regs[PWRAP_DEW_READ_TEST], &rdata);
- if (rdata != PWRAP_DEW_READ_TEST_VAL) {
- dev_err(wrp->dev,
- "Read failed on DIO mode: 0x%04x!=0x%04x\n",
- PWRAP_DEW_READ_TEST_VAL, rdata);
+ read_ok = pwrap_pmic_read_test(wrp, wrp->slave->dew_regs, PWRAP_DEW_READ_TEST_VAL);
+ if (!read_ok) {
+ dev_err(wrp->dev, "Read failed on DIO mode.\n");
return -EFAULT;
}
--
2.40.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v2 3/6] soc: mediatek: pwrap: Add kerneldoc for struct pwrap_slv_type
2023-03-24 9:41 ` AngeloGioacchino Del Regno
@ 2023-03-24 9:42 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-24 9:42 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, amergnat, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno
In preparation for adding new members with name abbreviations describe
the struct pwrap_slv_type with kerneldoc to enhance human readability.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/soc/mediatek/mtk-pmic-wrap.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 5c500be48f7c..a33a1b1820cb 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -1218,11 +1218,17 @@ struct pwrap_slv_regops {
int (*pwrap_write)(struct pmic_wrapper *wrp, u32 adr, u32 wdata);
};
+/**
+ * struct pwrap_slv_type - PMIC device wrapper definitions
+ * @dew_regs: Device Wrapper (DeW) register offsets
+ * @type: PMIC Type (model)
+ * @regops: Register R/W ops
+ * @caps: Capability flags for the target device
+ */
struct pwrap_slv_type {
const u32 *dew_regs;
enum pmic_type type;
const struct pwrap_slv_regops *regops;
- /* Flags indicating the capability for the target slave */
u32 caps;
};
--
2.40.0
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v2 3/6] soc: mediatek: pwrap: Add kerneldoc for struct pwrap_slv_type
@ 2023-03-24 9:42 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-24 9:42 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, amergnat, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno
In preparation for adding new members with name abbreviations describe
the struct pwrap_slv_type with kerneldoc to enhance human readability.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/soc/mediatek/mtk-pmic-wrap.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 5c500be48f7c..a33a1b1820cb 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -1218,11 +1218,17 @@ struct pwrap_slv_regops {
int (*pwrap_write)(struct pmic_wrapper *wrp, u32 adr, u32 wdata);
};
+/**
+ * struct pwrap_slv_type - PMIC device wrapper definitions
+ * @dew_regs: Device Wrapper (DeW) register offsets
+ * @type: PMIC Type (model)
+ * @regops: Register R/W ops
+ * @caps: Capability flags for the target device
+ */
struct pwrap_slv_type {
const u32 *dew_regs;
enum pmic_type type;
const struct pwrap_slv_regops *regops;
- /* Flags indicating the capability for the target slave */
u32 caps;
};
--
2.40.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v2 4/6] soc: mediatek: mtk-pmic-wrap: Add support for companion PMICs
2023-03-24 9:41 ` AngeloGioacchino Del Regno
@ 2023-03-24 9:42 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-24 9:42 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, amergnat, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno
Some PMICs are designed to work with a companion part, which provides
more regulators and/or companion devices such as LED controllers,
display backlight controllers, battery charging, fuel gauge, etc:
this kind of PMICs are usually present in smartphone platforms, where
tight integration is required.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/soc/mediatek/mtk-pmic-wrap.c | 73 ++++++++++++++++++++++------
1 file changed, 59 insertions(+), 14 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index a33a1b1820cb..366e40b802e4 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -47,6 +47,7 @@
/* macro for device wrapper default value */
#define PWRAP_DEW_READ_TEST_VAL 0x5aa5
+#define PWRAP_DEW_COMP_READ_TEST_VAL 0xa55a
#define PWRAP_DEW_WRITE_TEST_VAL 0xa55a
/* macro for manual command */
@@ -1222,12 +1223,16 @@ struct pwrap_slv_regops {
* struct pwrap_slv_type - PMIC device wrapper definitions
* @dew_regs: Device Wrapper (DeW) register offsets
* @type: PMIC Type (model)
+ * @comp_dew_regs: Device Wrapper (DeW) register offsets for companion device
+ * @comp_type: Companion PMIC Type (model)
* @regops: Register R/W ops
* @caps: Capability flags for the target device
*/
struct pwrap_slv_type {
const u32 *dew_regs;
enum pmic_type type;
+ const u32 *comp_dew_regs;
+ enum pmic_type comp_type;
const struct pwrap_slv_regops *regops;
u32 caps;
};
@@ -1548,9 +1553,12 @@ static int pwrap_init_dual_io(struct pmic_wrapper *wrp)
{
int ret;
bool read_ok, tmp;
+ bool comp_read_ok = true;
/* Enable dual IO mode */
pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_DIO_EN], 1);
+ if (wrp->slave->comp_dew_regs)
+ pwrap_write(wrp, wrp->slave->comp_dew_regs[PWRAP_DEW_DIO_EN], 1);
/* Check IDLE & INIT_DONE in advance */
ret = readx_poll_timeout(pwrap_is_fsm_idle_and_sync_idle, wrp, tmp, tmp,
@@ -1564,8 +1572,14 @@ static int pwrap_init_dual_io(struct pmic_wrapper *wrp)
/* Read Test */
read_ok = pwrap_pmic_read_test(wrp, wrp->slave->dew_regs, PWRAP_DEW_READ_TEST_VAL);
- if (!read_ok) {
- dev_err(wrp->dev, "Read failed on DIO mode.\n");
+ if (wrp->slave->comp_dew_regs)
+ comp_read_ok = pwrap_pmic_read_test(wrp, wrp->slave->comp_dew_regs,
+ PWRAP_DEW_COMP_READ_TEST_VAL);
+ if (!read_ok || !comp_read_ok) {
+ dev_err(wrp->dev, "Read failed on DIO mode. Main PMIC %s%s\n",
+ !read_ok ? "fail" : "success",
+ wrp->slave->comp_dew_regs && !comp_read_ok ?
+ ", Companion PMIC fail" : "");
return -EFAULT;
}
@@ -1640,19 +1654,41 @@ static bool pwrap_is_cipher_ready(struct pmic_wrapper *wrp)
return pwrap_readl(wrp, PWRAP_CIPHER_RDY) & 1;
}
-static bool pwrap_is_pmic_cipher_ready(struct pmic_wrapper *wrp)
+static bool __pwrap_is_pmic_cipher_ready(struct pmic_wrapper *wrp, const u32 *dew_regs)
{
u32 rdata;
int ret;
- ret = pwrap_read(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_RDY],
- &rdata);
+ ret = pwrap_read(wrp, dew_regs[PWRAP_DEW_CIPHER_RDY], &rdata);
if (ret)
return false;
return rdata == 1;
}
+
+static bool pwrap_is_pmic_cipher_ready(struct pmic_wrapper *wrp)
+{
+ bool ret = __pwrap_is_pmic_cipher_ready(wrp, wrp->slave->dew_regs);
+
+ if (!ret)
+ return ret;
+
+ /* If there's any companion, wait for it to be ready too */
+ if (wrp->slave->comp_dew_regs)
+ ret = __pwrap_is_pmic_cipher_ready(wrp, wrp->slave->comp_dew_regs);
+
+ return ret;
+}
+
+static void pwrap_config_cipher(struct pmic_wrapper *wrp, const u32 *dew_regs)
+{
+ pwrap_write(wrp, dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x1);
+ pwrap_write(wrp, dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x0);
+ pwrap_write(wrp, dew_regs[PWRAP_DEW_CIPHER_KEY_SEL], 0x1);
+ pwrap_write(wrp, dew_regs[PWRAP_DEW_CIPHER_IV_SEL], 0x2);
+}
+
static int pwrap_init_cipher(struct pmic_wrapper *wrp)
{
int ret;
@@ -1689,10 +1725,11 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
}
/* Config cipher mode @PMIC */
- pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x1);
- pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x0);
- pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_KEY_SEL], 0x1);
- pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_IV_SEL], 0x2);
+ pwrap_config_cipher(wrp, wrp->slave->dew_regs);
+
+ /* If there is any companion PMIC, configure cipher mode there too */
+ if (wrp->slave->comp_type > 0)
+ pwrap_config_cipher(wrp, wrp->slave->comp_dew_regs);
switch (wrp->slave->type) {
case PMIC_MT6397:
@@ -1754,6 +1791,7 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
static int pwrap_init_security(struct pmic_wrapper *wrp)
{
+ u32 crc_val;
int ret;
/* Enable encryption */
@@ -1762,14 +1800,21 @@ static int pwrap_init_security(struct pmic_wrapper *wrp)
return ret;
/* Signature checking - using CRC */
- if (pwrap_write(wrp,
- wrp->slave->dew_regs[PWRAP_DEW_CRC_EN], 0x1))
- return -EFAULT;
+ ret = pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CRC_EN], 0x1);
+ if (ret == 0 && wrp->slave->comp_dew_regs)
+ ret = pwrap_write(wrp, wrp->slave->comp_dew_regs[PWRAP_DEW_CRC_EN], 0x1);
pwrap_writel(wrp, 0x1, PWRAP_CRC_EN);
pwrap_writel(wrp, 0x0, PWRAP_SIG_MODE);
- pwrap_writel(wrp, wrp->slave->dew_regs[PWRAP_DEW_CRC_VAL],
- PWRAP_SIG_ADR);
+
+ /* CRC value */
+ crc_val = wrp->slave->dew_regs[PWRAP_DEW_CRC_VAL];
+ if (wrp->slave->comp_dew_regs)
+ crc_val |= wrp->slave->comp_dew_regs[PWRAP_DEW_CRC_VAL] << 16;
+
+ pwrap_writel(wrp, crc_val, PWRAP_SIG_ADR);
+
+ /* PMIC Wrapper Arbiter priority */
pwrap_writel(wrp,
wrp->master->arb_en_all, PWRAP_HIPRIO_ARB_EN);
--
2.40.0
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v2 4/6] soc: mediatek: mtk-pmic-wrap: Add support for companion PMICs
@ 2023-03-24 9:42 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-24 9:42 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, amergnat, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno
Some PMICs are designed to work with a companion part, which provides
more regulators and/or companion devices such as LED controllers,
display backlight controllers, battery charging, fuel gauge, etc:
this kind of PMICs are usually present in smartphone platforms, where
tight integration is required.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/soc/mediatek/mtk-pmic-wrap.c | 73 ++++++++++++++++++++++------
1 file changed, 59 insertions(+), 14 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index a33a1b1820cb..366e40b802e4 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -47,6 +47,7 @@
/* macro for device wrapper default value */
#define PWRAP_DEW_READ_TEST_VAL 0x5aa5
+#define PWRAP_DEW_COMP_READ_TEST_VAL 0xa55a
#define PWRAP_DEW_WRITE_TEST_VAL 0xa55a
/* macro for manual command */
@@ -1222,12 +1223,16 @@ struct pwrap_slv_regops {
* struct pwrap_slv_type - PMIC device wrapper definitions
* @dew_regs: Device Wrapper (DeW) register offsets
* @type: PMIC Type (model)
+ * @comp_dew_regs: Device Wrapper (DeW) register offsets for companion device
+ * @comp_type: Companion PMIC Type (model)
* @regops: Register R/W ops
* @caps: Capability flags for the target device
*/
struct pwrap_slv_type {
const u32 *dew_regs;
enum pmic_type type;
+ const u32 *comp_dew_regs;
+ enum pmic_type comp_type;
const struct pwrap_slv_regops *regops;
u32 caps;
};
@@ -1548,9 +1553,12 @@ static int pwrap_init_dual_io(struct pmic_wrapper *wrp)
{
int ret;
bool read_ok, tmp;
+ bool comp_read_ok = true;
/* Enable dual IO mode */
pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_DIO_EN], 1);
+ if (wrp->slave->comp_dew_regs)
+ pwrap_write(wrp, wrp->slave->comp_dew_regs[PWRAP_DEW_DIO_EN], 1);
/* Check IDLE & INIT_DONE in advance */
ret = readx_poll_timeout(pwrap_is_fsm_idle_and_sync_idle, wrp, tmp, tmp,
@@ -1564,8 +1572,14 @@ static int pwrap_init_dual_io(struct pmic_wrapper *wrp)
/* Read Test */
read_ok = pwrap_pmic_read_test(wrp, wrp->slave->dew_regs, PWRAP_DEW_READ_TEST_VAL);
- if (!read_ok) {
- dev_err(wrp->dev, "Read failed on DIO mode.\n");
+ if (wrp->slave->comp_dew_regs)
+ comp_read_ok = pwrap_pmic_read_test(wrp, wrp->slave->comp_dew_regs,
+ PWRAP_DEW_COMP_READ_TEST_VAL);
+ if (!read_ok || !comp_read_ok) {
+ dev_err(wrp->dev, "Read failed on DIO mode. Main PMIC %s%s\n",
+ !read_ok ? "fail" : "success",
+ wrp->slave->comp_dew_regs && !comp_read_ok ?
+ ", Companion PMIC fail" : "");
return -EFAULT;
}
@@ -1640,19 +1654,41 @@ static bool pwrap_is_cipher_ready(struct pmic_wrapper *wrp)
return pwrap_readl(wrp, PWRAP_CIPHER_RDY) & 1;
}
-static bool pwrap_is_pmic_cipher_ready(struct pmic_wrapper *wrp)
+static bool __pwrap_is_pmic_cipher_ready(struct pmic_wrapper *wrp, const u32 *dew_regs)
{
u32 rdata;
int ret;
- ret = pwrap_read(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_RDY],
- &rdata);
+ ret = pwrap_read(wrp, dew_regs[PWRAP_DEW_CIPHER_RDY], &rdata);
if (ret)
return false;
return rdata == 1;
}
+
+static bool pwrap_is_pmic_cipher_ready(struct pmic_wrapper *wrp)
+{
+ bool ret = __pwrap_is_pmic_cipher_ready(wrp, wrp->slave->dew_regs);
+
+ if (!ret)
+ return ret;
+
+ /* If there's any companion, wait for it to be ready too */
+ if (wrp->slave->comp_dew_regs)
+ ret = __pwrap_is_pmic_cipher_ready(wrp, wrp->slave->comp_dew_regs);
+
+ return ret;
+}
+
+static void pwrap_config_cipher(struct pmic_wrapper *wrp, const u32 *dew_regs)
+{
+ pwrap_write(wrp, dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x1);
+ pwrap_write(wrp, dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x0);
+ pwrap_write(wrp, dew_regs[PWRAP_DEW_CIPHER_KEY_SEL], 0x1);
+ pwrap_write(wrp, dew_regs[PWRAP_DEW_CIPHER_IV_SEL], 0x2);
+}
+
static int pwrap_init_cipher(struct pmic_wrapper *wrp)
{
int ret;
@@ -1689,10 +1725,11 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
}
/* Config cipher mode @PMIC */
- pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x1);
- pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x0);
- pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_KEY_SEL], 0x1);
- pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_IV_SEL], 0x2);
+ pwrap_config_cipher(wrp, wrp->slave->dew_regs);
+
+ /* If there is any companion PMIC, configure cipher mode there too */
+ if (wrp->slave->comp_type > 0)
+ pwrap_config_cipher(wrp, wrp->slave->comp_dew_regs);
switch (wrp->slave->type) {
case PMIC_MT6397:
@@ -1754,6 +1791,7 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
static int pwrap_init_security(struct pmic_wrapper *wrp)
{
+ u32 crc_val;
int ret;
/* Enable encryption */
@@ -1762,14 +1800,21 @@ static int pwrap_init_security(struct pmic_wrapper *wrp)
return ret;
/* Signature checking - using CRC */
- if (pwrap_write(wrp,
- wrp->slave->dew_regs[PWRAP_DEW_CRC_EN], 0x1))
- return -EFAULT;
+ ret = pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CRC_EN], 0x1);
+ if (ret == 0 && wrp->slave->comp_dew_regs)
+ ret = pwrap_write(wrp, wrp->slave->comp_dew_regs[PWRAP_DEW_CRC_EN], 0x1);
pwrap_writel(wrp, 0x1, PWRAP_CRC_EN);
pwrap_writel(wrp, 0x0, PWRAP_SIG_MODE);
- pwrap_writel(wrp, wrp->slave->dew_regs[PWRAP_DEW_CRC_VAL],
- PWRAP_SIG_ADR);
+
+ /* CRC value */
+ crc_val = wrp->slave->dew_regs[PWRAP_DEW_CRC_VAL];
+ if (wrp->slave->comp_dew_regs)
+ crc_val |= wrp->slave->comp_dew_regs[PWRAP_DEW_CRC_VAL] << 16;
+
+ pwrap_writel(wrp, crc_val, PWRAP_SIG_ADR);
+
+ /* PMIC Wrapper Arbiter priority */
pwrap_writel(wrp,
wrp->master->arb_en_all, PWRAP_HIPRIO_ARB_EN);
--
2.40.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v2 5/6] soc: mediatek: mtk-pmic-wrap: Add support for MT6331 w/ MT6332 companion
2023-03-24 9:41 ` AngeloGioacchino Del Regno
@ 2023-03-24 9:42 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-24 9:42 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, amergnat, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno
Add support for the MT6331 PMIC and for its companion MT6332 PMIC.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/soc/mediatek/mtk-pmic-wrap.c | 47 ++++++++++++++++++++++++++++
1 file changed, 47 insertions(+)
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 366e40b802e4..ceeac43f7bd1 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -170,6 +170,40 @@ static const u32 mt6323_regs[] = {
[PWRAP_DEW_RDDMY_NO] = 0x01a4,
};
+static const u32 mt6331_regs[] = {
+ [PWRAP_DEW_DIO_EN] = 0x018c,
+ [PWRAP_DEW_READ_TEST] = 0x018e,
+ [PWRAP_DEW_WRITE_TEST] = 0x0190,
+ [PWRAP_DEW_CRC_SWRST] = 0x0192,
+ [PWRAP_DEW_CRC_EN] = 0x0194,
+ [PWRAP_DEW_CRC_VAL] = 0x0196,
+ [PWRAP_DEW_MON_GRP_SEL] = 0x0198,
+ [PWRAP_DEW_CIPHER_KEY_SEL] = 0x019a,
+ [PWRAP_DEW_CIPHER_IV_SEL] = 0x019c,
+ [PWRAP_DEW_CIPHER_EN] = 0x019e,
+ [PWRAP_DEW_CIPHER_RDY] = 0x01a0,
+ [PWRAP_DEW_CIPHER_MODE] = 0x01a2,
+ [PWRAP_DEW_CIPHER_SWRST] = 0x01a4,
+ [PWRAP_DEW_RDDMY_NO] = 0x01a6,
+};
+
+static const u32 mt6332_regs[] = {
+ [PWRAP_DEW_DIO_EN] = 0x80f6,
+ [PWRAP_DEW_READ_TEST] = 0x80f8,
+ [PWRAP_DEW_WRITE_TEST] = 0x80fa,
+ [PWRAP_DEW_CRC_SWRST] = 0x80fc,
+ [PWRAP_DEW_CRC_EN] = 0x80fe,
+ [PWRAP_DEW_CRC_VAL] = 0x8100,
+ [PWRAP_DEW_MON_GRP_SEL] = 0x8102,
+ [PWRAP_DEW_CIPHER_KEY_SEL] = 0x8104,
+ [PWRAP_DEW_CIPHER_IV_SEL] = 0x8106,
+ [PWRAP_DEW_CIPHER_EN] = 0x8108,
+ [PWRAP_DEW_CIPHER_RDY] = 0x810a,
+ [PWRAP_DEW_CIPHER_MODE] = 0x810c,
+ [PWRAP_DEW_CIPHER_SWRST] = 0x810e,
+ [PWRAP_DEW_RDDMY_NO] = 0x8110,
+};
+
static const u32 mt6351_regs[] = {
[PWRAP_DEW_DIO_EN] = 0x02F2,
[PWRAP_DEW_READ_TEST] = 0x02F4,
@@ -1182,6 +1216,8 @@ static int mt8186_regs[] = {
enum pmic_type {
PMIC_MT6323,
+ PMIC_MT6331,
+ PMIC_MT6332,
PMIC_MT6351,
PMIC_MT6357,
PMIC_MT6358,
@@ -2041,6 +2077,16 @@ static const struct pwrap_slv_type pmic_mt6323 = {
PWRAP_SLV_CAP_SECURITY,
};
+static const struct pwrap_slv_type pmic_mt6331 = {
+ .dew_regs = mt6331_regs,
+ .type = PMIC_MT6331,
+ .comp_dew_regs = mt6332_regs,
+ .comp_type = PMIC_MT6332,
+ .regops = &pwrap_regops16,
+ .caps = PWRAP_SLV_CAP_SPI | PWRAP_SLV_CAP_DUALIO |
+ PWRAP_SLV_CAP_SECURITY,
+};
+
static const struct pwrap_slv_type pmic_mt6351 = {
.dew_regs = mt6351_regs,
.type = PMIC_MT6351,
@@ -2086,6 +2132,7 @@ static const struct pwrap_slv_type pmic_mt6397 = {
static const struct of_device_id of_slave_match_tbl[] = {
{ .compatible = "mediatek,mt6323", .data = &pmic_mt6323 },
+ { .compatible = "mediatek,mt6331", .data = &pmic_mt6331 },
{ .compatible = "mediatek,mt6351", .data = &pmic_mt6351 },
{ .compatible = "mediatek,mt6357", .data = &pmic_mt6357 },
{ .compatible = "mediatek,mt6358", .data = &pmic_mt6358 },
--
2.40.0
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v2 5/6] soc: mediatek: mtk-pmic-wrap: Add support for MT6331 w/ MT6332 companion
@ 2023-03-24 9:42 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-24 9:42 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, amergnat, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno
Add support for the MT6331 PMIC and for its companion MT6332 PMIC.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/soc/mediatek/mtk-pmic-wrap.c | 47 ++++++++++++++++++++++++++++
1 file changed, 47 insertions(+)
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 366e40b802e4..ceeac43f7bd1 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -170,6 +170,40 @@ static const u32 mt6323_regs[] = {
[PWRAP_DEW_RDDMY_NO] = 0x01a4,
};
+static const u32 mt6331_regs[] = {
+ [PWRAP_DEW_DIO_EN] = 0x018c,
+ [PWRAP_DEW_READ_TEST] = 0x018e,
+ [PWRAP_DEW_WRITE_TEST] = 0x0190,
+ [PWRAP_DEW_CRC_SWRST] = 0x0192,
+ [PWRAP_DEW_CRC_EN] = 0x0194,
+ [PWRAP_DEW_CRC_VAL] = 0x0196,
+ [PWRAP_DEW_MON_GRP_SEL] = 0x0198,
+ [PWRAP_DEW_CIPHER_KEY_SEL] = 0x019a,
+ [PWRAP_DEW_CIPHER_IV_SEL] = 0x019c,
+ [PWRAP_DEW_CIPHER_EN] = 0x019e,
+ [PWRAP_DEW_CIPHER_RDY] = 0x01a0,
+ [PWRAP_DEW_CIPHER_MODE] = 0x01a2,
+ [PWRAP_DEW_CIPHER_SWRST] = 0x01a4,
+ [PWRAP_DEW_RDDMY_NO] = 0x01a6,
+};
+
+static const u32 mt6332_regs[] = {
+ [PWRAP_DEW_DIO_EN] = 0x80f6,
+ [PWRAP_DEW_READ_TEST] = 0x80f8,
+ [PWRAP_DEW_WRITE_TEST] = 0x80fa,
+ [PWRAP_DEW_CRC_SWRST] = 0x80fc,
+ [PWRAP_DEW_CRC_EN] = 0x80fe,
+ [PWRAP_DEW_CRC_VAL] = 0x8100,
+ [PWRAP_DEW_MON_GRP_SEL] = 0x8102,
+ [PWRAP_DEW_CIPHER_KEY_SEL] = 0x8104,
+ [PWRAP_DEW_CIPHER_IV_SEL] = 0x8106,
+ [PWRAP_DEW_CIPHER_EN] = 0x8108,
+ [PWRAP_DEW_CIPHER_RDY] = 0x810a,
+ [PWRAP_DEW_CIPHER_MODE] = 0x810c,
+ [PWRAP_DEW_CIPHER_SWRST] = 0x810e,
+ [PWRAP_DEW_RDDMY_NO] = 0x8110,
+};
+
static const u32 mt6351_regs[] = {
[PWRAP_DEW_DIO_EN] = 0x02F2,
[PWRAP_DEW_READ_TEST] = 0x02F4,
@@ -1182,6 +1216,8 @@ static int mt8186_regs[] = {
enum pmic_type {
PMIC_MT6323,
+ PMIC_MT6331,
+ PMIC_MT6332,
PMIC_MT6351,
PMIC_MT6357,
PMIC_MT6358,
@@ -2041,6 +2077,16 @@ static const struct pwrap_slv_type pmic_mt6323 = {
PWRAP_SLV_CAP_SECURITY,
};
+static const struct pwrap_slv_type pmic_mt6331 = {
+ .dew_regs = mt6331_regs,
+ .type = PMIC_MT6331,
+ .comp_dew_regs = mt6332_regs,
+ .comp_type = PMIC_MT6332,
+ .regops = &pwrap_regops16,
+ .caps = PWRAP_SLV_CAP_SPI | PWRAP_SLV_CAP_DUALIO |
+ PWRAP_SLV_CAP_SECURITY,
+};
+
static const struct pwrap_slv_type pmic_mt6351 = {
.dew_regs = mt6351_regs,
.type = PMIC_MT6351,
@@ -2086,6 +2132,7 @@ static const struct pwrap_slv_type pmic_mt6397 = {
static const struct of_device_id of_slave_match_tbl[] = {
{ .compatible = "mediatek,mt6323", .data = &pmic_mt6323 },
+ { .compatible = "mediatek,mt6331", .data = &pmic_mt6331 },
{ .compatible = "mediatek,mt6351", .data = &pmic_mt6351 },
{ .compatible = "mediatek,mt6357", .data = &pmic_mt6357 },
{ .compatible = "mediatek,mt6358", .data = &pmic_mt6358 },
--
2.40.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v2 6/6] soc: mediatek: pwrap: Add support for MT6795 Helio X10
2023-03-24 9:41 ` AngeloGioacchino Del Regno
@ 2023-03-24 9:42 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-24 9:42 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, amergnat, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno
Add the necessary bits to support the MT6795 Helio X10 smartphone SoC:
this is always paired with a MT6331 PMIC, with MT6332 companion.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/soc/mediatek/mtk-pmic-wrap.c | 131 ++++++++++++++++++++++++++-
1 file changed, 130 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index ceeac43f7bd1..20d32328382a 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -639,6 +639,91 @@ static int mt6779_regs[] = {
[PWRAP_WACS2_VLDCLR] = 0xC28,
};
+static int mt6795_regs[] = {
+ [PWRAP_MUX_SEL] = 0x0,
+ [PWRAP_WRAP_EN] = 0x4,
+ [PWRAP_DIO_EN] = 0x8,
+ [PWRAP_SIDLY] = 0xc,
+ [PWRAP_RDDMY] = 0x10,
+ [PWRAP_SI_CK_CON] = 0x14,
+ [PWRAP_CSHEXT_WRITE] = 0x18,
+ [PWRAP_CSHEXT_READ] = 0x1c,
+ [PWRAP_CSLEXT_START] = 0x20,
+ [PWRAP_CSLEXT_END] = 0x24,
+ [PWRAP_STAUPD_PRD] = 0x28,
+ [PWRAP_STAUPD_GRPEN] = 0x2c,
+ [PWRAP_EINT_STA0_ADR] = 0x30,
+ [PWRAP_EINT_STA1_ADR] = 0x34,
+ [PWRAP_STAUPD_MAN_TRIG] = 0x40,
+ [PWRAP_STAUPD_STA] = 0x44,
+ [PWRAP_WRAP_STA] = 0x48,
+ [PWRAP_HARB_INIT] = 0x4c,
+ [PWRAP_HARB_HPRIO] = 0x50,
+ [PWRAP_HIPRIO_ARB_EN] = 0x54,
+ [PWRAP_HARB_STA0] = 0x58,
+ [PWRAP_HARB_STA1] = 0x5c,
+ [PWRAP_MAN_EN] = 0x60,
+ [PWRAP_MAN_CMD] = 0x64,
+ [PWRAP_MAN_RDATA] = 0x68,
+ [PWRAP_MAN_VLDCLR] = 0x6c,
+ [PWRAP_WACS0_EN] = 0x70,
+ [PWRAP_INIT_DONE0] = 0x74,
+ [PWRAP_WACS0_CMD] = 0x78,
+ [PWRAP_WACS0_RDATA] = 0x7c,
+ [PWRAP_WACS0_VLDCLR] = 0x80,
+ [PWRAP_WACS1_EN] = 0x84,
+ [PWRAP_INIT_DONE1] = 0x88,
+ [PWRAP_WACS1_CMD] = 0x8c,
+ [PWRAP_WACS1_RDATA] = 0x90,
+ [PWRAP_WACS1_VLDCLR] = 0x94,
+ [PWRAP_WACS2_EN] = 0x98,
+ [PWRAP_INIT_DONE2] = 0x9c,
+ [PWRAP_WACS2_CMD] = 0xa0,
+ [PWRAP_WACS2_RDATA] = 0xa4,
+ [PWRAP_WACS2_VLDCLR] = 0xa8,
+ [PWRAP_INT_EN] = 0xac,
+ [PWRAP_INT_FLG_RAW] = 0xb0,
+ [PWRAP_INT_FLG] = 0xb4,
+ [PWRAP_INT_CLR] = 0xb8,
+ [PWRAP_SIG_ADR] = 0xbc,
+ [PWRAP_SIG_MODE] = 0xc0,
+ [PWRAP_SIG_VALUE] = 0xc4,
+ [PWRAP_SIG_ERRVAL] = 0xc8,
+ [PWRAP_CRC_EN] = 0xcc,
+ [PWRAP_TIMER_EN] = 0xd0,
+ [PWRAP_TIMER_STA] = 0xd4,
+ [PWRAP_WDT_UNIT] = 0xd8,
+ [PWRAP_WDT_SRC_EN] = 0xdc,
+ [PWRAP_WDT_FLG] = 0xe0,
+ [PWRAP_DEBUG_INT_SEL] = 0xe4,
+ [PWRAP_DVFS_ADR0] = 0xe8,
+ [PWRAP_DVFS_WDATA0] = 0xec,
+ [PWRAP_DVFS_ADR1] = 0xf0,
+ [PWRAP_DVFS_WDATA1] = 0xf4,
+ [PWRAP_DVFS_ADR2] = 0xf8,
+ [PWRAP_DVFS_WDATA2] = 0xfc,
+ [PWRAP_DVFS_ADR3] = 0x100,
+ [PWRAP_DVFS_WDATA3] = 0x104,
+ [PWRAP_DVFS_ADR4] = 0x108,
+ [PWRAP_DVFS_WDATA4] = 0x10c,
+ [PWRAP_DVFS_ADR5] = 0x110,
+ [PWRAP_DVFS_WDATA5] = 0x114,
+ [PWRAP_DVFS_ADR6] = 0x118,
+ [PWRAP_DVFS_WDATA6] = 0x11c,
+ [PWRAP_DVFS_ADR7] = 0x120,
+ [PWRAP_DVFS_WDATA7] = 0x124,
+ [PWRAP_SPMINF_STA] = 0x128,
+ [PWRAP_CIPHER_KEY_SEL] = 0x12c,
+ [PWRAP_CIPHER_IV_SEL] = 0x130,
+ [PWRAP_CIPHER_EN] = 0x134,
+ [PWRAP_CIPHER_RDY] = 0x138,
+ [PWRAP_CIPHER_MODE] = 0x13c,
+ [PWRAP_CIPHER_SWRST] = 0x140,
+ [PWRAP_DCM_EN] = 0x144,
+ [PWRAP_DCM_DBC_PRD] = 0x148,
+ [PWRAP_EXT_CK] = 0x14c,
+};
+
static int mt6797_regs[] = {
[PWRAP_MUX_SEL] = 0x0,
[PWRAP_WRAP_EN] = 0x4,
@@ -1230,6 +1315,7 @@ enum pwrap_type {
PWRAP_MT2701,
PWRAP_MT6765,
PWRAP_MT6779,
+ PWRAP_MT6795,
PWRAP_MT6797,
PWRAP_MT6873,
PWRAP_MT7622,
@@ -1650,6 +1736,20 @@ static void pwrap_init_chip_select_ext(struct pmic_wrapper *wrp, u8 hext_write,
static int pwrap_common_init_reg_clock(struct pmic_wrapper *wrp)
{
switch (wrp->master->type) {
+ case PWRAP_MT6795:
+ if (wrp->slave->type == PMIC_MT6331) {
+ const u32 *dew_regs = wrp->slave->dew_regs;
+
+ pwrap_write(wrp, dew_regs[PWRAP_DEW_RDDMY_NO], 0x8);
+
+ if (wrp->slave->comp_type == PMIC_MT6332) {
+ dew_regs = wrp->slave->comp_dew_regs;
+ pwrap_write(wrp, dew_regs[PWRAP_DEW_RDDMY_NO], 0x8);
+ }
+ }
+ pwrap_writel(wrp, 0x88, PWRAP_RDDMY);
+ pwrap_init_chip_select_ext(wrp, 15, 15, 15, 15);
+ break;
case PWRAP_MT8173:
pwrap_init_chip_select_ext(wrp, 0, 4, 2, 2);
break;
@@ -1744,6 +1844,7 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
case PWRAP_MT2701:
case PWRAP_MT6765:
case PWRAP_MT6779:
+ case PWRAP_MT6795:
case PWRAP_MT6797:
case PWRAP_MT8173:
case PWRAP_MT8186:
@@ -1914,6 +2015,19 @@ static int pwrap_mt2701_init_soc_specific(struct pmic_wrapper *wrp)
return 0;
}
+static int pwrap_mt6795_init_soc_specific(struct pmic_wrapper *wrp)
+{
+ pwrap_writel(wrp, 0xf, PWRAP_STAUPD_GRPEN);
+
+ if (wrp->slave->type == PMIC_MT6331)
+ pwrap_writel(wrp, 0x1b4, PWRAP_EINT_STA0_ADR);
+
+ if (wrp->slave->comp_type == PMIC_MT6332)
+ pwrap_writel(wrp, 0x8112, PWRAP_EINT_STA1_ADR);
+
+ return 0;
+}
+
static int pwrap_mt7622_init_soc_specific(struct pmic_wrapper *wrp)
{
pwrap_writel(wrp, 0, PWRAP_STAUPD_PRD);
@@ -1949,7 +2063,8 @@ static int pwrap_init(struct pmic_wrapper *wrp)
if (wrp->rstc_bridge)
reset_control_reset(wrp->rstc_bridge);
- if (wrp->master->type == PWRAP_MT8173) {
+ if (wrp->master->type == PWRAP_MT8173 ||
+ wrp->master->type == PWRAP_MT6795) {
/* Enable DCM */
pwrap_writel(wrp, 3, PWRAP_DCM_EN);
pwrap_writel(wrp, 0, PWRAP_DCM_DBC_PRD);
@@ -2185,6 +2300,19 @@ static const struct pmic_wrapper_type pwrap_mt6779 = {
.init_soc_specific = NULL,
};
+static const struct pmic_wrapper_type pwrap_mt6795 = {
+ .regs = mt6795_regs,
+ .type = PWRAP_MT6795,
+ .arb_en_all = 0x3f,
+ .int_en_all = ~(u32)(BIT(31) | BIT(2) | BIT(1)),
+ .int1_en_all = 0,
+ .spi_w = PWRAP_MAN_CMD_SPI_WRITE,
+ .wdt_src = PWRAP_WDT_SRC_MASK_NO_STAUPD,
+ .caps = PWRAP_CAP_RESET | PWRAP_CAP_DCM,
+ .init_reg_clock = pwrap_common_init_reg_clock,
+ .init_soc_specific = pwrap_mt6795_init_soc_specific,
+};
+
static const struct pmic_wrapper_type pwrap_mt6797 = {
.regs = mt6797_regs,
.type = PWRAP_MT6797,
@@ -2318,6 +2446,7 @@ static const struct of_device_id of_pwrap_match_tbl[] = {
{ .compatible = "mediatek,mt2701-pwrap", .data = &pwrap_mt2701 },
{ .compatible = "mediatek,mt6765-pwrap", .data = &pwrap_mt6765 },
{ .compatible = "mediatek,mt6779-pwrap", .data = &pwrap_mt6779 },
+ { .compatible = "mediatek,mt6795-pwrap", .data = &pwrap_mt6795 },
{ .compatible = "mediatek,mt6797-pwrap", .data = &pwrap_mt6797 },
{ .compatible = "mediatek,mt6873-pwrap", .data = &pwrap_mt6873 },
{ .compatible = "mediatek,mt7622-pwrap", .data = &pwrap_mt7622 },
--
2.40.0
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v2 6/6] soc: mediatek: pwrap: Add support for MT6795 Helio X10
@ 2023-03-24 9:42 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-24 9:42 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, amergnat, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno
Add the necessary bits to support the MT6795 Helio X10 smartphone SoC:
this is always paired with a MT6331 PMIC, with MT6332 companion.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/soc/mediatek/mtk-pmic-wrap.c | 131 ++++++++++++++++++++++++++-
1 file changed, 130 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index ceeac43f7bd1..20d32328382a 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -639,6 +639,91 @@ static int mt6779_regs[] = {
[PWRAP_WACS2_VLDCLR] = 0xC28,
};
+static int mt6795_regs[] = {
+ [PWRAP_MUX_SEL] = 0x0,
+ [PWRAP_WRAP_EN] = 0x4,
+ [PWRAP_DIO_EN] = 0x8,
+ [PWRAP_SIDLY] = 0xc,
+ [PWRAP_RDDMY] = 0x10,
+ [PWRAP_SI_CK_CON] = 0x14,
+ [PWRAP_CSHEXT_WRITE] = 0x18,
+ [PWRAP_CSHEXT_READ] = 0x1c,
+ [PWRAP_CSLEXT_START] = 0x20,
+ [PWRAP_CSLEXT_END] = 0x24,
+ [PWRAP_STAUPD_PRD] = 0x28,
+ [PWRAP_STAUPD_GRPEN] = 0x2c,
+ [PWRAP_EINT_STA0_ADR] = 0x30,
+ [PWRAP_EINT_STA1_ADR] = 0x34,
+ [PWRAP_STAUPD_MAN_TRIG] = 0x40,
+ [PWRAP_STAUPD_STA] = 0x44,
+ [PWRAP_WRAP_STA] = 0x48,
+ [PWRAP_HARB_INIT] = 0x4c,
+ [PWRAP_HARB_HPRIO] = 0x50,
+ [PWRAP_HIPRIO_ARB_EN] = 0x54,
+ [PWRAP_HARB_STA0] = 0x58,
+ [PWRAP_HARB_STA1] = 0x5c,
+ [PWRAP_MAN_EN] = 0x60,
+ [PWRAP_MAN_CMD] = 0x64,
+ [PWRAP_MAN_RDATA] = 0x68,
+ [PWRAP_MAN_VLDCLR] = 0x6c,
+ [PWRAP_WACS0_EN] = 0x70,
+ [PWRAP_INIT_DONE0] = 0x74,
+ [PWRAP_WACS0_CMD] = 0x78,
+ [PWRAP_WACS0_RDATA] = 0x7c,
+ [PWRAP_WACS0_VLDCLR] = 0x80,
+ [PWRAP_WACS1_EN] = 0x84,
+ [PWRAP_INIT_DONE1] = 0x88,
+ [PWRAP_WACS1_CMD] = 0x8c,
+ [PWRAP_WACS1_RDATA] = 0x90,
+ [PWRAP_WACS1_VLDCLR] = 0x94,
+ [PWRAP_WACS2_EN] = 0x98,
+ [PWRAP_INIT_DONE2] = 0x9c,
+ [PWRAP_WACS2_CMD] = 0xa0,
+ [PWRAP_WACS2_RDATA] = 0xa4,
+ [PWRAP_WACS2_VLDCLR] = 0xa8,
+ [PWRAP_INT_EN] = 0xac,
+ [PWRAP_INT_FLG_RAW] = 0xb0,
+ [PWRAP_INT_FLG] = 0xb4,
+ [PWRAP_INT_CLR] = 0xb8,
+ [PWRAP_SIG_ADR] = 0xbc,
+ [PWRAP_SIG_MODE] = 0xc0,
+ [PWRAP_SIG_VALUE] = 0xc4,
+ [PWRAP_SIG_ERRVAL] = 0xc8,
+ [PWRAP_CRC_EN] = 0xcc,
+ [PWRAP_TIMER_EN] = 0xd0,
+ [PWRAP_TIMER_STA] = 0xd4,
+ [PWRAP_WDT_UNIT] = 0xd8,
+ [PWRAP_WDT_SRC_EN] = 0xdc,
+ [PWRAP_WDT_FLG] = 0xe0,
+ [PWRAP_DEBUG_INT_SEL] = 0xe4,
+ [PWRAP_DVFS_ADR0] = 0xe8,
+ [PWRAP_DVFS_WDATA0] = 0xec,
+ [PWRAP_DVFS_ADR1] = 0xf0,
+ [PWRAP_DVFS_WDATA1] = 0xf4,
+ [PWRAP_DVFS_ADR2] = 0xf8,
+ [PWRAP_DVFS_WDATA2] = 0xfc,
+ [PWRAP_DVFS_ADR3] = 0x100,
+ [PWRAP_DVFS_WDATA3] = 0x104,
+ [PWRAP_DVFS_ADR4] = 0x108,
+ [PWRAP_DVFS_WDATA4] = 0x10c,
+ [PWRAP_DVFS_ADR5] = 0x110,
+ [PWRAP_DVFS_WDATA5] = 0x114,
+ [PWRAP_DVFS_ADR6] = 0x118,
+ [PWRAP_DVFS_WDATA6] = 0x11c,
+ [PWRAP_DVFS_ADR7] = 0x120,
+ [PWRAP_DVFS_WDATA7] = 0x124,
+ [PWRAP_SPMINF_STA] = 0x128,
+ [PWRAP_CIPHER_KEY_SEL] = 0x12c,
+ [PWRAP_CIPHER_IV_SEL] = 0x130,
+ [PWRAP_CIPHER_EN] = 0x134,
+ [PWRAP_CIPHER_RDY] = 0x138,
+ [PWRAP_CIPHER_MODE] = 0x13c,
+ [PWRAP_CIPHER_SWRST] = 0x140,
+ [PWRAP_DCM_EN] = 0x144,
+ [PWRAP_DCM_DBC_PRD] = 0x148,
+ [PWRAP_EXT_CK] = 0x14c,
+};
+
static int mt6797_regs[] = {
[PWRAP_MUX_SEL] = 0x0,
[PWRAP_WRAP_EN] = 0x4,
@@ -1230,6 +1315,7 @@ enum pwrap_type {
PWRAP_MT2701,
PWRAP_MT6765,
PWRAP_MT6779,
+ PWRAP_MT6795,
PWRAP_MT6797,
PWRAP_MT6873,
PWRAP_MT7622,
@@ -1650,6 +1736,20 @@ static void pwrap_init_chip_select_ext(struct pmic_wrapper *wrp, u8 hext_write,
static int pwrap_common_init_reg_clock(struct pmic_wrapper *wrp)
{
switch (wrp->master->type) {
+ case PWRAP_MT6795:
+ if (wrp->slave->type == PMIC_MT6331) {
+ const u32 *dew_regs = wrp->slave->dew_regs;
+
+ pwrap_write(wrp, dew_regs[PWRAP_DEW_RDDMY_NO], 0x8);
+
+ if (wrp->slave->comp_type == PMIC_MT6332) {
+ dew_regs = wrp->slave->comp_dew_regs;
+ pwrap_write(wrp, dew_regs[PWRAP_DEW_RDDMY_NO], 0x8);
+ }
+ }
+ pwrap_writel(wrp, 0x88, PWRAP_RDDMY);
+ pwrap_init_chip_select_ext(wrp, 15, 15, 15, 15);
+ break;
case PWRAP_MT8173:
pwrap_init_chip_select_ext(wrp, 0, 4, 2, 2);
break;
@@ -1744,6 +1844,7 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
case PWRAP_MT2701:
case PWRAP_MT6765:
case PWRAP_MT6779:
+ case PWRAP_MT6795:
case PWRAP_MT6797:
case PWRAP_MT8173:
case PWRAP_MT8186:
@@ -1914,6 +2015,19 @@ static int pwrap_mt2701_init_soc_specific(struct pmic_wrapper *wrp)
return 0;
}
+static int pwrap_mt6795_init_soc_specific(struct pmic_wrapper *wrp)
+{
+ pwrap_writel(wrp, 0xf, PWRAP_STAUPD_GRPEN);
+
+ if (wrp->slave->type == PMIC_MT6331)
+ pwrap_writel(wrp, 0x1b4, PWRAP_EINT_STA0_ADR);
+
+ if (wrp->slave->comp_type == PMIC_MT6332)
+ pwrap_writel(wrp, 0x8112, PWRAP_EINT_STA1_ADR);
+
+ return 0;
+}
+
static int pwrap_mt7622_init_soc_specific(struct pmic_wrapper *wrp)
{
pwrap_writel(wrp, 0, PWRAP_STAUPD_PRD);
@@ -1949,7 +2063,8 @@ static int pwrap_init(struct pmic_wrapper *wrp)
if (wrp->rstc_bridge)
reset_control_reset(wrp->rstc_bridge);
- if (wrp->master->type == PWRAP_MT8173) {
+ if (wrp->master->type == PWRAP_MT8173 ||
+ wrp->master->type == PWRAP_MT6795) {
/* Enable DCM */
pwrap_writel(wrp, 3, PWRAP_DCM_EN);
pwrap_writel(wrp, 0, PWRAP_DCM_DBC_PRD);
@@ -2185,6 +2300,19 @@ static const struct pmic_wrapper_type pwrap_mt6779 = {
.init_soc_specific = NULL,
};
+static const struct pmic_wrapper_type pwrap_mt6795 = {
+ .regs = mt6795_regs,
+ .type = PWRAP_MT6795,
+ .arb_en_all = 0x3f,
+ .int_en_all = ~(u32)(BIT(31) | BIT(2) | BIT(1)),
+ .int1_en_all = 0,
+ .spi_w = PWRAP_MAN_CMD_SPI_WRITE,
+ .wdt_src = PWRAP_WDT_SRC_MASK_NO_STAUPD,
+ .caps = PWRAP_CAP_RESET | PWRAP_CAP_DCM,
+ .init_reg_clock = pwrap_common_init_reg_clock,
+ .init_soc_specific = pwrap_mt6795_init_soc_specific,
+};
+
static const struct pmic_wrapper_type pwrap_mt6797 = {
.regs = mt6797_regs,
.type = PWRAP_MT6797,
@@ -2318,6 +2446,7 @@ static const struct of_device_id of_pwrap_match_tbl[] = {
{ .compatible = "mediatek,mt2701-pwrap", .data = &pwrap_mt2701 },
{ .compatible = "mediatek,mt6765-pwrap", .data = &pwrap_mt6765 },
{ .compatible = "mediatek,mt6779-pwrap", .data = &pwrap_mt6779 },
+ { .compatible = "mediatek,mt6795-pwrap", .data = &pwrap_mt6795 },
{ .compatible = "mediatek,mt6797-pwrap", .data = &pwrap_mt6797 },
{ .compatible = "mediatek,mt6873-pwrap", .data = &pwrap_mt6873 },
{ .compatible = "mediatek,mt7622-pwrap", .data = &pwrap_mt7622 },
--
2.40.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [PATCH v2 1/6] dt-bindings: soc: mediatek: pwrap: Add compatible for MT6795 Helio X10
2023-03-24 9:42 ` AngeloGioacchino Del Regno
@ 2023-03-27 7:23 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 30+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-27 7:23 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, amergnat, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming
On 24/03/2023 10:42, AngeloGioacchino Del Regno wrote:
> Add a compatible for the PMIC Wrapper found on the MT6795 Helio X10 SoC.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 1 +
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 1/6] dt-bindings: soc: mediatek: pwrap: Add compatible for MT6795 Helio X10
@ 2023-03-27 7:23 ` Krzysztof Kozlowski
0 siblings, 0 replies; 30+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-27 7:23 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, matthias.bgg
Cc: robh+dt, krzysztof.kozlowski+dt, amergnat, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming
On 24/03/2023 10:42, AngeloGioacchino Del Regno wrote:
> Add a compatible for the PMIC Wrapper found on the MT6795 Helio X10 SoC.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 1 +
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 2/6] soc: mediatek: pwrap: Move PMIC read test sequence in function
2023-03-24 9:42 ` AngeloGioacchino Del Regno
@ 2023-03-28 9:19 ` Alexandre Mergnat
-1 siblings, 0 replies; 30+ messages in thread
From: Alexandre Mergnat @ 2023-03-28 9:19 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: matthias.bgg, robh+dt, krzysztof.kozlowski+dt, flora.fu,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
kernel, phone-devel, ~postmarketos/upstreaming
Le ven. 24 mars 2023 à 10:42, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> a écrit :
>
> The PMIC read test is performed in two places: pwrap_init_dual_io()
> and pwrap_init_sidly().
> In preparation for adding support for PMICs requiring a companion
> part, move this sequence to a new function pwrap_pmic_read_test().
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 32 +++++++++++++++++-----------
> 1 file changed, 20 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 15789a03e6c6..5c500be48f7c 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -1455,6 +1455,18 @@ static int pwrap_regmap_write(void *context, u32 adr, u32 wdata)
> return pwrap_write(context, adr, wdata);
> }
>
> +static bool pwrap_pmic_read_test(struct pmic_wrapper *wrp, const u32 *dew_regs,
> + u16 read_test_val)
> +{
> + bool is_success;
> + u32 rdata;
> +
> + pwrap_read(wrp, dew_regs[PWRAP_DEW_READ_TEST], &rdata);
> + is_success = ((rdata & U16_MAX) == read_test_val);
> +
> + return is_success;
> +}
> +
> static int pwrap_reset_spislave(struct pmic_wrapper *wrp)
> {
> bool tmp;
> @@ -1498,18 +1510,18 @@ static int pwrap_reset_spislave(struct pmic_wrapper *wrp)
> */
> static int pwrap_init_sidly(struct pmic_wrapper *wrp)
> {
> - u32 rdata;
> u32 i;
> u32 pass = 0;
> + bool read_ok;
> signed char dly[16] = {
> -1, 0, 1, 0, 2, -1, 1, 1, 3, -1, -1, -1, 3, -1, 2, 1
> };
>
> for (i = 0; i < 4; i++) {
> pwrap_writel(wrp, i, PWRAP_SIDLY);
> - pwrap_read(wrp, wrp->slave->dew_regs[PWRAP_DEW_READ_TEST],
> - &rdata);
> - if (rdata == PWRAP_DEW_READ_TEST_VAL) {
> + read_ok = pwrap_pmic_read_test(wrp, wrp->slave->dew_regs,
> + PWRAP_DEW_READ_TEST_VAL);
> + if (read_ok) {
> dev_dbg(wrp->dev, "[Read Test] pass, SIDLY=%x\n", i);
> pass |= 1 << i;
> }
> @@ -1529,8 +1541,7 @@ static int pwrap_init_sidly(struct pmic_wrapper *wrp)
> static int pwrap_init_dual_io(struct pmic_wrapper *wrp)
> {
> int ret;
> - bool tmp;
> - u32 rdata;
> + bool read_ok, tmp;
>
> /* Enable dual IO mode */
> pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_DIO_EN], 1);
> @@ -1546,12 +1557,9 @@ static int pwrap_init_dual_io(struct pmic_wrapper *wrp)
> pwrap_writel(wrp, 1, PWRAP_DIO_EN);
>
> /* Read Test */
> - pwrap_read(wrp,
> - wrp->slave->dew_regs[PWRAP_DEW_READ_TEST], &rdata);
> - if (rdata != PWRAP_DEW_READ_TEST_VAL) {
> - dev_err(wrp->dev,
> - "Read failed on DIO mode: 0x%04x!=0x%04x\n",
> - PWRAP_DEW_READ_TEST_VAL, rdata);
> + read_ok = pwrap_pmic_read_test(wrp, wrp->slave->dew_regs, PWRAP_DEW_READ_TEST_VAL);
> + if (!read_ok) {
> + dev_err(wrp->dev, "Read failed on DIO mode.\n");
> return -EFAULT;
> }
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Regards,
Alexandre
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 2/6] soc: mediatek: pwrap: Move PMIC read test sequence in function
@ 2023-03-28 9:19 ` Alexandre Mergnat
0 siblings, 0 replies; 30+ messages in thread
From: Alexandre Mergnat @ 2023-03-28 9:19 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: matthias.bgg, robh+dt, krzysztof.kozlowski+dt, flora.fu,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
kernel, phone-devel, ~postmarketos/upstreaming
Le ven. 24 mars 2023 à 10:42, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> a écrit :
>
> The PMIC read test is performed in two places: pwrap_init_dual_io()
> and pwrap_init_sidly().
> In preparation for adding support for PMICs requiring a companion
> part, move this sequence to a new function pwrap_pmic_read_test().
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 32 +++++++++++++++++-----------
> 1 file changed, 20 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 15789a03e6c6..5c500be48f7c 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -1455,6 +1455,18 @@ static int pwrap_regmap_write(void *context, u32 adr, u32 wdata)
> return pwrap_write(context, adr, wdata);
> }
>
> +static bool pwrap_pmic_read_test(struct pmic_wrapper *wrp, const u32 *dew_regs,
> + u16 read_test_val)
> +{
> + bool is_success;
> + u32 rdata;
> +
> + pwrap_read(wrp, dew_regs[PWRAP_DEW_READ_TEST], &rdata);
> + is_success = ((rdata & U16_MAX) == read_test_val);
> +
> + return is_success;
> +}
> +
> static int pwrap_reset_spislave(struct pmic_wrapper *wrp)
> {
> bool tmp;
> @@ -1498,18 +1510,18 @@ static int pwrap_reset_spislave(struct pmic_wrapper *wrp)
> */
> static int pwrap_init_sidly(struct pmic_wrapper *wrp)
> {
> - u32 rdata;
> u32 i;
> u32 pass = 0;
> + bool read_ok;
> signed char dly[16] = {
> -1, 0, 1, 0, 2, -1, 1, 1, 3, -1, -1, -1, 3, -1, 2, 1
> };
>
> for (i = 0; i < 4; i++) {
> pwrap_writel(wrp, i, PWRAP_SIDLY);
> - pwrap_read(wrp, wrp->slave->dew_regs[PWRAP_DEW_READ_TEST],
> - &rdata);
> - if (rdata == PWRAP_DEW_READ_TEST_VAL) {
> + read_ok = pwrap_pmic_read_test(wrp, wrp->slave->dew_regs,
> + PWRAP_DEW_READ_TEST_VAL);
> + if (read_ok) {
> dev_dbg(wrp->dev, "[Read Test] pass, SIDLY=%x\n", i);
> pass |= 1 << i;
> }
> @@ -1529,8 +1541,7 @@ static int pwrap_init_sidly(struct pmic_wrapper *wrp)
> static int pwrap_init_dual_io(struct pmic_wrapper *wrp)
> {
> int ret;
> - bool tmp;
> - u32 rdata;
> + bool read_ok, tmp;
>
> /* Enable dual IO mode */
> pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_DIO_EN], 1);
> @@ -1546,12 +1557,9 @@ static int pwrap_init_dual_io(struct pmic_wrapper *wrp)
> pwrap_writel(wrp, 1, PWRAP_DIO_EN);
>
> /* Read Test */
> - pwrap_read(wrp,
> - wrp->slave->dew_regs[PWRAP_DEW_READ_TEST], &rdata);
> - if (rdata != PWRAP_DEW_READ_TEST_VAL) {
> - dev_err(wrp->dev,
> - "Read failed on DIO mode: 0x%04x!=0x%04x\n",
> - PWRAP_DEW_READ_TEST_VAL, rdata);
> + read_ok = pwrap_pmic_read_test(wrp, wrp->slave->dew_regs, PWRAP_DEW_READ_TEST_VAL);
> + if (!read_ok) {
> + dev_err(wrp->dev, "Read failed on DIO mode.\n");
> return -EFAULT;
> }
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Regards,
Alexandre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 3/6] soc: mediatek: pwrap: Add kerneldoc for struct pwrap_slv_type
2023-03-24 9:42 ` AngeloGioacchino Del Regno
@ 2023-03-28 9:22 ` Alexandre Mergnat
-1 siblings, 0 replies; 30+ messages in thread
From: Alexandre Mergnat @ 2023-03-28 9:22 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: matthias.bgg, robh+dt, krzysztof.kozlowski+dt, flora.fu,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
kernel, phone-devel, ~postmarketos/upstreaming
Le ven. 24 mars 2023 à 10:42, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> a écrit :
>
> In preparation for adding new members with name abbreviations describe
> the struct pwrap_slv_type with kerneldoc to enhance human readability.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 5c500be48f7c..a33a1b1820cb 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -1218,11 +1218,17 @@ struct pwrap_slv_regops {
> int (*pwrap_write)(struct pmic_wrapper *wrp, u32 adr, u32 wdata);
> };
>
> +/**
> + * struct pwrap_slv_type - PMIC device wrapper definitions
> + * @dew_regs: Device Wrapper (DeW) register offsets
> + * @type: PMIC Type (model)
> + * @regops: Register R/W ops
> + * @caps: Capability flags for the target device
> + */
> struct pwrap_slv_type {
> const u32 *dew_regs;
> enum pmic_type type;
> const struct pwrap_slv_regops *regops;
> - /* Flags indicating the capability for the target slave */
> u32 caps;
> };
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Regards,
Alexandre
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 3/6] soc: mediatek: pwrap: Add kerneldoc for struct pwrap_slv_type
@ 2023-03-28 9:22 ` Alexandre Mergnat
0 siblings, 0 replies; 30+ messages in thread
From: Alexandre Mergnat @ 2023-03-28 9:22 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: matthias.bgg, robh+dt, krzysztof.kozlowski+dt, flora.fu,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
kernel, phone-devel, ~postmarketos/upstreaming
Le ven. 24 mars 2023 à 10:42, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> a écrit :
>
> In preparation for adding new members with name abbreviations describe
> the struct pwrap_slv_type with kerneldoc to enhance human readability.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 5c500be48f7c..a33a1b1820cb 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -1218,11 +1218,17 @@ struct pwrap_slv_regops {
> int (*pwrap_write)(struct pmic_wrapper *wrp, u32 adr, u32 wdata);
> };
>
> +/**
> + * struct pwrap_slv_type - PMIC device wrapper definitions
> + * @dew_regs: Device Wrapper (DeW) register offsets
> + * @type: PMIC Type (model)
> + * @regops: Register R/W ops
> + * @caps: Capability flags for the target device
> + */
> struct pwrap_slv_type {
> const u32 *dew_regs;
> enum pmic_type type;
> const struct pwrap_slv_regops *regops;
> - /* Flags indicating the capability for the target slave */
> u32 caps;
> };
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Regards,
Alexandre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 4/6] soc: mediatek: mtk-pmic-wrap: Add support for companion PMICs
2023-03-24 9:42 ` AngeloGioacchino Del Regno
@ 2023-03-29 22:40 ` Alexandre Mergnat
-1 siblings, 0 replies; 30+ messages in thread
From: Alexandre Mergnat @ 2023-03-29 22:40 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: matthias.bgg, robh+dt, krzysztof.kozlowski+dt, flora.fu,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
kernel, phone-devel, ~postmarketos/upstreaming
Le ven. 24 mars 2023 à 10:42, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> a écrit :
>
> Some PMICs are designed to work with a companion part, which provides
> more regulators and/or companion devices such as LED controllers,
> display backlight controllers, battery charging, fuel gauge, etc:
> this kind of PMICs are usually present in smartphone platforms, where
> tight integration is required.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 73 ++++++++++++++++++++++------
> 1 file changed, 59 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index a33a1b1820cb..366e40b802e4 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -47,6 +47,7 @@
>
> /* macro for device wrapper default value */
> #define PWRAP_DEW_READ_TEST_VAL 0x5aa5
> +#define PWRAP_DEW_COMP_READ_TEST_VAL 0xa55a
> #define PWRAP_DEW_WRITE_TEST_VAL 0xa55a
>
> /* macro for manual command */
> @@ -1222,12 +1223,16 @@ struct pwrap_slv_regops {
> * struct pwrap_slv_type - PMIC device wrapper definitions
> * @dew_regs: Device Wrapper (DeW) register offsets
> * @type: PMIC Type (model)
> + * @comp_dew_regs: Device Wrapper (DeW) register offsets for companion device
> + * @comp_type: Companion PMIC Type (model)
> * @regops: Register R/W ops
> * @caps: Capability flags for the target device
> */
> struct pwrap_slv_type {
> const u32 *dew_regs;
> enum pmic_type type;
> + const u32 *comp_dew_regs;
> + enum pmic_type comp_type;
> const struct pwrap_slv_regops *regops;
> u32 caps;
> };
> @@ -1548,9 +1553,12 @@ static int pwrap_init_dual_io(struct pmic_wrapper *wrp)
> {
> int ret;
> bool read_ok, tmp;
> + bool comp_read_ok = true;
>
> /* Enable dual IO mode */
> pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_DIO_EN], 1);
> + if (wrp->slave->comp_dew_regs)
> + pwrap_write(wrp, wrp->slave->comp_dew_regs[PWRAP_DEW_DIO_EN], 1);
>
> /* Check IDLE & INIT_DONE in advance */
> ret = readx_poll_timeout(pwrap_is_fsm_idle_and_sync_idle, wrp, tmp, tmp,
> @@ -1564,8 +1572,14 @@ static int pwrap_init_dual_io(struct pmic_wrapper *wrp)
>
> /* Read Test */
> read_ok = pwrap_pmic_read_test(wrp, wrp->slave->dew_regs, PWRAP_DEW_READ_TEST_VAL);
> - if (!read_ok) {
> - dev_err(wrp->dev, "Read failed on DIO mode.\n");
> + if (wrp->slave->comp_dew_regs)
> + comp_read_ok = pwrap_pmic_read_test(wrp, wrp->slave->comp_dew_regs,
> + PWRAP_DEW_COMP_READ_TEST_VAL);
> + if (!read_ok || !comp_read_ok) {
> + dev_err(wrp->dev, "Read failed on DIO mode. Main PMIC %s%s\n",
> + !read_ok ? "fail" : "success",
> + wrp->slave->comp_dew_regs && !comp_read_ok ?
> + ", Companion PMIC fail" : "");
> return -EFAULT;
> }
>
> @@ -1640,19 +1654,41 @@ static bool pwrap_is_cipher_ready(struct pmic_wrapper *wrp)
> return pwrap_readl(wrp, PWRAP_CIPHER_RDY) & 1;
> }
>
> -static bool pwrap_is_pmic_cipher_ready(struct pmic_wrapper *wrp)
> +static bool __pwrap_is_pmic_cipher_ready(struct pmic_wrapper *wrp, const u32 *dew_regs)
> {
> u32 rdata;
> int ret;
>
> - ret = pwrap_read(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_RDY],
> - &rdata);
> + ret = pwrap_read(wrp, dew_regs[PWRAP_DEW_CIPHER_RDY], &rdata);
> if (ret)
> return false;
>
> return rdata == 1;
> }
>
> +
Remove this extra line please.
> +static bool pwrap_is_pmic_cipher_ready(struct pmic_wrapper *wrp)
> +{
> + bool ret = __pwrap_is_pmic_cipher_ready(wrp, wrp->slave->dew_regs);
> +
> + if (!ret)
> + return ret;
> +
> + /* If there's any companion, wait for it to be ready too */
> + if (wrp->slave->comp_dew_regs)
> + ret = __pwrap_is_pmic_cipher_ready(wrp, wrp->slave->comp_dew_regs);
> +
> + return ret;
> +}
> +
> +static void pwrap_config_cipher(struct pmic_wrapper *wrp, const u32 *dew_regs)
> +{
> + pwrap_write(wrp, dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x1);
> + pwrap_write(wrp, dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x0);
> + pwrap_write(wrp, dew_regs[PWRAP_DEW_CIPHER_KEY_SEL], 0x1);
> + pwrap_write(wrp, dew_regs[PWRAP_DEW_CIPHER_IV_SEL], 0x2);
> +}
> +
> static int pwrap_init_cipher(struct pmic_wrapper *wrp)
> {
> int ret;
> @@ -1689,10 +1725,11 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
> }
>
> /* Config cipher mode @PMIC */
> - pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x1);
> - pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x0);
> - pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_KEY_SEL], 0x1);
> - pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_IV_SEL], 0x2);
> + pwrap_config_cipher(wrp, wrp->slave->dew_regs);
> +
> + /* If there is any companion PMIC, configure cipher mode there too */
> + if (wrp->slave->comp_type > 0)
> + pwrap_config_cipher(wrp, wrp->slave->comp_dew_regs);
>
> switch (wrp->slave->type) {
> case PMIC_MT6397:
> @@ -1754,6 +1791,7 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
>
> static int pwrap_init_security(struct pmic_wrapper *wrp)
> {
> + u32 crc_val;
> int ret;
>
> /* Enable encryption */
> @@ -1762,14 +1800,21 @@ static int pwrap_init_security(struct pmic_wrapper *wrp)
> return ret;
>
> /* Signature checking - using CRC */
> - if (pwrap_write(wrp,
> - wrp->slave->dew_regs[PWRAP_DEW_CRC_EN], 0x1))
> - return -EFAULT;
> + ret = pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CRC_EN], 0x1);
> + if (ret == 0 && wrp->slave->comp_dew_regs)
> + ret = pwrap_write(wrp, wrp->slave->comp_dew_regs[PWRAP_DEW_CRC_EN], 0x1);
>
> pwrap_writel(wrp, 0x1, PWRAP_CRC_EN);
> pwrap_writel(wrp, 0x0, PWRAP_SIG_MODE);
> - pwrap_writel(wrp, wrp->slave->dew_regs[PWRAP_DEW_CRC_VAL],
> - PWRAP_SIG_ADR);
> +
> + /* CRC value */
> + crc_val = wrp->slave->dew_regs[PWRAP_DEW_CRC_VAL];
> + if (wrp->slave->comp_dew_regs)
> + crc_val |= wrp->slave->comp_dew_regs[PWRAP_DEW_CRC_VAL] << 16;
IMHO, the number 16 should be replaced by a define even if I guess
it's a simple shift value.
> +
> + pwrap_writel(wrp, crc_val, PWRAP_SIG_ADR);
> +
> + /* PMIC Wrapper Arbiter priority */
> pwrap_writel(wrp,
> wrp->master->arb_en_all, PWRAP_HIPRIO_ARB_EN);
>
> --
> 2.40.0
>
Sounds good to me.
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Regards,
Alex
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 4/6] soc: mediatek: mtk-pmic-wrap: Add support for companion PMICs
@ 2023-03-29 22:40 ` Alexandre Mergnat
0 siblings, 0 replies; 30+ messages in thread
From: Alexandre Mergnat @ 2023-03-29 22:40 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: matthias.bgg, robh+dt, krzysztof.kozlowski+dt, flora.fu,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
kernel, phone-devel, ~postmarketos/upstreaming
Le ven. 24 mars 2023 à 10:42, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> a écrit :
>
> Some PMICs are designed to work with a companion part, which provides
> more regulators and/or companion devices such as LED controllers,
> display backlight controllers, battery charging, fuel gauge, etc:
> this kind of PMICs are usually present in smartphone platforms, where
> tight integration is required.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 73 ++++++++++++++++++++++------
> 1 file changed, 59 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index a33a1b1820cb..366e40b802e4 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -47,6 +47,7 @@
>
> /* macro for device wrapper default value */
> #define PWRAP_DEW_READ_TEST_VAL 0x5aa5
> +#define PWRAP_DEW_COMP_READ_TEST_VAL 0xa55a
> #define PWRAP_DEW_WRITE_TEST_VAL 0xa55a
>
> /* macro for manual command */
> @@ -1222,12 +1223,16 @@ struct pwrap_slv_regops {
> * struct pwrap_slv_type - PMIC device wrapper definitions
> * @dew_regs: Device Wrapper (DeW) register offsets
> * @type: PMIC Type (model)
> + * @comp_dew_regs: Device Wrapper (DeW) register offsets for companion device
> + * @comp_type: Companion PMIC Type (model)
> * @regops: Register R/W ops
> * @caps: Capability flags for the target device
> */
> struct pwrap_slv_type {
> const u32 *dew_regs;
> enum pmic_type type;
> + const u32 *comp_dew_regs;
> + enum pmic_type comp_type;
> const struct pwrap_slv_regops *regops;
> u32 caps;
> };
> @@ -1548,9 +1553,12 @@ static int pwrap_init_dual_io(struct pmic_wrapper *wrp)
> {
> int ret;
> bool read_ok, tmp;
> + bool comp_read_ok = true;
>
> /* Enable dual IO mode */
> pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_DIO_EN], 1);
> + if (wrp->slave->comp_dew_regs)
> + pwrap_write(wrp, wrp->slave->comp_dew_regs[PWRAP_DEW_DIO_EN], 1);
>
> /* Check IDLE & INIT_DONE in advance */
> ret = readx_poll_timeout(pwrap_is_fsm_idle_and_sync_idle, wrp, tmp, tmp,
> @@ -1564,8 +1572,14 @@ static int pwrap_init_dual_io(struct pmic_wrapper *wrp)
>
> /* Read Test */
> read_ok = pwrap_pmic_read_test(wrp, wrp->slave->dew_regs, PWRAP_DEW_READ_TEST_VAL);
> - if (!read_ok) {
> - dev_err(wrp->dev, "Read failed on DIO mode.\n");
> + if (wrp->slave->comp_dew_regs)
> + comp_read_ok = pwrap_pmic_read_test(wrp, wrp->slave->comp_dew_regs,
> + PWRAP_DEW_COMP_READ_TEST_VAL);
> + if (!read_ok || !comp_read_ok) {
> + dev_err(wrp->dev, "Read failed on DIO mode. Main PMIC %s%s\n",
> + !read_ok ? "fail" : "success",
> + wrp->slave->comp_dew_regs && !comp_read_ok ?
> + ", Companion PMIC fail" : "");
> return -EFAULT;
> }
>
> @@ -1640,19 +1654,41 @@ static bool pwrap_is_cipher_ready(struct pmic_wrapper *wrp)
> return pwrap_readl(wrp, PWRAP_CIPHER_RDY) & 1;
> }
>
> -static bool pwrap_is_pmic_cipher_ready(struct pmic_wrapper *wrp)
> +static bool __pwrap_is_pmic_cipher_ready(struct pmic_wrapper *wrp, const u32 *dew_regs)
> {
> u32 rdata;
> int ret;
>
> - ret = pwrap_read(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_RDY],
> - &rdata);
> + ret = pwrap_read(wrp, dew_regs[PWRAP_DEW_CIPHER_RDY], &rdata);
> if (ret)
> return false;
>
> return rdata == 1;
> }
>
> +
Remove this extra line please.
> +static bool pwrap_is_pmic_cipher_ready(struct pmic_wrapper *wrp)
> +{
> + bool ret = __pwrap_is_pmic_cipher_ready(wrp, wrp->slave->dew_regs);
> +
> + if (!ret)
> + return ret;
> +
> + /* If there's any companion, wait for it to be ready too */
> + if (wrp->slave->comp_dew_regs)
> + ret = __pwrap_is_pmic_cipher_ready(wrp, wrp->slave->comp_dew_regs);
> +
> + return ret;
> +}
> +
> +static void pwrap_config_cipher(struct pmic_wrapper *wrp, const u32 *dew_regs)
> +{
> + pwrap_write(wrp, dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x1);
> + pwrap_write(wrp, dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x0);
> + pwrap_write(wrp, dew_regs[PWRAP_DEW_CIPHER_KEY_SEL], 0x1);
> + pwrap_write(wrp, dew_regs[PWRAP_DEW_CIPHER_IV_SEL], 0x2);
> +}
> +
> static int pwrap_init_cipher(struct pmic_wrapper *wrp)
> {
> int ret;
> @@ -1689,10 +1725,11 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
> }
>
> /* Config cipher mode @PMIC */
> - pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x1);
> - pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x0);
> - pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_KEY_SEL], 0x1);
> - pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_IV_SEL], 0x2);
> + pwrap_config_cipher(wrp, wrp->slave->dew_regs);
> +
> + /* If there is any companion PMIC, configure cipher mode there too */
> + if (wrp->slave->comp_type > 0)
> + pwrap_config_cipher(wrp, wrp->slave->comp_dew_regs);
>
> switch (wrp->slave->type) {
> case PMIC_MT6397:
> @@ -1754,6 +1791,7 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
>
> static int pwrap_init_security(struct pmic_wrapper *wrp)
> {
> + u32 crc_val;
> int ret;
>
> /* Enable encryption */
> @@ -1762,14 +1800,21 @@ static int pwrap_init_security(struct pmic_wrapper *wrp)
> return ret;
>
> /* Signature checking - using CRC */
> - if (pwrap_write(wrp,
> - wrp->slave->dew_regs[PWRAP_DEW_CRC_EN], 0x1))
> - return -EFAULT;
> + ret = pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CRC_EN], 0x1);
> + if (ret == 0 && wrp->slave->comp_dew_regs)
> + ret = pwrap_write(wrp, wrp->slave->comp_dew_regs[PWRAP_DEW_CRC_EN], 0x1);
>
> pwrap_writel(wrp, 0x1, PWRAP_CRC_EN);
> pwrap_writel(wrp, 0x0, PWRAP_SIG_MODE);
> - pwrap_writel(wrp, wrp->slave->dew_regs[PWRAP_DEW_CRC_VAL],
> - PWRAP_SIG_ADR);
> +
> + /* CRC value */
> + crc_val = wrp->slave->dew_regs[PWRAP_DEW_CRC_VAL];
> + if (wrp->slave->comp_dew_regs)
> + crc_val |= wrp->slave->comp_dew_regs[PWRAP_DEW_CRC_VAL] << 16;
IMHO, the number 16 should be replaced by a define even if I guess
it's a simple shift value.
> +
> + pwrap_writel(wrp, crc_val, PWRAP_SIG_ADR);
> +
> + /* PMIC Wrapper Arbiter priority */
> pwrap_writel(wrp,
> wrp->master->arb_en_all, PWRAP_HIPRIO_ARB_EN);
>
> --
> 2.40.0
>
Sounds good to me.
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Regards,
Alex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 6/6] soc: mediatek: pwrap: Add support for MT6795 Helio X10
2023-03-24 9:42 ` AngeloGioacchino Del Regno
@ 2023-03-29 23:07 ` Alexandre Mergnat
-1 siblings, 0 replies; 30+ messages in thread
From: Alexandre Mergnat @ 2023-03-29 23:07 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: matthias.bgg, robh+dt, krzysztof.kozlowski+dt, flora.fu,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
kernel, phone-devel, ~postmarketos/upstreaming
" or
Le ven. 24 mars 2023 à 10:42, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> a écrit :
>
> Add the necessary bits to support the MT6795 Helio X10 smartphone SoC:
> this is always paired with a MT6331 PMIC, with MT6332 companion.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 131 ++++++++++++++++++++++++++-
> 1 file changed, 130 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index ceeac43f7bd1..20d32328382a 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -639,6 +639,91 @@ static int mt6779_regs[] = {
> [PWRAP_WACS2_VLDCLR] = 0xC28,
> };
>
> +static int mt6795_regs[] = {
> + [PWRAP_MUX_SEL] = 0x0,
> + [PWRAP_WRAP_EN] = 0x4,
> + [PWRAP_DIO_EN] = 0x8,
> + [PWRAP_SIDLY] = 0xc,
> + [PWRAP_RDDMY] = 0x10,
> + [PWRAP_SI_CK_CON] = 0x14,
> + [PWRAP_CSHEXT_WRITE] = 0x18,
> + [PWRAP_CSHEXT_READ] = 0x1c,
> + [PWRAP_CSLEXT_START] = 0x20,
> + [PWRAP_CSLEXT_END] = 0x24,
> + [PWRAP_STAUPD_PRD] = 0x28,
> + [PWRAP_STAUPD_GRPEN] = 0x2c,
> + [PWRAP_EINT_STA0_ADR] = 0x30,
> + [PWRAP_EINT_STA1_ADR] = 0x34,
> + [PWRAP_STAUPD_MAN_TRIG] = 0x40,
> + [PWRAP_STAUPD_STA] = 0x44,
> + [PWRAP_WRAP_STA] = 0x48,
> + [PWRAP_HARB_INIT] = 0x4c,
> + [PWRAP_HARB_HPRIO] = 0x50,
> + [PWRAP_HIPRIO_ARB_EN] = 0x54,
> + [PWRAP_HARB_STA0] = 0x58,
> + [PWRAP_HARB_STA1] = 0x5c,
> + [PWRAP_MAN_EN] = 0x60,
> + [PWRAP_MAN_CMD] = 0x64,
> + [PWRAP_MAN_RDATA] = 0x68,
> + [PWRAP_MAN_VLDCLR] = 0x6c,
> + [PWRAP_WACS0_EN] = 0x70,
> + [PWRAP_INIT_DONE0] = 0x74,
> + [PWRAP_WACS0_CMD] = 0x78,
> + [PWRAP_WACS0_RDATA] = 0x7c,
> + [PWRAP_WACS0_VLDCLR] = 0x80,
> + [PWRAP_WACS1_EN] = 0x84,
> + [PWRAP_INIT_DONE1] = 0x88,
> + [PWRAP_WACS1_CMD] = 0x8c,
> + [PWRAP_WACS1_RDATA] = 0x90,
> + [PWRAP_WACS1_VLDCLR] = 0x94,
> + [PWRAP_WACS2_EN] = 0x98,
> + [PWRAP_INIT_DONE2] = 0x9c,
> + [PWRAP_WACS2_CMD] = 0xa0,
> + [PWRAP_WACS2_RDATA] = 0xa4,
> + [PWRAP_WACS2_VLDCLR] = 0xa8,
> + [PWRAP_INT_EN] = 0xac,
> + [PWRAP_INT_FLG_RAW] = 0xb0,
> + [PWRAP_INT_FLG] = 0xb4,
> + [PWRAP_INT_CLR] = 0xb8,
> + [PWRAP_SIG_ADR] = 0xbc,
> + [PWRAP_SIG_MODE] = 0xc0,
> + [PWRAP_SIG_VALUE] = 0xc4,
> + [PWRAP_SIG_ERRVAL] = 0xc8,
> + [PWRAP_CRC_EN] = 0xcc,
> + [PWRAP_TIMER_EN] = 0xd0,
> + [PWRAP_TIMER_STA] = 0xd4,
> + [PWRAP_WDT_UNIT] = 0xd8,
> + [PWRAP_WDT_SRC_EN] = 0xdc,
> + [PWRAP_WDT_FLG] = 0xe0,
> + [PWRAP_DEBUG_INT_SEL] = 0xe4,
> + [PWRAP_DVFS_ADR0] = 0xe8,
> + [PWRAP_DVFS_WDATA0] = 0xec,
> + [PWRAP_DVFS_ADR1] = 0xf0,
> + [PWRAP_DVFS_WDATA1] = 0xf4,
> + [PWRAP_DVFS_ADR2] = 0xf8,
> + [PWRAP_DVFS_WDATA2] = 0xfc,
> + [PWRAP_DVFS_ADR3] = 0x100,
> + [PWRAP_DVFS_WDATA3] = 0x104,
> + [PWRAP_DVFS_ADR4] = 0x108,
> + [PWRAP_DVFS_WDATA4] = 0x10c,
> + [PWRAP_DVFS_ADR5] = 0x110,
> + [PWRAP_DVFS_WDATA5] = 0x114,
> + [PWRAP_DVFS_ADR6] = 0x118,
> + [PWRAP_DVFS_WDATA6] = 0x11c,
> + [PWRAP_DVFS_ADR7] = 0x120,
> + [PWRAP_DVFS_WDATA7] = 0x124,
> + [PWRAP_SPMINF_STA] = 0x128,
> + [PWRAP_CIPHER_KEY_SEL] = 0x12c,
> + [PWRAP_CIPHER_IV_SEL] = 0x130,
> + [PWRAP_CIPHER_EN] = 0x134,
> + [PWRAP_CIPHER_RDY] = 0x138,
> + [PWRAP_CIPHER_MODE] = 0x13c,
> + [PWRAP_CIPHER_SWRST] = 0x140,
> + [PWRAP_DCM_EN] = 0x144,
> + [PWRAP_DCM_DBC_PRD] = 0x148,
> + [PWRAP_EXT_CK] = 0x14c,
> +};
> +
> static int mt6797_regs[] = {
> [PWRAP_MUX_SEL] = 0x0,
> [PWRAP_WRAP_EN] = 0x4,
> @@ -1230,6 +1315,7 @@ enum pwrap_type {
> PWRAP_MT2701,
> PWRAP_MT6765,
> PWRAP_MT6779,
> + PWRAP_MT6795,
> PWRAP_MT6797,
> PWRAP_MT6873,
> PWRAP_MT7622,
> @@ -1650,6 +1736,20 @@ static void pwrap_init_chip_select_ext(struct pmic_wrapper *wrp, u8 hext_write,
> static int pwrap_common_init_reg_clock(struct pmic_wrapper *wrp)
> {
> switch (wrp->master->type) {
> + case PWRAP_MT6795:
> + if (wrp->slave->type == PMIC_MT6331) {
> + const u32 *dew_regs = wrp->slave->dew_regs;
> +
> + pwrap_write(wrp, dew_regs[PWRAP_DEW_RDDMY_NO], 0x8);
> +
> + if (wrp->slave->comp_type == PMIC_MT6332) {
> + dew_regs = wrp->slave->comp_dew_regs;
> + pwrap_write(wrp, dew_regs[PWRAP_DEW_RDDMY_NO], 0x8);
> + }
> + }
> + pwrap_writel(wrp, 0x88, PWRAP_RDDMY);
> + pwrap_init_chip_select_ext(wrp, 15, 15, 15, 15);
> + break;
> case PWRAP_MT8173:
> pwrap_init_chip_select_ext(wrp, 0, 4, 2, 2);
> break;
> @@ -1744,6 +1844,7 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
> case PWRAP_MT2701:
> case PWRAP_MT6765:
> case PWRAP_MT6779:
> + case PWRAP_MT6795:
> case PWRAP_MT6797:
> case PWRAP_MT8173:
> case PWRAP_MT8186:
> @@ -1914,6 +2015,19 @@ static int pwrap_mt2701_init_soc_specific(struct pmic_wrapper *wrp)
> return 0;
> }
>
> +static int pwrap_mt6795_init_soc_specific(struct pmic_wrapper *wrp)
> +{
> + pwrap_writel(wrp, 0xf, PWRAP_STAUPD_GRPEN);
> +
> + if (wrp->slave->type == PMIC_MT6331)
> + pwrap_writel(wrp, 0x1b4, PWRAP_EINT_STA0_ADR);
> +
> + if (wrp->slave->comp_type == PMIC_MT6332)
> + pwrap_writel(wrp, 0x8112, PWRAP_EINT_STA1_ADR);
> +
> + return 0;
> +}
> +
> static int pwrap_mt7622_init_soc_specific(struct pmic_wrapper *wrp)
> {
> pwrap_writel(wrp, 0, PWRAP_STAUPD_PRD);
> @@ -1949,7 +2063,8 @@ static int pwrap_init(struct pmic_wrapper *wrp)
> if (wrp->rstc_bridge)
> reset_control_reset(wrp->rstc_bridge);
>
> - if (wrp->master->type == PWRAP_MT8173) {
> + if (wrp->master->type == PWRAP_MT8173 ||
> + wrp->master->type == PWRAP_MT6795) {
I would prefer to put a switch case like it's done in
"pwrap_common_init_reg_clock" or
"pwrap_init_cipher".
My second choice (which isn't aligned with the current
implementation), is to add boolean
capabilities in the "struct pmic_wrapper_type".
> /* Enable DCM */
> pwrap_writel(wrp, 3, PWRAP_DCM_EN);
> pwrap_writel(wrp, 0, PWRAP_DCM_DBC_PRD);
> @@ -2185,6 +2300,19 @@ static const struct pmic_wrapper_type pwrap_mt6779 = {
> .init_soc_specific = NULL,
> };
>
> +static const struct pmic_wrapper_type pwrap_mt6795 = {
> + .regs = mt6795_regs,
> + .type = PWRAP_MT6795,
> + .arb_en_all = 0x3f,
> + .int_en_all = ~(u32)(BIT(31) | BIT(2) | BIT(1)),
> + .int1_en_all = 0,
> + .spi_w = PWRAP_MAN_CMD_SPI_WRITE,
> + .wdt_src = PWRAP_WDT_SRC_MASK_NO_STAUPD,
> + .caps = PWRAP_CAP_RESET | PWRAP_CAP_DCM,
> + .init_reg_clock = pwrap_common_init_reg_clock,
> + .init_soc_specific = pwrap_mt6795_init_soc_specific,
TBH, I don't know if variables should be reordered in alphabetic order
or keep the order of other structures.
it's just to notify.
> +};
> +
> static const struct pmic_wrapper_type pwrap_mt6797 = {
> .regs = mt6797_regs,
> .type = PWRAP_MT6797,
> @@ -2318,6 +2446,7 @@ static const struct of_device_id of_pwrap_match_tbl[] = {
> { .compatible = "mediatek,mt2701-pwrap", .data = &pwrap_mt2701 },
> { .compatible = "mediatek,mt6765-pwrap", .data = &pwrap_mt6765 },
> { .compatible = "mediatek,mt6779-pwrap", .data = &pwrap_mt6779 },
> + { .compatible = "mediatek,mt6795-pwrap", .data = &pwrap_mt6795 },
> { .compatible = "mediatek,mt6797-pwrap", .data = &pwrap_mt6797 },
> { .compatible = "mediatek,mt6873-pwrap", .data = &pwrap_mt6873 },
> { .compatible = "mediatek,mt7622-pwrap", .data = &pwrap_mt7622 },
> --
> 2.40.0
>
Regards,
Alex
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 6/6] soc: mediatek: pwrap: Add support for MT6795 Helio X10
@ 2023-03-29 23:07 ` Alexandre Mergnat
0 siblings, 0 replies; 30+ messages in thread
From: Alexandre Mergnat @ 2023-03-29 23:07 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: matthias.bgg, robh+dt, krzysztof.kozlowski+dt, flora.fu,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
kernel, phone-devel, ~postmarketos/upstreaming
" or
Le ven. 24 mars 2023 à 10:42, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> a écrit :
>
> Add the necessary bits to support the MT6795 Helio X10 smartphone SoC:
> this is always paired with a MT6331 PMIC, with MT6332 companion.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 131 ++++++++++++++++++++++++++-
> 1 file changed, 130 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index ceeac43f7bd1..20d32328382a 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -639,6 +639,91 @@ static int mt6779_regs[] = {
> [PWRAP_WACS2_VLDCLR] = 0xC28,
> };
>
> +static int mt6795_regs[] = {
> + [PWRAP_MUX_SEL] = 0x0,
> + [PWRAP_WRAP_EN] = 0x4,
> + [PWRAP_DIO_EN] = 0x8,
> + [PWRAP_SIDLY] = 0xc,
> + [PWRAP_RDDMY] = 0x10,
> + [PWRAP_SI_CK_CON] = 0x14,
> + [PWRAP_CSHEXT_WRITE] = 0x18,
> + [PWRAP_CSHEXT_READ] = 0x1c,
> + [PWRAP_CSLEXT_START] = 0x20,
> + [PWRAP_CSLEXT_END] = 0x24,
> + [PWRAP_STAUPD_PRD] = 0x28,
> + [PWRAP_STAUPD_GRPEN] = 0x2c,
> + [PWRAP_EINT_STA0_ADR] = 0x30,
> + [PWRAP_EINT_STA1_ADR] = 0x34,
> + [PWRAP_STAUPD_MAN_TRIG] = 0x40,
> + [PWRAP_STAUPD_STA] = 0x44,
> + [PWRAP_WRAP_STA] = 0x48,
> + [PWRAP_HARB_INIT] = 0x4c,
> + [PWRAP_HARB_HPRIO] = 0x50,
> + [PWRAP_HIPRIO_ARB_EN] = 0x54,
> + [PWRAP_HARB_STA0] = 0x58,
> + [PWRAP_HARB_STA1] = 0x5c,
> + [PWRAP_MAN_EN] = 0x60,
> + [PWRAP_MAN_CMD] = 0x64,
> + [PWRAP_MAN_RDATA] = 0x68,
> + [PWRAP_MAN_VLDCLR] = 0x6c,
> + [PWRAP_WACS0_EN] = 0x70,
> + [PWRAP_INIT_DONE0] = 0x74,
> + [PWRAP_WACS0_CMD] = 0x78,
> + [PWRAP_WACS0_RDATA] = 0x7c,
> + [PWRAP_WACS0_VLDCLR] = 0x80,
> + [PWRAP_WACS1_EN] = 0x84,
> + [PWRAP_INIT_DONE1] = 0x88,
> + [PWRAP_WACS1_CMD] = 0x8c,
> + [PWRAP_WACS1_RDATA] = 0x90,
> + [PWRAP_WACS1_VLDCLR] = 0x94,
> + [PWRAP_WACS2_EN] = 0x98,
> + [PWRAP_INIT_DONE2] = 0x9c,
> + [PWRAP_WACS2_CMD] = 0xa0,
> + [PWRAP_WACS2_RDATA] = 0xa4,
> + [PWRAP_WACS2_VLDCLR] = 0xa8,
> + [PWRAP_INT_EN] = 0xac,
> + [PWRAP_INT_FLG_RAW] = 0xb0,
> + [PWRAP_INT_FLG] = 0xb4,
> + [PWRAP_INT_CLR] = 0xb8,
> + [PWRAP_SIG_ADR] = 0xbc,
> + [PWRAP_SIG_MODE] = 0xc0,
> + [PWRAP_SIG_VALUE] = 0xc4,
> + [PWRAP_SIG_ERRVAL] = 0xc8,
> + [PWRAP_CRC_EN] = 0xcc,
> + [PWRAP_TIMER_EN] = 0xd0,
> + [PWRAP_TIMER_STA] = 0xd4,
> + [PWRAP_WDT_UNIT] = 0xd8,
> + [PWRAP_WDT_SRC_EN] = 0xdc,
> + [PWRAP_WDT_FLG] = 0xe0,
> + [PWRAP_DEBUG_INT_SEL] = 0xe4,
> + [PWRAP_DVFS_ADR0] = 0xe8,
> + [PWRAP_DVFS_WDATA0] = 0xec,
> + [PWRAP_DVFS_ADR1] = 0xf0,
> + [PWRAP_DVFS_WDATA1] = 0xf4,
> + [PWRAP_DVFS_ADR2] = 0xf8,
> + [PWRAP_DVFS_WDATA2] = 0xfc,
> + [PWRAP_DVFS_ADR3] = 0x100,
> + [PWRAP_DVFS_WDATA3] = 0x104,
> + [PWRAP_DVFS_ADR4] = 0x108,
> + [PWRAP_DVFS_WDATA4] = 0x10c,
> + [PWRAP_DVFS_ADR5] = 0x110,
> + [PWRAP_DVFS_WDATA5] = 0x114,
> + [PWRAP_DVFS_ADR6] = 0x118,
> + [PWRAP_DVFS_WDATA6] = 0x11c,
> + [PWRAP_DVFS_ADR7] = 0x120,
> + [PWRAP_DVFS_WDATA7] = 0x124,
> + [PWRAP_SPMINF_STA] = 0x128,
> + [PWRAP_CIPHER_KEY_SEL] = 0x12c,
> + [PWRAP_CIPHER_IV_SEL] = 0x130,
> + [PWRAP_CIPHER_EN] = 0x134,
> + [PWRAP_CIPHER_RDY] = 0x138,
> + [PWRAP_CIPHER_MODE] = 0x13c,
> + [PWRAP_CIPHER_SWRST] = 0x140,
> + [PWRAP_DCM_EN] = 0x144,
> + [PWRAP_DCM_DBC_PRD] = 0x148,
> + [PWRAP_EXT_CK] = 0x14c,
> +};
> +
> static int mt6797_regs[] = {
> [PWRAP_MUX_SEL] = 0x0,
> [PWRAP_WRAP_EN] = 0x4,
> @@ -1230,6 +1315,7 @@ enum pwrap_type {
> PWRAP_MT2701,
> PWRAP_MT6765,
> PWRAP_MT6779,
> + PWRAP_MT6795,
> PWRAP_MT6797,
> PWRAP_MT6873,
> PWRAP_MT7622,
> @@ -1650,6 +1736,20 @@ static void pwrap_init_chip_select_ext(struct pmic_wrapper *wrp, u8 hext_write,
> static int pwrap_common_init_reg_clock(struct pmic_wrapper *wrp)
> {
> switch (wrp->master->type) {
> + case PWRAP_MT6795:
> + if (wrp->slave->type == PMIC_MT6331) {
> + const u32 *dew_regs = wrp->slave->dew_regs;
> +
> + pwrap_write(wrp, dew_regs[PWRAP_DEW_RDDMY_NO], 0x8);
> +
> + if (wrp->slave->comp_type == PMIC_MT6332) {
> + dew_regs = wrp->slave->comp_dew_regs;
> + pwrap_write(wrp, dew_regs[PWRAP_DEW_RDDMY_NO], 0x8);
> + }
> + }
> + pwrap_writel(wrp, 0x88, PWRAP_RDDMY);
> + pwrap_init_chip_select_ext(wrp, 15, 15, 15, 15);
> + break;
> case PWRAP_MT8173:
> pwrap_init_chip_select_ext(wrp, 0, 4, 2, 2);
> break;
> @@ -1744,6 +1844,7 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
> case PWRAP_MT2701:
> case PWRAP_MT6765:
> case PWRAP_MT6779:
> + case PWRAP_MT6795:
> case PWRAP_MT6797:
> case PWRAP_MT8173:
> case PWRAP_MT8186:
> @@ -1914,6 +2015,19 @@ static int pwrap_mt2701_init_soc_specific(struct pmic_wrapper *wrp)
> return 0;
> }
>
> +static int pwrap_mt6795_init_soc_specific(struct pmic_wrapper *wrp)
> +{
> + pwrap_writel(wrp, 0xf, PWRAP_STAUPD_GRPEN);
> +
> + if (wrp->slave->type == PMIC_MT6331)
> + pwrap_writel(wrp, 0x1b4, PWRAP_EINT_STA0_ADR);
> +
> + if (wrp->slave->comp_type == PMIC_MT6332)
> + pwrap_writel(wrp, 0x8112, PWRAP_EINT_STA1_ADR);
> +
> + return 0;
> +}
> +
> static int pwrap_mt7622_init_soc_specific(struct pmic_wrapper *wrp)
> {
> pwrap_writel(wrp, 0, PWRAP_STAUPD_PRD);
> @@ -1949,7 +2063,8 @@ static int pwrap_init(struct pmic_wrapper *wrp)
> if (wrp->rstc_bridge)
> reset_control_reset(wrp->rstc_bridge);
>
> - if (wrp->master->type == PWRAP_MT8173) {
> + if (wrp->master->type == PWRAP_MT8173 ||
> + wrp->master->type == PWRAP_MT6795) {
I would prefer to put a switch case like it's done in
"pwrap_common_init_reg_clock" or
"pwrap_init_cipher".
My second choice (which isn't aligned with the current
implementation), is to add boolean
capabilities in the "struct pmic_wrapper_type".
> /* Enable DCM */
> pwrap_writel(wrp, 3, PWRAP_DCM_EN);
> pwrap_writel(wrp, 0, PWRAP_DCM_DBC_PRD);
> @@ -2185,6 +2300,19 @@ static const struct pmic_wrapper_type pwrap_mt6779 = {
> .init_soc_specific = NULL,
> };
>
> +static const struct pmic_wrapper_type pwrap_mt6795 = {
> + .regs = mt6795_regs,
> + .type = PWRAP_MT6795,
> + .arb_en_all = 0x3f,
> + .int_en_all = ~(u32)(BIT(31) | BIT(2) | BIT(1)),
> + .int1_en_all = 0,
> + .spi_w = PWRAP_MAN_CMD_SPI_WRITE,
> + .wdt_src = PWRAP_WDT_SRC_MASK_NO_STAUPD,
> + .caps = PWRAP_CAP_RESET | PWRAP_CAP_DCM,
> + .init_reg_clock = pwrap_common_init_reg_clock,
> + .init_soc_specific = pwrap_mt6795_init_soc_specific,
TBH, I don't know if variables should be reordered in alphabetic order
or keep the order of other structures.
it's just to notify.
> +};
> +
> static const struct pmic_wrapper_type pwrap_mt6797 = {
> .regs = mt6797_regs,
> .type = PWRAP_MT6797,
> @@ -2318,6 +2446,7 @@ static const struct of_device_id of_pwrap_match_tbl[] = {
> { .compatible = "mediatek,mt2701-pwrap", .data = &pwrap_mt2701 },
> { .compatible = "mediatek,mt6765-pwrap", .data = &pwrap_mt6765 },
> { .compatible = "mediatek,mt6779-pwrap", .data = &pwrap_mt6779 },
> + { .compatible = "mediatek,mt6795-pwrap", .data = &pwrap_mt6795 },
> { .compatible = "mediatek,mt6797-pwrap", .data = &pwrap_mt6797 },
> { .compatible = "mediatek,mt6873-pwrap", .data = &pwrap_mt6873 },
> { .compatible = "mediatek,mt7622-pwrap", .data = &pwrap_mt7622 },
> --
> 2.40.0
>
Regards,
Alex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 5/6] soc: mediatek: mtk-pmic-wrap: Add support for MT6331 w/ MT6332 companion
2023-03-24 9:42 ` AngeloGioacchino Del Regno
@ 2023-03-29 23:17 ` Alexandre Mergnat
-1 siblings, 0 replies; 30+ messages in thread
From: Alexandre Mergnat @ 2023-03-29 23:17 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: matthias.bgg, robh+dt, krzysztof.kozlowski+dt, flora.fu,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
kernel, phone-devel, ~postmarketos/upstreaming
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Regards,
Alexandre
Le ven. 24 mars 2023 à 10:42, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> a écrit :
>
> Add support for the MT6331 PMIC and for its companion MT6332 PMIC.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 47 ++++++++++++++++++++++++++++
> 1 file changed, 47 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 366e40b802e4..ceeac43f7bd1 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -170,6 +170,40 @@ static const u32 mt6323_regs[] = {
> [PWRAP_DEW_RDDMY_NO] = 0x01a4,
> };
>
> +static const u32 mt6331_regs[] = {
> + [PWRAP_DEW_DIO_EN] = 0x018c,
> + [PWRAP_DEW_READ_TEST] = 0x018e,
> + [PWRAP_DEW_WRITE_TEST] = 0x0190,
> + [PWRAP_DEW_CRC_SWRST] = 0x0192,
> + [PWRAP_DEW_CRC_EN] = 0x0194,
> + [PWRAP_DEW_CRC_VAL] = 0x0196,
> + [PWRAP_DEW_MON_GRP_SEL] = 0x0198,
> + [PWRAP_DEW_CIPHER_KEY_SEL] = 0x019a,
> + [PWRAP_DEW_CIPHER_IV_SEL] = 0x019c,
> + [PWRAP_DEW_CIPHER_EN] = 0x019e,
> + [PWRAP_DEW_CIPHER_RDY] = 0x01a0,
> + [PWRAP_DEW_CIPHER_MODE] = 0x01a2,
> + [PWRAP_DEW_CIPHER_SWRST] = 0x01a4,
> + [PWRAP_DEW_RDDMY_NO] = 0x01a6,
> +};
> +
> +static const u32 mt6332_regs[] = {
> + [PWRAP_DEW_DIO_EN] = 0x80f6,
> + [PWRAP_DEW_READ_TEST] = 0x80f8,
> + [PWRAP_DEW_WRITE_TEST] = 0x80fa,
> + [PWRAP_DEW_CRC_SWRST] = 0x80fc,
> + [PWRAP_DEW_CRC_EN] = 0x80fe,
> + [PWRAP_DEW_CRC_VAL] = 0x8100,
> + [PWRAP_DEW_MON_GRP_SEL] = 0x8102,
> + [PWRAP_DEW_CIPHER_KEY_SEL] = 0x8104,
> + [PWRAP_DEW_CIPHER_IV_SEL] = 0x8106,
> + [PWRAP_DEW_CIPHER_EN] = 0x8108,
> + [PWRAP_DEW_CIPHER_RDY] = 0x810a,
> + [PWRAP_DEW_CIPHER_MODE] = 0x810c,
> + [PWRAP_DEW_CIPHER_SWRST] = 0x810e,
> + [PWRAP_DEW_RDDMY_NO] = 0x8110,
> +};
> +
> static const u32 mt6351_regs[] = {
> [PWRAP_DEW_DIO_EN] = 0x02F2,
> [PWRAP_DEW_READ_TEST] = 0x02F4,
> @@ -1182,6 +1216,8 @@ static int mt8186_regs[] = {
>
> enum pmic_type {
> PMIC_MT6323,
> + PMIC_MT6331,
> + PMIC_MT6332,
> PMIC_MT6351,
> PMIC_MT6357,
> PMIC_MT6358,
> @@ -2041,6 +2077,16 @@ static const struct pwrap_slv_type pmic_mt6323 = {
> PWRAP_SLV_CAP_SECURITY,
> };
>
> +static const struct pwrap_slv_type pmic_mt6331 = {
> + .dew_regs = mt6331_regs,
> + .type = PMIC_MT6331,
> + .comp_dew_regs = mt6332_regs,
> + .comp_type = PMIC_MT6332,
> + .regops = &pwrap_regops16,
> + .caps = PWRAP_SLV_CAP_SPI | PWRAP_SLV_CAP_DUALIO |
> + PWRAP_SLV_CAP_SECURITY,
> +};
> +
> static const struct pwrap_slv_type pmic_mt6351 = {
> .dew_regs = mt6351_regs,
> .type = PMIC_MT6351,
> @@ -2086,6 +2132,7 @@ static const struct pwrap_slv_type pmic_mt6397 = {
>
> static const struct of_device_id of_slave_match_tbl[] = {
> { .compatible = "mediatek,mt6323", .data = &pmic_mt6323 },
> + { .compatible = "mediatek,mt6331", .data = &pmic_mt6331 },
> { .compatible = "mediatek,mt6351", .data = &pmic_mt6351 },
> { .compatible = "mediatek,mt6357", .data = &pmic_mt6357 },
> { .compatible = "mediatek,mt6358", .data = &pmic_mt6358 },
> --
> 2.40.0
>
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 5/6] soc: mediatek: mtk-pmic-wrap: Add support for MT6331 w/ MT6332 companion
@ 2023-03-29 23:17 ` Alexandre Mergnat
0 siblings, 0 replies; 30+ messages in thread
From: Alexandre Mergnat @ 2023-03-29 23:17 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: matthias.bgg, robh+dt, krzysztof.kozlowski+dt, flora.fu,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
kernel, phone-devel, ~postmarketos/upstreaming
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Regards,
Alexandre
Le ven. 24 mars 2023 à 10:42, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> a écrit :
>
> Add support for the MT6331 PMIC and for its companion MT6332 PMIC.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 47 ++++++++++++++++++++++++++++
> 1 file changed, 47 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 366e40b802e4..ceeac43f7bd1 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -170,6 +170,40 @@ static const u32 mt6323_regs[] = {
> [PWRAP_DEW_RDDMY_NO] = 0x01a4,
> };
>
> +static const u32 mt6331_regs[] = {
> + [PWRAP_DEW_DIO_EN] = 0x018c,
> + [PWRAP_DEW_READ_TEST] = 0x018e,
> + [PWRAP_DEW_WRITE_TEST] = 0x0190,
> + [PWRAP_DEW_CRC_SWRST] = 0x0192,
> + [PWRAP_DEW_CRC_EN] = 0x0194,
> + [PWRAP_DEW_CRC_VAL] = 0x0196,
> + [PWRAP_DEW_MON_GRP_SEL] = 0x0198,
> + [PWRAP_DEW_CIPHER_KEY_SEL] = 0x019a,
> + [PWRAP_DEW_CIPHER_IV_SEL] = 0x019c,
> + [PWRAP_DEW_CIPHER_EN] = 0x019e,
> + [PWRAP_DEW_CIPHER_RDY] = 0x01a0,
> + [PWRAP_DEW_CIPHER_MODE] = 0x01a2,
> + [PWRAP_DEW_CIPHER_SWRST] = 0x01a4,
> + [PWRAP_DEW_RDDMY_NO] = 0x01a6,
> +};
> +
> +static const u32 mt6332_regs[] = {
> + [PWRAP_DEW_DIO_EN] = 0x80f6,
> + [PWRAP_DEW_READ_TEST] = 0x80f8,
> + [PWRAP_DEW_WRITE_TEST] = 0x80fa,
> + [PWRAP_DEW_CRC_SWRST] = 0x80fc,
> + [PWRAP_DEW_CRC_EN] = 0x80fe,
> + [PWRAP_DEW_CRC_VAL] = 0x8100,
> + [PWRAP_DEW_MON_GRP_SEL] = 0x8102,
> + [PWRAP_DEW_CIPHER_KEY_SEL] = 0x8104,
> + [PWRAP_DEW_CIPHER_IV_SEL] = 0x8106,
> + [PWRAP_DEW_CIPHER_EN] = 0x8108,
> + [PWRAP_DEW_CIPHER_RDY] = 0x810a,
> + [PWRAP_DEW_CIPHER_MODE] = 0x810c,
> + [PWRAP_DEW_CIPHER_SWRST] = 0x810e,
> + [PWRAP_DEW_RDDMY_NO] = 0x8110,
> +};
> +
> static const u32 mt6351_regs[] = {
> [PWRAP_DEW_DIO_EN] = 0x02F2,
> [PWRAP_DEW_READ_TEST] = 0x02F4,
> @@ -1182,6 +1216,8 @@ static int mt8186_regs[] = {
>
> enum pmic_type {
> PMIC_MT6323,
> + PMIC_MT6331,
> + PMIC_MT6332,
> PMIC_MT6351,
> PMIC_MT6357,
> PMIC_MT6358,
> @@ -2041,6 +2077,16 @@ static const struct pwrap_slv_type pmic_mt6323 = {
> PWRAP_SLV_CAP_SECURITY,
> };
>
> +static const struct pwrap_slv_type pmic_mt6331 = {
> + .dew_regs = mt6331_regs,
> + .type = PMIC_MT6331,
> + .comp_dew_regs = mt6332_regs,
> + .comp_type = PMIC_MT6332,
> + .regops = &pwrap_regops16,
> + .caps = PWRAP_SLV_CAP_SPI | PWRAP_SLV_CAP_DUALIO |
> + PWRAP_SLV_CAP_SECURITY,
> +};
> +
> static const struct pwrap_slv_type pmic_mt6351 = {
> .dew_regs = mt6351_regs,
> .type = PMIC_MT6351,
> @@ -2086,6 +2132,7 @@ static const struct pwrap_slv_type pmic_mt6397 = {
>
> static const struct of_device_id of_slave_match_tbl[] = {
> { .compatible = "mediatek,mt6323", .data = &pmic_mt6323 },
> + { .compatible = "mediatek,mt6331", .data = &pmic_mt6331 },
> { .compatible = "mediatek,mt6351", .data = &pmic_mt6351 },
> { .compatible = "mediatek,mt6357", .data = &pmic_mt6357 },
> { .compatible = "mediatek,mt6358", .data = &pmic_mt6358 },
> --
> 2.40.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 6/6] soc: mediatek: pwrap: Add support for MT6795 Helio X10
2023-03-29 23:07 ` Alexandre Mergnat
@ 2023-04-12 12:55 ` Matthias Brugger
-1 siblings, 0 replies; 30+ messages in thread
From: Matthias Brugger @ 2023-04-12 12:55 UTC (permalink / raw)
To: Alexandre Mergnat, AngeloGioacchino Del Regno
Cc: robh+dt, krzysztof.kozlowski+dt, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming
On 30/03/2023 01:07, Alexandre Mergnat wrote:
> " or
>
> Le ven. 24 mars 2023 à 10:42, AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> a écrit :
>>
>> Add the necessary bits to support the MT6795 Helio X10 smartphone SoC:
>> this is always paired with a MT6331 PMIC, with MT6332 companion.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>> drivers/soc/mediatek/mtk-pmic-wrap.c | 131 ++++++++++++++++++++++++++-
>> 1 file changed, 130 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> index ceeac43f7bd1..20d32328382a 100644
>> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
>> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> @@ -639,6 +639,91 @@ static int mt6779_regs[] = {
>> [PWRAP_WACS2_VLDCLR] = 0xC28,
>> };
>>
>> +static int mt6795_regs[] = {
>> + [PWRAP_MUX_SEL] = 0x0,
>> + [PWRAP_WRAP_EN] = 0x4,
>> + [PWRAP_DIO_EN] = 0x8,
>> + [PWRAP_SIDLY] = 0xc,
>> + [PWRAP_RDDMY] = 0x10,
>> + [PWRAP_SI_CK_CON] = 0x14,
>> + [PWRAP_CSHEXT_WRITE] = 0x18,
>> + [PWRAP_CSHEXT_READ] = 0x1c,
>> + [PWRAP_CSLEXT_START] = 0x20,
>> + [PWRAP_CSLEXT_END] = 0x24,
>> + [PWRAP_STAUPD_PRD] = 0x28,
>> + [PWRAP_STAUPD_GRPEN] = 0x2c,
>> + [PWRAP_EINT_STA0_ADR] = 0x30,
>> + [PWRAP_EINT_STA1_ADR] = 0x34,
>> + [PWRAP_STAUPD_MAN_TRIG] = 0x40,
>> + [PWRAP_STAUPD_STA] = 0x44,
>> + [PWRAP_WRAP_STA] = 0x48,
>> + [PWRAP_HARB_INIT] = 0x4c,
>> + [PWRAP_HARB_HPRIO] = 0x50,
>> + [PWRAP_HIPRIO_ARB_EN] = 0x54,
>> + [PWRAP_HARB_STA0] = 0x58,
>> + [PWRAP_HARB_STA1] = 0x5c,
>> + [PWRAP_MAN_EN] = 0x60,
>> + [PWRAP_MAN_CMD] = 0x64,
>> + [PWRAP_MAN_RDATA] = 0x68,
>> + [PWRAP_MAN_VLDCLR] = 0x6c,
>> + [PWRAP_WACS0_EN] = 0x70,
>> + [PWRAP_INIT_DONE0] = 0x74,
>> + [PWRAP_WACS0_CMD] = 0x78,
>> + [PWRAP_WACS0_RDATA] = 0x7c,
>> + [PWRAP_WACS0_VLDCLR] = 0x80,
>> + [PWRAP_WACS1_EN] = 0x84,
>> + [PWRAP_INIT_DONE1] = 0x88,
>> + [PWRAP_WACS1_CMD] = 0x8c,
>> + [PWRAP_WACS1_RDATA] = 0x90,
>> + [PWRAP_WACS1_VLDCLR] = 0x94,
>> + [PWRAP_WACS2_EN] = 0x98,
>> + [PWRAP_INIT_DONE2] = 0x9c,
>> + [PWRAP_WACS2_CMD] = 0xa0,
>> + [PWRAP_WACS2_RDATA] = 0xa4,
>> + [PWRAP_WACS2_VLDCLR] = 0xa8,
>> + [PWRAP_INT_EN] = 0xac,
>> + [PWRAP_INT_FLG_RAW] = 0xb0,
>> + [PWRAP_INT_FLG] = 0xb4,
>> + [PWRAP_INT_CLR] = 0xb8,
>> + [PWRAP_SIG_ADR] = 0xbc,
>> + [PWRAP_SIG_MODE] = 0xc0,
>> + [PWRAP_SIG_VALUE] = 0xc4,
>> + [PWRAP_SIG_ERRVAL] = 0xc8,
>> + [PWRAP_CRC_EN] = 0xcc,
>> + [PWRAP_TIMER_EN] = 0xd0,
>> + [PWRAP_TIMER_STA] = 0xd4,
>> + [PWRAP_WDT_UNIT] = 0xd8,
>> + [PWRAP_WDT_SRC_EN] = 0xdc,
>> + [PWRAP_WDT_FLG] = 0xe0,
>> + [PWRAP_DEBUG_INT_SEL] = 0xe4,
>> + [PWRAP_DVFS_ADR0] = 0xe8,
>> + [PWRAP_DVFS_WDATA0] = 0xec,
>> + [PWRAP_DVFS_ADR1] = 0xf0,
>> + [PWRAP_DVFS_WDATA1] = 0xf4,
>> + [PWRAP_DVFS_ADR2] = 0xf8,
>> + [PWRAP_DVFS_WDATA2] = 0xfc,
>> + [PWRAP_DVFS_ADR3] = 0x100,
>> + [PWRAP_DVFS_WDATA3] = 0x104,
>> + [PWRAP_DVFS_ADR4] = 0x108,
>> + [PWRAP_DVFS_WDATA4] = 0x10c,
>> + [PWRAP_DVFS_ADR5] = 0x110,
>> + [PWRAP_DVFS_WDATA5] = 0x114,
>> + [PWRAP_DVFS_ADR6] = 0x118,
>> + [PWRAP_DVFS_WDATA6] = 0x11c,
>> + [PWRAP_DVFS_ADR7] = 0x120,
>> + [PWRAP_DVFS_WDATA7] = 0x124,
>> + [PWRAP_SPMINF_STA] = 0x128,
>> + [PWRAP_CIPHER_KEY_SEL] = 0x12c,
>> + [PWRAP_CIPHER_IV_SEL] = 0x130,
>> + [PWRAP_CIPHER_EN] = 0x134,
>> + [PWRAP_CIPHER_RDY] = 0x138,
>> + [PWRAP_CIPHER_MODE] = 0x13c,
>> + [PWRAP_CIPHER_SWRST] = 0x140,
>> + [PWRAP_DCM_EN] = 0x144,
>> + [PWRAP_DCM_DBC_PRD] = 0x148,
>> + [PWRAP_EXT_CK] = 0x14c,
>> +};
>> +
>> static int mt6797_regs[] = {
>> [PWRAP_MUX_SEL] = 0x0,
>> [PWRAP_WRAP_EN] = 0x4,
>> @@ -1230,6 +1315,7 @@ enum pwrap_type {
>> PWRAP_MT2701,
>> PWRAP_MT6765,
>> PWRAP_MT6779,
>> + PWRAP_MT6795,
>> PWRAP_MT6797,
>> PWRAP_MT6873,
>> PWRAP_MT7622,
>> @@ -1650,6 +1736,20 @@ static void pwrap_init_chip_select_ext(struct pmic_wrapper *wrp, u8 hext_write,
>> static int pwrap_common_init_reg_clock(struct pmic_wrapper *wrp)
>> {
>> switch (wrp->master->type) {
>> + case PWRAP_MT6795:
>> + if (wrp->slave->type == PMIC_MT6331) {
>> + const u32 *dew_regs = wrp->slave->dew_regs;
>> +
>> + pwrap_write(wrp, dew_regs[PWRAP_DEW_RDDMY_NO], 0x8);
>> +
>> + if (wrp->slave->comp_type == PMIC_MT6332) {
>> + dew_regs = wrp->slave->comp_dew_regs;
>> + pwrap_write(wrp, dew_regs[PWRAP_DEW_RDDMY_NO], 0x8);
>> + }
>> + }
>> + pwrap_writel(wrp, 0x88, PWRAP_RDDMY);
>> + pwrap_init_chip_select_ext(wrp, 15, 15, 15, 15);
>> + break;
>> case PWRAP_MT8173:
>> pwrap_init_chip_select_ext(wrp, 0, 4, 2, 2);
>> break;
>> @@ -1744,6 +1844,7 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
>> case PWRAP_MT2701:
>> case PWRAP_MT6765:
>> case PWRAP_MT6779:
>> + case PWRAP_MT6795:
>> case PWRAP_MT6797:
>> case PWRAP_MT8173:
>> case PWRAP_MT8186:
>> @@ -1914,6 +2015,19 @@ static int pwrap_mt2701_init_soc_specific(struct pmic_wrapper *wrp)
>> return 0;
>> }
>>
>> +static int pwrap_mt6795_init_soc_specific(struct pmic_wrapper *wrp)
>> +{
>> + pwrap_writel(wrp, 0xf, PWRAP_STAUPD_GRPEN);
>> +
>> + if (wrp->slave->type == PMIC_MT6331)
>> + pwrap_writel(wrp, 0x1b4, PWRAP_EINT_STA0_ADR);
>> +
>> + if (wrp->slave->comp_type == PMIC_MT6332)
>> + pwrap_writel(wrp, 0x8112, PWRAP_EINT_STA1_ADR);
>> +
>> + return 0;
>> +}
>> +
>> static int pwrap_mt7622_init_soc_specific(struct pmic_wrapper *wrp)
>> {
>> pwrap_writel(wrp, 0, PWRAP_STAUPD_PRD);
>> @@ -1949,7 +2063,8 @@ static int pwrap_init(struct pmic_wrapper *wrp)
>> if (wrp->rstc_bridge)
>> reset_control_reset(wrp->rstc_bridge);
>>
>> - if (wrp->master->type == PWRAP_MT8173) {
>> + if (wrp->master->type == PWRAP_MT8173 ||
>> + wrp->master->type == PWRAP_MT6795) {
>
> I would prefer to put a switch case like it's done in
> "pwrap_common_init_reg_clock" or
> "pwrap_init_cipher".
>
I agree, a switch would be better here.
Regards,
Matthias
> My second choice (which isn't aligned with the current
> implementation), is to add boolean
> capabilities in the "struct pmic_wrapper_type".
>
>> /* Enable DCM */
>> pwrap_writel(wrp, 3, PWRAP_DCM_EN);
>> pwrap_writel(wrp, 0, PWRAP_DCM_DBC_PRD);
>> @@ -2185,6 +2300,19 @@ static const struct pmic_wrapper_type pwrap_mt6779 = {
>> .init_soc_specific = NULL,
>> };
>>
>> +static const struct pmic_wrapper_type pwrap_mt6795 = {
>> + .regs = mt6795_regs,
>> + .type = PWRAP_MT6795,
>> + .arb_en_all = 0x3f,
>> + .int_en_all = ~(u32)(BIT(31) | BIT(2) | BIT(1)),
>> + .int1_en_all = 0,
>> + .spi_w = PWRAP_MAN_CMD_SPI_WRITE,
>> + .wdt_src = PWRAP_WDT_SRC_MASK_NO_STAUPD,
>> + .caps = PWRAP_CAP_RESET | PWRAP_CAP_DCM,
>> + .init_reg_clock = pwrap_common_init_reg_clock,
>> + .init_soc_specific = pwrap_mt6795_init_soc_specific,
>
> TBH, I don't know if variables should be reordered in alphabetic order
> or keep the order of other structures.
> it's just to notify.
>
>> +};
>> +
>> static const struct pmic_wrapper_type pwrap_mt6797 = {
>> .regs = mt6797_regs,
>> .type = PWRAP_MT6797,
>> @@ -2318,6 +2446,7 @@ static const struct of_device_id of_pwrap_match_tbl[] = {
>> { .compatible = "mediatek,mt2701-pwrap", .data = &pwrap_mt2701 },
>> { .compatible = "mediatek,mt6765-pwrap", .data = &pwrap_mt6765 },
>> { .compatible = "mediatek,mt6779-pwrap", .data = &pwrap_mt6779 },
>> + { .compatible = "mediatek,mt6795-pwrap", .data = &pwrap_mt6795 },
>> { .compatible = "mediatek,mt6797-pwrap", .data = &pwrap_mt6797 },
>> { .compatible = "mediatek,mt6873-pwrap", .data = &pwrap_mt6873 },
>> { .compatible = "mediatek,mt7622-pwrap", .data = &pwrap_mt7622 },
>> --
>> 2.40.0
>>
>
> Regards,
> Alex
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 6/6] soc: mediatek: pwrap: Add support for MT6795 Helio X10
@ 2023-04-12 12:55 ` Matthias Brugger
0 siblings, 0 replies; 30+ messages in thread
From: Matthias Brugger @ 2023-04-12 12:55 UTC (permalink / raw)
To: Alexandre Mergnat, AngeloGioacchino Del Regno
Cc: robh+dt, krzysztof.kozlowski+dt, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming
On 30/03/2023 01:07, Alexandre Mergnat wrote:
> " or
>
> Le ven. 24 mars 2023 à 10:42, AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> a écrit :
>>
>> Add the necessary bits to support the MT6795 Helio X10 smartphone SoC:
>> this is always paired with a MT6331 PMIC, with MT6332 companion.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>> drivers/soc/mediatek/mtk-pmic-wrap.c | 131 ++++++++++++++++++++++++++-
>> 1 file changed, 130 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> index ceeac43f7bd1..20d32328382a 100644
>> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
>> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> @@ -639,6 +639,91 @@ static int mt6779_regs[] = {
>> [PWRAP_WACS2_VLDCLR] = 0xC28,
>> };
>>
>> +static int mt6795_regs[] = {
>> + [PWRAP_MUX_SEL] = 0x0,
>> + [PWRAP_WRAP_EN] = 0x4,
>> + [PWRAP_DIO_EN] = 0x8,
>> + [PWRAP_SIDLY] = 0xc,
>> + [PWRAP_RDDMY] = 0x10,
>> + [PWRAP_SI_CK_CON] = 0x14,
>> + [PWRAP_CSHEXT_WRITE] = 0x18,
>> + [PWRAP_CSHEXT_READ] = 0x1c,
>> + [PWRAP_CSLEXT_START] = 0x20,
>> + [PWRAP_CSLEXT_END] = 0x24,
>> + [PWRAP_STAUPD_PRD] = 0x28,
>> + [PWRAP_STAUPD_GRPEN] = 0x2c,
>> + [PWRAP_EINT_STA0_ADR] = 0x30,
>> + [PWRAP_EINT_STA1_ADR] = 0x34,
>> + [PWRAP_STAUPD_MAN_TRIG] = 0x40,
>> + [PWRAP_STAUPD_STA] = 0x44,
>> + [PWRAP_WRAP_STA] = 0x48,
>> + [PWRAP_HARB_INIT] = 0x4c,
>> + [PWRAP_HARB_HPRIO] = 0x50,
>> + [PWRAP_HIPRIO_ARB_EN] = 0x54,
>> + [PWRAP_HARB_STA0] = 0x58,
>> + [PWRAP_HARB_STA1] = 0x5c,
>> + [PWRAP_MAN_EN] = 0x60,
>> + [PWRAP_MAN_CMD] = 0x64,
>> + [PWRAP_MAN_RDATA] = 0x68,
>> + [PWRAP_MAN_VLDCLR] = 0x6c,
>> + [PWRAP_WACS0_EN] = 0x70,
>> + [PWRAP_INIT_DONE0] = 0x74,
>> + [PWRAP_WACS0_CMD] = 0x78,
>> + [PWRAP_WACS0_RDATA] = 0x7c,
>> + [PWRAP_WACS0_VLDCLR] = 0x80,
>> + [PWRAP_WACS1_EN] = 0x84,
>> + [PWRAP_INIT_DONE1] = 0x88,
>> + [PWRAP_WACS1_CMD] = 0x8c,
>> + [PWRAP_WACS1_RDATA] = 0x90,
>> + [PWRAP_WACS1_VLDCLR] = 0x94,
>> + [PWRAP_WACS2_EN] = 0x98,
>> + [PWRAP_INIT_DONE2] = 0x9c,
>> + [PWRAP_WACS2_CMD] = 0xa0,
>> + [PWRAP_WACS2_RDATA] = 0xa4,
>> + [PWRAP_WACS2_VLDCLR] = 0xa8,
>> + [PWRAP_INT_EN] = 0xac,
>> + [PWRAP_INT_FLG_RAW] = 0xb0,
>> + [PWRAP_INT_FLG] = 0xb4,
>> + [PWRAP_INT_CLR] = 0xb8,
>> + [PWRAP_SIG_ADR] = 0xbc,
>> + [PWRAP_SIG_MODE] = 0xc0,
>> + [PWRAP_SIG_VALUE] = 0xc4,
>> + [PWRAP_SIG_ERRVAL] = 0xc8,
>> + [PWRAP_CRC_EN] = 0xcc,
>> + [PWRAP_TIMER_EN] = 0xd0,
>> + [PWRAP_TIMER_STA] = 0xd4,
>> + [PWRAP_WDT_UNIT] = 0xd8,
>> + [PWRAP_WDT_SRC_EN] = 0xdc,
>> + [PWRAP_WDT_FLG] = 0xe0,
>> + [PWRAP_DEBUG_INT_SEL] = 0xe4,
>> + [PWRAP_DVFS_ADR0] = 0xe8,
>> + [PWRAP_DVFS_WDATA0] = 0xec,
>> + [PWRAP_DVFS_ADR1] = 0xf0,
>> + [PWRAP_DVFS_WDATA1] = 0xf4,
>> + [PWRAP_DVFS_ADR2] = 0xf8,
>> + [PWRAP_DVFS_WDATA2] = 0xfc,
>> + [PWRAP_DVFS_ADR3] = 0x100,
>> + [PWRAP_DVFS_WDATA3] = 0x104,
>> + [PWRAP_DVFS_ADR4] = 0x108,
>> + [PWRAP_DVFS_WDATA4] = 0x10c,
>> + [PWRAP_DVFS_ADR5] = 0x110,
>> + [PWRAP_DVFS_WDATA5] = 0x114,
>> + [PWRAP_DVFS_ADR6] = 0x118,
>> + [PWRAP_DVFS_WDATA6] = 0x11c,
>> + [PWRAP_DVFS_ADR7] = 0x120,
>> + [PWRAP_DVFS_WDATA7] = 0x124,
>> + [PWRAP_SPMINF_STA] = 0x128,
>> + [PWRAP_CIPHER_KEY_SEL] = 0x12c,
>> + [PWRAP_CIPHER_IV_SEL] = 0x130,
>> + [PWRAP_CIPHER_EN] = 0x134,
>> + [PWRAP_CIPHER_RDY] = 0x138,
>> + [PWRAP_CIPHER_MODE] = 0x13c,
>> + [PWRAP_CIPHER_SWRST] = 0x140,
>> + [PWRAP_DCM_EN] = 0x144,
>> + [PWRAP_DCM_DBC_PRD] = 0x148,
>> + [PWRAP_EXT_CK] = 0x14c,
>> +};
>> +
>> static int mt6797_regs[] = {
>> [PWRAP_MUX_SEL] = 0x0,
>> [PWRAP_WRAP_EN] = 0x4,
>> @@ -1230,6 +1315,7 @@ enum pwrap_type {
>> PWRAP_MT2701,
>> PWRAP_MT6765,
>> PWRAP_MT6779,
>> + PWRAP_MT6795,
>> PWRAP_MT6797,
>> PWRAP_MT6873,
>> PWRAP_MT7622,
>> @@ -1650,6 +1736,20 @@ static void pwrap_init_chip_select_ext(struct pmic_wrapper *wrp, u8 hext_write,
>> static int pwrap_common_init_reg_clock(struct pmic_wrapper *wrp)
>> {
>> switch (wrp->master->type) {
>> + case PWRAP_MT6795:
>> + if (wrp->slave->type == PMIC_MT6331) {
>> + const u32 *dew_regs = wrp->slave->dew_regs;
>> +
>> + pwrap_write(wrp, dew_regs[PWRAP_DEW_RDDMY_NO], 0x8);
>> +
>> + if (wrp->slave->comp_type == PMIC_MT6332) {
>> + dew_regs = wrp->slave->comp_dew_regs;
>> + pwrap_write(wrp, dew_regs[PWRAP_DEW_RDDMY_NO], 0x8);
>> + }
>> + }
>> + pwrap_writel(wrp, 0x88, PWRAP_RDDMY);
>> + pwrap_init_chip_select_ext(wrp, 15, 15, 15, 15);
>> + break;
>> case PWRAP_MT8173:
>> pwrap_init_chip_select_ext(wrp, 0, 4, 2, 2);
>> break;
>> @@ -1744,6 +1844,7 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
>> case PWRAP_MT2701:
>> case PWRAP_MT6765:
>> case PWRAP_MT6779:
>> + case PWRAP_MT6795:
>> case PWRAP_MT6797:
>> case PWRAP_MT8173:
>> case PWRAP_MT8186:
>> @@ -1914,6 +2015,19 @@ static int pwrap_mt2701_init_soc_specific(struct pmic_wrapper *wrp)
>> return 0;
>> }
>>
>> +static int pwrap_mt6795_init_soc_specific(struct pmic_wrapper *wrp)
>> +{
>> + pwrap_writel(wrp, 0xf, PWRAP_STAUPD_GRPEN);
>> +
>> + if (wrp->slave->type == PMIC_MT6331)
>> + pwrap_writel(wrp, 0x1b4, PWRAP_EINT_STA0_ADR);
>> +
>> + if (wrp->slave->comp_type == PMIC_MT6332)
>> + pwrap_writel(wrp, 0x8112, PWRAP_EINT_STA1_ADR);
>> +
>> + return 0;
>> +}
>> +
>> static int pwrap_mt7622_init_soc_specific(struct pmic_wrapper *wrp)
>> {
>> pwrap_writel(wrp, 0, PWRAP_STAUPD_PRD);
>> @@ -1949,7 +2063,8 @@ static int pwrap_init(struct pmic_wrapper *wrp)
>> if (wrp->rstc_bridge)
>> reset_control_reset(wrp->rstc_bridge);
>>
>> - if (wrp->master->type == PWRAP_MT8173) {
>> + if (wrp->master->type == PWRAP_MT8173 ||
>> + wrp->master->type == PWRAP_MT6795) {
>
> I would prefer to put a switch case like it's done in
> "pwrap_common_init_reg_clock" or
> "pwrap_init_cipher".
>
I agree, a switch would be better here.
Regards,
Matthias
> My second choice (which isn't aligned with the current
> implementation), is to add boolean
> capabilities in the "struct pmic_wrapper_type".
>
>> /* Enable DCM */
>> pwrap_writel(wrp, 3, PWRAP_DCM_EN);
>> pwrap_writel(wrp, 0, PWRAP_DCM_DBC_PRD);
>> @@ -2185,6 +2300,19 @@ static const struct pmic_wrapper_type pwrap_mt6779 = {
>> .init_soc_specific = NULL,
>> };
>>
>> +static const struct pmic_wrapper_type pwrap_mt6795 = {
>> + .regs = mt6795_regs,
>> + .type = PWRAP_MT6795,
>> + .arb_en_all = 0x3f,
>> + .int_en_all = ~(u32)(BIT(31) | BIT(2) | BIT(1)),
>> + .int1_en_all = 0,
>> + .spi_w = PWRAP_MAN_CMD_SPI_WRITE,
>> + .wdt_src = PWRAP_WDT_SRC_MASK_NO_STAUPD,
>> + .caps = PWRAP_CAP_RESET | PWRAP_CAP_DCM,
>> + .init_reg_clock = pwrap_common_init_reg_clock,
>> + .init_soc_specific = pwrap_mt6795_init_soc_specific,
>
> TBH, I don't know if variables should be reordered in alphabetic order
> or keep the order of other structures.
> it's just to notify.
>
>> +};
>> +
>> static const struct pmic_wrapper_type pwrap_mt6797 = {
>> .regs = mt6797_regs,
>> .type = PWRAP_MT6797,
>> @@ -2318,6 +2446,7 @@ static const struct of_device_id of_pwrap_match_tbl[] = {
>> { .compatible = "mediatek,mt2701-pwrap", .data = &pwrap_mt2701 },
>> { .compatible = "mediatek,mt6765-pwrap", .data = &pwrap_mt6765 },
>> { .compatible = "mediatek,mt6779-pwrap", .data = &pwrap_mt6779 },
>> + { .compatible = "mediatek,mt6795-pwrap", .data = &pwrap_mt6795 },
>> { .compatible = "mediatek,mt6797-pwrap", .data = &pwrap_mt6797 },
>> { .compatible = "mediatek,mt6873-pwrap", .data = &pwrap_mt6873 },
>> { .compatible = "mediatek,mt7622-pwrap", .data = &pwrap_mt7622 },
>> --
>> 2.40.0
>>
>
> Regards,
> Alex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 6/6] soc: mediatek: pwrap: Add support for MT6795 Helio X10
2023-04-12 12:55 ` Matthias Brugger
@ 2023-04-12 13:01 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-04-12 13:01 UTC (permalink / raw)
To: Matthias Brugger, Alexandre Mergnat
Cc: robh+dt, krzysztof.kozlowski+dt, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming
Il 12/04/23 14:55, Matthias Brugger ha scritto:
>
>
> On 30/03/2023 01:07, Alexandre Mergnat wrote:
>> " or
>>
>> Le ven. 24 mars 2023 à 10:42, AngeloGioacchino Del Regno
>> <angelogioacchino.delregno@collabora.com> a écrit :
>>>
>>> Add the necessary bits to support the MT6795 Helio X10 smartphone SoC:
>>> this is always paired with a MT6331 PMIC, with MT6332 companion.
>>>
>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>> ---
>>> drivers/soc/mediatek/mtk-pmic-wrap.c | 131 ++++++++++++++++++++++++++-
>>> 1 file changed, 130 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c
>>> b/drivers/soc/mediatek/mtk-pmic-wrap.c
>>> index ceeac43f7bd1..20d32328382a 100644
>>> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
>>> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
>>> @@ -639,6 +639,91 @@ static int mt6779_regs[] = {
>>> [PWRAP_WACS2_VLDCLR] = 0xC28,
>>> };
>>>
>>> +static int mt6795_regs[] = {
>>> + [PWRAP_MUX_SEL] = 0x0,
>>> + [PWRAP_WRAP_EN] = 0x4,
>>> + [PWRAP_DIO_EN] = 0x8,
>>> + [PWRAP_SIDLY] = 0xc,
>>> + [PWRAP_RDDMY] = 0x10,
>>> + [PWRAP_SI_CK_CON] = 0x14,
>>> + [PWRAP_CSHEXT_WRITE] = 0x18,
>>> + [PWRAP_CSHEXT_READ] = 0x1c,
>>> + [PWRAP_CSLEXT_START] = 0x20,
>>> + [PWRAP_CSLEXT_END] = 0x24,
>>> + [PWRAP_STAUPD_PRD] = 0x28,
>>> + [PWRAP_STAUPD_GRPEN] = 0x2c,
>>> + [PWRAP_EINT_STA0_ADR] = 0x30,
>>> + [PWRAP_EINT_STA1_ADR] = 0x34,
>>> + [PWRAP_STAUPD_MAN_TRIG] = 0x40,
>>> + [PWRAP_STAUPD_STA] = 0x44,
>>> + [PWRAP_WRAP_STA] = 0x48,
>>> + [PWRAP_HARB_INIT] = 0x4c,
>>> + [PWRAP_HARB_HPRIO] = 0x50,
>>> + [PWRAP_HIPRIO_ARB_EN] = 0x54,
>>> + [PWRAP_HARB_STA0] = 0x58,
>>> + [PWRAP_HARB_STA1] = 0x5c,
>>> + [PWRAP_MAN_EN] = 0x60,
>>> + [PWRAP_MAN_CMD] = 0x64,
>>> + [PWRAP_MAN_RDATA] = 0x68,
>>> + [PWRAP_MAN_VLDCLR] = 0x6c,
>>> + [PWRAP_WACS0_EN] = 0x70,
>>> + [PWRAP_INIT_DONE0] = 0x74,
>>> + [PWRAP_WACS0_CMD] = 0x78,
>>> + [PWRAP_WACS0_RDATA] = 0x7c,
>>> + [PWRAP_WACS0_VLDCLR] = 0x80,
>>> + [PWRAP_WACS1_EN] = 0x84,
>>> + [PWRAP_INIT_DONE1] = 0x88,
>>> + [PWRAP_WACS1_CMD] = 0x8c,
>>> + [PWRAP_WACS1_RDATA] = 0x90,
>>> + [PWRAP_WACS1_VLDCLR] = 0x94,
>>> + [PWRAP_WACS2_EN] = 0x98,
>>> + [PWRAP_INIT_DONE2] = 0x9c,
>>> + [PWRAP_WACS2_CMD] = 0xa0,
>>> + [PWRAP_WACS2_RDATA] = 0xa4,
>>> + [PWRAP_WACS2_VLDCLR] = 0xa8,
>>> + [PWRAP_INT_EN] = 0xac,
>>> + [PWRAP_INT_FLG_RAW] = 0xb0,
>>> + [PWRAP_INT_FLG] = 0xb4,
>>> + [PWRAP_INT_CLR] = 0xb8,
>>> + [PWRAP_SIG_ADR] = 0xbc,
>>> + [PWRAP_SIG_MODE] = 0xc0,
>>> + [PWRAP_SIG_VALUE] = 0xc4,
>>> + [PWRAP_SIG_ERRVAL] = 0xc8,
>>> + [PWRAP_CRC_EN] = 0xcc,
>>> + [PWRAP_TIMER_EN] = 0xd0,
>>> + [PWRAP_TIMER_STA] = 0xd4,
>>> + [PWRAP_WDT_UNIT] = 0xd8,
>>> + [PWRAP_WDT_SRC_EN] = 0xdc,
>>> + [PWRAP_WDT_FLG] = 0xe0,
>>> + [PWRAP_DEBUG_INT_SEL] = 0xe4,
>>> + [PWRAP_DVFS_ADR0] = 0xe8,
>>> + [PWRAP_DVFS_WDATA0] = 0xec,
>>> + [PWRAP_DVFS_ADR1] = 0xf0,
>>> + [PWRAP_DVFS_WDATA1] = 0xf4,
>>> + [PWRAP_DVFS_ADR2] = 0xf8,
>>> + [PWRAP_DVFS_WDATA2] = 0xfc,
>>> + [PWRAP_DVFS_ADR3] = 0x100,
>>> + [PWRAP_DVFS_WDATA3] = 0x104,
>>> + [PWRAP_DVFS_ADR4] = 0x108,
>>> + [PWRAP_DVFS_WDATA4] = 0x10c,
>>> + [PWRAP_DVFS_ADR5] = 0x110,
>>> + [PWRAP_DVFS_WDATA5] = 0x114,
>>> + [PWRAP_DVFS_ADR6] = 0x118,
>>> + [PWRAP_DVFS_WDATA6] = 0x11c,
>>> + [PWRAP_DVFS_ADR7] = 0x120,
>>> + [PWRAP_DVFS_WDATA7] = 0x124,
>>> + [PWRAP_SPMINF_STA] = 0x128,
>>> + [PWRAP_CIPHER_KEY_SEL] = 0x12c,
>>> + [PWRAP_CIPHER_IV_SEL] = 0x130,
>>> + [PWRAP_CIPHER_EN] = 0x134,
>>> + [PWRAP_CIPHER_RDY] = 0x138,
>>> + [PWRAP_CIPHER_MODE] = 0x13c,
>>> + [PWRAP_CIPHER_SWRST] = 0x140,
>>> + [PWRAP_DCM_EN] = 0x144,
>>> + [PWRAP_DCM_DBC_PRD] = 0x148,
>>> + [PWRAP_EXT_CK] = 0x14c,
>>> +};
>>> +
>>> static int mt6797_regs[] = {
>>> [PWRAP_MUX_SEL] = 0x0,
>>> [PWRAP_WRAP_EN] = 0x4,
>>> @@ -1230,6 +1315,7 @@ enum pwrap_type {
>>> PWRAP_MT2701,
>>> PWRAP_MT6765,
>>> PWRAP_MT6779,
>>> + PWRAP_MT6795,
>>> PWRAP_MT6797,
>>> PWRAP_MT6873,
>>> PWRAP_MT7622,
>>> @@ -1650,6 +1736,20 @@ static void pwrap_init_chip_select_ext(struct
>>> pmic_wrapper *wrp, u8 hext_write,
>>> static int pwrap_common_init_reg_clock(struct pmic_wrapper *wrp)
>>> {
>>> switch (wrp->master->type) {
>>> + case PWRAP_MT6795:
>>> + if (wrp->slave->type == PMIC_MT6331) {
>>> + const u32 *dew_regs = wrp->slave->dew_regs;
>>> +
>>> + pwrap_write(wrp, dew_regs[PWRAP_DEW_RDDMY_NO], 0x8);
>>> +
>>> + if (wrp->slave->comp_type == PMIC_MT6332) {
>>> + dew_regs = wrp->slave->comp_dew_regs;
>>> + pwrap_write(wrp, dew_regs[PWRAP_DEW_RDDMY_NO],
>>> 0x8);
>>> + }
>>> + }
>>> + pwrap_writel(wrp, 0x88, PWRAP_RDDMY);
>>> + pwrap_init_chip_select_ext(wrp, 15, 15, 15, 15);
>>> + break;
>>> case PWRAP_MT8173:
>>> pwrap_init_chip_select_ext(wrp, 0, 4, 2, 2);
>>> break;
>>> @@ -1744,6 +1844,7 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
>>> case PWRAP_MT2701:
>>> case PWRAP_MT6765:
>>> case PWRAP_MT6779:
>>> + case PWRAP_MT6795:
>>> case PWRAP_MT6797:
>>> case PWRAP_MT8173:
>>> case PWRAP_MT8186:
>>> @@ -1914,6 +2015,19 @@ static int pwrap_mt2701_init_soc_specific(struct
>>> pmic_wrapper *wrp)
>>> return 0;
>>> }
>>>
>>> +static int pwrap_mt6795_init_soc_specific(struct pmic_wrapper *wrp)
>>> +{
>>> + pwrap_writel(wrp, 0xf, PWRAP_STAUPD_GRPEN);
>>> +
>>> + if (wrp->slave->type == PMIC_MT6331)
>>> + pwrap_writel(wrp, 0x1b4, PWRAP_EINT_STA0_ADR);
>>> +
>>> + if (wrp->slave->comp_type == PMIC_MT6332)
>>> + pwrap_writel(wrp, 0x8112, PWRAP_EINT_STA1_ADR);
>>> +
>>> + return 0;
>>> +}
>>> +
>>> static int pwrap_mt7622_init_soc_specific(struct pmic_wrapper *wrp)
>>> {
>>> pwrap_writel(wrp, 0, PWRAP_STAUPD_PRD);
>>> @@ -1949,7 +2063,8 @@ static int pwrap_init(struct pmic_wrapper *wrp)
>>> if (wrp->rstc_bridge)
>>> reset_control_reset(wrp->rstc_bridge);
>>>
>>> - if (wrp->master->type == PWRAP_MT8173) {
>>> + if (wrp->master->type == PWRAP_MT8173 ||
>>> + wrp->master->type == PWRAP_MT6795) {
>>
>> I would prefer to put a switch case like it's done in
>> "pwrap_common_init_reg_clock" or
>> "pwrap_init_cipher".
>>
>
> I agree, a switch would be better here.
Doing that in a jiffy :-)
Cheers,
Angelo
>
> Regards,
> Matthias
>
>> My second choice (which isn't aligned with the current
>> implementation), is to add boolean
>> capabilities in the "struct pmic_wrapper_type".
>>
>>> /* Enable DCM */
>>> pwrap_writel(wrp, 3, PWRAP_DCM_EN);
>>> pwrap_writel(wrp, 0, PWRAP_DCM_DBC_PRD);
>>> @@ -2185,6 +2300,19 @@ static const struct pmic_wrapper_type pwrap_mt6779 = {
>>> .init_soc_specific = NULL,
>>> };
>>>
>>> +static const struct pmic_wrapper_type pwrap_mt6795 = {
>>> + .regs = mt6795_regs,
>>> + .type = PWRAP_MT6795,
>>> + .arb_en_all = 0x3f,
>>> + .int_en_all = ~(u32)(BIT(31) | BIT(2) | BIT(1)),
>>> + .int1_en_all = 0,
>>> + .spi_w = PWRAP_MAN_CMD_SPI_WRITE,
>>> + .wdt_src = PWRAP_WDT_SRC_MASK_NO_STAUPD,
>>> + .caps = PWRAP_CAP_RESET | PWRAP_CAP_DCM,
>>> + .init_reg_clock = pwrap_common_init_reg_clock,
>>> + .init_soc_specific = pwrap_mt6795_init_soc_specific,
>>
>> TBH, I don't know if variables should be reordered in alphabetic order
>> or keep the order of other structures.
>> it's just to notify.
>>
>>> +};
>>> +
>>> static const struct pmic_wrapper_type pwrap_mt6797 = {
>>> .regs = mt6797_regs,
>>> .type = PWRAP_MT6797,
>>> @@ -2318,6 +2446,7 @@ static const struct of_device_id of_pwrap_match_tbl[] = {
>>> { .compatible = "mediatek,mt2701-pwrap", .data = &pwrap_mt2701 },
>>> { .compatible = "mediatek,mt6765-pwrap", .data = &pwrap_mt6765 },
>>> { .compatible = "mediatek,mt6779-pwrap", .data = &pwrap_mt6779 },
>>> + { .compatible = "mediatek,mt6795-pwrap", .data = &pwrap_mt6795 },
>>> { .compatible = "mediatek,mt6797-pwrap", .data = &pwrap_mt6797 },
>>> { .compatible = "mediatek,mt6873-pwrap", .data = &pwrap_mt6873 },
>>> { .compatible = "mediatek,mt7622-pwrap", .data = &pwrap_mt7622 },
>>> --
>>> 2.40.0
>>>
>>
>> Regards,
>> Alex
>
--
AngeloGioacchino Del Regno
Software Engineer
Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK
Registered in England & Wales, no. 5513718
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 6/6] soc: mediatek: pwrap: Add support for MT6795 Helio X10
@ 2023-04-12 13:01 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-04-12 13:01 UTC (permalink / raw)
To: Matthias Brugger, Alexandre Mergnat
Cc: robh+dt, krzysztof.kozlowski+dt, flora.fu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
phone-devel, ~postmarketos/upstreaming
Il 12/04/23 14:55, Matthias Brugger ha scritto:
>
>
> On 30/03/2023 01:07, Alexandre Mergnat wrote:
>> " or
>>
>> Le ven. 24 mars 2023 à 10:42, AngeloGioacchino Del Regno
>> <angelogioacchino.delregno@collabora.com> a écrit :
>>>
>>> Add the necessary bits to support the MT6795 Helio X10 smartphone SoC:
>>> this is always paired with a MT6331 PMIC, with MT6332 companion.
>>>
>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>> ---
>>> drivers/soc/mediatek/mtk-pmic-wrap.c | 131 ++++++++++++++++++++++++++-
>>> 1 file changed, 130 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c
>>> b/drivers/soc/mediatek/mtk-pmic-wrap.c
>>> index ceeac43f7bd1..20d32328382a 100644
>>> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
>>> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
>>> @@ -639,6 +639,91 @@ static int mt6779_regs[] = {
>>> [PWRAP_WACS2_VLDCLR] = 0xC28,
>>> };
>>>
>>> +static int mt6795_regs[] = {
>>> + [PWRAP_MUX_SEL] = 0x0,
>>> + [PWRAP_WRAP_EN] = 0x4,
>>> + [PWRAP_DIO_EN] = 0x8,
>>> + [PWRAP_SIDLY] = 0xc,
>>> + [PWRAP_RDDMY] = 0x10,
>>> + [PWRAP_SI_CK_CON] = 0x14,
>>> + [PWRAP_CSHEXT_WRITE] = 0x18,
>>> + [PWRAP_CSHEXT_READ] = 0x1c,
>>> + [PWRAP_CSLEXT_START] = 0x20,
>>> + [PWRAP_CSLEXT_END] = 0x24,
>>> + [PWRAP_STAUPD_PRD] = 0x28,
>>> + [PWRAP_STAUPD_GRPEN] = 0x2c,
>>> + [PWRAP_EINT_STA0_ADR] = 0x30,
>>> + [PWRAP_EINT_STA1_ADR] = 0x34,
>>> + [PWRAP_STAUPD_MAN_TRIG] = 0x40,
>>> + [PWRAP_STAUPD_STA] = 0x44,
>>> + [PWRAP_WRAP_STA] = 0x48,
>>> + [PWRAP_HARB_INIT] = 0x4c,
>>> + [PWRAP_HARB_HPRIO] = 0x50,
>>> + [PWRAP_HIPRIO_ARB_EN] = 0x54,
>>> + [PWRAP_HARB_STA0] = 0x58,
>>> + [PWRAP_HARB_STA1] = 0x5c,
>>> + [PWRAP_MAN_EN] = 0x60,
>>> + [PWRAP_MAN_CMD] = 0x64,
>>> + [PWRAP_MAN_RDATA] = 0x68,
>>> + [PWRAP_MAN_VLDCLR] = 0x6c,
>>> + [PWRAP_WACS0_EN] = 0x70,
>>> + [PWRAP_INIT_DONE0] = 0x74,
>>> + [PWRAP_WACS0_CMD] = 0x78,
>>> + [PWRAP_WACS0_RDATA] = 0x7c,
>>> + [PWRAP_WACS0_VLDCLR] = 0x80,
>>> + [PWRAP_WACS1_EN] = 0x84,
>>> + [PWRAP_INIT_DONE1] = 0x88,
>>> + [PWRAP_WACS1_CMD] = 0x8c,
>>> + [PWRAP_WACS1_RDATA] = 0x90,
>>> + [PWRAP_WACS1_VLDCLR] = 0x94,
>>> + [PWRAP_WACS2_EN] = 0x98,
>>> + [PWRAP_INIT_DONE2] = 0x9c,
>>> + [PWRAP_WACS2_CMD] = 0xa0,
>>> + [PWRAP_WACS2_RDATA] = 0xa4,
>>> + [PWRAP_WACS2_VLDCLR] = 0xa8,
>>> + [PWRAP_INT_EN] = 0xac,
>>> + [PWRAP_INT_FLG_RAW] = 0xb0,
>>> + [PWRAP_INT_FLG] = 0xb4,
>>> + [PWRAP_INT_CLR] = 0xb8,
>>> + [PWRAP_SIG_ADR] = 0xbc,
>>> + [PWRAP_SIG_MODE] = 0xc0,
>>> + [PWRAP_SIG_VALUE] = 0xc4,
>>> + [PWRAP_SIG_ERRVAL] = 0xc8,
>>> + [PWRAP_CRC_EN] = 0xcc,
>>> + [PWRAP_TIMER_EN] = 0xd0,
>>> + [PWRAP_TIMER_STA] = 0xd4,
>>> + [PWRAP_WDT_UNIT] = 0xd8,
>>> + [PWRAP_WDT_SRC_EN] = 0xdc,
>>> + [PWRAP_WDT_FLG] = 0xe0,
>>> + [PWRAP_DEBUG_INT_SEL] = 0xe4,
>>> + [PWRAP_DVFS_ADR0] = 0xe8,
>>> + [PWRAP_DVFS_WDATA0] = 0xec,
>>> + [PWRAP_DVFS_ADR1] = 0xf0,
>>> + [PWRAP_DVFS_WDATA1] = 0xf4,
>>> + [PWRAP_DVFS_ADR2] = 0xf8,
>>> + [PWRAP_DVFS_WDATA2] = 0xfc,
>>> + [PWRAP_DVFS_ADR3] = 0x100,
>>> + [PWRAP_DVFS_WDATA3] = 0x104,
>>> + [PWRAP_DVFS_ADR4] = 0x108,
>>> + [PWRAP_DVFS_WDATA4] = 0x10c,
>>> + [PWRAP_DVFS_ADR5] = 0x110,
>>> + [PWRAP_DVFS_WDATA5] = 0x114,
>>> + [PWRAP_DVFS_ADR6] = 0x118,
>>> + [PWRAP_DVFS_WDATA6] = 0x11c,
>>> + [PWRAP_DVFS_ADR7] = 0x120,
>>> + [PWRAP_DVFS_WDATA7] = 0x124,
>>> + [PWRAP_SPMINF_STA] = 0x128,
>>> + [PWRAP_CIPHER_KEY_SEL] = 0x12c,
>>> + [PWRAP_CIPHER_IV_SEL] = 0x130,
>>> + [PWRAP_CIPHER_EN] = 0x134,
>>> + [PWRAP_CIPHER_RDY] = 0x138,
>>> + [PWRAP_CIPHER_MODE] = 0x13c,
>>> + [PWRAP_CIPHER_SWRST] = 0x140,
>>> + [PWRAP_DCM_EN] = 0x144,
>>> + [PWRAP_DCM_DBC_PRD] = 0x148,
>>> + [PWRAP_EXT_CK] = 0x14c,
>>> +};
>>> +
>>> static int mt6797_regs[] = {
>>> [PWRAP_MUX_SEL] = 0x0,
>>> [PWRAP_WRAP_EN] = 0x4,
>>> @@ -1230,6 +1315,7 @@ enum pwrap_type {
>>> PWRAP_MT2701,
>>> PWRAP_MT6765,
>>> PWRAP_MT6779,
>>> + PWRAP_MT6795,
>>> PWRAP_MT6797,
>>> PWRAP_MT6873,
>>> PWRAP_MT7622,
>>> @@ -1650,6 +1736,20 @@ static void pwrap_init_chip_select_ext(struct
>>> pmic_wrapper *wrp, u8 hext_write,
>>> static int pwrap_common_init_reg_clock(struct pmic_wrapper *wrp)
>>> {
>>> switch (wrp->master->type) {
>>> + case PWRAP_MT6795:
>>> + if (wrp->slave->type == PMIC_MT6331) {
>>> + const u32 *dew_regs = wrp->slave->dew_regs;
>>> +
>>> + pwrap_write(wrp, dew_regs[PWRAP_DEW_RDDMY_NO], 0x8);
>>> +
>>> + if (wrp->slave->comp_type == PMIC_MT6332) {
>>> + dew_regs = wrp->slave->comp_dew_regs;
>>> + pwrap_write(wrp, dew_regs[PWRAP_DEW_RDDMY_NO],
>>> 0x8);
>>> + }
>>> + }
>>> + pwrap_writel(wrp, 0x88, PWRAP_RDDMY);
>>> + pwrap_init_chip_select_ext(wrp, 15, 15, 15, 15);
>>> + break;
>>> case PWRAP_MT8173:
>>> pwrap_init_chip_select_ext(wrp, 0, 4, 2, 2);
>>> break;
>>> @@ -1744,6 +1844,7 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
>>> case PWRAP_MT2701:
>>> case PWRAP_MT6765:
>>> case PWRAP_MT6779:
>>> + case PWRAP_MT6795:
>>> case PWRAP_MT6797:
>>> case PWRAP_MT8173:
>>> case PWRAP_MT8186:
>>> @@ -1914,6 +2015,19 @@ static int pwrap_mt2701_init_soc_specific(struct
>>> pmic_wrapper *wrp)
>>> return 0;
>>> }
>>>
>>> +static int pwrap_mt6795_init_soc_specific(struct pmic_wrapper *wrp)
>>> +{
>>> + pwrap_writel(wrp, 0xf, PWRAP_STAUPD_GRPEN);
>>> +
>>> + if (wrp->slave->type == PMIC_MT6331)
>>> + pwrap_writel(wrp, 0x1b4, PWRAP_EINT_STA0_ADR);
>>> +
>>> + if (wrp->slave->comp_type == PMIC_MT6332)
>>> + pwrap_writel(wrp, 0x8112, PWRAP_EINT_STA1_ADR);
>>> +
>>> + return 0;
>>> +}
>>> +
>>> static int pwrap_mt7622_init_soc_specific(struct pmic_wrapper *wrp)
>>> {
>>> pwrap_writel(wrp, 0, PWRAP_STAUPD_PRD);
>>> @@ -1949,7 +2063,8 @@ static int pwrap_init(struct pmic_wrapper *wrp)
>>> if (wrp->rstc_bridge)
>>> reset_control_reset(wrp->rstc_bridge);
>>>
>>> - if (wrp->master->type == PWRAP_MT8173) {
>>> + if (wrp->master->type == PWRAP_MT8173 ||
>>> + wrp->master->type == PWRAP_MT6795) {
>>
>> I would prefer to put a switch case like it's done in
>> "pwrap_common_init_reg_clock" or
>> "pwrap_init_cipher".
>>
>
> I agree, a switch would be better here.
Doing that in a jiffy :-)
Cheers,
Angelo
>
> Regards,
> Matthias
>
>> My second choice (which isn't aligned with the current
>> implementation), is to add boolean
>> capabilities in the "struct pmic_wrapper_type".
>>
>>> /* Enable DCM */
>>> pwrap_writel(wrp, 3, PWRAP_DCM_EN);
>>> pwrap_writel(wrp, 0, PWRAP_DCM_DBC_PRD);
>>> @@ -2185,6 +2300,19 @@ static const struct pmic_wrapper_type pwrap_mt6779 = {
>>> .init_soc_specific = NULL,
>>> };
>>>
>>> +static const struct pmic_wrapper_type pwrap_mt6795 = {
>>> + .regs = mt6795_regs,
>>> + .type = PWRAP_MT6795,
>>> + .arb_en_all = 0x3f,
>>> + .int_en_all = ~(u32)(BIT(31) | BIT(2) | BIT(1)),
>>> + .int1_en_all = 0,
>>> + .spi_w = PWRAP_MAN_CMD_SPI_WRITE,
>>> + .wdt_src = PWRAP_WDT_SRC_MASK_NO_STAUPD,
>>> + .caps = PWRAP_CAP_RESET | PWRAP_CAP_DCM,
>>> + .init_reg_clock = pwrap_common_init_reg_clock,
>>> + .init_soc_specific = pwrap_mt6795_init_soc_specific,
>>
>> TBH, I don't know if variables should be reordered in alphabetic order
>> or keep the order of other structures.
>> it's just to notify.
>>
>>> +};
>>> +
>>> static const struct pmic_wrapper_type pwrap_mt6797 = {
>>> .regs = mt6797_regs,
>>> .type = PWRAP_MT6797,
>>> @@ -2318,6 +2446,7 @@ static const struct of_device_id of_pwrap_match_tbl[] = {
>>> { .compatible = "mediatek,mt2701-pwrap", .data = &pwrap_mt2701 },
>>> { .compatible = "mediatek,mt6765-pwrap", .data = &pwrap_mt6765 },
>>> { .compatible = "mediatek,mt6779-pwrap", .data = &pwrap_mt6779 },
>>> + { .compatible = "mediatek,mt6795-pwrap", .data = &pwrap_mt6795 },
>>> { .compatible = "mediatek,mt6797-pwrap", .data = &pwrap_mt6797 },
>>> { .compatible = "mediatek,mt6873-pwrap", .data = &pwrap_mt6873 },
>>> { .compatible = "mediatek,mt7622-pwrap", .data = &pwrap_mt7622 },
>>> --
>>> 2.40.0
>>>
>>
>> Regards,
>> Alex
>
--
AngeloGioacchino Del Regno
Software Engineer
Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK
Registered in England & Wales, no. 5513718
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
end of thread, other threads:[~2023-04-12 13:02 UTC | newest]
Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-24 9:41 [PATCH v2 0/6] MediaTek Helio X10 MT6795 - MT6331/6332 PMIC Wrapper AngeloGioacchino Del Regno
2023-03-24 9:41 ` AngeloGioacchino Del Regno
2023-03-24 9:42 ` [PATCH v2 1/6] dt-bindings: soc: mediatek: pwrap: Add compatible for MT6795 Helio X10 AngeloGioacchino Del Regno
2023-03-24 9:42 ` AngeloGioacchino Del Regno
2023-03-27 7:23 ` Krzysztof Kozlowski
2023-03-27 7:23 ` Krzysztof Kozlowski
2023-03-24 9:42 ` [PATCH v2 2/6] soc: mediatek: pwrap: Move PMIC read test sequence in function AngeloGioacchino Del Regno
2023-03-24 9:42 ` AngeloGioacchino Del Regno
2023-03-28 9:19 ` Alexandre Mergnat
2023-03-28 9:19 ` Alexandre Mergnat
2023-03-24 9:42 ` [PATCH v2 3/6] soc: mediatek: pwrap: Add kerneldoc for struct pwrap_slv_type AngeloGioacchino Del Regno
2023-03-24 9:42 ` AngeloGioacchino Del Regno
2023-03-28 9:22 ` Alexandre Mergnat
2023-03-28 9:22 ` Alexandre Mergnat
2023-03-24 9:42 ` [PATCH v2 4/6] soc: mediatek: mtk-pmic-wrap: Add support for companion PMICs AngeloGioacchino Del Regno
2023-03-24 9:42 ` AngeloGioacchino Del Regno
2023-03-29 22:40 ` Alexandre Mergnat
2023-03-29 22:40 ` Alexandre Mergnat
2023-03-24 9:42 ` [PATCH v2 5/6] soc: mediatek: mtk-pmic-wrap: Add support for MT6331 w/ MT6332 companion AngeloGioacchino Del Regno
2023-03-24 9:42 ` AngeloGioacchino Del Regno
2023-03-29 23:17 ` Alexandre Mergnat
2023-03-29 23:17 ` Alexandre Mergnat
2023-03-24 9:42 ` [PATCH v2 6/6] soc: mediatek: pwrap: Add support for MT6795 Helio X10 AngeloGioacchino Del Regno
2023-03-24 9:42 ` AngeloGioacchino Del Regno
2023-03-29 23:07 ` Alexandre Mergnat
2023-03-29 23:07 ` Alexandre Mergnat
2023-04-12 12:55 ` Matthias Brugger
2023-04-12 12:55 ` Matthias Brugger
2023-04-12 13:01 ` AngeloGioacchino Del Regno
2023-04-12 13:01 ` AngeloGioacchino Del Regno
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.