From: Bjorn Andersson <andersson@kernel.org> To: Vinod Polimera <quic_vpolimer@quicinc.com> Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robdclark@gmail.com, dianders@chromium.org, swboyd@chromium.org, quic_kalyant@quicinc.com, dmitry.baryshkov@linaro.org, quic_khsieh@quicinc.com, quic_vproddut@quicinc.com, quic_bjorande@quicinc.com, quic_abhinavk@quicinc.com, quic_sbillaka@quicinc.com Subject: Re: [PATCH v14 14/14] drm/msm/dp: set self refresh aware based on PSR support Date: Sun, 26 Mar 2023 09:27:23 -0700 [thread overview] Message-ID: <20230326162723.3lo6pnsfdwzsvbhj@ripper> (raw) In-Reply-To: <1677774797-31063-15-git-send-email-quic_vpolimer@quicinc.com> On Thu, Mar 02, 2023 at 10:03:17PM +0530, Vinod Polimera wrote: > For the PSR to kick in, self_refresh_aware has to be set. > Initialize it based on the PSR support for the eDP interface. > When I boot my sc8280xp devices (CRD and X13s) to console with this patch included I get a login prompt, and then there are no more screen updates. Switching virtual terminal (ctrl+alt+fN) causes the screen to redraw. Blindly login in and launching Wayland works and from then on screen updates works as expected. Switching from Wayland to another virtual terminal causes the problem to re-appear, no updates after the initial refresh, switching back go the Wayland-terminal crashed the machine. Reverting this single patch resolves both the issue with the console updating as exected and flipping between the virtual terminal with Wayland and the others no longer crashes my machine. Regards, Bjorn > Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com> > --- > drivers/gpu/drm/msm/dp/dp_drm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c > index 029e08c..785d766 100644 > --- a/drivers/gpu/drm/msm/dp/dp_drm.c > +++ b/drivers/gpu/drm/msm/dp/dp_drm.c > @@ -117,6 +117,8 @@ static int edp_bridge_atomic_check(struct drm_bridge *drm_bridge, > if (WARN_ON(!conn_state)) > return -ENODEV; > > + conn_state->self_refresh_aware = dp->psr_supported; > + > if (!conn_state->crtc || !crtc_state) > return 0; > > -- > 2.7.4 >
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <andersson@kernel.org> To: Vinod Polimera <quic_vpolimer@quicinc.com> Cc: quic_kalyant@quicinc.com, devicetree@vger.kernel.org, quic_sbillaka@quicinc.com, quic_bjorande@quicinc.com, quic_abhinavk@quicinc.com, quic_vproddut@quicinc.com, linux-arm-msm@vger.kernel.org, quic_khsieh@quicinc.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, dmitry.baryshkov@linaro.org, swboyd@chromium.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH v14 14/14] drm/msm/dp: set self refresh aware based on PSR support Date: Sun, 26 Mar 2023 09:27:23 -0700 [thread overview] Message-ID: <20230326162723.3lo6pnsfdwzsvbhj@ripper> (raw) In-Reply-To: <1677774797-31063-15-git-send-email-quic_vpolimer@quicinc.com> On Thu, Mar 02, 2023 at 10:03:17PM +0530, Vinod Polimera wrote: > For the PSR to kick in, self_refresh_aware has to be set. > Initialize it based on the PSR support for the eDP interface. > When I boot my sc8280xp devices (CRD and X13s) to console with this patch included I get a login prompt, and then there are no more screen updates. Switching virtual terminal (ctrl+alt+fN) causes the screen to redraw. Blindly login in and launching Wayland works and from then on screen updates works as expected. Switching from Wayland to another virtual terminal causes the problem to re-appear, no updates after the initial refresh, switching back go the Wayland-terminal crashed the machine. Reverting this single patch resolves both the issue with the console updating as exected and flipping between the virtual terminal with Wayland and the others no longer crashes my machine. Regards, Bjorn > Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com> > --- > drivers/gpu/drm/msm/dp/dp_drm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c > index 029e08c..785d766 100644 > --- a/drivers/gpu/drm/msm/dp/dp_drm.c > +++ b/drivers/gpu/drm/msm/dp/dp_drm.c > @@ -117,6 +117,8 @@ static int edp_bridge_atomic_check(struct drm_bridge *drm_bridge, > if (WARN_ON(!conn_state)) > return -ENODEV; > > + conn_state->self_refresh_aware = dp->psr_supported; > + > if (!conn_state->crtc || !crtc_state) > return 0; > > -- > 2.7.4 >
next prev parent reply other threads:[~2023-03-26 16:24 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-02 16:33 [PATCH v14 00/14] Add PSR support for eDP Vinod Polimera 2023-03-02 16:33 ` Vinod Polimera 2023-03-02 16:33 ` [PATCH v14 01/14] drm: add helper functions to retrieve old and new crtc Vinod Polimera 2023-03-02 16:33 ` Vinod Polimera 2023-03-02 16:33 ` [PATCH v14 02/14] drm/bridge: use atomic enable/disable callbacks for panel bridge Vinod Polimera 2023-03-02 16:33 ` Vinod Polimera 2023-03-02 16:33 ` [PATCH v14 03/14] drm/bridge: add psr support for panel bridge callbacks Vinod Polimera 2023-03-02 16:33 ` Vinod Polimera 2023-03-02 16:33 ` [PATCH v14 04/14] drm/msm/disp/dpu: check for crtc enable rather than crtc active to release shared resources Vinod Polimera 2023-03-02 16:33 ` Vinod Polimera 2023-03-02 16:33 ` [PATCH v14 05/14] drm/msm/disp/dpu: get timing engine status from intf status register Vinod Polimera 2023-03-02 16:33 ` Vinod Polimera 2023-03-02 16:33 ` [PATCH v14 06/14] drm/msm/disp/dpu: wait for extra vsync till timing engine status is disabled Vinod Polimera 2023-03-02 16:33 ` Vinod Polimera 2023-03-02 16:33 ` [PATCH v14 07/14] drm/msm/disp/dpu: reset the datapath after timing engine disable Vinod Polimera 2023-03-02 16:33 ` Vinod Polimera 2023-03-02 16:33 ` [PATCH v14 08/14] drm/msm/dp: use atomic callbacks for DP bridge ops Vinod Polimera 2023-03-02 16:33 ` Vinod Polimera 2023-03-02 16:33 ` [PATCH v14 09/14] drm/msm/dp: Add basic PSR support for eDP Vinod Polimera 2023-03-02 16:33 ` Vinod Polimera 2023-03-02 16:33 ` [PATCH v14 10/14] drm/msm/dp: use the eDP bridge ops to validate eDP modes Vinod Polimera 2023-03-02 16:33 ` Vinod Polimera 2023-03-02 16:33 ` [PATCH v14 11/14] drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder functions Vinod Polimera 2023-03-02 16:33 ` Vinod Polimera 2023-03-02 16:33 ` [PATCH v14 12/14] drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver Vinod Polimera 2023-03-02 16:33 ` Vinod Polimera 2023-03-02 16:33 ` [PATCH v14 13/14] drm/msm/disp/dpu: update dpu_enc crtc state on crtc enable/disable during self refresh Vinod Polimera 2023-03-02 16:33 ` Vinod Polimera 2023-03-14 10:32 ` Vinod Polimera 2023-03-14 10:32 ` Vinod Polimera 2023-03-02 16:33 ` [PATCH v14 14/14] drm/msm/dp: set self refresh aware based on PSR support Vinod Polimera 2023-03-02 16:33 ` Vinod Polimera 2023-03-02 16:40 ` Dmitry Baryshkov 2023-03-02 16:40 ` Dmitry Baryshkov 2023-03-26 16:27 ` Bjorn Andersson [this message] 2023-03-26 16:27 ` Bjorn Andersson 2023-03-26 16:35 ` Bjorn Andersson 2023-03-26 16:35 ` Bjorn Andersson 2023-03-27 16:27 ` Stephen Boyd 2023-03-27 16:27 ` Stephen Boyd 2023-03-29 15:16 ` Vinod Polimera 2023-03-29 15:16 ` Vinod Polimera 2023-03-29 15:47 ` Doug Anderson 2023-03-29 15:47 ` Doug Anderson 2023-03-30 14:23 ` Doug Anderson 2023-03-30 14:23 ` Doug Anderson 2023-03-30 14:27 ` Vinod Polimera 2023-03-30 14:27 ` Vinod Polimera 2023-03-26 22:02 ` Dmitry Baryshkov 2023-03-26 22:02 ` Dmitry Baryshkov 2023-03-06 17:35 ` [PATCH v14 00/14] Add PSR support for eDP Doug Anderson 2023-03-06 17:35 ` Doug Anderson 2023-03-07 13:54 ` Dmitry Baryshkov 2023-03-07 13:54 ` Dmitry Baryshkov 2023-03-16 0:44 ` Dmitry Baryshkov 2023-03-16 0:44 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230326162723.3lo6pnsfdwzsvbhj@ripper \ --to=andersson@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_bjorande@quicinc.com \ --cc=quic_kalyant@quicinc.com \ --cc=quic_khsieh@quicinc.com \ --cc=quic_sbillaka@quicinc.com \ --cc=quic_vpolimer@quicinc.com \ --cc=quic_vproddut@quicinc.com \ --cc=robdclark@gmail.com \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.